maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix majority of terminal line/column cases

Browse source 
Part of #34193
This commit is contained in:
Daniel Imms 2017-09-12 11:38:35 -07:00
parent 35c8bc4daa
commit b411fb2c2c
2 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/parts/terminal/electron-browser/terminalLinkHandler.ts
View file

@ -41,7 +41,7 @@ const lineAndColumnClause = [
// Changing any regex may effect this value, hence changes this as well if required.
const winLineAndColumnMatchIndex = 12;
const unixLineAndColumnMatchIndex = 15;
const unixLineAndColumnMatchIndex = 23;
// Each line and column clause have 6 groups (ie no. of expressions in round brackets)
const lineAndColumnClauseGroupCount = 6;

20
src/vs/workbench/parts/terminal/test/electron-browser/terminalLinkHandler.test.ts
View file

@ -138,16 +138,16 @@ suite('Workbench - TerminalLinkHandler', () => {
// { urlFormat: '{0} on line {1}, column {2}', line: '5', column: '3' },
// { urlFormat: '{0}:line {1}', line: '5' },
// { urlFormat: '{0}:line {1}, column {2}', line: '5', column: '3' },
// { urlFormat: '{0}({1})', line: '5' },
// { urlFormat: '{0} ({1})', line: '5' },
// { urlFormat: '{0}({1},{2})', line: '5', column: '3' },
// { urlFormat: '{0} ({1},{2})', line: '5', column: '3' },
// { urlFormat: '{0}:{1}', line: '5' },
// { urlFormat: '{0}:{1}:{2}', line: '5', column: '3' },
// { urlFormat: '{0}[{1}]', line: '5' },
// { urlFormat: '{0} [{1}]', line: '5' },
// { urlFormat: '{0}[{1},{2}]', line: '5', column: '3' },
// { urlFormat: '{0} [{1},{2}]', line: '5', column: '3' }
{ urlFormat: '{0}({1})', line: '5' },
{ urlFormat: '{0} ({1})', line: '5' },
{ urlFormat: '{0}({1},{2})', line: '5', column: '3' },
{ urlFormat: '{0} ({1},{2})', line: '5', column: '3' },
{ urlFormat: '{0}:{1}', line: '5' },
{ urlFormat: '{0}:{1}:{2}', line: '5', column: '3' },
{ urlFormat: '{0}[{1}]', line: '5' },
{ urlFormat: '{0} [{1}]', line: '5' },
{ urlFormat: '{0}[{1},{2}]', line: '5', column: '3' },
{ urlFormat: '{0} [{1},{2}]', line: '5', column: '3' }
];
linkUrls.forEach(linkUrl => {