maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Next attempt to fix should respect dimension overrides in remote

Browse source 
Fixes #137155
This commit is contained in:
Daniel Imms 2021-11-17 05:28:31 -08:00
parent 61913650d8
commit b66d2e7bbd
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts
View file

@ -492,8 +492,7 @@ import { assertNoRpc } from '../utils';
// const terminal = window.createTerminal({ name: 'foo', pty });
// });
// Skip in remote for now as it's flaky https://github.com/microsoft/vscode/issues/137155
(process.env.REMOTE_VSCODE ? test.skip : test)('should respect dimension overrides', async () => {
test('should respect dimension overrides', async () => {
const writeEmitter = new EventEmitter<string>();
const overrideDimensionsEmitter = new EventEmitter<TerminalDimensions>();
const pty: Pseudoterminal = {
@ -510,17 +509,25 @@ import { assertNoRpc } from '../utils';
}));
const created = window.createTerminal({ name: 'foo', pty });
});
// Exit the test early if dimensions already match which may happen if the exthost
// has high latency
if (terminal.dimensions?.columns === 10 && terminal.dimensions?.rows === 5) {
return;
}
// TODO: Remove logs when the test is verified as non-flaky
await new Promise<void>(r => {
// Does this never fire because it's already set to 10x5?
disposables.push(window.onDidChangeTerminalDimensions(e => {
strictEqual(e.terminal, terminal);
console.log(`window.onDidChangeTerminalDimensions event, dimensions = ${e.dimensions?.columns}x${e.dimensions?.rows}`);
// The default pty dimensions have a chance to appear here since override
// dimensions happens after the terminal is created. If so just ignore and
// wait for the right dimensions
if (e.dimensions.columns === 10 || e.dimensions.rows === 5) {
if (e.terminal === terminal && e.dimensions.columns === 10 && e.dimensions.rows === 5) {
disposables.push(window.onDidCloseTerminal(() => r()));
terminal.dispose();
}
}));
console.log(`listening for window.onDidChangeTerminalDimensions, current dimensions = ${terminal.dimensions?.columns}x${terminal.dimensions?.rows}`);
terminal.show();
});
});