maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

shared process - log errors/crashes also to active window

Browse source
This commit is contained in:
Benjamin Pasero 2021-02-17 14:07:29 +01:00
parent 678acbe536
commit c1230f8847
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/vs/platform/sharedProcess/electron-main/sharedProcess.ts
View file

@ -15,6 +15,7 @@ import { ISharedProcess, ISharedProcessConfiguration } from 'vs/platform/sharedP
import { Disposable } from 'vs/base/common/lifecycle';
import { connect as connectMessagePort } from 'vs/base/parts/ipc/electron-main/ipc.mp';
import { assertIsDefined } from 'vs/base/common/types';
import { onUnexpectedError } from 'vs/base/common/errors';
export class SharedProcess extends Disposable implements ISharedProcess {
@ -201,9 +202,11 @@ export class SharedProcess extends Disposable implements ISharedProcess {
this.window.on('close', this.windowCloseListener);
// Crashes & Unrsponsive & Failed to load
this.window.webContents.on('render-process-gone', (event, details) => this.logService.error(`SharedProcess: crashed (detail: ${details?.reason})`));
this.window.on('unresponsive', () => this.logService.error('SharedProcess: detected unresponsive window'));
this.window.webContents.on('did-fail-load', (event, errorCode, errorDescription) => this.logService.warn('SharedProcess: failed to load window, ', errorDescription));
// We use `onUnexpectedError` explicitly because the error handler
// will send the error to the active window to log in devtools too
this.window.webContents.on('render-process-gone', (event, details) => onUnexpectedError(new Error(`SharedProcess: crashed (detail: ${details?.reason})`)));
this.window.on('unresponsive', () => onUnexpectedError(new Error('SharedProcess: detected unresponsive window')));
this.window.webContents.on('did-fail-load', (event, errorCode, errorDescription) => onUnexpectedError(new Error(`SharedProcess: failed to load window: ${errorDescription}`)));
}
spawn(userEnv: NodeJS.ProcessEnv): void {