maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Save prompt is shown while saving from settings split json editor (fix #106330)

Browse source
This commit is contained in:
Benjamin Pasero 2020-09-09 16:51:31 +02:00
parent f41efe546c
commit c1e9502223
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/vs/workbench/contrib/files/browser/fileCommands.ts
View file

@ -371,9 +371,14 @@ async function saveSelectedEditors(accessor: ServicesAccessor, options?: ISaveEd
// Special treatment for side by side editors: if the active editor
// has 2 sides, we consider both, to support saving both sides.
// We only allow this when saving, not for "Save As".
// We only allow this when saving, not for "Save As" and not if any
// editor is untitled which would bring up a "Save As" dialog too.
// See also https://github.com/microsoft/vscode/issues/4180
if (activeGroup.activeEditor instanceof SideBySideEditorInput && !options?.saveAs) {
// See also https://github.com/microsoft/vscode/issues/106330
if (
activeGroup.activeEditor instanceof SideBySideEditorInput &&
!options?.saveAs && !(activeGroup.activeEditor.primary.isUntitled() || activeGroup.activeEditor.secondary.isUntitled())
) {
editors.push({ groupId: activeGroup.id, editor: activeGroup.activeEditor.primary });
editors.push({ groupId: activeGroup.id, editor: activeGroup.activeEditor.secondary });
} else {