maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

debt - remove appReady from timerService, use perf-marks

Browse source
This commit is contained in:
Johannes Rieken 2017-12-13 11:18:04 +01:00
parent 09f3da07b8
commit c219c3f733
5 changed files with 2 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/main.js
View file

@ -219,7 +219,6 @@ var nodeCachedDataDir = getNodeCachedDataDir().then(function (value) {
// Load our code once ready
app.once('ready', function () {
perf.mark('main:appReady');
global.perfAppReady = Date.now();
var nlsConfig = getNLSConfiguration();
process.env['VSCODE_NLS_CONFIG'] = JSON.stringify(nlsConfig);

1
src/vs/code/electron-main/window.ts
View file

@ -587,7 +587,6 @@ export class CodeWindow implements ICodeWindow {
// Perf Counters
windowConfiguration.perfEntries = exportEntries();
windowConfiguration.perfStartTime = global.perfStartTime;
windowConfiguration.perfAppReady = global.perfAppReady;
windowConfiguration.perfWindowLoadTime = Date.now();
// Config (combination of process.argv and window configuration)

1
src/vs/workbench/electron-browser/bootstrap/index.js
View file

@ -175,7 +175,6 @@ function main() {
isInitialStartup: !!configuration.isInitialStartup,
hasAccessibilitySupport: !!configuration.accessibilitySupport,
start: configuration.perfStartTime,
appReady: configuration.perfAppReady,
windowLoad: configuration.perfWindowLoadTime
};

4
src/vs/workbench/services/timer/common/timerService.ts
View file

@ -83,11 +83,7 @@ export interface IStartupMetrics {
export interface IInitData {
start: number;
appReady: number;
windowLoad: number;
isInitialStartup: boolean;
hasAccessibilitySupport: boolean;
}

6
src/vs/workbench/services/timer/node/timerService.ts
View file

@ -14,7 +14,6 @@ export class TimerService implements ITimerService {
public _serviceBrand: any;
public readonly start: number;
public readonly appReady: number;
public readonly windowLoad: number;
public readonly isInitialStartup: boolean;
@ -24,7 +23,6 @@ export class TimerService implements ITimerService {
constructor(initData: IInitData, private isEmptyWorkbench: boolean) {
this.start = initData.start;
this.appReady = initData.appReady;
this.windowLoad = initData.windowLoad;
this.isInitialStartup = initData.isInitialStartup;
@ -100,8 +98,8 @@ export class TimerService implements ITimerService {
};
if (initialStartup) {
this._startupMetrics.timers.ellapsedAppReady = this.appReady - this.start;
this._startupMetrics.timers.ellapsedWindowLoad = this.windowLoad - this.appReady;
this._startupMetrics.timers.ellapsedAppReady = perf.getDuration('main:started', 'main:appReady');
this._startupMetrics.timers.ellapsedWindowLoad = this.windowLoad - perf.getEntry('mark', 'main:appReady').startTime;
}
}
}