maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Make collapse/expanse cell actions apply to all selected cells

Browse source 
Fixes #121695

Currently these commands just apply to the active cell
This commit is contained in:
Matt Bierner 2021-04-20 11:56:11 -07:00
parent 1764fc81a8
commit c32f4d0afd
No known key found for this signature in database
GPG key ID: 099C331567E11888
1 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/vs/workbench/contrib/notebook/browser/contrib/coreActions.ts
View file

@ -94,25 +94,24 @@ export interface INotebookActionContext {
readonly cell?: ICellViewModel;
readonly notebookEditor: IActiveNotebookEditor;
readonly ui?: boolean;
readonly selectedCells?: ICellViewModel[];
}
export interface INotebookCellActionContext extends INotebookActionContext {
cell: ICellViewModel;
}
function getContextFromActiveEditor(editorService: IEditorService) {
function getContextFromActiveEditor(editorService: IEditorService): INotebookActionContext | undefined {
const editor = getNotebookEditorFromEditorPane(editorService.activeEditorPane);
if (!editor) {
return;
}
if (!editor.hasModel()) {
if (!editor || !editor.hasModel()) {
return;
}
const activeCell = editor.getActiveCell();
const selectedCells = editor.getSelectionViewModels();
return {
cell: activeCell,
selectedCells,
notebookEditor: editor
};
}
@ -1566,19 +1565,21 @@ registerAction2(class extends NotebookCellAction {
abstract class ChangeNotebookCellMetadataAction extends NotebookCellAction {
async runWithContext(accessor: ServicesAccessor, context: INotebookCellActionContext): Promise<void> {
const cell = context.cell;
const textModel = context.notebookEditor.viewModel.notebookDocument;
if (!textModel) {
return;
}
const index = textModel.cells.indexOf(cell.model);
if (index < 0) {
return;
const metadataDelta = this.getMetadataDelta();
const edits: ICellEditOperation[] = [];
for (const cell of context.selectedCells || []) {
const index = textModel.cells.indexOf(cell.model);
if (index >= 0) {
edits.push({ editType: CellEditType.Metadata, index, metadata: { ...context.cell.metadata, ...metadataDelta } });
}
}
textModel.applyEdits([{ editType: CellEditType.Metadata, index, metadata: { ...context.cell.metadata, ...this.getMetadataDelta() } }], true, undefined, () => undefined, undefined);
textModel.applyEdits(edits, true, undefined, () => undefined, undefined);
}
abstract getMetadataDelta(): NotebookCellMetadata;