maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove extra dispose implementations

Browse source
This commit is contained in:
Matt Bierner 2020-06-28 01:06:42 -07:00
parent 4521e5d1a6
commit c5b91342d6
1 changed files with 10 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
extensions/typescript-language-features/src/utils/dependentRegistration.ts
View file

@ -45,18 +45,14 @@ export class VersionDependentRegistration extends Disposable {
register: () => vscode.Disposable,
) {
super();
this._registration = new ConditionalRegistration(register);
this._registration = this._register(new ConditionalRegistration(register));
this._register(this.client.onTsServerStarted(() => {
this.update(this.client.apiVersion);
}));
this.update(client.apiVersion);
this.client.onTsServerStarted(() => {
this.update(this.client.apiVersion);
}, null, this._disposables);
}
public dispose() {
super.dispose();
this._registration.dispose();
}
private update(api: API) {
@ -74,14 +70,11 @@ export class ConfigurationDependentRegistration extends Disposable {
register: () => vscode.Disposable,
) {
super();
this._registration = new ConditionalRegistration(register);
this.update();
vscode.workspace.onDidChangeConfiguration(this.update, this, this._disposables);
}
this._registration = this._register(new ConditionalRegistration(register));
public dispose() {
super.dispose();
this._registration.dispose();
this._register(vscode.workspace.onDidChangeConfiguration(this.update, this));
this.update();
}
private update() {