maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove showing search result when the search viewlet visibility changes

Browse source 
This is broken and I don't really like this behavior anyway
This commit is contained in:
Rob Lourens 2019-07-03 12:02:40 -07:00
parent e5feef0d72
commit cb555f0004
1 changed files with 1 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/vs/workbench/contrib/search/browser/searchView.ts
View file

@ -320,14 +320,6 @@ export class SearchView extends ViewletPanel {
if (this.viewModel) {
this.viewModel.searchResult.toggleHighlights(visible);
}
// Open focused element from results in case the editor area is otherwise empty
if (visible && !this.editorService.activeEditor) {
const focus = this.tree.getFocus();
if (focus) {
this.onFocus(focus, true);
}
}
}
get searchAndReplaceWidget(): SearchWidget {
@ -1548,12 +1540,7 @@ export class SearchView extends ViewletPanel {
this.currentSelectedFileMatch = undefined;
}
private onFocus(lineMatch: any, preserveFocus?: boolean, sideBySide?: boolean, pinned?: boolean): Promise<any> {
if (!(lineMatch instanceof Match)) {
this.viewModel.searchResult.rangeHighlightDecorations.removeHighlightRange();
return Promise.resolve(true);
}
private onFocus(lineMatch: Match, preserveFocus?: boolean, sideBySide?: boolean, pinned?: boolean): Promise<any> {
const useReplacePreview = this.configurationService.getValue<ISearchConfiguration>().search.useReplacePreview;
return (useReplacePreview && this.viewModel.isReplaceActive() && !!this.viewModel.replaceString) ?
this.replaceService.openReplacePreview(lineMatch, preserveFocus, sideBySide, pinned) :