From ce57f8ad58fd0f4ea6051ae08b3894e47d8d4045 Mon Sep 17 00:00:00 2001 From: Git-Lior Date: Tue, 7 Apr 2020 23:22:28 +0300 Subject: [PATCH] bugfix - typescript code completion doesn't recognize property modifiers when more than one exists (#94165) * fix microsoft/TypeScript#37117 - code completion in typescript fails to recognize property modifiers * split kindModifiers by comma or spaces --- .../typescript-language-features/src/features/completions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/typescript-language-features/src/features/completions.ts b/extensions/typescript-language-features/src/features/completions.ts index 6758b85b0f6..594687ab97f 100644 --- a/extensions/typescript-language-features/src/features/completions.ts +++ b/extensions/typescript-language-features/src/features/completions.ts @@ -97,7 +97,7 @@ class MyCompletionItem extends vscode.CompletionItem { } if (tsEntry.kindModifiers) { - const kindModifiers = new Set(tsEntry.kindModifiers.split(/\s+/g)); + const kindModifiers = new Set(tsEntry.kindModifiers.split(/,|\s+/g)); if (kindModifiers.has(PConst.KindModifiers.optional)) { if (!this.insertText) { this.insertText = this.label;