maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

proper name for register function: registerFileDecorationProvider, #54938

Browse source
This commit is contained in:
Johannes Rieken 2020-11-19 08:13:18 +01:00
parent a36c68b9ec
commit d04f3178dc
5 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
extensions/git/src/decorationProvider.ts
View file

@ -26,7 +26,7 @@ class GitIgnoreDecorationProvider implements FileDecorationProvider {
model.onDidCloseRepository
));
this.disposables.push(window.registerDecorationProvider(this));
this.disposables.push(window.registerFileDecorationProvider(this));
}
async provideFileDecoration(uri: Uri): Promise<FileDecoration | undefined> {
@ -100,7 +100,7 @@ class GitDecorationProvider implements FileDecorationProvider {
constructor(private repository: Repository) {
this.disposables.push(
window.registerDecorationProvider(this),
window.registerFileDecorationProvider(this),
repository.onDidRunGitStatus(this.onDidRunGitStatus, this)
);
}

2
src/vs/vscode.proposed.d.ts vendored
View file

@ -801,7 +801,7 @@ declare module 'vscode' {
}
export namespace window {
export function registerDecorationProvider(provider: FileDecorationProvider): Disposable;
export function registerFileDecorationProvider(provider: FileDecorationProvider): Disposable;
}
//#endregion

4
src/vs/workbench/api/common/extHost.api.impl.ts
View file

@ -617,9 +617,9 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
registerCustomEditorProvider: (viewType: string, provider: vscode.CustomTextEditorProvider | vscode.CustomReadonlyEditorProvider, options: { webviewOptions?: vscode.WebviewPanelOptions, supportsMultipleEditorsPerDocument?: boolean } = {}) => {
return extHostCustomEditors.registerCustomEditorProvider(extension, viewType, provider, options);
},
registerDecorationProvider(provider: vscode.FileDecorationProvider) {
registerFileDecorationProvider(provider: vscode.FileDecorationProvider) {
checkProposedApiEnabled(extension);
return extHostDecorations.registerDecorationProvider(provider, extension.identifier);
return extHostDecorations.registerFileDecorationProvider(provider, extension.identifier);
},
registerUriHandler(handler: vscode.UriHandler) {
return extHostUrls.registerUriHandler(extension.identifier, handler);

2
src/vs/workbench/api/common/extHostDecorations.ts
View file

@ -37,7 +37,7 @@ export class ExtHostDecorations implements ExtHostDecorationsShape {
this._proxy = extHostRpc.getProxy(MainContext.MainThreadDecorations);
}
registerDecorationProvider(provider: vscode.FileDecorationProvider, extensionId: ExtensionIdentifier): vscode.Disposable {
registerFileDecorationProvider(provider: vscode.FileDecorationProvider, extensionId: ExtensionIdentifier): vscode.Disposable {
const handle = ExtHostDecorations._handlePool++;
this._provider.set(handle, { provider, extensionId });
this._proxy.$registerDecorationProvider(handle, extensionId.value);

4
src/vs/workbench/test/browser/api/extHostDecorations.test.ts
View file

@ -46,7 +46,7 @@ suite('ExtHostDecorations', function () {
let calledB = false;
// never returns
extHostDecorations.registerDecorationProvider({
extHostDecorations.registerFileDecorationProvider({
provideFileDecoration() {
calledA = true;
@ -55,7 +55,7 @@ suite('ExtHostDecorations', function () {
}, nullExtensionDescription.identifier);
// always returns
extHostDecorations.registerDecorationProvider({
extHostDecorations.registerFileDecorationProvider({
provideFileDecoration() {
calledB = true;