maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Adding more explicit typings for TS 4.1 new Promise logic

Browse source
This commit is contained in:
Matt Bierner 2020-09-16 08:47:51 -07:00
parent 240afbde58
commit d1b49cd8b9
4 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
extensions/vscode-api-tests/src/singlefolder-tests/languages.test.ts
View file

@ -31,7 +31,7 @@ suite('vscode API - languages', () => {
let clock = 0;
const disposables: vscode.Disposable[] = [];
let close = new Promise(resolve => {
let close = new Promise<void>(resolve => {
disposables.push(vscode.workspace.onDidCloseTextDocument(e => {
if (e === doc) {
assert.equal(doc.languageId, langIdNow);
@ -41,7 +41,7 @@ suite('vscode API - languages', () => {
}
}));
});
let open = new Promise(resolve => {
let open = new Promise<void>(resolve => {
disposables.push(vscode.workspace.onDidOpenTextDocument(e => {
if (e === doc) { // same instance!
assert.equal(doc.languageId, 'json');

10
extensions/vscode-api-tests/src/singlefolder-tests/window.test.ts
View file

@ -85,7 +85,7 @@ suite('vscode API - window', () => {
let [one, two] = editors;
await new Promise(resolve => {
await new Promise<void>(resolve => {
let registration2 = window.onDidChangeTextEditorViewColumn(event => {
actualEvent = event;
registration2.dispose();
@ -120,7 +120,7 @@ suite('vscode API - window', () => {
let [, two] = editors;
two.show();
return new Promise(resolve => {
return new Promise<void>(resolve => {
let registration2 = window.onDidChangeTextEditorViewColumn(event => {
actualEvents.push(event);
@ -433,7 +433,7 @@ suite('vscode API - window', () => {
let i = 0;
const resolves: ((value: string) => void)[] = [];
let done: () => void;
const unexpected = new Promise((resolve, reject) => {
const unexpected = new Promise<void>((resolve, reject) => {
done = () => resolve();
resolves.push(reject);
});
@ -594,7 +594,7 @@ suite('vscode API - window', () => {
function createQuickPickTracker<T extends string | QuickPickItem>() {
const resolves: ((value: T) => void)[] = [];
let done: () => void;
const unexpected = new Promise((resolve, reject) => {
const unexpected = new Promise<void>((resolve, reject) => {
done = () => resolve();
resolves.push(reject);
});
@ -613,7 +613,7 @@ suite('vscode API - window', () => {
return workspace.openTextDocument(join(workspace.rootPath || '', './far.js')).then(doc => window.showTextDocument(doc)).then(editor => {
return new Promise((resolve, _reject) => {
return new Promise<void>((resolve, _reject) => {
let subscription = window.onDidChangeTextEditorSelection(e => {
assert.ok(e.textEditor === editor);

4
extensions/vscode-api-tests/src/singlefolder-tests/workspace.tasks.test.ts
View file

@ -168,7 +168,7 @@ import { window, tasks, Disposable, TaskDefinition, Task, EventEmitter, CustomEx
});
test('Execution from onDidEndTaskProcess and onDidStartTaskProcess are equal to original', () => {
return new Promise(async (resolve) => {
return new Promise<void>(async (resolve) => {
const task = new Task({ type: 'testTask' }, TaskScope.Workspace, 'echo', 'testTask', new ShellExecution('echo', ['hello test']));
let taskExecution: TaskExecution | undefined;
const executeDoneEvent: EventEmitter<void> = new EventEmitter();
@ -213,7 +213,7 @@ import { window, tasks, Disposable, TaskDefinition, Task, EventEmitter, CustomEx
// https://github.com/microsoft/vscode/issues/100577
test('A CustomExecution task can be fetched and executed', () => {
return new Promise(async (resolve, reject) => {
return new Promise<void>(async (resolve, reject) => {
class CustomTerminal implements Pseudoterminal {
private readonly writeEmitter = new EventEmitter<string>();
public readonly onDidWrite: Event<string> = this.writeEmitter.event;

4
extensions/vscode-notebook-tests/src/notebook.test.ts
View file

@ -57,7 +57,7 @@ async function splitEditor() {
}
async function saveFileAndCloseAll(resource: vscode.Uri) {
const documentClosed = new Promise((resolve, _reject) => {
const documentClosed = new Promise<void>((resolve, _reject) => {
const d = vscode.notebook.onDidCloseNotebookDocument(e => {
if (e.uri.toString() === resource.toString()) {
d.dispose();
@ -71,7 +71,7 @@ async function saveFileAndCloseAll(resource: vscode.Uri) {
}
async function saveAllFilesAndCloseAll(resource: vscode.Uri | undefined) {
const documentClosed = new Promise((resolve, _reject) => {
const documentClosed = new Promise<void>((resolve, _reject) => {
if (!resource) {
return resolve();
}