From d1dfa5e91b463d261295a0830f7b9cf871aa1750 Mon Sep 17 00:00:00 2001
From: Johannes Rieken <johannes.rieken@gmail.com>
Date: Fri, 17 Apr 2020 09:05:58 +0200
Subject: [PATCH] iterate over suggestions only once, #95324

---
 .../src/features/completions.ts                          | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/extensions/typescript-language-features/src/features/completions.ts b/extensions/typescript-language-features/src/features/completions.ts
index e1ef02c998c..df7f7ea9a5b 100644
--- a/extensions/typescript-language-features/src/features/completions.ts
+++ b/extensions/typescript-language-features/src/features/completions.ts
@@ -535,9 +535,12 @@ class TypeScriptCompletionItemProvider implements vscode.CompletionItemProvider
 			useFuzzyWordRangeLogic: this.client.apiVersion.lt(API.v390),
 		};
 
-		const items = entries
-			.filter(entry => !shouldExcludeCompletionEntry(entry, completionConfiguration))
-			.map(entry => new MyCompletionItem(position, document, entry, completionContext, metadata));
+		const items: vscode.CompletionItem[] = [];
+		for (let entry of entries) {
+			if (!shouldExcludeCompletionEntry(entry, completionConfiguration)) {
+				items.push(new MyCompletionItem(position, document, entry, completionContext, metadata));
+			}
+		}
 		return new vscode.CompletionList(items, isIncomplete);
 	}