maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Hack to work around terminal firing exit before line data

Browse source 
Part of #92868
This commit is contained in:
Alex Ross 2020-05-26 11:30:58 +02:00
parent 1ba6a15920
commit d6354443f4
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts
View file

@ -821,7 +821,6 @@ export class TerminalTaskSystem implements ITaskSystem {
});
promise = new Promise<ITaskSummary>((resolve, reject) => {
const onExit = terminal!.onExit((exitCode) => {
onData.dispose();
onExit.dispose();
let key = task.getMapKey();
this.removeFromActiveTasks(task);
@ -847,8 +846,12 @@ export class TerminalTaskSystem implements ITaskSystem {
this.terminalService.setActiveInstance(terminal);
this.terminalService.showPanel(false);
}
startStopProblemMatcher.done();
startStopProblemMatcher.dispose();
// Hack to work around #92868 until terminal is fixed.
setTimeout(() => {
onData.dispose();
startStopProblemMatcher.done();
startStopProblemMatcher.dispose();
}, 100);
if (!processStartedSignaled && terminal) {
this._onDidStateChange.fire(TaskEvent.create(TaskEventKind.ProcessStarted, task, terminal.processId!));
processStartedSignaled = true;