maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Improve getting started response to slow network conditions for content overrides

Browse source
This commit is contained in:
Jackson Kearl 2021-03-22 15:03:15 -07:00
parent efb75d7262
commit d657779c01
No known key found for this signature in database
GPG key ID: DA09A59C409FC400
2 changed files with 7 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/vs/workbench/contrib/welcome/gettingStarted/browser/gettingStarted.ts
View file

@ -38,6 +38,7 @@ import { splitName } from 'vs/base/common/labels';
import { IHostService } from 'vs/workbench/services/host/browser/host';
import { coalesce } from 'vs/base/common/arrays';
import { isMacintosh } from 'vs/base/common/platform';
import { Throttler } from 'vs/base/common/async';
const SLIDE_TRANSITION_TIME_MS = 250;
const configurationKey = 'workbench.startupEditor';
@ -107,6 +108,7 @@ export class GettingStartedPage extends EditorPane {
private categoriesScrollbar: DomScrollableElement | undefined;
private detailsScrollbar: DomScrollableElement | undefined;
private detailImageScrollbar: DomScrollableElement | undefined;
private buildSlideThrottle: Throttler = new Throttler();
private container: HTMLElement;
@ -150,22 +152,17 @@ export class GettingStartedPage extends EditorPane {
this.gettingStartedCategories = this.gettingStartedService.getCategories();
this._register(this.dispatchListeners);
this.buildSlideThrottle = new Throttler();
this._register(this.gettingStartedService.onDidAddTask(task => {
this.gettingStartedCategories = this.gettingStartedService.getCategories();
this.buildCategoriesSlide();
this.buildSlideThrottle.queue(() => this.buildCategoriesSlide());
}));
this._register(this.gettingStartedService.onDidChangeTask(task => {
const ourCategory = this.gettingStartedCategories.find(c => c.id === task.category);
if (!ourCategory || ourCategory.content.type === 'startEntry') {
console.error('Attempting to modify category that does not exist or is invalid type', task);
return;
}
if (!ourCategory || ourCategory.content.type === 'startEntry') { return; }
const ourTask = ourCategory.content.items.find(item => item.id === task.id);
if (!ourTask) {
console.error('Attempting to modify task that cannot be found', task);
return;
}
if (!ourTask) { return; }
ourTask.title = task.title;
ourTask.description = task.description;
ourTask.media.path = task.media.path;
@ -173,10 +170,7 @@ export class GettingStartedPage extends EditorPane {
this._register(this.gettingStartedService.onDidChangeCategory(category => {
const ourCategory = this.gettingStartedCategories.find(c => c.id === category.id);
if (!ourCategory) {
console.error('Attempting to modify category that does not exist or is invalid type', category);
return;
}
if (!ourCategory) { return; }
ourCategory.title = category.title;
ourCategory.description = category.description;

1
src/vs/workbench/contrib/welcome/gettingStarted/common/gettingStartedService.ts
View file

@ -212,7 +212,6 @@ export class GettingStartedService extends Disposable implements IGettingStarted
const existing = assertIsDefined(this.gettingStartedContributions.get(category.id));
existing.title = title ?? existing.title;
existing.description = description ?? existing.description;
console.log('hello', title, description, existing);
this._onDidChangeCategory.fire(this.getCategoryProgress(existing));
} else {
resolve({