maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

remove undefined from outline data source

Browse source
This commit is contained in:
Johannes Rieken 2021-01-13 14:16:47 +01:00
parent cf03ef33f4
commit daa7afebd0
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/contrib/codeEditor/browser/outline/documentSymbolsOutline.ts
View file

@ -142,7 +142,7 @@ class DocumentSymbolsOutline implements IOutline<DocumentSymbolItem> {
this._breadcrumbsDataSource = new DocumentSymbolBreadcrumbsSource(_editor, textResourceConfigurationService);
const delegate = new DocumentSymbolVirtualDelegate();
const renderers = [new DocumentSymbolGroupRenderer(), instantiationService.createInstance(DocumentSymbolRenderer, true)];
const treeDataSource: IDataSource<this | undefined, DocumentSymbolItem> = {
const treeDataSource: IDataSource<this, DocumentSymbolItem> = {
getChildren: (parent) => {
if (parent instanceof OutlineElement || parent instanceof OutlineGroup) {
return parent.children.values();

2
src/vs/workbench/contrib/notebook/browser/contrib/outline/notebookOutline.ts
View file

@ -322,7 +322,7 @@ class NotebookCellOutline implements IOutline<OutlineEntry> {
keyboardNavigationLabelProvider: new NotebookNavigationLabelProvider()
};
const treeDataSource: IDataSource<this | undefined, OutlineEntry> = { getChildren: parent => parent instanceof NotebookCellOutline ? this._entries : parent?.children ?? [] };
const treeDataSource: IDataSource<this, OutlineEntry> = { getChildren: parent => parent instanceof NotebookCellOutline ? this._entries : parent.children };
const delegate = new NotebookOutlineVirtualDelegate();
const renderers = [instantiationService.createInstance(NotebookOutlineRenderer)];
const comparator = new NotebookComparator();

2
src/vs/workbench/services/outline/browser/outline.ts
View file

@ -59,7 +59,7 @@ export interface IQuickPickDataSource<E> {
export interface IOutlineListConfig<E> {
readonly breadcrumbsDataSource: IBreadcrumbsDataSource<E>;
readonly treeDataSource: IDataSource<IOutline<E> | undefined, E>;
readonly treeDataSource: IDataSource<IOutline<E>, E>;
readonly delegate: IListVirtualDelegate<E>;
readonly renderers: ITreeRenderer<E, FuzzyScore, any>[];
readonly comparator: IOutlineComparator<E>;