maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix scm groups count badge

Browse source
This commit is contained in:
Joao Moreno 2017-11-20 21:33:07 +01:00
parent dfc24221a5
commit dbfa1c0ae5
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/vs/workbench/parts/scm/electron-browser/scmViewlet.ts
View file

@ -340,6 +340,7 @@ interface ResourceGroupTemplate {
name: HTMLElement;
count: CountBadge;
actionBar: ActionBar;
elementDisposable: IDisposable;
dispose: () => void;
}
@ -362,9 +363,10 @@ class ResourceGroupRenderer implements IRenderer<ISCMResourceGroup, ResourceGrou
const countContainer = append(element, $('.count'));
const count = new CountBadge(countContainer);
const styler = attachBadgeStyler(count, this.themeService);
const elementDisposable = EmptyDisposable;
return {
name, count, actionBar, dispose: () => {
name, count, actionBar, elementDisposable, dispose: () => {
actionBar.dispose();
styler.dispose();
}
@ -372,11 +374,16 @@ class ResourceGroupRenderer implements IRenderer<ISCMResourceGroup, ResourceGrou
}
renderElement(group: ISCMResourceGroup, index: number, template: ResourceGroupTemplate): void {
template.elementDisposable.dispose();
template.name.textContent = group.label;
template.count.setCount(group.elements.length);
template.actionBar.clear();
template.actionBar.context = group;
template.actionBar.push(this.scmMenus.getResourceGroupActions(group), { icon: true, label: false });
const updateCount = () => template.count.setCount(group.elements.length);
template.elementDisposable = group.onDidSplice(updateCount);
updateCount();
}
disposeTemplate(template: ResourceGroupTemplate): void {