From ecd39ef3c1f0a26ad7cea54b10ea2de60ff1ddc2 Mon Sep 17 00:00:00 2001 From: Joao Moreno Date: Wed, 17 Aug 2016 09:04:36 +0200 Subject: [PATCH] remove fallback from package.ts and product.ts --- src/vs/platform/package.ts | 16 +++------------- src/vs/platform/product.ts | 15 +++------------ test/all.js | 8 ++++---- 3 files changed, 10 insertions(+), 29 deletions(-) diff --git a/src/vs/platform/package.ts b/src/vs/platform/package.ts index d8ba7e07908..fff85d911f2 100644 --- a/src/vs/platform/package.ts +++ b/src/vs/platform/package.ts @@ -11,16 +11,6 @@ export interface IPackageConfiguration { version: string; } -let pkg: IPackageConfiguration; -try { - const rootPath = path.dirname(uri.parse(require.toUrl('')).fsPath); - const packageJsonPath = path.join(rootPath, 'package.json'); - pkg = require.__$__nodeRequire(packageJsonPath) as IPackageConfiguration; -} catch (error) { - pkg = { - name: 'code-oss-dev', - version: '1.x.x' - }; -} - -export default pkg; \ No newline at end of file +const rootPath = path.dirname(uri.parse(require.toUrl('')).fsPath); +const packageJsonPath = path.join(rootPath, 'package.json'); +export default require.__$__nodeRequire(packageJsonPath) as IPackageConfiguration; \ No newline at end of file diff --git a/src/vs/platform/product.ts b/src/vs/platform/product.ts index 81e6c30d8d6..720faaaad87 100644 --- a/src/vs/platform/product.ts +++ b/src/vs/platform/product.ts @@ -47,18 +47,9 @@ export interface IProductConfiguration { npsSurveyUrl: string; } -let product: IProductConfiguration; -try { - const rootPath = path.dirname(uri.parse(require.toUrl('')).fsPath); - const productJsonPath = path.join(rootPath, 'product.json'); - product = require.__$__nodeRequire(productJsonPath) as IProductConfiguration; -} catch (error) { - product = { - nameLong: 'Code - OSS', - applicationName: 'code-oss', - dataFolderName: '.vscode-oss' - }; -} +const rootPath = path.dirname(uri.parse(require.toUrl('')).fsPath); +const productJsonPath = path.join(rootPath, 'product.json'); +const product = require.__$__nodeRequire(productJsonPath) as IProductConfiguration; if (process.env['VSCODE_DEV']) { product.nameShort += ' Dev'; diff --git a/test/all.js b/test/all.js index 208d9ca2514..6bd7d62862b 100644 --- a/test/all.js +++ b/test/all.js @@ -79,11 +79,11 @@ function main() { var loaderConfig = { nodeRequire: require, nodeMain: __filename, - baseUrl: path.join(path.dirname(__dirname)), + baseUrl: path.join(path.dirname(__dirname), 'src'), paths: { - 'vs': out + '/vs', - 'lib': out + '/lib', - 'bootstrap': out + '/bootstrap' + 'vs': `../${ out }/vs`, + 'lib': `../${ out }/lib`, + 'bootstrap': `../${ out }/bootstrap` }, catchError: true };