maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Move show/hide/unhide into markdown cell

Browse source
This commit is contained in:
Matt Bierner 2021-06-08 15:26:50 -07:00
parent a336b7a424
commit ed9bd5919e
No known key found for this signature in database
GPG key ID: 099C331567E11888
1 changed files with 42 additions and 41 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

83
src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
View file

@ -1049,64 +1049,40 @@ async function webviewPreloads(style: PreloadStyles, options: PreloadOptions, re
}
public deleteMarkupCell(id: string) {
const entry = this._markupCells.get(id);
if (!entry) {
return;
const cell = this.getExpectedMarkupCell(id);
if (cell) {
cell.element.remove();
this._markupCells.delete(id);
}
entry.element.remove();
this._markupCells.delete(id);
}
public async updateMarkupContent(id: string, newContent: string): Promise<void> {
const cell = this._markupCells.get(id);
if (!cell) {
throw new Error('Trying to update a cell that does not exist');
}
return cell.updateContentAndRender(newContent);
const cell = this.getExpectedMarkupCell(id);
await cell?.updateContentAndRender(newContent);
}
public showMarkupCell(id: string, top: number, newContent: string | undefined): void {
const cell = this._markupCells.get(id);
if (!cell) {
console.log(`Could not find markup cell '${id}'`);
return;
}
cell.element.style.visibility = 'visible';
cell.element.style.top = `${top}px`;
if (typeof newContent === 'string') {
cell.updateContentAndRender(newContent);
} else {
this.updateMarkupDimensions(cell);
}
const cell = this.getExpectedMarkupCell(id);
cell?.show(id, top, newContent);
}
public hideMarkupCell(id: string): void {
const cell = this._markupCells.get(id);
if (!cell) {
console.log(`Could not find markup cell '${id}'`);
return;
}
cell.element.style.visibility = 'hidden';
const cell = this.getExpectedMarkupCell(id);
cell?.hide();
}
public unhideMarkupCell(id: string): void {
const cell = this.getExpectedMarkupCell(id);
cell?.unhide();
}
private getExpectedMarkupCell(id: string): MarkdownCell | undefined {
const cell = this._markupCells.get(id);
if (!cell) {
console.log(`Could not find markup cell '${id}'`);
return;
return undefined;
}
cell.element.style.visibility = 'visible';
this.updateMarkupDimensions(cell);
}
private async updateMarkupDimensions(cell: MarkdownCell) {
dimensionUpdater.update(cell.id, cell.element.clientHeight, {
isOutput: false
});
return cell;
}
}();
@ -1231,6 +1207,31 @@ async function webviewPreloads(style: PreloadStyles, options: PreloadOptions, re
isOutput: false
});
}
public show(id: string, top: number, newContent: string | undefined): void {
this.element.style.visibility = 'visible';
this.element.style.top = `${top}px`;
if (typeof newContent === 'string') {
this.updateContentAndRender(newContent);
} else {
this.updateMarkupDimensions();
}
}
public hide() {
this.element.style.visibility = 'hidden';
}
public unhide() {
this.element.style.visibility = 'visible';
this.updateMarkupDimensions();
}
private async updateMarkupDimensions() {
dimensionUpdater.update(this.id, this.element.clientHeight, {
isOutput: false
});
}
}
vscode.postMessage({