From efb781e5becac763a91e7a7434aaef671b38d9a9 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Mon, 10 Feb 2020 16:57:41 -0800 Subject: [PATCH] Marking that documents/workspaces arrays cannot be mutated --- extensions/css-language-features/client/src/customData.ts | 2 +- extensions/html-language-features/client/src/customData.ts | 2 +- .../src/typescriptServiceClient.ts | 2 +- src/vs/vscode.d.ts | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/extensions/css-language-features/client/src/customData.ts b/extensions/css-language-features/client/src/customData.ts index 7054d0f1ba9..92d9030a343 100644 --- a/extensions/css-language-features/client/src/customData.ts +++ b/extensions/css-language-features/client/src/customData.ts @@ -13,7 +13,7 @@ interface ExperimentalConfig { }; } -export function getCustomDataPathsInAllWorkspaces(workspaceFolders: WorkspaceFolder[] | undefined): string[] { +export function getCustomDataPathsInAllWorkspaces(workspaceFolders: readonly WorkspaceFolder[] | undefined): string[] { const dataPaths: string[] = []; if (!workspaceFolders) { diff --git a/extensions/html-language-features/client/src/customData.ts b/extensions/html-language-features/client/src/customData.ts index 14d8a66a8aa..38b51d37596 100644 --- a/extensions/html-language-features/client/src/customData.ts +++ b/extensions/html-language-features/client/src/customData.ts @@ -13,7 +13,7 @@ interface ExperimentalConfig { }; } -export function getCustomDataPathsInAllWorkspaces(workspaceFolders: WorkspaceFolder[] | undefined): string[] { +export function getCustomDataPathsInAllWorkspaces(workspaceFolders: readonly WorkspaceFolder[] | undefined): string[] { const dataPaths: string[] = []; if (!workspaceFolders) { diff --git a/extensions/typescript-language-features/src/typescriptServiceClient.ts b/extensions/typescript-language-features/src/typescriptServiceClient.ts index db218a8f8a8..1fb1dce18b0 100644 --- a/extensions/typescript-language-features/src/typescriptServiceClient.ts +++ b/extensions/typescript-language-features/src/typescriptServiceClient.ts @@ -634,7 +634,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType } public getWorkspaceRootForResource(resource: vscode.Uri): string | undefined { - const roots = vscode.workspace.workspaceFolders; + const roots = vscode.workspace.workspaceFolders ? Array.from(vscode.workspace.workspaceFolders) : undefined; if (!roots || !roots.length) { return undefined; } diff --git a/src/vs/vscode.d.ts b/src/vs/vscode.d.ts index c2aad774b55..4f97500f6c2 100644 --- a/src/vs/vscode.d.ts +++ b/src/vs/vscode.d.ts @@ -8435,7 +8435,7 @@ declare module 'vscode' { * List of workspace folders or `undefined` when no folder is open. * *Note* that the first entry corresponds to the value of `rootPath`. */ - export const workspaceFolders: WorkspaceFolder[] | undefined; + export const workspaceFolders: ReadonlyArray | undefined; /** * The name of the workspace. `undefined` when no folder @@ -8609,7 +8609,7 @@ declare module 'vscode' { /** * All text documents currently known to the system. */ - export const textDocuments: TextDocument[]; + export const textDocuments: ReadonlyArray; /** * Opens a document. Will return early if this document is already open. Otherwise