From f01f7ebe93337574c9b0b9f776a57a21d7833570 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Tue, 31 Dec 2019 09:53:57 +0100 Subject: [PATCH] fix some (future) linting issues --- extensions/npm/extension.webpack.config.js | 2 +- extensions/search-result/syntaxes/generateTMLanguage.js | 2 ++ extensions/shared.webpack.config.js | 4 ++-- .../src/test/functionCallSnippet.test.ts | 3 +++ src/vs/base/common/performance.js | 2 +- 5 files changed, 9 insertions(+), 4 deletions(-) diff --git a/extensions/npm/extension.webpack.config.js b/extensions/npm/extension.webpack.config.js index d50d9966f63..56a1589f460 100644 --- a/extensions/npm/extension.webpack.config.js +++ b/extensions/npm/extension.webpack.config.js @@ -19,7 +19,7 @@ module.exports = withDefaults({ output: { filename: 'main.js', path: path.join(__dirname, 'dist'), - libraryTarget: "commonjs", + libraryTarget: 'commonjs', }, resolve: { mainFields: ['module', 'main'], diff --git a/extensions/search-result/syntaxes/generateTMLanguage.js b/extensions/search-result/syntaxes/generateTMLanguage.js index 10245850891..51d9e0ea7c3 100644 --- a/extensions/search-result/syntaxes/generateTMLanguage.js +++ b/extensions/search-result/syntaxes/generateTMLanguage.js @@ -1,4 +1,6 @@ // @ts-check +// todo@jackson +/* eslint code-no-unexternalized-strings: 0 */ const mappings = [ ['bat', 'source.batchfile'], diff --git a/extensions/shared.webpack.config.js b/extensions/shared.webpack.config.js index 2fba65c92bd..2bcb6c47474 100644 --- a/extensions/shared.webpack.config.js +++ b/extensions/shared.webpack.config.js @@ -49,7 +49,7 @@ module.exports = function withDefaults(/**@type WebpackConfig*/extConfig) { loader: 'ts-loader', options: { compilerOptions: { - "sourceMap": true, + 'sourceMap': true, } } }] @@ -63,7 +63,7 @@ module.exports = function withDefaults(/**@type WebpackConfig*/extConfig) { // packaging depends on that and this must always be like it filename: '[name].js', path: path.join(extConfig.context, 'dist'), - libraryTarget: "commonjs", + libraryTarget: 'commonjs', }, // yes, really source maps devtool: 'source-map', diff --git a/extensions/typescript-language-features/src/test/functionCallSnippet.test.ts b/extensions/typescript-language-features/src/test/functionCallSnippet.test.ts index e053719f3d4..1289b87b4bc 100644 --- a/extensions/typescript-language-features/src/test/functionCallSnippet.test.ts +++ b/extensions/typescript-language-features/src/test/functionCallSnippet.test.ts @@ -3,6 +3,9 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ +// todo@matt +/* eslint code-no-unexternalized-strings: 0 */ + import * as assert from 'assert'; import 'mocha'; import * as vscode from 'vscode'; diff --git a/src/vs/base/common/performance.js b/src/vs/base/common/performance.js index 2bc77108620..16960cea069 100644 --- a/src/vs/base/common/performance.js +++ b/src/vs/base/common/performance.js @@ -100,7 +100,7 @@ if (typeof global === 'object') { if (typeof define === 'function') { // amd define([], function () { return _factory(sharedObj); }); -} else if (typeof module === "object" && typeof module.exports === "object") { +} else if (typeof module === 'object' && typeof module.exports === 'object') { // commonjs module.exports = _factory(sharedObj); } else {