From 766fbd0443c3136363b74eacebd6cf3e997a4cbf Mon Sep 17 00:00:00 2001 From: Miguel Solorio Date: Tue, 4 Sep 2018 15:30:02 -0700 Subject: [PATCH 1/3] Update outline color to be slightly brighter --- src/vs/platform/theme/common/colorRegistry.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/platform/theme/common/colorRegistry.ts b/src/vs/platform/theme/common/colorRegistry.ts index 3aeda392f74..96f6db438ff 100644 --- a/src/vs/platform/theme/common/colorRegistry.ts +++ b/src/vs/platform/theme/common/colorRegistry.ts @@ -153,7 +153,7 @@ export const foreground = registerColor('foreground', { dark: '#CCCCCC', light: export const errorForeground = registerColor('errorForeground', { dark: '#F48771', light: '#A1260D', hc: '#F48771' }, nls.localize('errorForeground', "Overall foreground color for error messages. This color is only used if not overridden by a component.")); export const descriptionForeground = registerColor('descriptionForeground', { light: '#717171', dark: transparent(foreground, 0.7), hc: transparent(foreground, 0.7) }, nls.localize('descriptionForeground', "Foreground color for description text providing additional information, for example for a label.")); -export const focusBorder = registerColor('focusBorder', { dark: Color.fromHex('#0E639C').transparent(0.6), light: Color.fromHex('#007ACC').transparent(0.4), hc: '#F38518' }, nls.localize('focusBorder', "Overall border color for focused elements. This color is only used if not overridden by a component.")); +export const focusBorder = registerColor('focusBorder', { dark: Color.fromHex('#0E639C').transparent(0.8), light: Color.fromHex('#007ACC').transparent(0.4), hc: '#F38518' }, nls.localize('focusBorder', "Overall border color for focused elements. This color is only used if not overridden by a component.")); export const contrastBorder = registerColor('contrastBorder', { light: null, dark: null, hc: '#6FC3DF' }, nls.localize('contrastBorder', "An extra border around elements to separate them from others for greater contrast.")); export const activeContrastBorder = registerColor('contrastActiveBorder', { light: null, dark: null, hc: focusBorder }, nls.localize('activeContrastBorder', "An extra border around active elements to separate them from others for greater contrast.")); From 8d12adc72399b465b0db1c6422bbe74cadabfcbe Mon Sep 17 00:00:00 2001 From: Miguel Solorio Date: Tue, 4 Sep 2018 15:30:44 -0700 Subject: [PATCH 2/3] Make keybindings.json link brighter when in focus --- .../preferences/browser/media/keybindingsEditor.css | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/parts/preferences/browser/media/keybindingsEditor.css b/src/vs/workbench/parts/preferences/browser/media/keybindingsEditor.css index 7951d65678f..5fc8abaf148 100644 --- a/src/vs/workbench/parts/preferences/browser/media/keybindingsEditor.css +++ b/src/vs/workbench/parts/preferences/browser/media/keybindingsEditor.css @@ -45,16 +45,23 @@ .keybindings-editor > .keybindings-header .open-keybindings-container { margin-top: 10px; - opacity: 0.7; display: flex; } +.keybindings-editor > .keybindings-header .open-keybindings-container > div { + opacity: 0.7; +} + .keybindings-editor > .keybindings-header .open-keybindings-container > .file-name { text-decoration: underline; cursor: pointer; margin-left: 4px; } +.keybindings-editor > .keybindings-header .open-keybindings-container > .file-name:focus { + opacity: 1; +} + /** List based styling **/ .keybindings-editor > .keybindings-body .keybindings-list-container { From 09ce28b83093dd337a62ef869d0c4435f234a1ae Mon Sep 17 00:00:00 2001 From: Miguel Solorio Date: Tue, 4 Sep 2018 15:31:16 -0700 Subject: [PATCH 3/3] Make sort icon 1px smaller so there's a gap for outline focus --- .../parts/preferences/browser/media/sort_precedence.svg | 2 +- .../parts/preferences/browser/media/sort_precedence_inverse.svg | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/parts/preferences/browser/media/sort_precedence.svg b/src/vs/workbench/parts/preferences/browser/media/sort_precedence.svg index 25b013f5c32..07e6d6b84ba 100644 --- a/src/vs/workbench/parts/preferences/browser/media/sort_precedence.svg +++ b/src/vs/workbench/parts/preferences/browser/media/sort_precedence.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/src/vs/workbench/parts/preferences/browser/media/sort_precedence_inverse.svg b/src/vs/workbench/parts/preferences/browser/media/sort_precedence_inverse.svg index 1b4301884a6..92c9a64dbc4 100644 --- a/src/vs/workbench/parts/preferences/browser/media/sort_precedence_inverse.svg +++ b/src/vs/workbench/parts/preferences/browser/media/sort_precedence_inverse.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file