maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove _wrapWebWorkerExtHostInIframe

Browse source
This commit is contained in:
Alexandru Dima 2021-03-05 17:10:00 +01:00
parent 25dc50c18e
commit f7ff53d7b0
No known key found for this signature in database
GPG key ID: 6E58D7B045760DA0
2 changed files with 1 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts
View file

@ -85,14 +85,6 @@ export class WebWorkerExtensionHost extends Disposable implements IExtensionHost
this._extensionHostLogFile = joinPath(this._extensionHostLogsLocation, `${ExtensionHostLogFileName}.log`);
}
private _wrapInIframe(): boolean {
if (this._environmentService.options && typeof this._environmentService.options._wrapWebWorkerExtHostInIframe === 'boolean') {
return this._environmentService.options._wrapWebWorkerExtHostInIframe;
}
// wrap in <iframe> by default
return true;
}
private _webWorkerExtensionHostIframeSrc(): string | null {
if (this._environmentService.options && this._environmentService.options.webWorkerExtensionHostIframeSrc) {
return this._environmentService.options.webWorkerExtensionHostIframeSrc;
@ -119,7 +111,7 @@ export class WebWorkerExtensionHost extends Disposable implements IExtensionHost
if (!this._protocolPromise) {
if (platform.isWeb) {
const webWorkerExtensionHostIframeSrc = this._webWorkerExtensionHostIframeSrc();
if (webWorkerExtensionHostIframeSrc && this._wrapInIframe()) {
if (webWorkerExtensionHostIframeSrc) {
this._protocolPromise = this._startInsideIframe(webWorkerExtensionHostIframeSrc);
} else {
console.warn(`The web worker extension host is started without an iframe sandbox!`);

7
src/vs/workbench/workbench.web.api.ts
View file

@ -323,13 +323,6 @@ interface IWorkbenchConstructionOptions {
*/
readonly _enableBuiltinExtensions?: boolean;
/**
* [TEMPORARY]: This will be removed soon.
* Enable `<iframe>` wrapping.
* Defaults to false.
*/
readonly _wrapWebWorkerExtHostInIframe?: boolean;
/**
* Support for URL callbacks.
*/