maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix #99195.

Browse source
This commit is contained in:
rebornix 2020-06-02 19:01:58 -07:00
parent 42d1059b4c
commit f8410b439e
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/vs/workbench/contrib/notebook/browser/notebookEditor.ts
View file

@ -96,7 +96,11 @@ export class NotebookEditor extends BaseEditor {
this.saveEditorViewState(this.input);
}
this._widget?.onWillHide();
if (this.input && NotebookRegistry.getNotebookEditorWidget(this.input as NotebookEditorInput) === this._widget) {
// the widget is not transfered to other editor inputs
this._widget?.onWillHide();
}
super.onWillHide();
}
@ -147,8 +151,12 @@ export class NotebookEditor extends BaseEditor {
const existingEditorWidgetForInput = NotebookRegistry.getNotebookEditorWidget(input);
if (existingEditorWidgetForInput) {
// hide current widget
this._widget?.onWillHide();
// hide previous widget
if (NotebookRegistry.getNotebookEditorWidget(this.input! as NotebookEditorInput) === this._widget) {
// the widet is not transfered to other editor inputs
this._widget?.onWillHide();
}
// previous widget is then detached
// set the new one
this._widget = existingEditorWidgetForInput;