Commit graph

7586 commits

Author SHA1 Message Date
Rachel Macfarlane 700780d927
Set default colors for 'minimap.selectionHighlight' in other built in themes 2019-09-12 16:40:57 -07:00
Johannes Rieken 9aab002dea push workaround for ts-loader weirdness 2019-09-12 09:59:31 +02:00
Matt Bierner 153e063486 Fix markdown preview refresh command potentially resetting preview scroll position to top if focused on preview
Fixes #80680
2019-09-11 20:50:52 -07:00
Matt Bierner 22db92f71b Add telemetry event when TS server is spawned
This is needed to help us better understand which TS versions users have enabled in their workspaces
2019-09-11 18:03:14 -07:00
Matt Bierner f4524551e9 Remove gating for TS < 2.2.0 features
Based on telemetry, these versions have pretty much zero usage in the past 30 days. Removing the extra gating code since we can now assume users are on TS > 2.2.
2019-09-11 15:50:50 -07:00
Matt Bierner a835f40c5b Remove deprecated scrollPreviewWithEditorSelection setting 2019-09-11 14:28:22 -07:00
Pine Wu 4dec1f7b49 Fix #32200 2019-09-11 14:27:25 -07:00
Konstantin Solomatov 5db460d2fe Fix activation of linters on unopened files caused by markdown plugin (#80506)
* Fix bug causing a large number of linters to be activated due to the markdown extension opening TextDocuments during indexing

* indentation problem

* code review by @OmarTawfik

* revert changed file

* Code review: use nodejs' Buffer

* fix ineffcient code
code review comments

* introduce SkinnyTextLine

* refactor redundant code

* revert changed files

* formatting

* remove empty line
2019-09-11 11:39:08 -07:00
Johannes Rieken 3a384c9c59 add test for #80688 2019-09-11 16:37:47 +02:00
Martin Aeschlimann dd7daae7de associate .i with c 2019-09-11 10:27:02 +02:00
Matt Bierner 011836a150
Prototyping custom editors (#77789)
* Custom Editor exploration

For #77131

Adds a prototype of custom editors contributed by extensions. This change does the following:

- Introduces a new contribution point for the declarative parts of a custom editor
- Adds API for registering a webview editor provider. This lets VS Code decided when to create a webview editor
- Adds an `openWith` command that lets you select which editor to use to open a resource from the file explorer
- Adds a setting that lets you say that you always want to use a custom editor for a given file extension
- Hooks up auto opening of a custom editor when opening a file from quick open or explorer
- Adds a new extension that contributes a custom image preview for png and jpg files

Still needs a lot of UX work and testing. We are also going to explore a more generic "open handler" based approach for supporting custom editors

Revert

* Re-use existing custom editor if one is already open

* Don't re-create custom editor webview when clicking on already visible custom editor

* Move customEditorInput to own file

* First draft of serializing custom editor inputs

* Use glob patterns instead of simple file extensions for matching custom resoruces for custom editors

* Add descriptions

* Try opening standard editor while prompting for custom editor

* Make sure we hide image status on dispose

* Make sure we restore editor group too

* Use glob patterns for workbench.editor.custom

* Allow users to configure custom editors for additional file types

* Use filename glob instead of glob on full resource path

* Adding placeholder for prompt open with

* Add enableByDefault setting for editor contributions

* Enable custom editors by default and add `discretion` enum

Changes `enableByDefault` boolean to a `discretion` enum. This should give more flexibility if we want other options (such as forcing a given custom editor to always be used even if there are other default ones)

* Allow custom editors to specify both a scheme and filenamePattern they are active for

* Rework custom editor setting

* Don't allow custom editors to be enabled for all resources by a config mistake

* Replace built-in image editor with one from extension

* Adding reopen with command

* Improve comment

* Remove commented code

* Localize package.json and remove image

* Remove extra lib setting from tsconfig
2019-09-10 17:56:57 -07:00
Matt Bierner 2fe62e7dfe Use the document that contains the md link as the resource for getting config, not the target document 2019-09-10 16:31:53 -07:00
Matt Bierner 28c5988f47 Renaming setting names 2019-09-10 16:20:01 -07:00
Matt Bierner 728ee3aa73 Extract 2019-09-10 16:06:08 -07:00
Salvador Cabrera Lozano c307d73664 Fix for #26659. (#80227)
* Fix for #26659.

Clicking on a  local file link will open up the editor on a separate editor group (new or reuse existing one).

* Fix for #26659: Add way to open Markdown links in a different editor group

Adding "markdown.editor.openMarkdownLinks" setting to specify where
links to markdown files should open (current editor group by default).
2019-09-10 15:58:27 -07:00
Matt Bierner a7704164b4 Pick up TS 3.6.3 insiders 2019-09-10 08:51:33 -07:00
Pine Wu 1c5b3fd83d Update html service. Fix #80600 2019-09-10 08:26:32 -07:00
Alexander 3ff6b96ab7 Update enablement of status bar item in constructor (#80517) 2019-09-10 10:27:33 +02:00
Matt Bierner 7226e32d1b Use shared tsconfig for markdown preview
Fixes #80121
2019-09-09 10:20:56 -07:00
Johannes Rieken f8ba99ba5a update test file 2019-09-09 11:04:36 +02:00
Alex Dima ea661bb83f Fix HTML integration test 2019-09-07 00:28:05 +02:00
Johannes Rieken f8daa9eac4 use project-src() to compile what tsconfig-defines 2019-09-06 18:16:12 +02:00
Joao Moreno fe44d14e71 fixes #80415 2019-09-06 09:40:08 +02:00
Alex Ross 7077b6b7f9 Fix very annoying gulp task error that always takes you to tasks output
Even when you click dismiss
2019-09-05 15:20:08 +02:00
Alex Ross 32d72e6565 Filter out 'No license field' in gulp tasks
Fixes #80081
2019-09-04 17:43:33 +02:00
Johannes Rieken 6c0bb9ba4d make DecorationData a class and rename it to Decoration, #54938 2019-09-04 11:16:11 +02:00
Johannes Rieken 07d19b90a5 remove automatic merging/overwriting of decorations, simplify proposed API, #54938 2019-09-04 11:16:11 +02:00
Benjamin Pasero 4cd5047073 build 💄 2019-09-04 08:55:20 +02:00
Pine Wu 1c623c163d Part of #71996 2019-09-03 10:54:02 -07:00
Pine Wu 6829b31625 Fix #80274 2019-09-03 10:13:46 -07:00
Pine Wu 14a3819e74 Fix #80269 2019-09-03 09:19:56 -07:00
Benjamin Pasero e655624145 remote - it is still server.bat locally 2019-09-03 16:11:10 +02:00
Benjamin Pasero e34c6c18e6 remote - server.bat => server.cmd 2019-09-03 16:08:55 +02:00
Benjamin Pasero c6c88cbbfb
debt - remote integration tests (#80265)
* fix

* 🆙 distro
2019-09-03 15:31:23 +02:00
Benjamin Pasero 7c4afcf360
add TEST_RESOLVER_USE_SERVER_FROM_SOURCES (#80254)
* remove unused deps

* use TEST_RESOLVER_USE_SERVER_FROM_SOURCES
2019-09-03 11:25:50 +02:00
Matt Bierner 7a00ddf9f8 Format files for 3.6
Fixes #80118
2019-09-02 21:29:05 -06:00
Benjamin Pasero db0d5ee0e7 fix env.test for remote 2019-09-02 15:07:45 +02:00
Martin Aeschlimann 7df2c87e94
Merge pull request #80187 from Heromyth/master
Add .c++ externsion support for CPP
2019-09-02 14:46:01 +02:00
Benjamin Pasero 4312a6ca44 debt - enable env.remoteName test again 2019-09-02 12:02:01 +02:00
Alex Ross 3ac5830dcf Update grammars 2019-09-02 11:39:10 +02:00
Benjamin Pasero 155f85b679
Build: run integration tests against actual build (#80203)
* experiment with running macOS integration test against real build

* echo command

* more tests

* Revert "more tests"

This reverts commit b07bde89be.

* test

* fix script

* fix build

* fix tests

* fix build

* fix build

* conditionally enable test for remote

* adopt for linux and windows

* disable failing test

* fix build

* windows - echo off

* fix variable check

* fix path

* fix compile

* echo off

* mac polish
2019-09-02 11:26:26 +02:00
heromyth 69c9f545d1 Add c++ externsion support for CPP 2019-09-02 11:33:57 +08:00
João Moreno b3f85bc76d
fix git branch sort order (#80096) 2019-08-30 10:27:20 +02:00
Martin Aeschlimann a7def72d9e trailing commas only for setting files 2019-08-29 13:19:03 +02:00
Joao Moreno 3b439a8c49 rephrase related to #66296 2019-08-29 09:07:59 +02:00
Matt Bierner 54c9d7f62c Pick up TS 3.6.2
Fixes #78973
2019-08-28 17:42:17 -07:00
Pine Wu 43788e3ee1 Update html services 2019-08-28 17:25:14 -07:00
Pine Wu 8cafaf5900 Fix #79766 2019-08-28 12:58:08 -07:00
Pine Wu 64c07ab1e3 Polish description for customdata 2019-08-28 10:21:41 -07:00
Alex Ross ac565b419d Fix bad grunt task in resolve task 2019-08-28 12:37:54 +02:00