Commit graph

498 commits

Author SHA1 Message Date
Matt Bierner 134c345351
Try adding browser specific tsconfig
Trying to add this to catch dependencies we take on node types
2021-07-22 17:00:17 -07:00
Matt Bierner b7cba9e7d4
Don't use custom tsconfig settings for markdown ext 2021-07-22 17:00:17 -07:00
Matt Bierner ff922dc231
Use TextDecoder instead of Buffer
Fixes #129165
2021-07-22 13:36:22 -07:00
Martin Aeschlimann 7927075f89
Merge pull request #128545 from microsoft/joh/webpack5
Adopt webpack 5
2021-07-14 22:32:54 +02:00
Matt Bierner 5b8ce768f3
Add getNonce function to generate webview nonces 2021-07-13 10:02:24 -07:00
Martin Aeschlimann 7ebe6a6054
adopt web extensions to webpack 5 2021-07-08 21:41:03 +02:00
Matt Bierner a71ebc98ff
Avoid warning when acessing md setting 2021-07-07 16:58:04 -07:00
Matt Bierner 92418e0ea0
Remove usage of non-standard setImmediate
This was broken after upgrading to webpack5
2021-07-06 12:42:27 -07:00
Andrea Mah 1664732e44 separated editor scroll info by type and consume entry on access 2021-06-14 13:34:41 -06:00
Matt Bierner bc14fe9e8d
Use templates for markdown styles
These styles shouldn't be added into the notebook itself, only into the shadow dom of the markdown cells
2021-06-09 15:17:21 -07:00
Matt Bierner 39dc60dec6
Move notebook empty markdown cell logic into markdown extension 2021-06-08 13:50:10 -07:00
Matt Bierner 30ed48f190
Move notebook markdown styles and shadow root to markdown-it extension 2021-06-08 13:08:44 -07:00
Matt Bierner 0a57fd87b1
Enable math in markdown preview
Fixes #124783
2021-06-08 09:58:54 -07:00
Henning Dieterichs ce5023b635
Merge pull request #124015 from microsoft/hediet/refactor-language-configuration
Refactors calls to languages.setLanguageConfiguration to declarative descriptions in language-configuration.json
2021-06-08 16:19:10 +02:00
Matt Bierner fd430418a0
Refine CellInfo type (#125351)
For #125269

- Rename `CellInfo` - >`OutputItem` (only internally, we also need to update the published types)
- Move `id` into `OutputItem`
- Move `element` out of `OutputItem`
- Rename `renderCell` to `renderOutputItem`
- Rename `destoryCell` to `disposeOutputItem` (`dispose` is  the term we generally use in our APIs)
2021-06-03 13:01:02 -07:00
Henning Dieterichs feed53b813
Merge branch 'main' into hediet/refactor-language-configuration 2021-05-31 19:40:48 +02:00
rebornix 866ecdd45a Merge branch 'notebook/dev' into main 2021-05-27 14:04:55 -07:00
Matt Bierner b8f11107f7
Use @types/vscode-webview 2021-05-27 13:41:38 -07:00
Johannes Rieken 9ef57b5c21
remove NotebookCellOutputItem#value, https://github.com/microsoft/vscode/issues/123884 2021-05-27 14:55:25 +02:00
Matt Bierner 6a12866c3e
💄 2021-05-26 12:55:32 -07:00
Ashray Jha 5eb64c54ca
Modified markdown preview nested list styling (#124445)
* Modified markdown preview nested list styling

* Added proper styling to the nested list

* merge different rules into a single one
2021-05-26 09:05:35 -07:00
rebornix 473cfe28bf Revert "Revert "Merge branch 'main' of https://github.com/microsoft/vscode into main""
This reverts commit 7c01395da1.
2021-05-25 17:49:34 -07:00
Harald Kirschner 7c01395da1 Revert "Merge branch 'main' of https://github.com/microsoft/vscode into main"
This reverts commit 7a976501eb, reversing
changes made to 2257676834.
2021-05-25 17:19:40 -07:00
Johannes Rieken ffd1f84ea9
rename notebookOutputRenderer to notebookRenderer, https://github.com/microsoft/vscode/issues/121819 2021-05-25 12:31:53 +02:00
Hassan Sani dbdc7a259e
added bottom spacing for table in markdown preview (#124385) 2021-05-24 12:14:01 -07:00
Matt Bierner 7bc2019b8d
Updating pinning test 2021-05-21 15:01:05 -07:00
Jean Pierre be8745ac9e
Fixes #123228 (#123584)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2021-05-21 14:51:18 -07:00
Matt Bierner 6ee883bfa3
Split href before decoding instead of after
Fixes #123228

This fixes the case where `#` appears in the path
2021-05-21 14:49:46 -07:00
Matt Bierner 77ff6eb03b
Add image specific link normalizer (#124400) 2021-05-21 14:42:50 -07:00
Matt Bierner e9b8c12915
Add types 2021-05-21 14:36:19 -07:00
rebornix a03daaf850
Merge branch 'notebook/dev' into main 2021-05-21 14:13:43 -07:00
Matt Bierner 22dc518a21
Remove unused type 2021-05-21 12:16:49 -07:00
Matt Bierner 97bbacd808
Remove extra call to with 2021-05-21 12:16:49 -07:00
Matt Bierner 79dea51e79
Rewrite webview urls to be more url-ish
## Problem

Webview uris currently have the form:

```
https://uuid.vscode-webview.net/vscode-resource/scheme/authority/path...
```

We have this syntax because we need to be able to recover the original scheme and authority of the resource in order to load it from disk

However this syntax means that absolute urls don't behave as you'd expect. For example, if you have a webview that sets a `<base>` to a document in the workspace, an absolute url `/abs/path.png` ends up being resolved to:

```
https://uuid.vscode-webview.net/abs/path.png
```

This drops the original scheme and authority, which prevents us from loading the resource

## Fix
With this change, I've moved the original scheme and authority into the authority of the webview uri instead of the path:

```
https://scheme+authority.vscode-resource.uuid.vscode-webview.net/path...
```

With this change, absolute paths should correctly be resolved
2021-05-21 09:28:43 -07:00
Johannes Rieken effac5be7f
drop as-prefix for ICreateCellInfo 2021-05-21 17:30:29 +02:00
Johannes Rieken 494e827e35
expose output item bytes to renderers and provide util functions: asText, asJSON, asBytes, asBlob, fyi @connor4312, https://github.com/microsoft/vscode/issues/123884 2021-05-21 12:36:10 +02:00
Andrea Mah 4fbd548d72 Merge branch 'main' into dev/t-andreamah/markdown-static-preview-scroll-state 2021-05-19 17:25:56 -06:00
Andrea Mah f594bb47e5 removing more unecessary whitespace 2021-05-19 17:00:55 -06:00
Andrea Mah 41606da2dc removing unecessary spaces 2021-05-19 16:59:26 -06:00
Andrea Mah 9ee1906718 pr feedback and combining prevEditor info for preview and non-preview 2021-05-19 16:57:12 -06:00
Henning Dieterichs a1af8aa651
Refactors calls to languages.setLanguageConfiguration to declarative descriptions in language-configuration.json. This fixes #98621. 2021-05-17 09:12:01 +02:00
Andrea Mah 94498778fb cleanup 2021-05-13 15:24:56 -06:00
Andrea Mah 9731995d94 addressed ! nit 2021-05-13 12:39:52 -06:00
Andrea Mah 3dec3b3385 applied PR feedback 2021-05-13 12:30:10 -06:00
Matt Bierner 66fa5c41b3
First cut at unifying notebook renderers apis
This implements the api described in #123540. Major points:

- Instead of having the `markdown-it` renderer pull it its dependencies, instead the dependencies can call `getRenderer` to import the object returned by the `markdown-it` renderer

- We try to detect if a renderer is using the old or new api. Old renderers are still run as globals while new ones are loaded with `import`

- I have only hooked up the new API for markdown renderers so far
2021-05-12 19:32:57 -07:00
Andrea Mah d2894562d5 fixing issue with static scroll alongside text editor 2021-05-12 17:59:00 -06:00
Andrea Mah ee4510b4bf Merge branch 'main' into dev/t-andreamah/markdown-static-preview-scroll-state 2021-05-12 17:01:41 -06:00
Andrea Mah 18950181eb scroll state persists while toggling between static preview and text 2021-05-12 16:59:57 -06:00
Matt Bierner 11a8c4b4bc
Merge the notebookMarkupRenderer contribution point into the renderers contribition point
For #123540
2021-05-12 13:28:28 -07:00
Andrea Mah 927e791753
Fix Initial Scroll Position on Markdown Dynamic Preview (#123613)
* added semicolons to pass code check

* removed preliminary work for static preview

* cleanup

Co-authored-by: Andrea Mah <t-andreamah@microsoft.com>
2021-05-11 17:12:19 -07:00