Commit graph

20 commits

Author SHA1 Message Date
deepak1556 ac29daaf3b
Fixes #136771: update to Electron v13.5.2 and pass --ms-enable-run-as-node together with ELECTRON_RUN_AS_NODE 2021-11-09 19:09:26 +01:00
João Moreno 3583edcc0b
fixes #136034 2021-11-01 15:30:45 +01:00
Benjamin Pasero 3cda269c80 ESlint: enable no-async-promise-executor (#134873) 2021-10-12 10:50:44 +02:00
Benjamin Pasero 0debadce72 shell env - reject with error not string 2021-10-11 14:16:37 +02:00
Benjamin Pasero be2f951fde debt - introduce Promises.withAsyncBody and adopt in a few places 2021-10-11 13:27:43 +02:00
Benjamin Pasero 80ca5cfdba
debt - do not directly use node.js path module 2021-10-04 14:13:30 +02:00
Benjamin Pasero fc151abbc3
gh issues - add another repo 2021-09-29 15:55:21 +02:00
Benjamin Pasero c70170a480
Show an error when resolving shell environment fails or is timing out (fix #133910) 2021-09-29 13:54:18 +02:00
Matt Bierner ee1655a82e
Organize imports in vs/platform 2021-08-05 15:32:53 -07:00
Benjamin Pasero 6cd2784c46
shell env - dispose in finally 2021-06-16 18:12:49 +02:00
Benjamin Pasero f4fe15ac91
shell env - kill child process after 10s 2021-06-16 15:36:27 +02:00
Benjamin Pasero eaf29b7e24
shell env - timeout after 10s of trying 2021-06-15 11:48:59 +02:00
Tyler James Leonhardt 74454818fe
Use single quotes instead of double quotes (#122703)
* use backtick instead of double quote

* also try all single quotes

* refactored in if/else

* add comment
2021-04-29 18:20:26 -07:00
Daniel Imms 328937e7b6
Use OperatingSystem over Platform in terminal
This prevents the invalid 'web' from possibly being used
2021-04-16 07:00:13 -07:00
Tyler James Leonhardt 932742fb26
Resolve unix shell env when default shell is PowerShell (#120769)
* resolve unix shell env when default shell is PowerShell

* Update src/vs/platform/environment/node/shellEnv.ts

* Update src/vs/platform/environment/node/shellEnv.ts

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2021-04-12 07:50:36 +00:00
Christof Marti 3af3fe66aa Improve logging (#4813) 2021-04-09 10:17:34 +02:00
Benjamin Pasero 1968bda7e6 platform#IProcessEnvironment is badly typed (fix #119046) 2021-03-30 19:05:44 +02:00
João Moreno f83b2f46de
shell env: add more logging
related to #118372
2021-03-10 11:19:09 +01:00
Tyler James Leonhardt 27975dad4f
move to IProcessEnvService where appropriate in default shell logic (#118271)
* move to IProcessEnvService where appropriate

* change distro
2021-03-08 19:46:34 -08:00
Benjamin Pasero f82462ba7c debt - move shellEnv to platform 2021-02-10 07:49:11 +01:00
Renamed from src/vs/code/node/shellEnv.ts (Browse further)