Commit graph

61281 commits

Author SHA1 Message Date
Benjamin Pasero 21fca08c97
Revisit webviewExternalEndpoint in environment (#118950) (#119780) 2021-03-29 14:13:29 -07:00
Matt Bierner 4dc2d399c7 Fix TS 4.3 compile errors
For https://github.com/microsoft/TypeScript/issues/43419

- Works around type assertions not catching a method can modify the type
- Add more explicit typings
2021-03-29 14:10:00 -07:00
Matt Bierner 47256436d8 Remove explicit assignment
This breaks TS's type inference. Required for TS 4.3
2021-03-29 14:09:59 -07:00
Matt Bierner 755424b11f Add type for constant
For TS 4.3 update
2021-03-29 14:09:59 -07:00
Logan Ramos 31fd94b660
First round of getting rid of deprecated asserts (#120125) 2021-03-29 15:48:46 -04:00
SteVen Batten 5da392fdf0
allow authority in wt (#120059)
* allow authority in wt

* update rendering of host property
2021-03-29 12:44:20 -07:00
Matt Bierner 12c4596ce3
Try fixing leak of backlayer webviews for notebook diffs (#119372)
Fixes #118147

The main fix here is to add the webviews to `_modifiedResourceDisposableStore`.

I also fixed a potential leak if multiple calls to `_createModifiedWebview` would leak the original webview
2021-03-29 11:36:25 -07:00
Matt Bierner a39120ddd1
Add support for JSDoc link tags (#119358)
* Add support for JSDoc @link tags

Fixes #119357

* Fix unresolved links not rendering
2021-03-29 11:29:52 -07:00
Peng Lyu a573d500d0
Merge pull request #120086 from arnobl/fix-notebook-redo-selection
fix(notebook): redo cell creation does not re-select the cell
2021-03-29 10:59:04 -07:00
Eric Amodio 030cb3c75c Moves extension prop out of proposed 2021-03-29 11:03:41 -04:00
Logan Ramos 7164efa38e
Open Editor refactors (#119274)
* Have editor service attempt to resolve viewtype

* Use existing editor service function

* Rename old editor input factory and create new glob based one

* Move override to editor service and create onWillMoveEditor event

* Addressed the minor PR feedback

* Make the editor move event more robust

* Fix notebook re-rendering

* Notify of new groups on restore

* consistently refer to serializers and not factories

* 💄 IEditorMoveEvent

* get rid of move/copy options

* some more 💄

* Fix notebooks knowing about editor groups on startup

* Fix broken tests

* Rename file

* Fix compilation errors

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2021-03-29 14:56:10 +00:00
Logan Ramos 7c8da70fd0
Respect viewtype for reopen with in notebooks (#120101)
* Respect viewtype for reopen with in notebooks

* Switch to using a ternary
2021-03-29 14:38:15 +00:00
SteVen Batten 3e0f2f1c6e
allow wt description in widget (#119291)
* allow wt description in widget
cleanup widget

* use card style with 3 lines and 2 columns

* remove hover feedback as the tiles are not buttons

* fix delegate width mishap
2021-03-29 07:24:46 -07:00
Benjamin Pasero 9c2b053778
🆙 sudo-prompt 2021-03-29 15:31:04 +02:00
isidor 13bbe762f5
Inline values provider isn't called with new view port when scrolling editor content
fixes #119559
2021-03-29 15:26:40 +02:00
Isidor Nikolic c318085f38
Merge pull request #119817 from yannickowow/master
Show current DataBreakpoint access type in "Breakpoints" view (#119588)
2021-03-29 14:40:13 +02:00
isidor e09a24028e
Automatically show inline values if an inline values provider is registered
fixes #119560
2021-03-29 14:37:29 +02:00
Yanis 0d2b550ab1 Show current DataBreakpoint access type in "Breakpoints" view
- Append debugViewlet.css for "access-type" element
- extend IBaseBreakpointTemplateData when rendering
2021-03-29 14:28:35 +02:00
Benjamin Pasero 3a2a24e452
cli - set VSCODE_CLI earlier (#119660) 2021-03-29 14:20:45 +02:00
isidor 456651f286
zen mode: do not keep pointer to editor. Just reset line number visibility for all visible editors
fixes #119308
2021-03-29 14:11:36 +02:00
isidor ddd480046d
debug: update inline values when variable is set
fixes #119564
2021-03-29 13:03:30 +02:00
isidor ce184d9ec7
fixes #119825 2021-03-29 12:56:11 +02:00
Benjamin Pasero e5b2742fff
debt - provide common method to load renderer with config param 2021-03-29 11:31:53 +02:00
Benjamin Pasero 19f6f31036
💄 remove extra comment slashes 2021-03-29 11:31:53 +02:00
Sandeep Somavarapu e96e70d59e remove overflow action when there are no overflows 2021-03-29 11:26:48 +02:00
Benjamin Pasero 44f89fc13c
editors - do not wait for editor to resolve to signal restored phase (fix #119059) 2021-03-29 11:13:03 +02:00
isidor f554a74550
debug: always show top call stack column
fixes #119485
2021-03-29 11:03:22 +02:00
Daniel Imms 01e844e75d
Merge pull request #119992 from microsoft/tyriar/119046
Allow undefined in terminal env map, unify interfaces
2021-03-29 02:03:17 -07:00
Benjamin Pasero df6d78a169
debt - align editor model closer to file working copy 2021-03-29 10:43:37 +02:00
Benjamin Pasero 7031abadea
debt - less explicit any 2021-03-29 10:30:03 +02:00
João Moreno ec1def6ca8 fixes #120066 2021-03-29 10:09:23 +02:00
Benjamin Pasero 7f9835ac43
file working copy - better cancellation support 2021-03-29 08:26:55 +02:00
Benjamin Pasero 5e3df4ce30
debt - onDispose => onWillDispose 2021-03-29 08:21:09 +02:00
arnobl 7fbddb5522 fix(notebook): redo cell creation does not re-select the cell 2021-03-28 23:15:28 +02:00
deepak1556 c0fa3dfd3e chore: allow vmodule switch for debugging 2021-03-27 19:26:24 -07:00
Ladislau Szomoru f453ed8e38
Fix issue with bottom border for focus 2021-03-27 21:24:59 +01:00
Ladislau Szomoru c4eb927231
Add confirmation for workspace trust state transition 2021-03-27 21:12:01 +01:00
Ladislau Szomoru c2b5d3d471
Workspace trust - extension enablement (#120028) 2021-03-27 19:30:02 +00:00
Ladislau Szomoru 6aa528024b
Remove code that is not needed (#120005) 2021-03-27 07:52:29 +00:00
Harald Kirschner 364923c06b Fixes #115327 with HC images for GS setup/beginners. 2021-03-26 16:33:56 -07:00
Harald Kirschner 80a74dde2e Recommend Quick Open when a workspace is open. 2021-03-26 16:33:56 -07:00
Daniel Imms a802d1f9df
Allow 100ms for terminal container to become available before spawn
Fixes #117188
2021-03-26 15:08:46 -07:00
Daniel Imms 02d3809824
Allow undefined in terminal env map, unify interfaces
Note that this adds undefined as an option to TerminalOptions.env which could end up
causing compile errors, but they will be more correct and could reveal a bug in an
extension since some key could return undefined.

Fixes #119046
2021-03-26 14:40:12 -07:00
Megan Rogge a05c63db4f Enable terminal event batching from ptyHost (#117268)
* fix #116468
Co-authored-by: Daniel Imms <daimms@microsoft.com>
2021-03-26 13:46:20 -07:00
meganrogge 778d622ca1 replace one additional displayDetectedWslProfiles 2021-03-26 13:37:56 -07:00
Megan Rogge 31f8118486 allow terminal profiles w a source to have args (#119967) 2021-03-26 13:23:04 -07:00
Megan Rogge cc077af2d6 iPad OS ctrl + c in terminal (#119979) 2021-03-26 13:14:05 -07:00
Daniel Imms 6bbfedaa7d
displayDetectedWslProfiles -> useWslProfiles
Update setting name to remove ambiguity with the 'detected' section in
select default profile
2021-03-26 13:00:40 -07:00
Ladislau Szomoru b45ab9da56
Workspace trust - multi-window improvements (#119483)
* Multi-window improvements
2021-03-26 20:53:58 +01:00
Ladislau Szomoru 3f511d294f
Reload window on workspace trust state transition 2021-03-26 20:52:29 +01:00