From 3600c7270989d6fe79f8dbf96df075ce9c66a61a Mon Sep 17 00:00:00 2001 From: yueh Date: Thu, 27 Oct 2016 19:01:40 +0200 Subject: [PATCH] Fixes #2515: Incorrectly version comparison Incorrectly prefer the channel over revision to determine the newest version. --- src/main/java/appeng/services/version/DefaultVersion.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/appeng/services/version/DefaultVersion.java b/src/main/java/appeng/services/version/DefaultVersion.java index 1f8f8e77..e060165f 100644 --- a/src/main/java/appeng/services/version/DefaultVersion.java +++ b/src/main/java/appeng/services/version/DefaultVersion.java @@ -42,14 +42,14 @@ public final class DefaultVersion extends BaseVersion @Override public boolean isNewerAs( final Version maybeOlder ) { - if( this.revision() > maybeOlder.revision() ) + if( this.revision() < maybeOlder.revision() ) { - return true; + return false; } - if( this.channel().compareTo( maybeOlder.channel() ) > 0 ) + if( this.channel().compareTo( maybeOlder.channel() ) < 0 ) { - return true; + return false; } return this.build() > maybeOlder.build();