Use StringBuilder for creating appended Strings in a loop

This commit is contained in:
thatsIch 2015-03-26 10:15:33 +01:00
parent 1067d30264
commit e41d6a0289

View file

@ -19,6 +19,7 @@
package appeng.integration; package appeng.integration;
import java.util.Collection;
import java.util.LinkedList; import java.util.LinkedList;
import cpw.mods.fml.relauncher.FMLLaunchHandler; import cpw.mods.fml.relauncher.FMLLaunchHandler;
@ -29,7 +30,7 @@ public enum IntegrationRegistry
{ {
INSTANCE; INSTANCE;
private final LinkedList<IntegrationNode> modules = new LinkedList<IntegrationNode>(); private final Collection<IntegrationNode> modules = new LinkedList<IntegrationNode>();
public void add( IntegrationType type ) public void add( IntegrationType type )
{ {
@ -59,19 +60,20 @@ public enum IntegrationRegistry
public String getStatus() public String getStatus()
{ {
String out = null; final StringBuilder builder = new StringBuilder( this.modules.size() * 3 );
for ( IntegrationNode node : this.modules ) for ( IntegrationNode node : this.modules )
{ {
String str = node.shortName + ":" + ( node.state == IntegrationStage.FAILED ? "OFF" : "ON" ); if ( builder.length() != 0 )
{
builder.append( ", " );
}
if ( out == null ) final String integrationState = node.shortName + ":" + ( node.state == IntegrationStage.FAILED ? "OFF" : "ON" );
out = str; builder.append( integrationState );
else
out += ", " + str;
} }
return out; return builder.toString();
} }
public boolean isEnabled( IntegrationType name ) public boolean isEnabled( IntegrationType name )