From f29644552119ab518613e992c58f39483e30afcb Mon Sep 17 00:00:00 2001 From: yueh Date: Fri, 28 Oct 2016 01:01:40 +0800 Subject: [PATCH] Fixes #2515: Incorrectly version comparison Incorrectly prefer the channel over revision to determine the newest version. (cherry picked from commit 3600c72) --- src/main/java/appeng/services/version/DefaultVersion.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/appeng/services/version/DefaultVersion.java b/src/main/java/appeng/services/version/DefaultVersion.java index 4b252053..dc9ee0d4 100644 --- a/src/main/java/appeng/services/version/DefaultVersion.java +++ b/src/main/java/appeng/services/version/DefaultVersion.java @@ -42,14 +42,14 @@ public final class DefaultVersion extends BaseVersion @Override public boolean isNewerAs( final Version maybeOlder ) { - if( this.revision() > maybeOlder.revision() ) + if( this.revision() < maybeOlder.revision() ) { - return true; + return false; } - if( this.channel().compareTo( maybeOlder.channel() ) > 0 ) + if( this.channel().compareTo( maybeOlder.channel() ) < 0 ) { - return true; + return false; } return this.build() > maybeOlder.build();