yueh
85de600d16
Splitted channeldata into two ints
...
Previously it did encode the current and previous used channels into the
same as well as mask it with 0xFF. Which lead to an overflow every 256
gridnodes requiring a channel. This will not happen at > 2^31
Also removes the need to bitshift them for every access.
Fixes #1510
2015-06-16 14:57:04 +02:00
thatsIch
d1e4ea6579
Improves the message generated when generating the folder for the compass data.
...
Outsources the encoding of the compass data into the file name
Written tests for the encoding
Did some internal cleaning of the class
2015-06-13 16:05:59 +02:00
yueh
05f90760f2
No longer invalidate the cache of MEMonitorIInventory on simulate.
...
Should fix #1036
2015-06-05 19:35:52 +02:00
yueh
61dfc05ae0
Added a simple ETA to crafting jobs
2015-05-21 21:31:13 +02:00
thatsIch
1d737c3167
Merge pull request #1425 from thatsIch/e-weaker-collection-type
...
Use weaker collection types
2015-05-09 15:57:57 +02:00
thatsIch
168038c595
Merge pull request #1426 from thatsIch/e-overly-strong-cast
...
reduces overly strong type cast
2015-05-09 15:57:47 +02:00
yueh
b6b76d145b
Organize imports
2015-05-09 13:06:09 +02:00
thatsIch
7c9b734948
reduces overly strong type cast
2015-05-09 12:45:46 +02:00
thatsIch
16c0fbe3c1
Use weaker collection types
2015-05-09 12:33:16 +02:00
thatsIch
5832e2d828
Merge pull request #1420 from thatsIch/e-method-parameter-naming-conventions
...
Replaces all method parameter regarding their naming conventions
2015-05-08 23:45:28 +02:00
thatsIch
f193c2adc4
Replaces all method parameter regarding their naming conventions
2015-05-08 23:25:19 +02:00
thatsIch
b748a1982f
Replaces all non constant fields with upper case name
2015-05-08 22:53:50 +02:00
thatsIch
875214c166
Adds annotations by contract of the interface
2015-05-02 15:39:59 +02:00
thatsIch
64ed05a1b4
Puts everywhere brackets
2015-04-29 18:38:24 +02:00
thatsIch
3783ae8619
Improved exceptions
...
Many exceptions got an improvement due to changed class or description or details it is providing.
Is not complete, needs to be done in patches in the regions, where it is needed, since some are just
swallowed.
Removed total usage of pure RuntimeExceptions to 0.
2015-04-21 17:43:24 +02:00
yueh
eaf57bedf6
Modifier are now using a consistent order based on the java conventions
2015-04-06 00:35:42 +02:00
thatsIch
d34c988c88
Basic reformat, hit once, hope never again
2015-04-03 15:07:13 +02:00
thatsIch
9986ffc458
Fixes #675 No disabled feature should log spam or crash anymore.
...
Deprecates the old usage of the AEItemDefinitions via the direct method access of
* blocks()
* parts()
* items()
* materials()
and thus use the new re-direct via definitions().
All definitions are now initialized, no matter what. But SubItems, Items and Blocks are not registered, if by chance are disabled.
2015-03-28 16:21:37 +01:00
thatsIch
dff48c07c9
finalized
2015-03-26 11:14:34 +01:00
thatsIch
234d97b8ce
Security issues: public static collections
2015-03-26 11:13:24 +01:00
thatsIch
9bf8b4388f
Extract ++ and -- from expressions
2015-03-26 11:07:26 +01:00
thatsIch
14df50dbf3
Unnecessary modifier in interfaces
2015-03-26 11:03:30 +01:00
thatsIch
3143c871d0
this access
2015-03-26 11:01:57 +01:00
thatsIch
f1248c4c33
Unused imports
2015-03-26 10:49:48 +01:00
thatsIch
bd2ee1c5ea
Assignment replaceable with operator assignment
2015-03-26 10:41:45 +01:00
thatsIch
8ef286b9d6
Replace call to simple setter from within class with inlined version
2015-03-26 10:27:07 +01:00
thatsIch
4b4693498d
Replace call to simple getter from within class with inlined version
2015-03-26 10:23:59 +01:00
thatsIch
eb98ec891b
Merge pull request #1066 from thatsIch/e-remove-deprecated-access
...
Removes deprecated method access of LocatableRegistry and getPickBlock
2015-03-24 12:47:55 +01:00
downslope7
30191eb5ba
Add coords to duplicate connection GridException.
...
This exception isn't caught and crashes the server. Added block coordinates to aid in diagnostics.
2015-03-21 20:05:08 -05:00
thatsIch
4552394f6e
Removes deprecated method access of LocatableRegistry and getPickBlock
2015-03-21 16:03:26 +01:00
yueh
1bb0109c45
Improved MEInventoryHandler.getAccess()
...
Changed the public fields to setters and getters
Added a cache for the evaluated values instead of calculating with each
access
2015-03-15 19:43:12 +01:00
yueh
311939c63c
Merge pull request #973 from yueh/feature-improve-security-audit-log
...
Some further improvements to the security audit
2015-03-07 16:37:59 +01:00
yueh
d8a3556bc3
Merge pull request #983 from yueh/fix-982
...
Removes creating a ItemStack with a full NBT copy
2015-03-07 16:35:56 +01:00
yueh
57e84c3039
Removes creating a ItemStack with a full NBT copy
...
There is no need to create a full copy just to fetch the already available
stacksize. It still respects the maximum stacksize of Integer.MAX_VALUE as they copy is doing.
Fixes #982
2015-03-07 15:45:59 +01:00
yueh
1bcf7f9d52
Some further improvements to the security audit
2015-03-05 14:53:10 +01:00
yueh
0b15c56037
Added some more information to the security audit
2015-02-28 17:22:17 +01:00
yueh
b18addbf37
remove trailing whitespaces
2015-02-03 12:04:13 +01:00
thatsIch
52c512635d
Renamed constants
2015-01-01 22:13:10 +01:00
thatsIch
8179259afa
Replaced C-style array instantiation with Java-Style
2015-01-01 21:15:03 +01:00
yueh
9b7b0fc0fb
Organize imports
2014-12-29 21:59:05 +01:00
yueh
f471513bd0
Changed access to use this qualifier
2014-12-29 15:13:47 +01:00
thatsIch
8abf2ed8ac
Basic enhancement of the grid for overall usage
...
has some performance improvement
replaced outdated classes
2014-12-05 23:51:01 +01:00
thatsIch
ca01e25f38
Remove tags in tag compound in inventories of cells if they are not needed anymore, should fix #535
2014-12-03 11:46:44 +01:00
thatsIch
2243c5a188
Refactoring
...
Type-safety
Minor performance improvements
2014-12-02 22:55:39 +01:00
thatsIch
7505f9b66a
Added copyright to all java files
2014-11-14 12:03:00 +01:00
yueh
9a33bb03c0
Fixes condenser dupe bug
2014-11-12 12:49:55 +01:00
thatsIch
542c1dcdbd
Improved various typos
2014-11-04 12:32:33 +01:00
yueh
9e48eb40a0
Moved getGrid() (WeakReference) to a local var
2014-11-02 10:23:32 +01:00
FireBall1725
88570117bc
Merge pull request #277 from yueh/fix-276
...
Changed TreeMap to a threadsafe implementation
2014-10-13 08:32:55 -04:00
Chris
52e548eebc
Merge pull request #281 from thatsIch/controlflow
...
Simplified some control flow statements
2014-10-09 13:22:55 -07:00
thatsIch
011ff54224
Simplified some control flow statements
2014-10-09 21:33:31 +02:00
thatsIch
54f479e827
Removed some imports
2014-10-09 21:17:48 +02:00
yueh
fdd1a362d6
Changed TreeMap to a threadsafe implementation
2014-10-09 16:37:25 +02:00
thatsIch
da148ef787
Renames, visibility, other cleanups
2014-10-05 16:15:36 +02:00
thatsIch
f32010a538
Renamed to a more readable version
2014-10-05 15:57:30 +02:00
thatsIch
9717450f13
Added missing Type
2014-10-05 15:43:52 +02:00
thatsIch
060255e9c7
Reduce visibility of fields
...
Implement against interfaces
Enforce immutability instead resetting it hard via new instantiation.
2014-10-05 15:38:56 +02:00
Chris
add0bd41e4
Merge pull request #245 from thatsIch/pathsegment
...
Remove redundant exception and instantiation
2014-10-04 16:43:50 -07:00
thatsIch
fd59d244df
Remove redundant exception and instantiation
2014-10-04 19:05:11 +02:00
thatsIch
bba04d0de9
Added missing types of collections
...
Fixed single loop
2014-10-04 19:00:41 +02:00
Andrew
7f225a5ec1
Deleted useless things
2014-10-03 23:08:28 -07:00
Chris
7ef413ab00
Merge pull request #222 from thatsIch/ignored
...
Temporary set of catch to ignored if they are ignored
2014-10-01 20:25:52 -07:00
Chris
c2fba2de55
Merge pull request #218 from thatsIch/localvars
...
Remove redundant local variables
2014-10-01 20:23:56 -07:00
thatsIch
c074280b68
Temporary set of catch to ignored if they are ignored
2014-10-01 15:20:42 +02:00
thatsIch
cd064ec05c
Remove redundant local variables
2014-10-01 11:34:27 +02:00
thatsIch
dedefee30b
Remove not needed imports
2014-10-01 10:43:26 +02:00
yueh
7fa7e43c29
Some performance or memory optimizations
...
Replaced String concat in loops with StringBuilder (performance)
Replaced for with keySet + Map.get() through for with entrySet (perf)
Changed inner classes to static classes, mostly struct like (memory)
2014-09-30 23:20:02 +02:00
thatsIch
474596f095
Make fields final if possible to ensure immutability
2014-09-30 09:52:57 +02:00
thatsIch
3db2d4960b
Replaced normal for loops with foreach loops which is less error prone when just iterating over collection/array
2014-09-29 23:48:25 +02:00
Chris
7b3bde7906
Merge pull request #182 from thatsIch/While
...
Replaces while iterators with foreach call
2014-09-29 14:10:03 -07:00
yueh
fd7c1ff5f8
Added checks for null and equal class to .equals()
...
Also switched a check for null in OreHelper#sameOre to prevent null ==
null => true
2014-09-29 12:39:40 +02:00
Andrew
d08ce4a2b4
Deleted some parens and fixed indentation
2014-09-29 00:29:55 -07:00
thatsIch
b6ec21c70a
Replaces while iterators with foreach call
2014-09-29 09:26:35 +02:00
Andrew
5c5aaa21ee
Merge remote-tracking branch 'upstream/rv2' into rv2
...
Conflicts:
src/main/java/appeng/items/tools/powered/ToolMassCannon.java
2014-09-29 00:26:15 -07:00
Chris
62fcf26fcc
Merge pull request #175 from thatsIch/TypeSafety
...
Type safety
2014-09-28 19:51:31 -07:00
thatsIch
56757bd828
Fixed crafting watchers not having the right type
2014-09-28 22:45:57 +02:00
thatsIch
f1ffbf08a2
Resolved some unchecked Types
2014-09-28 22:20:14 +02:00
Andrew
da63aca95c
Deleted unnecessary casts with Eclipse
2014-09-28 11:56:16 -07:00
Andrew
94d5319038
Fixed some warnings about unnecessary code
2014-09-28 11:55:09 -07:00
Andrew
8514e32f5f
Added missing @Override annotations with Eclipse
2014-09-28 11:34:00 -07:00
Andrew
0042176f29
Deleted redundant null checks
2014-09-28 10:41:51 -07:00
Chris
f9b9729fb5
Merge pull request #157 from thatsIch/Spelling
...
Spelling
2014-09-28 10:09:39 -07:00
thatsIch
76b147fd5b
Improved readability of variables
...
Hopefully improved semantics of variables
Fixed typos
Added hyphenations
2014-09-28 12:21:34 +02:00
thatsIch
1e71e86acc
Removes unnecessary semicolons
2014-09-28 12:08:47 +02:00
Chris
b1bc51158f
Merge pull request #8 from Ongy/Ticket1133
...
Fix for item #1133
Fixes #133
2014-09-27 17:12:00 -07:00
thatsIch
d37638f4ee
Use collections methods to add stuff
...
Remove redundant new String initialization
2014-09-27 23:54:17 +02:00
thatsIch
4088cca5ad
Fixing internal javadoc
2014-09-27 23:17:47 +02:00
AlgorithmX2
fed4109129
Fix a memory leak with GridStorage
2014-09-27 12:25:52 -05:00
Ongy
4586c0b0d2
Fix for item #1133
2014-09-27 01:09:40 +02:00
AlgorithmX2
386d18a059
Relocate Source to proper directory.
2014-09-23 19:26:27 -05:00
