yueh
38e7e579fa
Fixes #2043 : Storage buses updates should happen in the correct order.
...
This is loosely based on #2032 and should prevent any duplicated event,
but still does a refresh the whole cache due to potentially issues with
some inventories.
It also ensures that storage buses will not announce a CellArrayUpdate
before they are fully initialized, thus no longer causing them to return
null during an update.
Fixes #2403
2016-01-03 13:23:51 +01:00
yueh
1862ab3562
Revert "Changed NetworkMonitor to update its cache."
2015-12-11 22:26:21 +01:00
yueh
0696662254
Changed NetworkMonitor to update its cache.
...
No longer invalidates and refresh it with every single change.
This should now also ensure that updates are send exactly once per network
instead of multiple times scaling up with the amount of chained networks.
2015-12-10 16:11:30 +01:00
yueh
500fc47490
Reduces visibility of internal fields/methods
...
Reduces the visibility of all fields to private and create setters/getters
when necessary. Exceptions are fields with GuiSync as these need to be
public.
Reduces the visibility of internal methods to private/protected/default when possible.
2015-10-30 18:52:20 +01:00
thatsIch
410d2f1e0d
final variables and parameters
...
seeing some methods it does actually help to enforce the parameters
2015-09-26 21:08:18 +02:00
thatsIch
0387d30d1c
Reduce scope of variables
2015-09-26 20:07:51 +02:00
yueh
40dcf711f6
Fixed the order craftinglinks are notified for the last item.
...
Fixes #1833
2015-08-28 13:29:24 +02:00
yueh
0de7a2d83a
Closes #1283 : Add custom Callable to prevent memory leaks
2015-08-20 21:04:06 +02:00
yueh
9c8deac9de
Code format
2015-08-06 19:08:02 +02:00
thatsIch
d1e4ea6579
Improves the message generated when generating the folder for the compass data.
...
Outsources the encoding of the compass data into the file name
Written tests for the encoding
Did some internal cleaning of the class
2015-06-13 16:05:59 +02:00
yueh
b6b76d145b
Organize imports
2015-05-09 13:06:09 +02:00
thatsIch
f193c2adc4
Replaces all method parameter regarding their naming conventions
2015-05-08 23:25:19 +02:00
thatsIch
875214c166
Adds annotations by contract of the interface
2015-05-02 15:39:59 +02:00
thatsIch
64ed05a1b4
Puts everywhere brackets
2015-04-29 18:38:24 +02:00
thatsIch
3783ae8619
Improved exceptions
...
Many exceptions got an improvement due to changed class or description or details it is providing.
Is not complete, needs to be done in patches in the regions, where it is needed, since some are just
swallowed.
Removed total usage of pure RuntimeExceptions to 0.
2015-04-21 17:43:24 +02:00
yueh
eaf57bedf6
Modifier are now using a consistent order based on the java conventions
2015-04-06 00:35:42 +02:00
thatsIch
d34c988c88
Basic reformat, hit once, hope never again
2015-04-03 15:07:13 +02:00
thatsIch
dff48c07c9
finalized
2015-03-26 11:14:34 +01:00
thatsIch
234d97b8ce
Security issues: public static collections
2015-03-26 11:13:24 +01:00
thatsIch
bd2ee1c5ea
Assignment replaceable with operator assignment
2015-03-26 10:41:45 +01:00
yueh
b18addbf37
remove trailing whitespaces
2015-02-03 12:04:13 +01:00
thatsIch
52c512635d
Renamed constants
2015-01-01 22:13:10 +01:00
yueh
9b7b0fc0fb
Organize imports
2014-12-29 21:59:05 +01:00
yueh
f471513bd0
Changed access to use this qualifier
2014-12-29 15:13:47 +01:00
thatsIch
7505f9b66a
Added copyright to all java files
2014-11-14 12:03:00 +01:00
thatsIch
54f479e827
Removed some imports
2014-10-09 21:17:48 +02:00
thatsIch
da148ef787
Renames, visibility, other cleanups
2014-10-05 16:15:36 +02:00
thatsIch
f32010a538
Renamed to a more readable version
2014-10-05 15:57:30 +02:00
thatsIch
9717450f13
Added missing Type
2014-10-05 15:43:52 +02:00
thatsIch
060255e9c7
Reduce visibility of fields
...
Implement against interfaces
Enforce immutability instead resetting it hard via new instantiation.
2014-10-05 15:38:56 +02:00
thatsIch
bba04d0de9
Added missing types of collections
...
Fixed single loop
2014-10-04 19:00:41 +02:00
Andrew
7f225a5ec1
Deleted useless things
2014-10-03 23:08:28 -07:00
thatsIch
dedefee30b
Remove not needed imports
2014-10-01 10:43:26 +02:00
yueh
7fa7e43c29
Some performance or memory optimizations
...
Replaced String concat in loops with StringBuilder (performance)
Replaced for with keySet + Map.get() through for with entrySet (perf)
Changed inner classes to static classes, mostly struct like (memory)
2014-09-30 23:20:02 +02:00
thatsIch
474596f095
Make fields final if possible to ensure immutability
2014-09-30 09:52:57 +02:00
Chris
7b3bde7906
Merge pull request #182 from thatsIch/While
...
Replaces while iterators with foreach call
2014-09-29 14:10:03 -07:00
thatsIch
b6ec21c70a
Replaces while iterators with foreach call
2014-09-29 09:26:35 +02:00
Andrew
5c5aaa21ee
Merge remote-tracking branch 'upstream/rv2' into rv2
...
Conflicts:
src/main/java/appeng/items/tools/powered/ToolMassCannon.java
2014-09-29 00:26:15 -07:00
thatsIch
56757bd828
Fixed crafting watchers not having the right type
2014-09-28 22:45:57 +02:00
thatsIch
f1ffbf08a2
Resolved some unchecked Types
2014-09-28 22:20:14 +02:00
Andrew
da63aca95c
Deleted unnecessary casts with Eclipse
2014-09-28 11:56:16 -07:00
Andrew
8514e32f5f
Added missing @Override annotations with Eclipse
2014-09-28 11:34:00 -07:00
Chris
f9b9729fb5
Merge pull request #157 from thatsIch/Spelling
...
Spelling
2014-09-28 10:09:39 -07:00
thatsIch
76b147fd5b
Improved readability of variables
...
Hopefully improved semantics of variables
Fixed typos
Added hyphenations
2014-09-28 12:21:34 +02:00
thatsIch
1e71e86acc
Removes unnecessary semicolons
2014-09-28 12:08:47 +02:00
Ongy
4586c0b0d2
Fix for item #1133
2014-09-27 01:09:40 +02:00
AlgorithmX2
386d18a059
Relocate Source to proper directory.
2014-09-23 19:26:27 -05:00