From c8dd3314d673fce90a53520475cdb19d5358dd34 Mon Sep 17 00:00:00 2001
From: Erik Johnston <erik@matrix.org>
Date: Mon, 15 Dec 2014 13:55:22 +0000
Subject: [PATCH] Fix bug where we ignored event_edge_hashes table

---
 scripts/check_event_hash.py         |  3 +++
 synapse/events/utils.py             |  1 +
 synapse/storage/__init__.py         |  1 -
 synapse/storage/_base.py            |  1 -
 synapse/storage/event_federation.py | 11 ++++++-----
 5 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/scripts/check_event_hash.py b/scripts/check_event_hash.py
index 7c32f8102..679afbd26 100644
--- a/scripts/check_event_hash.py
+++ b/scripts/check_event_hash.py
@@ -18,6 +18,9 @@ class dictobj(dict):
     def get_full_dict(self):
         return dict(self)
 
+    def get_pdu_json(self):
+        return dict(self)
+
 
 def main():
     parser = argparse.ArgumentParser()
diff --git a/synapse/events/utils.py b/synapse/events/utils.py
index 4ab770dd5..94f3f15f5 100644
--- a/synapse/events/utils.py
+++ b/synapse/events/utils.py
@@ -42,6 +42,7 @@ def prune_event(event):
         "auth_events",
         "origin",
         "origin_server_ts",
+        "membership",
     ]
 
     new_content = {}
diff --git a/synapse/storage/__init__.py b/synapse/storage/__init__.py
index 079ddac60..d0ea304b3 100644
--- a/synapse/storage/__init__.py
+++ b/synapse/storage/__init__.py
@@ -91,7 +91,6 @@ class DataStore(RoomMemberStore, RoomStore,
 
     def __init__(self, hs):
         super(DataStore, self).__init__(hs)
-        self.event_factory = hs.get_event_factory()
         self.hs = hs
 
         self.min_token_deferred = self._get_min_token()
diff --git a/synapse/storage/_base.py b/synapse/storage/_base.py
index 1967290ad..31d5163c1 100644
--- a/synapse/storage/_base.py
+++ b/synapse/storage/_base.py
@@ -83,7 +83,6 @@ class SQLBaseStore(object):
     def __init__(self, hs):
         self.hs = hs
         self._db_pool = hs.get_db_pool()
-        self.event_factory = hs.get_event_factory()
         self._clock = hs.get_clock()
 
     @defer.inlineCallbacks
diff --git a/synapse/storage/event_federation.py b/synapse/storage/event_federation.py
index 6c559f8f6..ced066f40 100644
--- a/synapse/storage/event_federation.py
+++ b/synapse/storage/event_federation.py
@@ -177,14 +177,15 @@ class EventFederationStore(SQLBaseStore):
             retcols=["prev_event_id", "is_state"],
         )
 
+        hashes = self._get_prev_event_hashes_txn(txn, event_id)
+
         results = []
         for d in res:
-            hashes = self._get_event_reference_hashes_txn(
-                txn,
-                d["prev_event_id"]
-            )
+            edge_hash = self._get_event_reference_hashes_txn(txn, d["prev_event_id"])
+            edge_hash.update(hashes.get(d["prev_event_id"], {}))
             prev_hashes = {
-                k: encode_base64(v) for k, v in hashes.items()
+                k: encode_base64(v)
+                for k, v in edge_hash.items()
                 if k == "sha256"
             }
             results.append((d["prev_event_id"], prev_hashes, d["is_state"]))