2021-07-28 10:05:11 +02:00
|
|
|
#
|
2023-11-21 21:29:58 +01:00
|
|
|
# This file is licensed under the Affero General Public License (AGPL) version 3.
|
|
|
|
#
|
2024-01-23 12:26:48 +01:00
|
|
|
# Copyright 2021 Šimon Brandner <simon.bra.ag@gmail.com>
|
2023-11-21 21:29:58 +01:00
|
|
|
# Copyright (C) 2023 New Vector, Ltd
|
|
|
|
#
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
|
|
# it under the terms of the GNU Affero General Public License as
|
|
|
|
# published by the Free Software Foundation, either version 3 of the
|
|
|
|
# License, or (at your option) any later version.
|
|
|
|
#
|
|
|
|
# See the GNU Affero General Public License for more details:
|
|
|
|
# <https://www.gnu.org/licenses/agpl-3.0.html>.
|
|
|
|
#
|
|
|
|
# Originally licensed under the Apache License, Version 2.0:
|
|
|
|
# <http://www.apache.org/licenses/LICENSE-2.0>.
|
|
|
|
#
|
|
|
|
# [This file includes modifications made by New Vector Limited]
|
2021-07-28 10:05:11 +02:00
|
|
|
#
|
|
|
|
#
|
|
|
|
|
2022-05-16 17:06:23 +02:00
|
|
|
from copy import deepcopy
|
2021-07-28 10:05:11 +02:00
|
|
|
from typing import List
|
|
|
|
|
2022-12-16 12:53:01 +01:00
|
|
|
from twisted.test.proto_helpers import MemoryReactor
|
|
|
|
|
2022-05-27 13:14:36 +02:00
|
|
|
from synapse.api.constants import EduTypes, ReceiptTypes
|
2022-12-16 12:53:01 +01:00
|
|
|
from synapse.server import HomeServer
|
2021-07-28 10:05:11 +02:00
|
|
|
from synapse.types import JsonDict
|
2022-12-16 12:53:01 +01:00
|
|
|
from synapse.util import Clock
|
2021-07-28 10:05:11 +02:00
|
|
|
|
|
|
|
from tests import unittest
|
|
|
|
|
|
|
|
|
|
|
|
class ReceiptsTestCase(unittest.HomeserverTestCase):
|
2022-12-16 12:53:01 +01:00
|
|
|
def prepare(self, reactor: MemoryReactor, clock: Clock, hs: HomeServer) -> None:
|
2021-09-21 19:34:26 +02:00
|
|
|
self.event_source = hs.get_event_sources().sources.receipt
|
2021-07-28 10:05:11 +02:00
|
|
|
|
2022-09-01 14:31:54 +02:00
|
|
|
def test_filters_out_private_receipt(self) -> None:
|
2022-05-05 14:31:25 +02:00
|
|
|
self._test_filters_private(
|
2021-07-28 10:05:11 +02:00
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$1435641916114394fHBLK:matrix.org": {
|
2022-09-01 14:31:54 +02:00
|
|
|
ReceiptTypes.READ_PRIVATE: {
|
2021-07-28 10:05:11 +02:00
|
|
|
"@rikj:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2021-07-28 10:05:11 +02:00
|
|
|
}
|
|
|
|
],
|
|
|
|
[],
|
|
|
|
)
|
|
|
|
|
2022-09-01 14:31:54 +02:00
|
|
|
def test_filters_out_private_receipt_and_ignores_rest(self) -> None:
|
2022-05-05 14:31:25 +02:00
|
|
|
self._test_filters_private(
|
2021-07-28 10:05:11 +02:00
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$1dgdgrd5641916114394fHBLK:matrix.org": {
|
2022-09-01 14:31:54 +02:00
|
|
|
ReceiptTypes.READ_PRIVATE: {
|
2021-07-28 10:05:11 +02:00
|
|
|
"@rikj:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
},
|
2022-05-04 17:59:22 +02:00
|
|
|
},
|
|
|
|
ReceiptTypes.READ: {
|
2021-07-28 10:05:11 +02:00
|
|
|
"@user:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
},
|
2022-05-04 17:59:22 +02:00
|
|
|
},
|
|
|
|
},
|
2021-07-28 10:05:11 +02:00
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2021-07-28 10:05:11 +02:00
|
|
|
}
|
|
|
|
],
|
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$1dgdgrd5641916114394fHBLK:matrix.org": {
|
2022-04-28 19:34:12 +02:00
|
|
|
ReceiptTypes.READ: {
|
2021-07-28 10:05:11 +02:00
|
|
|
"@user:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2021-07-28 10:05:11 +02:00
|
|
|
}
|
|
|
|
],
|
|
|
|
)
|
|
|
|
|
2022-08-05 17:09:33 +02:00
|
|
|
def test_filters_out_event_with_only_private_receipts_and_ignores_the_rest(
|
2022-09-01 14:31:54 +02:00
|
|
|
self,
|
2022-08-05 17:09:33 +02:00
|
|
|
) -> None:
|
2022-05-05 14:31:25 +02:00
|
|
|
self._test_filters_private(
|
2021-07-28 10:05:11 +02:00
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$14356419edgd14394fHBLK:matrix.org": {
|
2022-09-01 14:31:54 +02:00
|
|
|
ReceiptTypes.READ_PRIVATE: {
|
2021-07-28 10:05:11 +02:00
|
|
|
"@rikj:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
},
|
|
|
|
"$1435641916114394fHBLK:matrix.org": {
|
2022-04-28 19:34:12 +02:00
|
|
|
ReceiptTypes.READ: {
|
2021-07-28 10:05:11 +02:00
|
|
|
"@user:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2021-07-28 10:05:11 +02:00
|
|
|
}
|
|
|
|
],
|
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$1435641916114394fHBLK:matrix.org": {
|
2022-04-28 19:34:12 +02:00
|
|
|
ReceiptTypes.READ: {
|
2021-07-28 10:05:11 +02:00
|
|
|
"@user:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2021-07-28 10:05:11 +02:00
|
|
|
}
|
|
|
|
],
|
|
|
|
)
|
|
|
|
|
2022-08-05 17:09:33 +02:00
|
|
|
def test_handles_empty_event(self) -> None:
|
2022-05-05 14:31:25 +02:00
|
|
|
self._test_filters_private(
|
2021-07-28 10:05:11 +02:00
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$143564gdfg6114394fHBLK:matrix.org": {},
|
|
|
|
"$1435641916114394fHBLK:matrix.org": {
|
2022-04-28 19:34:12 +02:00
|
|
|
ReceiptTypes.READ: {
|
2021-07-28 10:05:11 +02:00
|
|
|
"@user:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2021-07-28 10:05:11 +02:00
|
|
|
}
|
|
|
|
],
|
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$1435641916114394fHBLK:matrix.org": {
|
2022-04-28 19:34:12 +02:00
|
|
|
ReceiptTypes.READ: {
|
2021-07-28 10:05:11 +02:00
|
|
|
"@user:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2021-07-28 10:05:11 +02:00
|
|
|
}
|
|
|
|
],
|
|
|
|
)
|
|
|
|
|
2022-08-05 17:09:33 +02:00
|
|
|
def test_filters_out_receipt_event_with_only_private_receipt_and_ignores_rest(
|
2022-09-01 14:31:54 +02:00
|
|
|
self,
|
2022-08-05 17:09:33 +02:00
|
|
|
) -> None:
|
2022-05-05 14:31:25 +02:00
|
|
|
self._test_filters_private(
|
2021-07-28 10:05:11 +02:00
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$14356419edgd14394fHBLK:matrix.org": {
|
2022-09-01 14:31:54 +02:00
|
|
|
ReceiptTypes.READ_PRIVATE: {
|
2021-07-28 10:05:11 +02:00
|
|
|
"@rikj:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2021-07-28 10:05:11 +02:00
|
|
|
},
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$1435641916114394fHBLK:matrix.org": {
|
2022-04-28 19:34:12 +02:00
|
|
|
ReceiptTypes.READ: {
|
2021-07-28 10:05:11 +02:00
|
|
|
"@user:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2021-07-28 10:05:11 +02:00
|
|
|
},
|
|
|
|
],
|
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$1435641916114394fHBLK:matrix.org": {
|
2022-04-28 19:34:12 +02:00
|
|
|
ReceiptTypes.READ: {
|
2021-07-28 10:05:11 +02:00
|
|
|
"@user:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2021-07-28 10:05:11 +02:00
|
|
|
}
|
|
|
|
],
|
|
|
|
)
|
|
|
|
|
2022-08-05 17:09:33 +02:00
|
|
|
def test_handles_string_data(self) -> None:
|
2021-08-16 13:22:38 +02:00
|
|
|
"""
|
|
|
|
Tests that an invalid shape for read-receipts is handled.
|
|
|
|
Context: https://github.com/matrix-org/synapse/issues/10603
|
|
|
|
"""
|
|
|
|
|
2022-05-05 14:31:25 +02:00
|
|
|
self._test_filters_private(
|
2021-08-16 13:22:38 +02:00
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$14356419edgd14394fHBLK:matrix.org": {
|
2022-04-28 19:34:12 +02:00
|
|
|
ReceiptTypes.READ: {
|
2021-08-16 13:22:38 +02:00
|
|
|
"@rikj:jki.re": "string",
|
|
|
|
}
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2021-08-16 13:22:38 +02:00
|
|
|
},
|
|
|
|
],
|
2022-05-04 17:59:22 +02:00
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$14356419edgd14394fHBLK:matrix.org": {
|
|
|
|
ReceiptTypes.READ: {
|
|
|
|
"@rikj:jki.re": "string",
|
|
|
|
}
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2022-05-04 17:59:22 +02:00
|
|
|
},
|
|
|
|
],
|
|
|
|
)
|
|
|
|
|
2022-09-01 14:31:54 +02:00
|
|
|
def test_leaves_our_private_and_their_public(self) -> None:
|
2022-05-05 14:31:25 +02:00
|
|
|
self._test_filters_private(
|
2022-05-04 17:59:22 +02:00
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$1dgdgrd5641916114394fHBLK:matrix.org": {
|
2022-09-01 14:31:54 +02:00
|
|
|
ReceiptTypes.READ_PRIVATE: {
|
2022-05-04 17:59:22 +02:00
|
|
|
"@me:server.org": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
ReceiptTypes.READ: {
|
|
|
|
"@rikj:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"a.receipt.type": {
|
|
|
|
"@rikj:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2022-05-04 17:59:22 +02:00
|
|
|
}
|
|
|
|
],
|
|
|
|
[
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$1dgdgrd5641916114394fHBLK:matrix.org": {
|
2022-09-01 14:31:54 +02:00
|
|
|
ReceiptTypes.READ_PRIVATE: {
|
2022-05-04 17:59:22 +02:00
|
|
|
"@me:server.org": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
ReceiptTypes.READ: {
|
|
|
|
"@rikj:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"a.receipt.type": {
|
|
|
|
"@rikj:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2022-05-04 17:59:22 +02:00
|
|
|
}
|
|
|
|
],
|
2021-08-16 13:22:38 +02:00
|
|
|
)
|
|
|
|
|
2022-09-01 14:31:54 +02:00
|
|
|
def test_we_do_not_mutate(self) -> None:
|
2022-05-16 17:06:23 +02:00
|
|
|
"""Ensure the input values are not modified."""
|
|
|
|
events = [
|
|
|
|
{
|
|
|
|
"content": {
|
|
|
|
"$1435641916114394fHBLK:matrix.org": {
|
2022-09-01 14:31:54 +02:00
|
|
|
ReceiptTypes.READ_PRIVATE: {
|
2022-05-16 17:06:23 +02:00
|
|
|
"@rikj:jki.re": {
|
|
|
|
"ts": 1436451550453,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
|
2022-05-27 13:14:36 +02:00
|
|
|
"type": EduTypes.RECEIPT,
|
2022-05-16 17:06:23 +02:00
|
|
|
}
|
|
|
|
]
|
|
|
|
original_events = deepcopy(events)
|
|
|
|
self._test_filters_private(events, [])
|
|
|
|
# Since the events are fed in from a cache they should not be modified.
|
|
|
|
self.assertEqual(events, original_events)
|
|
|
|
|
2022-05-05 14:31:25 +02:00
|
|
|
def _test_filters_private(
|
2021-07-28 10:05:11 +02:00
|
|
|
self, events: List[JsonDict], expected_output: List[JsonDict]
|
2022-08-05 17:09:33 +02:00
|
|
|
) -> None:
|
2022-05-05 14:31:25 +02:00
|
|
|
"""Tests that the _filter_out_private returns the expected output"""
|
2022-05-16 17:06:23 +02:00
|
|
|
filtered_events = self.event_source.filter_out_private_receipts(
|
|
|
|
events, "@me:server.org"
|
|
|
|
)
|
2022-02-28 13:12:29 +01:00
|
|
|
self.assertEqual(filtered_events, expected_output)
|