MirrorHub/synapse
0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-11-16 15:01:23 +01:00
Code Issues Projects Releases Wiki Activity

Fix bug in calculating the federation retry backoff period (#6025)

Browse source 
This was intended to introduce an element of jitter; instead it gave you a
30/60 chance of resetting to zero.
This commit is contained in:
Richard van der Hoff 2019-09-12 12:59:43 +01:00 committed by GitHub
parent 59975f9a63
commit 0388beafe4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/6025.bugfix Normal file
View file

@ -0,0 +1 @@
Fix bug in calculating the federation retry backoff period.

5
synapse/util/retryutils.py
View file

@ -193,8 +193,9 @@ class RetryDestinationLimiter(object):
else: else:
# We couldn't connect. # We couldn't connect.
if self.retry_interval: if self.retry_interval:
self.retry_interval *= RETRY_MULTIPLIER self.retry_interval = int(
self.retry_interval *= int(random.uniform(0.8, 1.4)) self.retry_interval * RETRY_MULTIPLIER * random.uniform(0.8, 1.4)
)
if self.retry_interval >= MAX_RETRY_INTERVAL: if self.retry_interval >= MAX_RETRY_INTERVAL:
self.retry_interval = MAX_RETRY_INTERVAL self.retry_interval = MAX_RETRY_INTERVAL