MirrorHub/synapse
0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-11-12 04:52:26 +01:00
Code Issues Projects Releases Wiki Activity

Raise an error if an unknown preset is used to create a room. (#10738)

Browse source 
Raises a 400 error instead of a 500 if an unknown preset is passed
from a client to create a room.
This commit is contained in:
Patrick Cloke 2021-09-03 09:46:18 -04:00 committed by GitHub
parent ecbfa4fe4f
commit 2cb85bdf75
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/10738.misc Normal file
View file

@ -0,0 +1 @@
Additional error checking for the `preset` field when creating a room.

7
synapse/handlers/room.py
View file

@ -909,7 +909,12 @@ class RoomCreationHandler(BaseHandler):
) )
return last_stream_id return last_stream_id
config = self._presets_dict[preset_config] try:
config = self._presets_dict[preset_config]
except KeyError:
raise SynapseError(
400, f"'{preset_config}' is not a valid preset", errcode=Codes.BAD_JSON
)
creation_content.update({"creator": creator_id}) creation_content.update({"creator": creator_id})
await send(etype=EventTypes.Create, content=creation_content) await send(etype=EventTypes.Create, content=creation_content)