mirror of
https://mau.dev/maunium/synapse.git
synced 2024-12-14 06:33:47 +01:00
Update contributing.md to warn against rebasing an open PR. (#10563)
Signed-off-by: H.Shay <shaysquared@gmail.com>
This commit is contained in:
parent
b5de77cf86
commit
52bfa2d59a
2 changed files with 2 additions and 0 deletions
|
@ -252,6 +252,7 @@ To prepare a Pull Request, please:
|
||||||
4. on GitHub, [create the Pull Request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request);
|
4. on GitHub, [create the Pull Request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request);
|
||||||
5. add a [changelog entry](#changelog) and push it to your Pull Request;
|
5. add a [changelog entry](#changelog) and push it to your Pull Request;
|
||||||
6. for most contributors, that's all - however, if you are a member of the organization `matrix-org`, on GitHub, please request a review from `matrix.org / Synapse Core`.
|
6. for most contributors, that's all - however, if you are a member of the organization `matrix-org`, on GitHub, please request a review from `matrix.org / Synapse Core`.
|
||||||
|
7. if you need to update your PR, please avoid rebasing and just add new commits to your branch.
|
||||||
|
|
||||||
|
|
||||||
## Changelog
|
## Changelog
|
||||||
|
|
1
changelog.d/10563.misc
Normal file
1
changelog.d/10563.misc
Normal file
|
@ -0,0 +1 @@
|
||||||
|
Update contributing.md to warn against rebasing an open PR.
|
Loading…
Reference in a new issue