MirrorHub/synapse
0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-12-15 03:23:54 +01:00
Code Issues Projects Releases Wiki Activity

Use more portable syntax using attrs package.

Browse source 
Newer syntax

    attr.ib(factory=dict)

is just a syntactic sugar for

    attr.ib(default=attr.Factory(dict))

It was introduced in newest version of attrs package (18.1.0)
and doesn't work with older versions.

We should either require minimum version of attrs to be 18.1.0,
or use older (slightly more verbose) syntax.
Requiring newest version is not a good solution because
Linux distributions may have older version of attrs (17.4.0 in Fedora 28),
and requiring to build (and package)
newer version just to use newer syntactic sugar in only one test
is just too much.
It's much better to fix that test to use older syntax.

Signed-off-by: Oleg Girko <ol@infoserver.lv>
This commit is contained in:
Oleg Girko 2018-07-10 00:11:39 +01:00
parent 395fa8d1fd
commit 6c1ec5a1bd
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/server.py
View file

@ -22,7 +22,7 @@ class FakeChannel(object):
wire). wire).
""" """
result = attr.ib(factory=dict) result = attr.ib(default=attr.Factory(dict))
@property @property
def json_body(self): def json_body(self):