MirrorHub/synapse
0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-11-17 23:42:33 +01:00
Code Issues Projects Releases Wiki Activity

Rename remove_deleted_devices_from_device_inbox to ensure it is always run (#11353)

Browse source 
Co-authored-by: reivilibre <oliverw@matrix.org>
This commit is contained in:
Andrew Morgan 2021-11-16 13:16:43 +00:00 committed by GitHub
parent 9c59e117db
commit 6e084b62b8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/11353.misc Normal file
View file

@ -0,0 +1 @@
Fix an issue which prevented the 'remove deleted devices from `device_inbox` column' background process from running when updating from a recent Synapse version.

14
synapse/storage/schema/main/delta/65/05remove_deleted_devices_from_device_inbox.sql → synapse/storage/schema/main/delta/65/06remove_deleted_devices_from_device_inbox.sql
View file

@ -18,5 +18,17 @@
-- when a device was deleted using Synapse earlier than 1.47.0.
-- This runs as background task, but may take a bit to finish.
-- Remove any existing instances of this job running. It's OK to stop and restart this job,
-- as it's just deleting entries from a table - no progress will be lost.
--
-- This is necessary due a similar migration running the job accidentally
-- being included in schema version 64 during v1.47.0rc1,rc2. If a
-- homeserver had updated from Synapse <=v1.45.0 (schema version <=64),
-- then they would have started running this background update already.
-- If that update was still running, then simply inserting it again would
-- cause an SQL failure. So we effectively do an "upsert" here instead.
DELETE FROM background_updates WHERE update_name = 'remove_deleted_devices_from_device_inbox';
INSERT INTO background_updates (ordering, update_name, progress_json) VALUES
(6505, 'remove_deleted_devices_from_device_inbox', '{}');
(6506, 'remove_deleted_devices_from_device_inbox', '{}');