MirrorHub/synapse
0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-06-25 22:18:18 +02:00
Code Issues Projects Releases Wiki Activity

Stop populating state_events.prev_state (#11558)

Browse source 
this field is never read, so we may as well stop populating it.
This commit is contained in:
Richard van der Hoff 2021-12-10 14:13:23 +00:00 committed by GitHub
parent 9562f0c2f1
commit 86e7a6d16e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/11558.misc Normal file
View file

@ -0,0 +1 @@
Stop populating unused database column `state_events.prev_state`.

4
synapse/storage/databases/main/events.py
View file

@ -1410,10 +1410,6 @@ class PersistEventsStore:
"state_key": event.state_key,
}
# TODO: How does this work with backfilling?
if hasattr(event, "replaces_state"):
vals["prev_state"] = event.replaces_state
state_values.append(vals)
self.db_pool.simple_insert_many_txn(

5
synapse/storage/schema/__init__.py
View file

@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
SCHEMA_VERSION = 66 # remember to update the list below when updating
SCHEMA_VERSION = 67 # remember to update the list below when updating
"""Represents the expectations made by the codebase about the database schema
This should be incremented whenever the codebase changes its requirements on the
@ -50,6 +50,9 @@ Changes in SCHEMA_VERSION = 65:
Changes in SCHEMA_VERSION = 66:
- Queries on state_key columns are now disambiguated (ie, the codebase can handle
the `events` table having a `state_key` column).
Changes in SCHEMA_VERSION = 67:
- state_events.prev_state is no longer written to.
"""