MirrorHub/synapse
0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-12-13 13:03:27 +01:00
Code Issues Projects Releases Wiki Activity

Fix http/s proxy authentication with long username/passwords (#16504)

Browse source
This commit is contained in:
Richard Brežák 2023-10-24 15:45:21 +02:00 committed by GitHub
parent 2f1065f81b
commit 95076f77c1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/16504.bugfix Normal file
View file

@ -0,0 +1 @@
Fix a bug introduced in Synapse 1.41 where HTTP(S) forward proxy authorization would fail when using basic HTTP authentication with a long `username:password` string.

2
synapse/http/connectproxyclient.py
View file

@ -59,7 +59,7 @@ class BasicProxyCredentials(ProxyCredentials):
a Proxy-Authorization header.
"""
# Encode as base64 and prepend the authorization type
return b"Basic " + base64.encodebytes(self.username_password)
return b"Basic " + base64.b64encode(self.username_password)
@attr.s(auto_attribs=True)

21
tests/http/test_proxyagent.py
View file

@ -217,6 +217,27 @@ class ProxyParserTests(TestCase):
)
class TestBasicProxyCredentials(TestCase):
def test_long_user_pass_string_encoded_without_newlines(self) -> None:
"""Reproduces https://github.com/matrix-org/synapse/pull/16504."""
proxy_connection_string = b"looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooonguser:pass@proxy.local:9988"
_, _, _, creds = parse_proxy(proxy_connection_string)
assert creds is not None # for mypy's benefit
self.assertIsInstance(creds, BasicProxyCredentials)
auth_value = creds.as_proxy_authorization_value()
self.assertNotIn(b"\n", auth_value)
self.assertEqual(
creds.as_proxy_authorization_value(),
b"Basic bG9vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vbmd1c2VyOnBhc3M=",
)
basic_auth_payload = creds.as_proxy_authorization_value().split(b" ")[1]
self.assertEqual(
base64.b64decode(basic_auth_payload),
b"looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooonguser:pass",
)
class MatrixFederationAgentTests(TestCase):
def setUp(self) -> None:
self.reactor = ThreadedMemoryReactorClock()