MirrorHub/synapse
0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-11-13 05:21:43 +01:00
Code Issues Projects Releases Wiki Activity

Fix "Starting metrics collection from sentinel context" errors (#9053)

Browse source
This commit is contained in:
Erik Johnston 2021-01-08 14:33:53 +00:00 committed by GitHub
parent 12f79da587
commit a03d71dc9d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/9053.bugfix Normal file
View file

@ -0,0 +1 @@
Fix bug where we didn't correctly record CPU time spent in 'on_new_event' block.

1
synapse/notifier.py
View file

@ -396,7 +396,6 @@ class Notifier:
Will wake up all listeners for the given users and rooms. Will wake up all listeners for the given users and rooms.
""" """
with PreserveLoggingContext():
with Measure(self.clock, "on_new_event"): with Measure(self.clock, "on_new_event"):
user_streams = set() user_streams = set()

3
synapse/util/metrics.py
View file

@ -111,7 +111,8 @@ class Measure:
curr_context = current_context() curr_context = current_context()
if not curr_context: if not curr_context:
logger.warning( logger.warning(
"Starting metrics collection from sentinel context: metrics will be lost" "Starting metrics collection %r from sentinel context: metrics will be lost",
name,
) )
parent_context = None parent_context = None
else: else: