mirror of
https://mau.dev/maunium/synapse.git
synced 2024-12-14 09:33:53 +01:00
remove dead transaction persist code (#5622)
this hasn't done anything for years
This commit is contained in:
parent
9481707a52
commit
a6a776f3d8
4 changed files with 1 additions and 69 deletions
1
changelog.d/5622.misc
Normal file
1
changelog.d/5622.misc
Normal file
|
@ -0,0 +1 @@
|
||||||
|
Remove dead code for persiting outgoing federation transactions.
|
|
@ -21,8 +21,6 @@ These actions are mostly only used by the :py:mod:`.replication` module.
|
||||||
|
|
||||||
import logging
|
import logging
|
||||||
|
|
||||||
from twisted.internet import defer
|
|
||||||
|
|
||||||
from synapse.logging.utils import log_function
|
from synapse.logging.utils import log_function
|
||||||
|
|
||||||
logger = logging.getLogger(__name__)
|
logger = logging.getLogger(__name__)
|
||||||
|
@ -63,33 +61,3 @@ class TransactionActions(object):
|
||||||
return self.store.set_received_txn_response(
|
return self.store.set_received_txn_response(
|
||||||
transaction.transaction_id, origin, code, response
|
transaction.transaction_id, origin, code, response
|
||||||
)
|
)
|
||||||
|
|
||||||
@defer.inlineCallbacks
|
|
||||||
@log_function
|
|
||||||
def prepare_to_send(self, transaction):
|
|
||||||
""" Persists the `Transaction` we are about to send and works out the
|
|
||||||
correct value for the `prev_ids` key.
|
|
||||||
|
|
||||||
Returns:
|
|
||||||
Deferred
|
|
||||||
"""
|
|
||||||
transaction.prev_ids = yield self.store.prep_send_transaction(
|
|
||||||
transaction.transaction_id,
|
|
||||||
transaction.destination,
|
|
||||||
transaction.origin_server_ts,
|
|
||||||
)
|
|
||||||
|
|
||||||
@log_function
|
|
||||||
def delivered(self, transaction, response_code, response_dict):
|
|
||||||
""" Marks the given `Transaction` as having been successfully
|
|
||||||
delivered to the remote homeserver, and what the response was.
|
|
||||||
|
|
||||||
Returns:
|
|
||||||
Deferred
|
|
||||||
"""
|
|
||||||
return self.store.delivered_txn(
|
|
||||||
transaction.transaction_id,
|
|
||||||
transaction.destination,
|
|
||||||
response_code,
|
|
||||||
response_dict,
|
|
||||||
)
|
|
||||||
|
|
|
@ -63,8 +63,6 @@ class TransactionManager(object):
|
||||||
len(edus),
|
len(edus),
|
||||||
)
|
)
|
||||||
|
|
||||||
logger.debug("TX [%s] Persisting transaction...", destination)
|
|
||||||
|
|
||||||
transaction = Transaction.create_new(
|
transaction = Transaction.create_new(
|
||||||
origin_server_ts=int(self.clock.time_msec()),
|
origin_server_ts=int(self.clock.time_msec()),
|
||||||
transaction_id=txn_id,
|
transaction_id=txn_id,
|
||||||
|
@ -76,9 +74,6 @@ class TransactionManager(object):
|
||||||
|
|
||||||
self._next_txn_id += 1
|
self._next_txn_id += 1
|
||||||
|
|
||||||
yield self._transaction_actions.prepare_to_send(transaction)
|
|
||||||
|
|
||||||
logger.debug("TX [%s] Persisted transaction", destination)
|
|
||||||
logger.info(
|
logger.info(
|
||||||
"TX [%s] {%s} Sending transaction [%s]," " (PDUs: %d, EDUs: %d)",
|
"TX [%s] {%s} Sending transaction [%s]," " (PDUs: %d, EDUs: %d)",
|
||||||
destination,
|
destination,
|
||||||
|
@ -118,10 +113,6 @@ class TransactionManager(object):
|
||||||
|
|
||||||
logger.info("TX [%s] {%s} got %d response", destination, txn_id, code)
|
logger.info("TX [%s] {%s} got %d response", destination, txn_id, code)
|
||||||
|
|
||||||
yield self._transaction_actions.delivered(transaction, code, response)
|
|
||||||
|
|
||||||
logger.debug("TX [%s] {%s} Marked as delivered", destination, txn_id)
|
|
||||||
|
|
||||||
if code == 200:
|
if code == 200:
|
||||||
for e_id, r in response.get("pdus", {}).items():
|
for e_id, r in response.get("pdus", {}).items():
|
||||||
if "error" in r:
|
if "error" in r:
|
||||||
|
|
|
@ -133,34 +133,6 @@ class TransactionStore(SQLBaseStore):
|
||||||
desc="set_received_txn_response",
|
desc="set_received_txn_response",
|
||||||
)
|
)
|
||||||
|
|
||||||
def prep_send_transaction(self, transaction_id, destination, origin_server_ts):
|
|
||||||
"""Persists an outgoing transaction and calculates the values for the
|
|
||||||
previous transaction id list.
|
|
||||||
|
|
||||||
This should be called before sending the transaction so that it has the
|
|
||||||
correct value for the `prev_ids` key.
|
|
||||||
|
|
||||||
Args:
|
|
||||||
transaction_id (str)
|
|
||||||
destination (str)
|
|
||||||
origin_server_ts (int)
|
|
||||||
|
|
||||||
Returns:
|
|
||||||
list: A list of previous transaction ids.
|
|
||||||
"""
|
|
||||||
return defer.succeed([])
|
|
||||||
|
|
||||||
def delivered_txn(self, transaction_id, destination, code, response_dict):
|
|
||||||
"""Persists the response for an outgoing transaction.
|
|
||||||
|
|
||||||
Args:
|
|
||||||
transaction_id (str)
|
|
||||||
destination (str)
|
|
||||||
code (int)
|
|
||||||
response_json (str)
|
|
||||||
"""
|
|
||||||
pass
|
|
||||||
|
|
||||||
@defer.inlineCallbacks
|
@defer.inlineCallbacks
|
||||||
def get_destination_retry_timings(self, destination):
|
def get_destination_retry_timings(self, destination):
|
||||||
"""Gets the current retry timings (if any) for a given destination.
|
"""Gets the current retry timings (if any) for a given destination.
|
||||||
|
|
Loading…
Reference in a new issue