MirrorHub/synapse
0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-12-15 03:03:50 +01:00
Code Issues Projects Releases Wiki Activity

Remove unused code path from member change DB func

Browse source 
The function is never called without a from_key, so we can remove all
the handling for that scenario.
This commit is contained in:
Erik Johnston 2018-05-09 14:31:32 +01:00
parent 05e0a2462c
commit c0e08dc45b
1 changed files with 10 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
synapse/storage/stream.py
View file

@ -304,10 +304,7 @@ class StreamWorkerStore(EventsWorkerStore, SQLBaseStore):
@defer.inlineCallbacks @defer.inlineCallbacks
def get_membership_changes_for_user(self, user_id, from_key, to_key): def get_membership_changes_for_user(self, user_id, from_key, to_key):
if from_key is not None:
from_id = RoomStreamToken.parse_stream_token(from_key).stream from_id = RoomStreamToken.parse_stream_token(from_key).stream
else:
from_id = None
to_id = RoomStreamToken.parse_stream_token(to_key).stream to_id = RoomStreamToken.parse_stream_token(to_key).stream
if from_key == to_key: if from_key == to_key:
@ -321,7 +318,6 @@ class StreamWorkerStore(EventsWorkerStore, SQLBaseStore):
defer.returnValue([]) defer.returnValue([])
def f(txn): def f(txn):
if from_id is not None:
sql = ( sql = (
"SELECT m.event_id, stream_ordering FROM events AS e," "SELECT m.event_id, stream_ordering FROM events AS e,"
" room_memberships AS m" " room_memberships AS m"
@ -331,16 +327,6 @@ class StreamWorkerStore(EventsWorkerStore, SQLBaseStore):
" ORDER BY e.stream_ordering ASC" " ORDER BY e.stream_ordering ASC"
) )
txn.execute(sql, (user_id, from_id, to_id,)) txn.execute(sql, (user_id, from_id, to_id,))
else:
sql = (
"SELECT m.event_id, stream_ordering FROM events AS e,"
" room_memberships AS m"
" WHERE e.event_id = m.event_id"
" AND m.user_id = ?"
" AND stream_ordering <= ?"
" ORDER BY stream_ordering ASC"
)
txn.execute(sql, (user_id, to_id,))
rows = [_EventDictReturn(row[0], None, row[1]) for row in txn] rows = [_EventDictReturn(row[0], None, row[1]) for row in txn]