MirrorHub/synapse
0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-12-21 18:03:51 +01:00
Code Issues Projects Releases Wiki Activity

fix a logcontext leak in read receipt handling

Browse source
This commit is contained in:
Richard van der Hoff 2017-10-11 14:37:20 +01:00
parent 4d24becf7f
commit c3e190ce67
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
synapse/handlers/receipts.py
View file

@ -12,6 +12,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
from synapse.util import logcontext
from ._base import BaseHandler from ._base import BaseHandler
@ -59,6 +60,8 @@ class ReceiptsHandler(BaseHandler):
is_new = yield self._handle_new_receipts([receipt]) is_new = yield self._handle_new_receipts([receipt])
if is_new: if is_new:
# fire off a process in the background to send the receipt to
# remote servers
self._push_remotes([receipt]) self._push_remotes([receipt])
@defer.inlineCallbacks @defer.inlineCallbacks
@ -126,6 +129,7 @@ class ReceiptsHandler(BaseHandler):
defer.returnValue(True) defer.returnValue(True)
@logcontext.preserve_fn # caller should not yield on this
@defer.inlineCallbacks @defer.inlineCallbacks
def _push_remotes(self, receipts): def _push_remotes(self, receipts):
"""Given a list of receipts, works out which remote servers should be """Given a list of receipts, works out which remote servers should be