MirrorHub/synapse
0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-06-29 07:58:19 +02:00
Code Issues Projects Releases Wiki Activity

Add opentracing spans to calls to external cache (#12380)

Browse source
This commit is contained in:
Erik Johnston 2022-04-07 13:18:29 +01:00 committed by GitHub
parent 3a7e97c7ad
commit d1cd96ce29
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 24 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/12380.misc Normal file
View file

@ -0,0 +1 @@
Add opentracing spans to calls to external cache.

3
synapse/logging/opentracing.py
View file

@ -289,6 +289,9 @@ class SynapseTags:
# Uniqueish ID of a database transaction # Uniqueish ID of a database transaction
DB_TXN_ID = "db.txn_id" DB_TXN_ID = "db.txn_id"
# The name of the external cache
CACHE_NAME = "cache.name"
class SynapseBaggage: class SynapseBaggage:
FORCE_TRACING = "synapse-force-tracing" FORCE_TRACING = "synapse-force-tracing"

9
synapse/replication/tcp/external_cache.py
View file

@ -17,6 +17,7 @@ from typing import TYPE_CHECKING, Any, Optional
from prometheus_client import Counter, Histogram from prometheus_client import Counter, Histogram
from synapse.logging import opentracing
from synapse.logging.context import make_deferred_yieldable from synapse.logging.context import make_deferred_yieldable
from synapse.util import json_decoder, json_encoder from synapse.util import json_decoder, json_encoder
@ -93,6 +94,10 @@ class ExternalCache:
logger.debug("Caching %s %s: %r", cache_name, key, encoded_value) logger.debug("Caching %s %s: %r", cache_name, key, encoded_value)
with opentracing.start_active_span(
"ExternalCache.set",
tags={opentracing.SynapseTags.CACHE_NAME: cache_name},
):
with response_timer.labels("set").time(): with response_timer.labels("set").time():
return await make_deferred_yieldable( return await make_deferred_yieldable(
self._redis_connection.set( self._redis_connection.set(
@ -108,6 +113,10 @@ class ExternalCache:
if self._redis_connection is None: if self._redis_connection is None:
return None return None
with opentracing.start_active_span(
"ExternalCache.get",
tags={opentracing.SynapseTags.CACHE_NAME: cache_name},
):
with response_timer.labels("get").time(): with response_timer.labels("get").time():
result = await make_deferred_yieldable( result = await make_deferred_yieldable(
self._redis_connection.get(self._get_redis_key(cache_name, key)) self._redis_connection.get(self._get_redis_key(cache_name, key))