Erik Johnston
8f35f8148e
Fix bug where a new writer advances their token too quickly ( #16473 )
...
* Fix bug where a new writer advances their token too quickly
When starting a new writer (for e.g. persisting events), the
`MultiWriterIdGenerator` doesn't have a minimum token for it as there
are no rows matching that new writer in the DB.
This results in the the first stream ID it acquired being announced as
persisted *before* it actually finishes persisting, if another writer
gets and persists a subsequent stream ID. This is due to the logic of
setting the minimum persisted position to the minimum known position of
across all writers, and the new writer starts off not being considered.
* Fix sending out POSITIONs when our token advances without update
Broke in #14820
* For replication HTTP requests, only wait for minimal position
2023-10-23 16:57:30 +01:00
Erik Johnston
3bc23cc45c
Fix bug that could cause a /sync to tightloop with sqlite after restart ( #16540 )
...
This could happen if the last rows in the account data stream were inserted into `account_data`. After a restart the max account ID would be calculated without looking at the `account_data` table, and so have an old ID.
2023-10-23 13:39:25 +00:00
Marcel
3bcb6a059f
Mention how to redirect the Jaeger traces to a specific Jaeger instance ( #16531 )
2023-10-23 11:55:36 +00:00
Denis Kasak
3a0aa6fe76
Force TLS certificate verification in registration script. ( #16530 )
...
If using the script remotely, there's no particularly convincing reason
to disable certificate verification, as this makes the connection
interceptible.
If on the other hand, the script is used locally (the most common use
case), you can simply target the HTTP listener and avoid TLS altogether.
This is what the script already attempts to do if passed a homeserver
configuration YAML file.
2023-10-23 07:38:51 -04:00
Patrick Cloke
12ca87f5ea
Remove the last reference to event_txn_id. ( #16521 )
...
This table was no longer used, except for a background process
which purged old entries in it.
2023-10-23 07:37:45 -04:00
David Robertson
478a6c65eb
Bump matrix-synapse-ldap3 from 0.2.2 to 0.3.0 ( #16539 )
2023-10-23 12:28:29 +01:00
Patrick Cloke
d2eab22de7
Clarify presence router docs. ( #16529 )
2023-10-20 11:40:26 -04:00
Erik Johnston
e9069c9f91
Mark sync as limited if there is a gap in the timeline ( #16485 )
...
This splits thinsg into two queries, but most of the time we won't have
new event backwards extremities so this shouldn't actually add an extra
RTT for the majority of cases.
Note this removes the check for events with no prev events, but that was
part of MSC2716 work that has since been removed.
2023-10-19 15:04:18 +01:00
Patrick Cloke
49c9745b45
Avoid sending massive replication updates when purging a room. ( #16510 )
2023-10-18 12:26:01 -04:00
Mathieu Velten
bcff01b406
Improve performance of delete device messages query ( #16492 )
2023-10-18 16:42:01 +01:00
Patrick Cloke
8841db4d27
Run trial/integration tests if .ci is modified. ( #16512 )
2023-10-18 07:19:53 -04:00
Patrick Cloke
68d9559fef
Test against Python 3.12 release ( #16511 )
2023-10-17 14:41:10 -04:00
Patrick Cloke
6e6d611f55
1.95.0rc1
2023-10-17 11:54:45 -04:00
Patrick Cloke
6ad1f9eac2
Convert DeviceLastConnectionInfo to attrs. ( #16507 )
...
To improve type safety & memory usage.
2023-10-17 12:47:42 +00:00
Patrick Cloke
77dfc1f939
Fix a bug where servers could be marked as up when they were failing ( #16506 )
...
After this change a server will only be reported as back online
if they were previously having requests fail.
2023-10-17 07:32:40 -04:00
reivilibre
7291c68eea
Update the release script to remind releaser to check for special release notes. ( #16461 )
...
* Add reminder to check special release notes board in release script
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Update release.py
* Bah, black
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-10-16 15:22:50 +01:00
Patrick Cloke
e3e0ae4ab1
Convert state delta processing from a dict to attrs. ( #16469 )
...
For improved type checking & memory usage.
2023-10-16 07:35:22 -04:00
Mathieu Velten
eee6474bce
Remove useless async job to delete device messages on sync ( #16491 )
2023-10-16 11:06:27 +01:00
Richard van der Hoff
109882230c
Clean up logging on event persister endpoints ( #16488 )
2023-10-14 17:57:27 +01:00
Laurence Gill
166ffc0f23
Fix typo in useful_sql_for_admins.md ( #16477 )
2023-10-12 16:18:32 +01:00
Patrick Cloke
4cc729d480
Revert "Drop unused tables & unneeded access token ID for events. ( #16268 )" ( #16465 )
...
This reverts commit cabd577460
2023-10-12 08:56:10 -04:00
kegsay
f710d5480b
Update complement.sh to match new public API shape ( #16466 )
...
* Update complement.sh to match new public API shape
Sister PR to https://github.com/matrix-org/complement/pull/666
Context: https://github.com/matrix-org/complement/issues/654#issuecomment-1746613495
* Changelog
* Pedantry
* Run complement plz
2023-10-12 11:33:14 +01:00
Patrick Cloke
cc865fffc0
Convert user_get_threepids response to attrs. ( #16468 )
...
This improves type annotations by not having a dictionary of Any values.
2023-10-11 20:08:11 -04:00
Patrick Cloke
a4904dcb04
Convert simple_select_many_batch, simple_select_many_txn to tuples. ( #16444 )
2023-10-11 13:24:56 -04:00
Patrick Cloke
d6b7d49a61
Handle content types with parameters. ( #16440 )
2023-10-11 07:50:34 -04:00
Patrick Cloke
f1e43018b7
Inline simple_search_list/simple_search_list_txn. ( #16434 )
...
This only has a single use and is over abstracted. Inline it so that
we can improve type hints.
2023-10-10 12:16:36 -04:00
David Robertson
28fd28e92e
Add DB indices to speed up purging rooms ( #16457 )
2023-10-10 10:33:39 +01:00
reivilibre
8902b3031d
Disable statement timeout whilst purging rooms ( #16455 )
...
* Disable statement timeout whilst purging rooms
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Note the introduction version
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-10-09 15:41:17 +01:00
Erik Johnston
a6abee36bc
Don't block CI on sign-off ( #16454 )
...
As this doesn't work with the private sign off flow.
2023-10-09 12:22:54 +01:00
Christoph
32fd9bc673
Fix possible AttributeError when account-api is called over unix socket ( #16404 )
...
Fixes #16396
2023-10-09 10:16:07 +01:00
David Robertson
1f10c20806
Apply join rate limiter outside the lineariser ( #16441 )
2023-10-06 17:31:52 +00:00
Patrick Cloke
06bbf1029c
Convert simple_select_list_paginate_txn to return tuples. ( #16433 )
2023-10-06 11:41:57 -04:00
Patrick Cloke
7615e2bf48
Return ThumbnailInfo in more places ( #16438 )
...
Improves type hints by using concrete types instead of
dictionaries.
2023-10-06 10:12:43 -04:00
Patrick Cloke
cabd577460
Drop unused tables & unneeded access token ID for events. ( #16268 )
...
Drop the event_txn_id table and the tables related to MSC2716,
which is no longer supported in Synapse.
2023-10-06 08:29:33 -04:00
Patrick Cloke
fc31b495b3
Stop sending incorrect knock_state_events. ( #16403 )
...
Synapse was incorrectly implemented with a knock_state_events
property on some APIs (instead of knock_room_state). This was
correct in Synapse 1.70.0, but *both* fields were sent to also be
compatible with Synapse versions expecting the wrong field.
Enough time has passed that only the correct field needs to be
included/handled.
2023-10-06 07:27:35 -04:00
Patrick Cloke
ae5b997cfa
Fix comments related to replication. ( #16428 )
2023-10-06 07:25:44 -04:00
Patrick Cloke
694802eecd
Add documentation on background updates. ( #16420 )
2023-10-06 07:23:20 -04:00
Patrick Cloke
26b960b08b
Register media servlets via regex. ( #16419 )
...
This converts the media servlet URLs in the same way as
(most) of the rest of Synapse. This will give more flexibility
in the versions each endpoint exists under.
2023-10-06 07:22:55 -04:00
V02460
5946074d69
Bump pyo3 from 0.17.1 to 0.19.2 ( #16162 )
...
Signed-off-by: Kai A. Hiller <V02460@gmail.com>
2023-10-06 11:27:59 +01:00
Patrick Cloke
3555790b27
Remove unused method. ( #16435 )
2023-10-05 17:42:44 -04:00
Patrick Cloke
fa907025f4
Remove manys calls to cursor_to_dict ( #16431 )
...
This avoids calling cursor_to_dict and then immediately
unpacking the values in the dict for other users. By not
creating the intermediate dictionary we can avoid allocating
the dictionary and strings for the keys, which should generally
be more performant.
Additionally this improves type hints by avoid Dict[str, Any]
dictionaries coming out of the database layer.
2023-10-05 11:07:38 -04:00
Patrick Cloke
4e302b30b6
Add __slots__ to replication commands. ( #16429 )
...
To slightly reduce the amount of memory each command takes.
2023-10-05 07:38:55 -04:00
Erik Johnston
009b47badf
Factor out MultiWriter token from RoomStreamToken ( #16427 )
2023-10-05 10:46:28 +01:00
Patrick Cloke
ab9c1e8f39
Add type hints to synmark. ( #16421 )
2023-10-04 13:53:04 -04:00
Erik Johnston
80ec81dcc5
Some refactors around receipts stream ( #16426 )
2023-10-04 16:28:40 +01:00
David Robertson
8b50a9d01d
1.94.0rc1
2023-10-03 11:50:57 +01:00
Erik Johnston
1e67191a79
Add note to 'federation_domain_whitelist' option ( #16416 )
2023-10-03 09:55:29 +01:00
Patrick Cloke
127b940dc0
Clean-up old release notes ( #16418 )
...
Fixes some broken formatting from the reStructuedText to Markdown
conversion and fixes some typos.
2023-10-02 11:05:29 -04:00
David Robertson
1026776380
mypy plugin to check @cached return types ( #14911 )
...
Co-authored-by: David Robertson <davidr@element.io>
Co-authored-by: Patrick Cloke <patrickc@matrix.org>
Co-authored-by: Erik Johnston <erik@matrix.org>
Assert that the return type of callables wrapped in @cached
and @cachedList are cachable (aka immutable).
2023-10-02 14:22:36 +00:00
MomentQYC
5725712d47
Remove Python version from /_synapse/admin/v1/server_version ( #16380 )
...
There's no reason to expose the full Python version over what is
frequently a public API.
2023-10-02 09:07:53 -04:00
Erik Johnston
20fb08ec80
Downgrade repl stream time out error to warning ( #16401 )
...
This is because if a worker reaches ~100% CPU then everything starts
lagging and we hit the log line a lot. When at error we invoke sentry
and that has a lot of overhead, which then puts even more pressure on
the worker.
2023-09-29 11:52:48 +00:00
Will Hunt
79eb6c0cdc
Support rendering some media downloads as inline ( #15988 )
...
Use an `inline` Content-Disposition header when the media is
"safe" to display inline (some known text, image, video, audio
formats).
2023-09-29 07:19:38 -04:00
Patrick Cloke
fb664cf159
Remove warnings from the docs about using message retention. ( #16382 )
...
There are no known bugs in the message retention code, but
it is possible that there still exists race conditions. Additional
fixes will be made as reported.
2023-09-28 07:02:31 -04:00
Patrick Cloke
cdb89dcefe
Improve state types. ( #16395 )
2023-09-28 07:01:46 -04:00
Patrick Cloke
c690fd16c4
Use modern config for maturin. ( #16394 )
...
This allows maturin >= 0.15 to build the properly named
shared library object.
For now the old configuration is also kept to allow for
older maturin installs to be used.
2023-09-28 07:01:16 -04:00
Patrick Cloke
f84da3c32e
Add a cache around server ACL checking ( #16360 )
...
* Pre-compiles the server ACLs onto an object per room and
invalidates them when new events come in.
* Converts the server ACL checking into Rust.
2023-09-26 11:57:50 -04:00
Patrick Cloke
17800a0e97
Implement MSC4028: push all encrypted events. ( #16361 )
...
This unstable push rule is implemented behind an experimental
configuration flag.
2023-09-26 11:52:19 -04:00
David Robertson
06f650f5f4
Skip export-data on non-code (e.g. docs) PRs ( #16387 )
2023-09-26 15:21:07 +01:00
Patrick Cloke
ec1c709440
Add documentation about the user directory search algorithm ( #16320 )
2023-09-26 13:44:38 +00:00
Erik Johnston
47ffc7e548
Reduce calls to send_presence_to_destinations ( #16385 )
2023-09-26 11:49:44 +01:00
Patrick Cloke
2763c49eca
Improve comments in StateGroupBackgroundUpdateStore. ( #16383 )
2023-09-25 18:50:47 +00:00
reivilibre
9fd18e9b06
Add developer documentation concerning gradual schema migrations with column alterations. ( #15691 )
...
Co-authored-by: Eric Eastwood <erice@element.io>
2023-09-25 17:43:09 +00:00
reivilibre
525d9d6e11
Avoid running CI steps when the files they check have not been changed. ( #14745 )
2023-09-25 16:59:40 +00:00
dependabot[bot]
b225acf3e6
Bump types-psycopg2 from 2.9.21.11 to 2.9.21.14 ( #16381 )
...
* Bump types-psycopg2 from 2.9.21.11 to 2.9.21.14
Bumps [types-psycopg2](https://github.com/python/typeshed ) from 2.9.21.11 to 2.9.21.14.
- [Commits](https://github.com/python/typeshed/commits )
---
updated-dependencies:
- dependency-name: types-psycopg2
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Relax the annotation of Cursor.description
See
https://github.com/matrix-org/synapse/pull/16343#issuecomment-1726083384
for rationale.
* Changelog
* Changelog
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Robertson <davidr@element.io>
2023-09-25 17:48:42 +01:00
Maxwell G
12611bfcdd
Add support for pydantic v2 via pydantic.v1 compat module ( #16332 )
...
While maintaining support with pydantic v1.
2023-09-25 15:19:08 +00:00
David Robertson
fad4c63d25
Get CI to check PRs have been signed-off ( #16348 )
2023-09-25 14:45:17 +00:00
Patrick Cloke
c9a0e1673a
Add missing license header. ( #16359 )
2023-09-21 09:47:29 -04:00
Patrick Cloke
7ec0a141b4
Convert more cached return values to immutable types ( #16356 )
2023-09-20 07:48:55 -04:00
Patrick Cloke
d7c89c5908
Return immutable objects for cachedList decorators ( #16350 )
2023-09-19 15:26:44 -04:00
Patrick Cloke
5a66ff2f5c
Merge branch 'release-v1.93' into develop
2023-09-19 10:33:22 -04:00
Patrick Cloke
9fabde6ead
Fix-up deactivated notes in docs. ( #16355 )
2023-09-19 08:05:33 -04:00
Patrick Cloke
9caeb9be10
1.93.0rc1
2023-09-19 07:56:49 -04:00
Jan Christian Grünhage
3d60b07cde
Use string for federation_client_minimum_tls_version documentation examples ( #16353 )
2023-09-19 07:24:47 -04:00
Patrick Cloke
118036eeab
Test against PostgreSQL 16. ( #16351 )
2023-09-18 13:21:00 -04:00
Patrick Cloke
47d4bb6057
Stop patching EventBase.__eq__ in tests. ( #16349 )
...
It is clearer to directly test equality instead of doing indirect
assertions via patching __eq__.
2023-09-18 14:48:02 +00:00
Hanadi
eef2b9e344
Filter locked users in the admin API ( #16328 )
...
Co-authored-by: Hanadi Tamimi <hanadi.tamimi@sdui.de>
2023-09-18 15:37:51 +01:00
Patrick Cloke
c1e244c8f7
Make cached account data/tags/admin types immutable ( #16325 )
2023-09-18 09:55:04 -04:00
Patrick Cloke
85bfd4735e
Return an immutable value from get_latest_event_ids_in_room. ( #16326 )
2023-09-18 09:29:05 -04:00
Patrick Cloke
63d28a88c1
Additional validation of receipts ( #16327 )
...
Reject invalid receipts with a reasonable error message &
expands tests for receipts.
2023-09-18 13:02:12 +00:00
Mathieu Velten
4663d55502
Mandate Pillow>=10.0.1 because of libwebp CVE ( #16347 )
2023-09-18 15:01:23 +02:00
José Joaquín Atria
6946209e67
Set email charset as utf-8 rather than utf8 ( #16329 )
2023-09-18 07:32:01 -04:00
Mathieu Velten
dd44ee00b6
Add automatic purge after all users forget a room ( #15488 )
...
Also add restore of purge/shutdown rooms after a synapse restart.
Co-authored-by: Eric Eastwood <erice@matrix.org>
Co-authored-by: Erik Johnston <erikj@matrix.org>
2023-09-15 15:37:44 +02:00
Jason Little
2a0f86f88f
Convert _insert_graph_receipts_txn to simple_upsert ( #16299 )
2023-09-15 09:16:45 +01:00
Erik Johnston
edec0b93ca
Only use literal strings for process names ( #16315 )
2023-09-15 09:10:24 +01:00
Erik Johnston
329597022e
Some minor performance fixes for task schedular ( #16313 )
2023-09-14 16:20:47 +01:00
Erik Johnston
e9e2904eb2
Speed up deleting to-device messages task ( #16318 )
2023-09-14 14:56:07 +01:00
6543
39dc5de399
docs: Link to the Alpine Linux community package for Synapse ( #16304 )
2023-09-14 14:13:48 +01:00
Erik Johnston
954921736b
Refactor get_user_by_id ( #16316 )
2023-09-14 12:46:30 +01:00
Erik Johnston
032cf84f52
Remove a reference cycle in background process ( #16314 )
2023-09-13 16:17:06 +01:00
Hanadi
7afb5e0410
Fix using dehydrated devices (MSC2697) & refresh tokens ( #16288 )
...
Refresh tokens were not correctly moved to the rehydrated
device (similar to how the access token is currently handled).
This resulted in invalid refresh tokens after rehydration.
2023-09-13 08:33:39 -04:00
Patrick Cloke
d38d0dffc9
Use StrCollection in additional places. ( #16301 )
2023-09-13 07:57:19 -04:00
Erik Johnston
e9addf6a01
Don't schedule an async task on every sync ( #16312 )
2023-09-13 11:59:44 +01:00
Erik Johnston
be3c7b08a3
Fix deleting device inbox when using background worker ( #16311 )
...
Introduced in #16240
The action for the task was only defined on the "master" handler, rather than the base worker one.
2023-09-13 11:54:16 +01:00
Erik Johnston
ab13fb08bf
Improve logging of replication ( #16309 )
2023-09-13 09:51:50 +00:00
Mathieu Velten
12bee2dcc2
Merge branch 'master' into develop
2023-09-12 15:22:26 +02:00
Patrick Cloke
ba48c563c9
Bump mypy from 1.4.1 to 1.5.1. ( #16300 )
2023-09-12 07:16:09 -04:00
Patrick Cloke
16ef6f1e3c
Stop purging tables which are slated for removal. ( #16273 )
2023-09-12 07:12:31 -04:00
Erik Johnston
2b35626b6b
Refactor storing of server keys ( #16261 )
2023-09-12 11:08:04 +01:00
Mathieu Velten
efe778a0b8
1.92.0
2023-09-12 11:59:35 +02:00
Patrick Cloke
9400dc0535
Add the List-Unsubscribe header for notification emails. ( #16274 )
...
Adds both the List-Unsubscribe (RFC2369) and List-Unsubscribe-Post (RFC8058)
headers to push notification emails, which together should:
* Show an "Unsubscribe" link in the MUA UI when viewing Synapse notification emails.
* Enable "one-click" unsubscribe (the user never leaves their MUA, which automatically
makes a POST request to the specified endpoint).
2023-09-11 09:49:48 -04:00
