synapse

mirror of https://mau.dev/maunium/synapse.git synced 2024-12-30 05:53:56 +01:00

Author	SHA1	Message	Date
Richard van der Hoff	7fa1346f93	Merge branch 'social_login' into develop	2021-01-27 17:27:24 +00:00
Patrick Cloke	e54746bdf7	Clean-up the template loading code. (#9200 ) * Enables autoescape by default for HTML files. * Adds a new read_template method for reading a single template. * Some logic clean-up.	2021-01-27 10:59:50 -05:00
Erik Johnston	93b61589b0	Add a note to changelog about redis usage (#9227 )	2021-01-27 14:06:27 +00:00
Richard van der Hoff	a737cc2713	Implement MSC2858 support (#9183 ) Fixes #8928.	2021-01-27 12:41:24 +00:00
Andrew Morgan	a64c29926e	Pass a dict, instead of None, to modules if a None config is specified in the homeserver config (#9229 ) If a Synapse module's config block were empty in YAML, thus being translated to a `Nonetype` in Python, then some modules could fail as that None ends up getting passed to their `parse_config` method. Modules are expected to accept a `dict` instead. This PR ensures that if the user does end up specifying an empty config block (such as what [the default oidc config in the sample config](`5310808d3b/docs/sample_config.yaml (L1816-L1845)`) states) then `None` is not passed to the module. An empty dict is passed instead. This code assumes that no existing modules are relying on receiving a `None` config block, but I'd really hope that they aren't.	2021-01-27 11:49:31 +00:00
Patrick Cloke	1baab20352	Add type hints to various handlers. (#9223 ) With this change all handlers except the e2e_* ones have type hints enabled.	2021-01-26 10:50:21 -05:00
Patrick Cloke	26837d5dbe	Do not require the CAS service URL setting (use public_baseurl instead). (#9199 ) The current configuration is handled for backwards compatibility, but is considered deprecated.	2021-01-26 10:49:25 -05:00
Erik Johnston	dd8da8c5f6	Precompute joined hosts and store in Redis (#9198 )	2021-01-26 13:57:31 +00:00
Patrick Cloke	4937fe3d6b	Try to recover from unknown encodings when previewing media. (#9164 ) Treat unknown encodings (according to lxml) as UTF-8 when generating a preview for HTML documents. This isn't fully accurate, but will hopefully give a reasonable title and summary.	2021-01-26 07:32:17 -05:00
Andrew Morgan	e74bb96733	Update isort to v5.7.0 (#9222 ) This new version no longer has the problem of adding/removing a blank line in `.pyi` files, which black disagrees with. This would cause `isort` to slightly modify `.pyi` files, before `black` would subsequently modify back directly afterwards. Relevant `isort` issue: https://github.com/pycqa/isort/issues/1284	2021-01-26 11:36:12 +00:00
Jason Robinson	e5b659e9e1	Merge pull request #9062 from matrix-org/jaywink/admin-forward-extremities Add forward extremities endpoint to rooms admin API	2021-01-26 12:57:38 +02:00
Erik Johnston	a1ff1e967f	Periodically send pings to detect dead Redis connections (#9218 ) This is done by creating a custom `RedisFactory` subclass that periodically pings all connections in its pool. We also ensure that the `replyTimeout` param is non-null, so that we timeout waiting for the reply to those pings (and thus triggering a reconnect).	2021-01-26 10:54:54 +00:00
Jason Robinson	cee4010f94	Merge branch 'develop' into jaywink/admin-forward-extremities # Conflicts: # synapse/rest/admin/__init__.py	2021-01-26 10:15:32 +02:00
Patrick Cloke	fdf8346944	Merge remote-tracking branch 'origin/develop' into jaywink/admin-forward-extremities	2021-01-25 14:59:48 -05:00
Patrick Cloke	5b857b77f7	Don't error if deleting a non-existent pusher. (#9121 )	2021-01-25 14:52:30 -05:00
Patrick Cloke	4a55d267ee	Add an admin API for shadow-banning users. (#9209 ) This expands the current shadow-banning feature to be usable via the admin API and adds documentation for it. A shadow-banned users receives successful responses to their client-server API requests, but the events are not propagated into rooms. Shadow-banning a user should be used as a tool of last resort and may lead to confusing or broken behaviour for the client.	2021-01-25 14:49:39 -05:00
Patrick Cloke	2547d9d4d7	Fix Python 3.5 old deps build by using a compatible pip version. (#9217 ) Co-authored-by: Dan Callahan <danc@element.io> pip 21.0 stopped supporting Python 3.5.	2021-01-25 19:38:31 +00:00
Richard van der Hoff	65fb3b2e25	Synapse 1.26.0rc2 (2021-01-25) ============================== Bugfixes -------- - Fix receipts and account data not being sent down sync. Introduced in v1.26.0rc1. ([\#9193](https://github.com/matrix-org/synapse/issues/9193), [\#9195](https://github.com/matrix-org/synapse/issues/9195)) - Fix chain cover update to handle events with duplicate auth events. Introduced in v1.26.0rc1. ([\#9210](https://github.com/matrix-org/synapse/issues/9210)) Internal Changes ---------------- - Add an `oidc-` prefix to any `idp_id`s which are given in the `oidc_providers` configuration. ([\#9189](https://github.com/matrix-org/synapse/issues/9189)) - Bump minimum `psycopg2` version to v2.8. ([\#9204](https://github.com/matrix-org/synapse/issues/9204)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEF3tZXk38tRDFVnUIM/xY9qcRMEgFAmAOy7IACgkQM/xY9qcR MEj63w//WlHcArwcpJG4LdiNaKHBUQm00DFmtV27Tl7bixa7LlClUP4qhvE1PP1n +uFWQUUAMUCUC31ySF3X5MEny7svD0J3r2BzbUzP8Vo1d0bHXvpKDgMrh8GbIJsF BEe+uQkRII15Zlkg+Oa7sk7ZI3oyg8y+SQ6yodzc8fL1cRw9bCIUDvFjFcKR3JEw 2dHwzLq4MdYNnPME+mzhNKj30XsQ78VlbSImhGOoKdD/iBQ32E+RGpPNdVx6WDTb 09C8pFA7qvB8d1nrnH5yGLaBzbU6mxc6jaG9xfadnhMJzG7RDVIJya+1JLm0KF2C d8HJWZMIFn6IdHADr7xoQF2km6QN1JTedCSzYzpfbAHwq5bOCiRqBjNnU6xC4giw oYqsV7xRTqRd0psh+/nN8Gz2XiZzkeMbC31kAzjDofPIZFTcte3gR1NhpxWIKoQJ O2gZb2wV5mq8DgJEP4Xjfe/PXiMhFIpb3fbkLdX5tZonPhs95yQHAqZFeZXUaV51 /U3AWQrvxvkM7TpdcdDi+kqzMTCi6imXBuAzXKvY+nmcAd0nvmDg6WXAOSK3DL9O VDZJKm5urzBgbv8R0eKz7cWdW9YXqIIc0mcS/LCu/KYOJnK5YfhJc3grfJx9Dv/S g2T7T+xXUIj2ok9U5M56ACW/bdATNs62ihHx1uiereHQtP/GjtM= =Qc7+ -----END PGP SIGNATURE----- Merge tag 'v1.26.0rc2' into social_login Synapse 1.26.0rc2 (2021-01-25) ============================== Bugfixes -------- - Fix receipts and account data not being sent down sync. Introduced in v1.26.0rc1. ([\#9193](https://github.com/matrix-org/synapse/issues/9193), [\#9195](https://github.com/matrix-org/synapse/issues/9195)) - Fix chain cover update to handle events with duplicate auth events. Introduced in v1.26.0rc1. ([\#9210](https://github.com/matrix-org/synapse/issues/9210)) Internal Changes ---------------- - Add an `oidc-` prefix to any `idp_id`s which are given in the `oidc_providers` configuration. ([\#9189](https://github.com/matrix-org/synapse/issues/9189)) - Bump minimum `psycopg2` version to v2.8. ([\#9204](https://github.com/matrix-org/synapse/issues/9204))	2021-01-25 19:37:58 +00:00
Patrick Cloke	a71be9d62d	Fix Python 3.5 old deps build by using a compatible pip version. (#9217 ) Co-authored-by: Dan Callahan <danc@element.io> pip 21.0 stopped supporting Python 3.5.	2021-01-25 14:22:35 -05:00
Jason Robinson	fe18882bb5	Merge remote-tracking branch 'origin/develop' into jaywink/admin-forward-extremities	2021-01-25 15:55:54 +02:00
Patrick Cloke	e448dbbf5b	Synapse 1.26.0rc2 (2021-01-25) ============================== Bugfixes -------- - Fix receipts and account data not being sent down sync. Introduced in v1.26.0rc1. ([\#9193](https://github.com/matrix-org/synapse/issues/9193), [\#9195](https://github.com/matrix-org/synapse/issues/9195)) - Fix chain cover update to handle events with duplicate auth events. Introduced in v1.26.0rc1. ([\#9210](https://github.com/matrix-org/synapse/issues/9210)) Internal Changes ---------------- - Add an `oidc-` prefix to any `idp_id`s which are given in the `oidc_providers` configuration. ([\#9189](https://github.com/matrix-org/synapse/issues/9189)) - Bump minimum `psycopg2` version to v2.8. ([\#9204](https://github.com/matrix-org/synapse/issues/9204)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEF3tZXk38tRDFVnUIM/xY9qcRMEgFAmAOy7IACgkQM/xY9qcR MEj63w//WlHcArwcpJG4LdiNaKHBUQm00DFmtV27Tl7bixa7LlClUP4qhvE1PP1n +uFWQUUAMUCUC31ySF3X5MEny7svD0J3r2BzbUzP8Vo1d0bHXvpKDgMrh8GbIJsF BEe+uQkRII15Zlkg+Oa7sk7ZI3oyg8y+SQ6yodzc8fL1cRw9bCIUDvFjFcKR3JEw 2dHwzLq4MdYNnPME+mzhNKj30XsQ78VlbSImhGOoKdD/iBQ32E+RGpPNdVx6WDTb 09C8pFA7qvB8d1nrnH5yGLaBzbU6mxc6jaG9xfadnhMJzG7RDVIJya+1JLm0KF2C d8HJWZMIFn6IdHADr7xoQF2km6QN1JTedCSzYzpfbAHwq5bOCiRqBjNnU6xC4giw oYqsV7xRTqRd0psh+/nN8Gz2XiZzkeMbC31kAzjDofPIZFTcte3gR1NhpxWIKoQJ O2gZb2wV5mq8DgJEP4Xjfe/PXiMhFIpb3fbkLdX5tZonPhs95yQHAqZFeZXUaV51 /U3AWQrvxvkM7TpdcdDi+kqzMTCi6imXBuAzXKvY+nmcAd0nvmDg6WXAOSK3DL9O VDZJKm5urzBgbv8R0eKz7cWdW9YXqIIc0mcS/LCu/KYOJnK5YfhJc3grfJx9Dv/S g2T7T+xXUIj2ok9U5M56ACW/bdATNs62ihHx1uiereHQtP/GjtM= =Qc7+ -----END PGP SIGNATURE----- Merge tag 'v1.26.0rc2' into develop Synapse 1.26.0rc2 (2021-01-25) ============================== Bugfixes -------- - Fix receipts and account data not being sent down sync. Introduced in v1.26.0rc1. ([\#9193](https://github.com/matrix-org/synapse/issues/9193), [\#9195](https://github.com/matrix-org/synapse/issues/9195)) - Fix chain cover update to handle events with duplicate auth events. Introduced in v1.26.0rc1. ([\#9210](https://github.com/matrix-org/synapse/issues/9210)) Internal Changes ---------------- - Add an `oidc-` prefix to any `idp_id`s which are given in the `oidc_providers` configuration. ([\#9189](https://github.com/matrix-org/synapse/issues/9189)) - Bump minimum `psycopg2` version to v2.8. ([\#9204](https://github.com/matrix-org/synapse/issues/9204))	2021-01-25 08:51:45 -05:00
Patrick Cloke	a01605c136	1.26.0rc2	2021-01-25 08:25:40 -05:00
Patrick Cloke	6f7417c3db	Handle missing content keys when calculating presentable names. (#9165 ) Treat the content as untrusted and do not assume it is of the proper form.	2021-01-25 07:27:16 -05:00
Jason Robinson	8965b6cfec	Merge branch 'develop' into jaywink/admin-forward-extremities	2021-01-23 21:41:35 +02:00
Erik Johnston	056327457f	Fix chain cover update to handle events with duplicate auth events (#9210 )	2021-01-22 19:44:08 +00:00
Erik Johnston	28f255d5f3	Bump psycopg2 version (#9204 ) As we use `execute_values` with the `fetch` parameter.	2021-01-22 11:14:49 +00:00
Patrick Cloke	a7882f9887	Return a 404 if no valid thumbnail is found. (#9163 ) If no thumbnail of the requested type exists, return a 404 instead of erroring. This doesn't quite match the spec (which does not define what happens if no thumbnail can be found), but is consistent with what Synapse already does.	2021-01-21 14:53:58 -05:00
Andrew Morgan	31c5382d7a	Align the directories linted in CI with the defaults in scripts-dev/lint.sh (#9191 ) The lists of source directories to lint between `tox.ini` and `lint.sh` became out of sync. This PR tightens them up and adds some comments reminding any future readers to keep the list in sync.	2021-01-21 18:26:52 +00:00
Erik Johnston	758ed5f1bc	Speed up chain cover calculation (#9176 )	2021-01-21 17:00:12 +00:00
Erik Johnston	12ec55bfaa	Increase perf of handling concurrent use of StreamIDGenerators. (#9190 ) We have seen a failure mode here where if there are many in flight unfinished IDs then marking an ID as finished takes a lot of CPU (as calling deque.remove iterates over the list)	2021-01-21 16:31:51 +00:00
Erik Johnston	939ef657ce	Merge remote-tracking branch 'origin/release-v1.26.0' into develop	2021-01-21 16:05:13 +00:00
Erik Johnston	ccfafac882	Add schema update to fix existing DBs affected by #9193 (#9195 )	2021-01-21 16:03:25 +00:00
Erik Johnston	b249f002b8	Merge remote-tracking branch 'origin/release-v1.26.0' into develop	2021-01-21 15:09:30 +00:00
Erik Johnston	2506074ef0	Fix receipts or account data not being sent down sync (#9193 ) Introduced in #9104 This wasn't picked up by the tests as this is all fine the first time you run Synapse (after upgrading), but then when you restart the wrong value is pulled from `stream_positions`.	2021-01-21 15:09:09 +00:00
Erik Johnston	7a43482f19	Use execute_batch in more places (#9188 ) * Use execute_batch in more places * Newsfile	2021-01-21 14:44:12 +00:00
Dirk Klimpel	c55e62548c	Add tests for List Users Admin API (#9045 )	2021-01-21 09:18:46 -05:00
Richard van der Hoff	42a8e81370	Add a check for duplicate IdP ids (#9184 )	2021-01-21 13:20:58 +00:00
Richard van der Hoff	b5120f09f1	Merge remote-tracking branch 'origin/release-v1.26.0' into develop	2021-01-21 13:17:07 +00:00
Richard van der Hoff	7447f19702	Prefix idp_id with "oidc-" (#9189 ) ... to avoid clashes with other SSO mechanisms	2021-01-21 12:25:02 +00:00
Erik Johnston	eee6fcf5fa	Use execute_batch instead of executemany in places (#9181 ) `execute_batch` does fewer round trips in postgres than `executemany`, but does not give a correct `txn.rowcount` result after.	2021-01-21 10:22:53 +00:00
Patrick Cloke	1fa15b74e0	Specify that the long description is rST in the package metadata. (#9180 ) This avoids a warning when uploading packages to PyPI via twine.	2021-01-20 16:00:59 -05:00
Patrick Cloke	f81d02d75b	Synapse 1.26.0rc1 (2021-01-20) ============================== This release brings a new schema version for Synapse and rolling back to a previous verious is not trivial. Please review [UPGRADE.rst](UPGRADE.rst) for more details on these changes and for general upgrade guidance. Features -------- - Add support for multiple SSO Identity Providers. ([\#9015](https://github.com/matrix-org/synapse/issues/9015), [\#9017](https://github.com/matrix-org/synapse/issues/9017), [\#9036](https://github.com/matrix-org/synapse/issues/9036), [\#9067](https://github.com/matrix-org/synapse/issues/9067), [\#9081](https://github.com/matrix-org/synapse/issues/9081), [\#9082](https://github.com/matrix-org/synapse/issues/9082), [\#9105](https://github.com/matrix-org/synapse/issues/9105), [\#9107](https://github.com/matrix-org/synapse/issues/9107), [\#9109](https://github.com/matrix-org/synapse/issues/9109), [\#9110](https://github.com/matrix-org/synapse/issues/9110), [\#9127](https://github.com/matrix-org/synapse/issues/9127), [\#9153](https://github.com/matrix-org/synapse/issues/9153), [\#9154](https://github.com/matrix-org/synapse/issues/9154), [\#9177](https://github.com/matrix-org/synapse/issues/9177)) - During user-interactive authentication via single-sign-on, give a better error if the user uses the wrong account on the SSO IdP. ([\#9091](https://github.com/matrix-org/synapse/issues/9091)) - Give the `public_baseurl` a default value, if it is not explicitly set in the configuration file. ([\#9159](https://github.com/matrix-org/synapse/issues/9159)) - Improve performance when calculating ignored users in large rooms. ([\#9024](https://github.com/matrix-org/synapse/issues/9024)) - Implement [MSC2176](https://github.com/matrix-org/matrix-doc/pull/2176) in an experimental room version. ([\#8984](https://github.com/matrix-org/synapse/issues/8984)) - Add an admin API for protecting local media from quarantine. ([\#9086](https://github.com/matrix-org/synapse/issues/9086)) - Remove a user's avatar URL and display name when deactivated with the Admin API. ([\#8932](https://github.com/matrix-org/synapse/issues/8932)) - Update `/_synapse/admin/v1/users/<user_id>/joined_rooms` to work for both local and remote users. ([\#8948](https://github.com/matrix-org/synapse/issues/8948)) - Add experimental support for handling to-device messages on worker processes. ([\#9042](https://github.com/matrix-org/synapse/issues/9042), [\#9043](https://github.com/matrix-org/synapse/issues/9043), [\#9044](https://github.com/matrix-org/synapse/issues/9044), [\#9130](https://github.com/matrix-org/synapse/issues/9130)) - Add experimental support for handling `/keys/claim` and `/room_keys` APIs on worker processes. ([\#9068](https://github.com/matrix-org/synapse/issues/9068)) - Add experimental support for handling `/devices` API on worker processes. ([\#9092](https://github.com/matrix-org/synapse/issues/9092)) - Add experimental support for moving off receipts and account data persistence off master. ([\#9104](https://github.com/matrix-org/synapse/issues/9104), [\#9166](https://github.com/matrix-org/synapse/issues/9166)) Bugfixes -------- - Fix a long-standing issue where an internal server error would occur when requesting a profile over federation that did not include a display name / avatar URL. ([\#9023](https://github.com/matrix-org/synapse/issues/9023)) - Fix a long-standing bug where some caches could grow larger than configured. ([\#9028](https://github.com/matrix-org/synapse/issues/9028)) - Fix error handling during insertion of client IPs into the database. ([\#9051](https://github.com/matrix-org/synapse/issues/9051)) - Fix bug where we didn't correctly record CPU time spent in `on_new_event` block. ([\#9053](https://github.com/matrix-org/synapse/issues/9053)) - Fix a minor bug which could cause confusing error messages from invalid configurations. ([\#9054](https://github.com/matrix-org/synapse/issues/9054)) - Fix incorrect exit code when there is an error at startup. ([\#9059](https://github.com/matrix-org/synapse/issues/9059)) - Fix `JSONDecodeError` spamming the logs when sending transactions to remote servers. ([\#9070](https://github.com/matrix-org/synapse/issues/9070)) - Fix "Failed to send request" errors when a client provides an invalid room alias. ([\#9071](https://github.com/matrix-org/synapse/issues/9071)) - Fix bugs in federation catchup logic that caused outbound federation to be delayed for large servers after start up. Introduced in v1.8.0 and v1.21.0. ([\#9114](https://github.com/matrix-org/synapse/issues/9114), [\#9116](https://github.com/matrix-org/synapse/issues/9116)) - Fix corruption of `pushers` data when a postgres bouncer is used. ([\#9117](https://github.com/matrix-org/synapse/issues/9117)) - Fix minor bugs in handling the `clientRedirectUrl` parameter for SSO login. ([\#9128](https://github.com/matrix-org/synapse/issues/9128)) - Fix "Unhandled error in Deferred: BodyExceededMaxSize" errors when .well-known files that are too large. ([\#9108](https://github.com/matrix-org/synapse/issues/9108)) - Fix "UnboundLocalError: local variable 'length' referenced before assignment" errors when the response body exceeds the expected size. This bug was introduced in v1.25.0. ([\#9145](https://github.com/matrix-org/synapse/issues/9145)) - Fix a long-standing bug "ValueError: invalid literal for int() with base 10" when `/publicRooms` is requested with an invalid `server` parameter. ([\#9161](https://github.com/matrix-org/synapse/issues/9161)) Improved Documentation ---------------------- - Add some extra docs for getting Synapse running on macOS. ([\#8997](https://github.com/matrix-org/synapse/issues/8997)) - Correct a typo in the `systemd-with-workers` documentation. ([\#9035](https://github.com/matrix-org/synapse/issues/9035)) - Correct a typo in `INSTALL.md`. ([\#9040](https://github.com/matrix-org/synapse/issues/9040)) - Add missing `user_mapping_provider` configuration to the Keycloak OIDC example. Contributed by @chris-ruecker. ([\#9057](https://github.com/matrix-org/synapse/issues/9057)) - Quote `pip install` packages when extras are used to avoid shells interpreting bracket characters. ([\#9151](https://github.com/matrix-org/synapse/issues/9151)) Deprecations and Removals ------------------------- - Remove broken and unmaintained `demo/webserver.py` script. ([\#9039](https://github.com/matrix-org/synapse/issues/9039)) Internal Changes ---------------- - Improve efficiency of large state resolutions. ([\#8868](https://github.com/matrix-org/synapse/issues/8868), [\#9029](https://github.com/matrix-org/synapse/issues/9029), [\#9115](https://github.com/matrix-org/synapse/issues/9115), [\#9118](https://github.com/matrix-org/synapse/issues/9118), [\#9124](https://github.com/matrix-org/synapse/issues/9124)) - Various clean-ups to the structured logging and logging context code. ([\#8939](https://github.com/matrix-org/synapse/issues/8939)) - Ensure rejected events get added to some metadata tables. ([\#9016](https://github.com/matrix-org/synapse/issues/9016)) - Ignore date-rotated homeserver logs saved to disk. ([\#9018](https://github.com/matrix-org/synapse/issues/9018)) - Remove an unused column from `access_tokens` table. ([\#9025](https://github.com/matrix-org/synapse/issues/9025)) - Add a `-noextras` factor to `tox.ini`, to support running the tests with no optional dependencies. ([\#9030](https://github.com/matrix-org/synapse/issues/9030)) - Fix running unit tests when optional dependencies are not installed. ([\#9031](https://github.com/matrix-org/synapse/issues/9031)) - Allow bumping schema version when using split out state database. ([\#9033](https://github.com/matrix-org/synapse/issues/9033)) - Configure the linters to run on a consistent set of files. ([\#9038](https://github.com/matrix-org/synapse/issues/9038)) - Various cleanups to device inbox store. ([\#9041](https://github.com/matrix-org/synapse/issues/9041)) - Drop unused database tables. ([\#9055](https://github.com/matrix-org/synapse/issues/9055)) - Remove unused `SynapseService` class. ([\#9058](https://github.com/matrix-org/synapse/issues/9058)) - Remove unnecessary declarations in the tests for the admin API. ([\#9063](https://github.com/matrix-org/synapse/issues/9063)) - Remove `SynapseRequest.get_user_agent`. ([\#9069](https://github.com/matrix-org/synapse/issues/9069)) - Remove redundant `Homeserver.get_ip_from_request` method. ([\#9080](https://github.com/matrix-org/synapse/issues/9080)) - Add type hints to media repository. ([\#9093](https://github.com/matrix-org/synapse/issues/9093)) - Fix the wrong arguments being passed to `BlacklistingAgentWrapper` from `MatrixFederationAgent`. Contributed by Timothy Leung. ([\#9098](https://github.com/matrix-org/synapse/issues/9098)) - Reduce the scope of caught exceptions in `BlacklistingAgentWrapper`. ([\#9106](https://github.com/matrix-org/synapse/issues/9106)) - Improve `UsernamePickerTestCase`. ([\#9112](https://github.com/matrix-org/synapse/issues/9112)) - Remove dependency on `distutils`. ([\#9125](https://github.com/matrix-org/synapse/issues/9125)) - Enforce that replication HTTP clients are called with keyword arguments only. ([\#9144](https://github.com/matrix-org/synapse/issues/9144)) - Fix the Python 3.5 / old dependencies build in CI. ([\#9146](https://github.com/matrix-org/synapse/issues/9146)) - Replace the old `perspectives` option in the Synapse docker config file template with `trusted_key_servers`. ([\#9157](https://github.com/matrix-org/synapse/issues/9157)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEF3tZXk38tRDFVnUIM/xY9qcRMEgFAmAIVFkACgkQM/xY9qcR MEhLfQ//Z4xnP5Icx732k2xpdR+JaXX6heNVFm/UuLNd6wq+uXjO/Dgc9IKQ5LXD kfG+/OnNGDr/eUk4mQ5s/ccBvaTrOid2IIemJd4lUBy/Q5LvPvfKIp08QFr72WJT 7Y4Ma54nNSSMUAdESgj/aFAHjATbfHhxPOZ5OdQHGLAuJ/OUwR2ksasVNCuINbgh 8vrxrzjeYn1Zl3UTBrsdCcat7AFqYjxK/Y0i6JxfSgRwDZjUbW4M2C4OGWZJPUrU 2YTPHangxd+22+HObE2KDEzaHDdCR/Kj4dhCiJBynZ5iucuHSS+mgf39RtbjqWML 01cmXXUV+FH7rnCilmF9rYdmHZ6L9BJxtrQDQU4dB106BX9G7hKR6rYHc9Z6tjOh 3tg0cKWYMXOsTNnvRqiFNh2q0yBKS228HRAwyGosW/6NiYj43ArtYP6knX7dQyBX 0mYNkfry2dyX6Kj5el0i9MOTHYQxfc8apsBm2M3OTNYukgQKA0NhbAquibaAxEEW 2qIqbSp4CUlGPvM7+u+ZGTu0hEbVKKNjqMfXhuY8A4/BWiV2mSqKcEirR5cE/LqY mq5Ac7vbO4Uh+1xiRw/G9ITi1dqAjYIzhBawlhdUPOh+aINWTUikYYzjUSmm4PbN H9BTPLA9iAdVRfuWJ9um2G0DdS8Qpx/aIRh3MScXVly6cGCC6Do= =kgqn -----END PGP SIGNATURE----- Merge tag 'v1.26.0rc1' into develop Synapse 1.26.0rc1 (2021-01-20) ============================== This release brings a new schema version for Synapse and rolling back to a previous verious is not trivial. Please review [UPGRADE.rst](UPGRADE.rst) for more details on these changes and for general upgrade guidance. Features -------- - Add support for multiple SSO Identity Providers. ([\#9015](https://github.com/matrix-org/synapse/issues/9015), [\#9017](https://github.com/matrix-org/synapse/issues/9017), [\#9036](https://github.com/matrix-org/synapse/issues/9036), [\#9067](https://github.com/matrix-org/synapse/issues/9067), [\#9081](https://github.com/matrix-org/synapse/issues/9081), [\#9082](https://github.com/matrix-org/synapse/issues/9082), [\#9105](https://github.com/matrix-org/synapse/issues/9105), [\#9107](https://github.com/matrix-org/synapse/issues/9107), [\#9109](https://github.com/matrix-org/synapse/issues/9109), [\#9110](https://github.com/matrix-org/synapse/issues/9110), [\#9127](https://github.com/matrix-org/synapse/issues/9127), [\#9153](https://github.com/matrix-org/synapse/issues/9153), [\#9154](https://github.com/matrix-org/synapse/issues/9154), [\#9177](https://github.com/matrix-org/synapse/issues/9177)) - During user-interactive authentication via single-sign-on, give a better error if the user uses the wrong account on the SSO IdP. ([\#9091](https://github.com/matrix-org/synapse/issues/9091)) - Give the `public_baseurl` a default value, if it is not explicitly set in the configuration file. ([\#9159](https://github.com/matrix-org/synapse/issues/9159)) - Improve performance when calculating ignored users in large rooms. ([\#9024](https://github.com/matrix-org/synapse/issues/9024)) - Implement [MSC2176](https://github.com/matrix-org/matrix-doc/pull/2176) in an experimental room version. ([\#8984](https://github.com/matrix-org/synapse/issues/8984)) - Add an admin API for protecting local media from quarantine. ([\#9086](https://github.com/matrix-org/synapse/issues/9086)) - Remove a user's avatar URL and display name when deactivated with the Admin API. ([\#8932](https://github.com/matrix-org/synapse/issues/8932)) - Update `/_synapse/admin/v1/users/<user_id>/joined_rooms` to work for both local and remote users. ([\#8948](https://github.com/matrix-org/synapse/issues/8948)) - Add experimental support for handling to-device messages on worker processes. ([\#9042](https://github.com/matrix-org/synapse/issues/9042), [\#9043](https://github.com/matrix-org/synapse/issues/9043), [\#9044](https://github.com/matrix-org/synapse/issues/9044), [\#9130](https://github.com/matrix-org/synapse/issues/9130)) - Add experimental support for handling `/keys/claim` and `/room_keys` APIs on worker processes. ([\#9068](https://github.com/matrix-org/synapse/issues/9068)) - Add experimental support for handling `/devices` API on worker processes. ([\#9092](https://github.com/matrix-org/synapse/issues/9092)) - Add experimental support for moving off receipts and account data persistence off master. ([\#9104](https://github.com/matrix-org/synapse/issues/9104), [\#9166](https://github.com/matrix-org/synapse/issues/9166)) Bugfixes -------- - Fix a long-standing issue where an internal server error would occur when requesting a profile over federation that did not include a display name / avatar URL. ([\#9023](https://github.com/matrix-org/synapse/issues/9023)) - Fix a long-standing bug where some caches could grow larger than configured. ([\#9028](https://github.com/matrix-org/synapse/issues/9028)) - Fix error handling during insertion of client IPs into the database. ([\#9051](https://github.com/matrix-org/synapse/issues/9051)) - Fix bug where we didn't correctly record CPU time spent in `on_new_event` block. ([\#9053](https://github.com/matrix-org/synapse/issues/9053)) - Fix a minor bug which could cause confusing error messages from invalid configurations. ([\#9054](https://github.com/matrix-org/synapse/issues/9054)) - Fix incorrect exit code when there is an error at startup. ([\#9059](https://github.com/matrix-org/synapse/issues/9059)) - Fix `JSONDecodeError` spamming the logs when sending transactions to remote servers. ([\#9070](https://github.com/matrix-org/synapse/issues/9070)) - Fix "Failed to send request" errors when a client provides an invalid room alias. ([\#9071](https://github.com/matrix-org/synapse/issues/9071)) - Fix bugs in federation catchup logic that caused outbound federation to be delayed for large servers after start up. Introduced in v1.8.0 and v1.21.0. ([\#9114](https://github.com/matrix-org/synapse/issues/9114), [\#9116](https://github.com/matrix-org/synapse/issues/9116)) - Fix corruption of `pushers` data when a postgres bouncer is used. ([\#9117](https://github.com/matrix-org/synapse/issues/9117)) - Fix minor bugs in handling the `clientRedirectUrl` parameter for SSO login. ([\#9128](https://github.com/matrix-org/synapse/issues/9128)) - Fix "Unhandled error in Deferred: BodyExceededMaxSize" errors when .well-known files that are too large. ([\#9108](https://github.com/matrix-org/synapse/issues/9108)) - Fix "UnboundLocalError: local variable 'length' referenced before assignment" errors when the response body exceeds the expected size. This bug was introduced in v1.25.0. ([\#9145](https://github.com/matrix-org/synapse/issues/9145)) - Fix a long-standing bug "ValueError: invalid literal for int() with base 10" when `/publicRooms` is requested with an invalid `server` parameter. ([\#9161](https://github.com/matrix-org/synapse/issues/9161)) Improved Documentation ---------------------- - Add some extra docs for getting Synapse running on macOS. ([\#8997](https://github.com/matrix-org/synapse/issues/8997)) - Correct a typo in the `systemd-with-workers` documentation. ([\#9035](https://github.com/matrix-org/synapse/issues/9035)) - Correct a typo in `INSTALL.md`. ([\#9040](https://github.com/matrix-org/synapse/issues/9040)) - Add missing `user_mapping_provider` configuration to the Keycloak OIDC example. Contributed by @chris-ruecker. ([\#9057](https://github.com/matrix-org/synapse/issues/9057)) - Quote `pip install` packages when extras are used to avoid shells interpreting bracket characters. ([\#9151](https://github.com/matrix-org/synapse/issues/9151)) Deprecations and Removals ------------------------- - Remove broken and unmaintained `demo/webserver.py` script. ([\#9039](https://github.com/matrix-org/synapse/issues/9039)) Internal Changes ---------------- - Improve efficiency of large state resolutions. ([\#8868](https://github.com/matrix-org/synapse/issues/8868), [\#9029](https://github.com/matrix-org/synapse/issues/9029), [\#9115](https://github.com/matrix-org/synapse/issues/9115), [\#9118](https://github.com/matrix-org/synapse/issues/9118), [\#9124](https://github.com/matrix-org/synapse/issues/9124)) - Various clean-ups to the structured logging and logging context code. ([\#8939](https://github.com/matrix-org/synapse/issues/8939)) - Ensure rejected events get added to some metadata tables. ([\#9016](https://github.com/matrix-org/synapse/issues/9016)) - Ignore date-rotated homeserver logs saved to disk. ([\#9018](https://github.com/matrix-org/synapse/issues/9018)) - Remove an unused column from `access_tokens` table. ([\#9025](https://github.com/matrix-org/synapse/issues/9025)) - Add a `-noextras` factor to `tox.ini`, to support running the tests with no optional dependencies. ([\#9030](https://github.com/matrix-org/synapse/issues/9030)) - Fix running unit tests when optional dependencies are not installed. ([\#9031](https://github.com/matrix-org/synapse/issues/9031)) - Allow bumping schema version when using split out state database. ([\#9033](https://github.com/matrix-org/synapse/issues/9033)) - Configure the linters to run on a consistent set of files. ([\#9038](https://github.com/matrix-org/synapse/issues/9038)) - Various cleanups to device inbox store. ([\#9041](https://github.com/matrix-org/synapse/issues/9041)) - Drop unused database tables. ([\#9055](https://github.com/matrix-org/synapse/issues/9055)) - Remove unused `SynapseService` class. ([\#9058](https://github.com/matrix-org/synapse/issues/9058)) - Remove unnecessary declarations in the tests for the admin API. ([\#9063](https://github.com/matrix-org/synapse/issues/9063)) - Remove `SynapseRequest.get_user_agent`. ([\#9069](https://github.com/matrix-org/synapse/issues/9069)) - Remove redundant `Homeserver.get_ip_from_request` method. ([\#9080](https://github.com/matrix-org/synapse/issues/9080)) - Add type hints to media repository. ([\#9093](https://github.com/matrix-org/synapse/issues/9093)) - Fix the wrong arguments being passed to `BlacklistingAgentWrapper` from `MatrixFederationAgent`. Contributed by Timothy Leung. ([\#9098](https://github.com/matrix-org/synapse/issues/9098)) - Reduce the scope of caught exceptions in `BlacklistingAgentWrapper`. ([\#9106](https://github.com/matrix-org/synapse/issues/9106)) - Improve `UsernamePickerTestCase`. ([\#9112](https://github.com/matrix-org/synapse/issues/9112)) - Remove dependency on `distutils`. ([\#9125](https://github.com/matrix-org/synapse/issues/9125)) - Enforce that replication HTTP clients are called with keyword arguments only. ([\#9144](https://github.com/matrix-org/synapse/issues/9144)) - Fix the Python 3.5 / old dependencies build in CI. ([\#9146](https://github.com/matrix-org/synapse/issues/9146)) - Replace the old `perspectives` option in the Synapse docker config file template with `trusted_key_servers`. ([\#9157](https://github.com/matrix-org/synapse/issues/9157))	2021-01-20 11:27:39 -05:00
Patrick Cloke	7e072d38b1	Re-run towncrier.	2021-01-20 08:56:25 -05:00
Richard van der Hoff	e51b2f3f91	Tighten the restrictions on `idp_id` (#9177 )	2021-01-20 08:55:14 -05:00
Richard van der Hoff	0cd2938bc8	Support icons for Identity Providers (#9154 )	2021-01-20 08:15:14 -05:00
Patrick Cloke	620ecf13b0	Various improvements to the federation client. (#9129 ) * Type hints for `FederationClient`. * Using `async` functions instead of returning `Awaitable` instances.	2021-01-20 07:59:18 -05:00
rht	a5b9c87ac6	docs: Add link to Matrix VoIP tester for turn-howto (#9135 ) Signed-off-by: rht <rhtbot@protonmail.com>	2021-01-20 12:41:57 +00:00
Richard van der Hoff	6c0dfd2e8e	Merge remote-tracking branch 'origin/develop' into release-v1.26.0	2021-01-20 12:33:05 +00:00
Richard van der Hoff	fa50e4bf4d	Give `public_baseurl` a default value (#9159 )	2021-01-20 12:30:41 +00:00
Patrick Cloke	72822e60be	1.26.0rc1	2021-01-20 07:14:25 -05:00
Patrick Cloke	fa842a9866	Use the account handler in additional places. (#9166 )	2021-01-20 10:44:52 +00:00
Patrick Cloke	47d48a5853	Validate the server name for the /publicRooms endpoint. (#9161 ) If a remote server name is provided, ensure it is something reasonable before making remote connections to it.	2021-01-19 14:21:59 -05:00
Andrew Morgan	94549771f7	Replace 'perspectives' config block with 'trusted_key_servers' in docker homeserver.yaml template (#9157 )	2021-01-19 16:19:32 +00:00
Richard van der Hoff	73b03722f4	Fix error messages from OIDC config parsing (#9153 ) Make sure we report the correct config path for errors in the OIDC configs.	2021-01-19 14:56:54 +00:00
Patrick Cloke	de45bf5b5b	Quote pip install with brackets to avoid shell interpretation. (#9151 )	2021-01-18 11:12:20 -05:00
Erik Johnston	6633a4015a	Allow moving account data and receipts streams off master (#9104 )	2021-01-18 15:47:59 +00:00
Erik Johnston	f08ef64926	Enforce all replication HTTP clients calls use kwargs (#9144 )	2021-01-18 15:24:04 +00:00
Patrick Cloke	2b467d0b61	Properly raise an exception when the body exceeds the max size. (#9145 ) ...instead of just creating the exception object and doing nothing with it.	2021-01-18 10:21:42 -05:00
Richard van der Hoff	02070c69fa	Fix bugs in handling clientRedirectUrl, and improve OIDC tests (#9127 , #9128 ) * Factor out a common TestHtmlParser Looks like I'm doing this in a few different places. * Improve OIDC login test Complete the OIDC login flow, rather than giving up halfway through. * Ensure that OIDC login works with multiple OIDC providers * Fix bugs in handling clientRedirectUrl - don't drop duplicate query-params, or params with no value - allow utf-8 in query-params	2021-01-18 14:52:49 +00:00
Patrick Cloke	a8703819eb	Fix the Python 3.5 old-deps build. (#9146 ) setuptools 51.0.0 dropped support for Python 3.5.	2021-01-18 09:35:42 -05:00
Patrick Cloke	de1f8de319	Ensure the user ID is serialized in the payload instead of used as an instance name. (#9130 )	2021-01-18 11:08:26 +00:00
Erik Johnston	350d9923cd	Make chain cover index bg update go faster (#9124 ) We do this by allowing a single iteration to process multiple rooms at a time, as there are often a lot of really tiny rooms, which can massively slow things down.	2021-01-15 17:18:37 +00:00
Richard van der Hoff	2de7e263ed	Ensure we store pusher data as text (#9117 ) I don't think there's any need to use canonicaljson here. Fixes: #4475.	2021-01-15 16:57:23 +00:00
Richard van der Hoff	9de6b94117	Land support for multiple OIDC providers (#9110 ) This is the final step for supporting multiple OIDC providers concurrently. First of all, we reorganise the config so that you can specify a list of OIDC providers, instead of a single one. Before: oidc_config: enabled: true issuer: "https://oidc_provider" # etc After: oidc_providers: - idp_id: prov1 issuer: "https://oidc_provider" - idp_id: prov2 issuer: "https://another_oidc_provider" The old format is still grandfathered in. With that done, it's then simply a matter of having OidcHandler instantiate a new OidcProvider for each configured provider.	2021-01-15 16:55:29 +00:00
Patrick Cloke	3e4cdfe5d9	Add an admin API endpoint to protect media. (#9086 ) Protecting media stops it from being quarantined when e.g. all media in a room is quarantined. This is useful for sticker packs and other media that is uploaded by server administrators, but used by many people.	2021-01-15 11:18:09 -05:00
Patrick Cloke	74dd906041	Avoid raising the body exceeded error multiple times. (#9108 ) Previously this code generated unreferenced `Deferred` instances which caused "Unhandled Deferreds" errors to appear in error situations.	2021-01-15 11:00:13 -05:00
Richard van der Hoff	9ffac2bef1	Remote dependency on distutils (#9125 ) `distutils` is pretty much deprecated these days, and replaced with `setuptools`. It's also annoying because it's you can't `pip install` it, and it's hard to figure out which debian package we should depend on to make sure it's there. Since we only use it for a tiny function anyway, let's just vendor said function into our codebase.	2021-01-15 15:59:20 +00:00
Patrick Cloke	d34c6e1279	Add type hints to media rest resources. (#9093 )	2021-01-15 10:57:37 -05:00
Richard van der Hoff	0dd2649c12	Improve UsernamePickerTestCase (#9112 ) * make the OIDC bits of the test work at a higher level - via the REST api instead of poking the OIDCHandler directly. * Move it to test_login.py, where I think it fits better.	2021-01-15 13:45:13 +00:00
Richard van der Hoff	4575ad0b1e	Store an IdP ID in the OIDC session (#9109 ) Again in preparation for handling more than one OIDC provider, add a new caveat to the macaroon used as an OIDC session cookie, which remembers which OIDC provider we are talking to. In future, when we get a callback, we'll need it to make sure we talk to the right IdP. As part of this, I'm adding an idp_id and idp_name field to the OIDC configuration object. They aren't yet documented, and we'll just use the old values by default.	2021-01-15 13:22:12 +00:00
Eric Eastwood	20af310889	Add some extra notes for getting Synapse running on macOS. (#8997 )	2021-01-15 06:58:31 -05:00
Richard van der Hoff	14950a45d6	Merge pull request #9091 from matrix-org/rav/error_on_bad_sso Give the user a better error when they present bad SSO creds	2021-01-15 00:27:13 +00:00
Erik Johnston	1a08e0cdab	Fix event chain bg update. (#9118 ) We passed in a graph to `sorted_topologically` which didn't have an entry for each node (as we dropped nodes with no edges).	2021-01-14 18:57:32 +00:00
Erik Johnston	d2479c6870	Fix perf of get_cross_signing_keys (#9116 )	2021-01-14 17:57:09 +00:00
Erik Johnston	659c415ed4	Fix chain cover background update to work with split out event persisters (#9115 )	2021-01-14 17:19:35 +00:00
Erik Johnston	631dd06f2c	Fix get destinations to catch up query. (#9114 ) t was doing a sequential scan on `destination_rooms`, which took minutes.	2021-01-14 16:47:21 +00:00
Erik Johnston	7036e24e98	Add background update for add chain cover index (#9029 )	2021-01-14 15:18:27 +00:00
Richard van der Hoff	21a296cd5a	Split OidcProvider out of OidcHandler (#9107 ) The idea here is that we will have an instance of OidcProvider for each configured IdP, with OidcHandler just doing the marshalling of them. For now it's still hardcoded with a single provider.	2021-01-14 13:29:17 +00:00
Tim Leung	12702be951	Fix wrong arguments being passed to BlacklistingAgentWrapper (#9098 ) A reactor was being passed instead of a whitelist for the BlacklistingAgentWrapper used by the WellyKnownResolver. This coulld cause exceptions when attempting to connect to IP addresses that are blacklisted, but in reality this did not have any observable affect since this code is not used for IP literals.	2021-01-14 06:59:26 -05:00
Richard van der Hoff	5310808d3b	Give the user a better error when they present bad SSO creds If a user tries to do UI Auth via SSO, but uses the wrong account on the SSO IdP, try to give them a better error. Previously, the UIA would claim to be successful, but then the operation in question would simply fail with "auth fail". Instead, serve up an error page which explains the failure.	2021-01-13 20:22:41 +00:00
Richard van der Hoff	233c8b9fce	Add a test for UI-Auth-via-SSO (#9082 ) * Add complete test for UI-Auth-via-SSO. * review comments	2021-01-13 20:21:55 +00:00
Richard van der Hoff	d02e4b2825	Merge pull request #9105 from matrix-org/rav/multi_idp/oidc_provider_config Enhancements to OIDC configuration handling	2021-01-13 19:51:46 +00:00
Patrick Cloke	aee8e6a95d	Reduce scope of exception handler. (#9106 ) Removes a bare `except Exception` clause and replaces it with catching a specific exception around the portion that might throw.	2021-01-13 13:27:49 -05:00
Richard van der Hoff	ef410232f3	changelog	2021-01-13 17:47:27 +00:00
Patrick Cloke	d1eb1b96e8	Register the /devices endpoint on workers. (#9092 )	2021-01-13 12:35:40 -05:00
Patrick Cloke	98a64b7f7f	Add basic domain validation for `DomainSpecificString.is_valid`. (#9071 ) This checks that the domain given to `DomainSpecificString.is_valid` (e.g. `UserID`, `RoomAlias`, etc.) is of a valid form. Previously some validation was done on the localpart (e.g. the sigil), but not the domain portion.	2021-01-13 07:05:16 -05:00
Richard van der Hoff	bc4bf7b384	Preparatory refactors of OidcHandler (#9067 ) Some light refactoring of OidcHandler, in preparation for bigger things: * remove inheritance from deprecated BaseHandler * add an object to hold the things that go into a session cookie * factor out a separate class for manipulating said cookies	2021-01-13 10:26:12 +00:00
Dirk Klimpel	7a2e9b549d	Remove user's avatar URL and displayname when deactivated. (#8932 ) This only applies if the user's data is to be erased.	2021-01-12 16:30:15 -05:00
Richard van der Hoff	789d9ebad3	UI Auth via SSO: redirect the user to an appropriate SSO. (#9081 ) If we have integrations with multiple identity providers, when the user does a UI Auth, we need to redirect them to the right one. There are a few steps to this. First of all we actually need to store the userid of the user we are trying to validate in the UIA session, since the /auth/sso/fallback/web request is unauthenticated. Then, once we get the /auth/sso/fallback/web request, we can fish the user id out of the session, and use it to look up the external id mappings, and hence pick an SSO provider for them.	2021-01-12 17:38:03 +00:00
Patrick Cloke	723b19748a	Handle bad JSON data being returned from the federation API. (#9070 )	2021-01-12 11:07:01 -05:00
Richard van der Hoff	0f8945e166	Kill off `HomeServer.get_ip_from_request()` (#9080 ) Homeserver.get_ip_from_request() used to be a bit more complicated, but now it is totally redundant. Let's get rid of it.	2021-01-12 12:48:12 +00:00
Richard van der Hoff	2ec8ca5e60	Remove SynapseRequest.get_user_agent (#9069 ) SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests", which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the LoggingContext and write the right entries to the request log). Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a SynapseRequest when there is nothing synapse-specific about the Request at all, and any old twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult. In short: move get_user_agent out to a utility function.	2021-01-12 12:34:16 +00:00
David Teller	b161528fcc	Also support remote users on the joined_rooms admin API. (#8948 ) For remote users, only the rooms which the server knows about are returned. Local users have all of their joined rooms returned.	2021-01-11 14:32:17 -05:00
Erik Johnston	c9195744a4	Move more encryption endpoints off master (#9068 )	2021-01-11 18:01:27 +00:00
Dirk Klimpel	42d3a28d8b	Removes unnecessary declarations in the tests for the admin API. (#9063 )	2021-01-11 11:15:54 -05:00
Erik Johnston	1315a2e8be	Use a chain cover index to efficiently calculate auth chain difference (#8868 )	2021-01-11 16:09:22 +00:00
Richard van der Hoff	671138f658	Clean up exception handling in the startup code (#9059 ) Factor out the exception handling in the startup code to a utility function, and fix the some logging and exit code stuff.	2021-01-11 15:55:05 +00:00
Erik Johnston	4e04435bda	Remove old tables after schema version bump (#9055 ) These tables are unused, and can be dropped now the schema version has been bumped.	2021-01-11 13:58:19 +00:00
Erik Johnston	63f4990298	Ensure rejected events get added to some metadata tables (#9016 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2021-01-11 13:57:33 +00:00
0xflotus	2fb1c2b6e6	Fix a typo in the install docs. (#9040 )	2021-01-11 07:42:18 -05:00
Richard van der Hoff	7db2622d30	Remove unused SynapseService (#9058 )	2021-01-11 10:24:22 +00:00
Jerin J Titus	c21d8f1c1d	Drop last_used column from access_tokens (#9025 ) * Dropped last_used column from access_tokens Signed-off-by: Jerin J Titus <72017981+jerinjtitus@users.noreply.github.com>	2021-01-11 10:23:49 +00:00
Jason Robinson	e2c16edc78	Add changelog and admin API docs Signed-off-by: Jason Robinson <jasonr@matrix.org>	2021-01-09 22:58:29 +02:00
Christopher Rücker	bce0c91d9a	Keycloak mapping_provider example (#9037 ) (#9057 ) This PR adds the missing user_mapping_provider section in oidc.md Signed-off-by: Christopher Rücker chris-ruecker@protonmail.com	2021-01-08 18:29:30 +00:00
Erik Johnston	a03d71dc9d	Fix "Starting metrics collection from sentinel context" errors (#9053 )	2021-01-08 14:33:53 +00:00
Richard van der Hoff	12f79da587	Merge pull request #9036 from matrix-org/rav/multi_idp/tests Add tests for the IdP picker	2021-01-08 14:24:41 +00:00
Richard van der Hoff	d32870ffa5	Fix validate_config on nested objects (#9054 )	2021-01-08 14:23:04 +00:00
Erik Johnston	fa5f5cbc74	Fix error handling during insertion of client IPs (#9051 ) You can't continue using a transaction once an exception has been raised, so catching and dropping the error here is pointless and just causes more errors.	2021-01-08 14:15:20 +00:00
Richard van der Hoff	195adf4025	Remove broken and unmaintained 'webserver.py' script (#9039 ) I'm not even sure what this was supposed to do, but the fact it has python2isms and nobody has noticed suggests it's not terribly important. It doesn't seem to have been used since `ff23e5ba37`.	2021-01-08 14:09:06 +00:00
Richard van der Hoff	23a59d24ae	Run the linters on a consistent list of files (#9038 ) We were running some linters on some files and some on others. Extract a common setting and use it everywhere.	2021-01-08 14:08:44 +00:00
Erik Johnston	b530eaa262	Allow running sendToDevice on workers (#9044 )	2021-01-07 20:19:26 +00:00
Erik Johnston	5e99a94502	Support routing edu's to multiple instances (#9042 ) This is in preparation for moving `SendToDeviceServlet` off master	2021-01-07 18:07:28 +00:00
Erik Johnston	e34df813ce	Ensure that remote users' device list resyncing always happens on master (#9043 ) Currently `DeviceMessageHandler` only ever exists on master, but that is about to change.	2021-01-07 18:06:52 +00:00
Erik Johnston	63593134a1	Some cleanups to device inbox store. (#9041 )	2021-01-07 17:20:44 +00:00
Emelie	9066c2fd7f	Fix typo in docs/systemd-with-workers/README.md (#9035 ) Signed-off-by: Emelie em@nao.sh	2021-01-07 15:31:01 +00:00
Richard van der Hoff	a458e2866e	changelog	2021-01-07 14:56:42 +00:00
Patrick Cloke	23d701864f	Improve the performance of calculating ignored users in large rooms (#9024 ) This allows for efficiently finding which users ignore a particular user. Co-authored-by: Erik Johnston <erik@matrix.org>	2021-01-07 13:03:38 +00:00
Richard van der Hoff	1d5c021a45	tox: Add a -noextras factor (#9030 ) ... for running the tests with no optional deps.	2021-01-07 11:41:54 +00:00
Richard van der Hoff	8d3d264052	Skip unit tests which require optional dependencies (#9031 ) If we are lacking an optional dependency, skip the tests that rely on it.	2021-01-07 11:41:28 +00:00
Erik Johnston	eee3c3c52f	Handle updating schema version without any deltas. (#9033 ) This can happen when using a split out state database and we've upgraded the schema version without there being any changes in the state schema.	2021-01-07 11:33:36 +00:00
Patrick Cloke	1b4d5d6acf	Empty iterables should count towards cache usage. (#9028 )	2021-01-06 12:33:20 -05:00
Patrick Cloke	0312266ee3	Synapse 1.25.0rc1 (2021-01-06) ============================== Removal warning --------------- The old [Purge Room API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api/purge_room.md) and [Shutdown Room API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api/shutdown_room.md) are deprecated and will be removed in a future release. They will be replaced by the [Delete Room API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api/rooms.md#delete-room-api). `POST /_synapse/admin/v1/rooms/<room_id>/delete` replaces `POST /_synapse/admin/v1/purge_room` and `POST /_synapse/admin/v1/shutdown_room/<room_id>`. Features -------- - Add an admin API that lets server admins get power in rooms in which local users have power. ([\#8756](https://github.com/matrix-org/synapse/issues/8756)) - Add optional HTTP authentication to replication endpoints. ([\#8853](https://github.com/matrix-org/synapse/issues/8853)) - Improve the error messages printed as a result of configuration problems for extension modules. ([\#8874](https://github.com/matrix-org/synapse/issues/8874)) - Add the number of local devices to Room Details Admin API. Contributed by @dklimpel. ([\#8886](https://github.com/matrix-org/synapse/issues/8886)) - Add `X-Robots-Tag` header to stop web crawlers from indexing media. Contributed by Aaron Raimist. ([\#8887](https://github.com/matrix-org/synapse/issues/8887)) - Spam-checkers may now define their methods as `async`. ([\#8890](https://github.com/matrix-org/synapse/issues/8890)) - Add support for allowing users to pick their own user ID during a single-sign-on login. ([\#8897](https://github.com/matrix-org/synapse/issues/8897), [\#8900](https://github.com/matrix-org/synapse/issues/8900), [\#8911](https://github.com/matrix-org/synapse/issues/8911), [\#8938](https://github.com/matrix-org/synapse/issues/8938), [\#8941](https://github.com/matrix-org/synapse/issues/8941), [\#8942](https://github.com/matrix-org/synapse/issues/8942), [\#8951](https://github.com/matrix-org/synapse/issues/8951)) - Add an `email.invite_client_location` configuration option to send a web client location to the invite endpoint on the identity server which allows customisation of the email template. ([\#8930](https://github.com/matrix-org/synapse/issues/8930)) - The search term in the list room and list user Admin APIs is now treated as case-insensitive. ([\#8931](https://github.com/matrix-org/synapse/issues/8931)) - Apply an IP range blacklist to push and key revocation requests. ([\#8821](https://github.com/matrix-org/synapse/issues/8821), [\#8870](https://github.com/matrix-org/synapse/issues/8870), [\#8954](https://github.com/matrix-org/synapse/issues/8954)) - Add an option to allow re-use of user-interactive authentication sessions for a period of time. ([\#8970](https://github.com/matrix-org/synapse/issues/8970)) - Allow running the redact endpoint on workers. ([\#8994](https://github.com/matrix-org/synapse/issues/8994)) Bugfixes -------- - Fix bug where we might not correctly calculate the current state for rooms with multiple extremities. ([\#8827](https://github.com/matrix-org/synapse/issues/8827)) - Fix a long-standing bug in the register admin endpoint (`/_synapse/admin/v1/register`) when the `mac` field was not provided. The endpoint now properly returns a 400 error. Contributed by @edwargix. ([\#8837](https://github.com/matrix-org/synapse/issues/8837)) - Fix a long-standing bug on Synapse instances supporting Single-Sign-On, where users would be prompted to enter their password to confirm certain actions, even though they have not set a password. ([\#8858](https://github.com/matrix-org/synapse/issues/8858)) - Fix a longstanding bug where a 500 error would be returned if the `Content-Length` header was not provided to the upload media resource. ([\#8862](https://github.com/matrix-org/synapse/issues/8862)) - Add additional validation to pusher URLs to be compliant with the specification. ([\#8865](https://github.com/matrix-org/synapse/issues/8865)) - Fix the error code that is returned when a user tries to register on a homeserver on which new-user registration has been disabled. ([\#8867](https://github.com/matrix-org/synapse/issues/8867)) - Fix a bug where `PUT /_synapse/admin/v2/users/<user_id>` failed to create a new user when `avatar_url` is specified. Bug introduced in Synapse v1.9.0. ([\#8872](https://github.com/matrix-org/synapse/issues/8872)) - Fix a 500 error when attempting to preview an empty HTML file. ([\#8883](https://github.com/matrix-org/synapse/issues/8883)) - Fix occasional deadlock when handling SIGHUP. ([\#8918](https://github.com/matrix-org/synapse/issues/8918)) - Fix login API to not ratelimit application services that have ratelimiting disabled. ([\#8920](https://github.com/matrix-org/synapse/issues/8920)) - Fix bug where we ratelimited auto joining of rooms on registration (using `auto_join_rooms` config). ([\#8921](https://github.com/matrix-org/synapse/issues/8921)) - Fix a bug where deactivated users appeared in the user directory when their profile information was updated. ([\#8933](https://github.com/matrix-org/synapse/issues/8933), [\#8964](https://github.com/matrix-org/synapse/issues/8964)) - Fix bug introduced in Synapse v1.24.0 which would cause an exception on startup if both `enabled` and `localdb_enabled` were set to `False` in the `password_config` setting of the configuration file. ([\#8937](https://github.com/matrix-org/synapse/issues/8937)) - Fix a bug where 500 errors would be returned if the `m.room_history_visibility` event had invalid content. ([\#8945](https://github.com/matrix-org/synapse/issues/8945)) - Fix a bug causing common English words to not be considered for a user directory search. ([\#8959](https://github.com/matrix-org/synapse/issues/8959)) - Fix bug where application services couldn't register new ghost users if the server had reached its MAU limit. ([\#8962](https://github.com/matrix-org/synapse/issues/8962)) - Fix a long-standing bug where a `m.image` event without a `url` would cause errors on push. ([\#8965](https://github.com/matrix-org/synapse/issues/8965)) - Fix a small bug in v2 state resolution algorithm, which could also cause performance issues for rooms with large numbers of power levels. ([\#8971](https://github.com/matrix-org/synapse/issues/8971)) - Add validation to the `sendToDevice` API to raise a missing parameters error instead of a 500 error. ([\#8975](https://github.com/matrix-org/synapse/issues/8975)) - Add validation of group IDs to raise a 400 error instead of a 500 eror. ([\#8977](https://github.com/matrix-org/synapse/issues/8977)) Improved Documentation ---------------------- - Fix the "Event persist rate" section of the included grafana dashboard by adding missing prometheus rules. ([\#8802](https://github.com/matrix-org/synapse/issues/8802)) - Combine related media admin API docs. ([\#8839](https://github.com/matrix-org/synapse/issues/8839)) - Fix an error in the documentation for the SAML username mapping provider. ([\#8873](https://github.com/matrix-org/synapse/issues/8873)) - Clarify comments around template directories in `sample_config.yaml`. ([\#8891](https://github.com/matrix-org/synapse/issues/8891)) - Moved instructions for database setup, adjusted heading levels and improved syntax highlighting in [INSTALL.md](../INSTALL.md). Contributed by fossterer. ([\#8987](https://github.com/matrix-org/synapse/issues/8987)) - Update the example value of `group_creation_prefix` in the sample configuration. ([\#8992](https://github.com/matrix-org/synapse/issues/8992)) - Link the Synapse developer room to the development section in the docs. ([\#9002](https://github.com/matrix-org/synapse/issues/9002)) Deprecations and Removals ------------------------- - Deprecate Shutdown Room and Purge Room Admin APIs. ([\#8829](https://github.com/matrix-org/synapse/issues/8829)) Internal Changes ---------------- - Properly store the mapping of external ID to Matrix ID for CAS users. ([\#8856](https://github.com/matrix-org/synapse/issues/8856), [\#8958](https://github.com/matrix-org/synapse/issues/8958)) - Remove some unnecessary stubbing from unit tests. ([\#8861](https://github.com/matrix-org/synapse/issues/8861)) - Remove unused `FakeResponse` class from unit tests. ([\#8864](https://github.com/matrix-org/synapse/issues/8864)) - Pass `room_id` to `get_auth_chain_difference`. ([\#8879](https://github.com/matrix-org/synapse/issues/8879)) - Add type hints to push module. ([\#8880](https://github.com/matrix-org/synapse/issues/8880), [\#8882](https://github.com/matrix-org/synapse/issues/8882), [\#8901](https://github.com/matrix-org/synapse/issues/8901), [\#8940](https://github.com/matrix-org/synapse/issues/8940), [\#8943](https://github.com/matrix-org/synapse/issues/8943), [\#9020](https://github.com/matrix-org/synapse/issues/9020)) - Simplify logic for handling user-interactive-auth via single-sign-on servers. ([\#8881](https://github.com/matrix-org/synapse/issues/8881)) - Skip the SAML tests if the requirements (`pysaml2` and `xmlsec1`) aren't available. ([\#8905](https://github.com/matrix-org/synapse/issues/8905)) - Fix multiarch docker image builds. ([\#8906](https://github.com/matrix-org/synapse/issues/8906)) - Don't publish `latest` docker image until all archs are built. ([\#8909](https://github.com/matrix-org/synapse/issues/8909)) - Various clean-ups to the structured logging and logging context code. ([\#8916](https://github.com/matrix-org/synapse/issues/8916), [\#8935](https://github.com/matrix-org/synapse/issues/8935)) - Automatically drop stale forward-extremities under some specific conditions. ([\#8929](https://github.com/matrix-org/synapse/issues/8929)) - Refactor test utilities for injecting HTTP requests. ([\#8946](https://github.com/matrix-org/synapse/issues/8946)) - Add a maximum size of 50 kilobytes to .well-known lookups. ([\#8950](https://github.com/matrix-org/synapse/issues/8950)) - Fix bug in `generate_log_config` script which made it write empty files. ([\#8952](https://github.com/matrix-org/synapse/issues/8952)) - Clean up tox.ini file; disable coverage checking for non-test runs. ([\#8963](https://github.com/matrix-org/synapse/issues/8963)) - Add type hints to the admin and room list handlers. ([\#8973](https://github.com/matrix-org/synapse/issues/8973)) - Add type hints to the receipts and user directory handlers. ([\#8976](https://github.com/matrix-org/synapse/issues/8976)) - Drop the unused `local_invites` table. ([\#8979](https://github.com/matrix-org/synapse/issues/8979)) - Add type hints to the base storage code. ([\#8980](https://github.com/matrix-org/synapse/issues/8980)) - Support using PyJWT v2.0.0 in the test suite. ([\#8986](https://github.com/matrix-org/synapse/issues/8986)) - Fix `tests.federation.transport.RoomDirectoryFederationTests` and ensure it runs in CI. ([\#8998](https://github.com/matrix-org/synapse/issues/8998)) - Add type hints to the crypto module. ([\#8999](https://github.com/matrix-org/synapse/issues/8999)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEF3tZXk38tRDFVnUIM/xY9qcRMEgFAl/1rv4ACgkQM/xY9qcR MEiIGw/+PytgC2yOpaR7cIQl0K1v+y4X/AmNbshdQch7GtC3vtKxdmo4PJp4KwY4 Sxiiykq46Xx48w/Hqd3hoC7OqsTyfmNjRKW0InsTarbaXMrSv9umOtScItzMMWq8 SCmDPQ+cF0SP2GhOMwB/N5JpRS12OpdBzHXtcbwxULilTuO/EKD2/W1zq3wiSP7r BxhHHYsx69hufUGC3OGD0I8e26TqjgkLiVm0FeM6cC5TubozO3qrJDlmwTPSpFrL WZEBEbnYUVz4ydMKRq4ALiZzPzxxBfgQmITb79CNqim4+fc+M+AqV6mRez2ULrqh d4/UEMTaA0yh54i0oqei3gwf2ucns/NDftQ9cYwF1+a9LCcWAyJZY7+/9Hk4VKSU KqQUzGdBfxyefsLc2hNGANzS/VbThdejC09IjaxKtHSgaT+bb5LxS8GcbvcG5FxY LyD8yeazgXPub+Ixr6dvD51roCuBtpCYvGZtHHYOiX/S1MYbq22Duet2Z1zhy7qB Jl8r3L32x5wAG3lR8aLqDVNTrC1ur0TW9wUJ88bDjcwn0PsseQG41DHbQSoXQIlk p6/IKjJjfnbKJFTwzfC8RpL29NtyTPqA/d2JDJ7yqUbpEkAnc5GN+pO0B/736aOH aTRu8nVdP7GOoP4whZ9C7r5kYjiCR3jPtpZHRYXaPJtkw57dWS8= =/g7u -----END PGP SIGNATURE----- Merge tag 'v1.25.0rc1' into develop Synapse 1.25.0rc1 (2021-01-06) ============================== Removal warning --------------- The old [Purge Room API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api/purge_room.md) and [Shutdown Room API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api/shutdown_room.md) are deprecated and will be removed in a future release. They will be replaced by the [Delete Room API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api/rooms.md#delete-room-api). `POST /_synapse/admin/v1/rooms/<room_id>/delete` replaces `POST /_synapse/admin/v1/purge_room` and `POST /_synapse/admin/v1/shutdown_room/<room_id>`. Features -------- - Add an admin API that lets server admins get power in rooms in which local users have power. ([\#8756](https://github.com/matrix-org/synapse/issues/8756)) - Add optional HTTP authentication to replication endpoints. ([\#8853](https://github.com/matrix-org/synapse/issues/8853)) - Improve the error messages printed as a result of configuration problems for extension modules. ([\#8874](https://github.com/matrix-org/synapse/issues/8874)) - Add the number of local devices to Room Details Admin API. Contributed by @dklimpel. ([\#8886](https://github.com/matrix-org/synapse/issues/8886)) - Add `X-Robots-Tag` header to stop web crawlers from indexing media. Contributed by Aaron Raimist. ([\#8887](https://github.com/matrix-org/synapse/issues/8887)) - Spam-checkers may now define their methods as `async`. ([\#8890](https://github.com/matrix-org/synapse/issues/8890)) - Add support for allowing users to pick their own user ID during a single-sign-on login. ([\#8897](https://github.com/matrix-org/synapse/issues/8897), [\#8900](https://github.com/matrix-org/synapse/issues/8900), [\#8911](https://github.com/matrix-org/synapse/issues/8911), [\#8938](https://github.com/matrix-org/synapse/issues/8938), [\#8941](https://github.com/matrix-org/synapse/issues/8941), [\#8942](https://github.com/matrix-org/synapse/issues/8942), [\#8951](https://github.com/matrix-org/synapse/issues/8951)) - Add an `email.invite_client_location` configuration option to send a web client location to the invite endpoint on the identity server which allows customisation of the email template. ([\#8930](https://github.com/matrix-org/synapse/issues/8930)) - The search term in the list room and list user Admin APIs is now treated as case-insensitive. ([\#8931](https://github.com/matrix-org/synapse/issues/8931)) - Apply an IP range blacklist to push and key revocation requests. ([\#8821](https://github.com/matrix-org/synapse/issues/8821), [\#8870](https://github.com/matrix-org/synapse/issues/8870), [\#8954](https://github.com/matrix-org/synapse/issues/8954)) - Add an option to allow re-use of user-interactive authentication sessions for a period of time. ([\#8970](https://github.com/matrix-org/synapse/issues/8970)) - Allow running the redact endpoint on workers. ([\#8994](https://github.com/matrix-org/synapse/issues/8994)) Bugfixes -------- - Fix bug where we might not correctly calculate the current state for rooms with multiple extremities. ([\#8827](https://github.com/matrix-org/synapse/issues/8827)) - Fix a long-standing bug in the register admin endpoint (`/_synapse/admin/v1/register`) when the `mac` field was not provided. The endpoint now properly returns a 400 error. Contributed by @edwargix. ([\#8837](https://github.com/matrix-org/synapse/issues/8837)) - Fix a long-standing bug on Synapse instances supporting Single-Sign-On, where users would be prompted to enter their password to confirm certain actions, even though they have not set a password. ([\#8858](https://github.com/matrix-org/synapse/issues/8858)) - Fix a longstanding bug where a 500 error would be returned if the `Content-Length` header was not provided to the upload media resource. ([\#8862](https://github.com/matrix-org/synapse/issues/8862)) - Add additional validation to pusher URLs to be compliant with the specification. ([\#8865](https://github.com/matrix-org/synapse/issues/8865)) - Fix the error code that is returned when a user tries to register on a homeserver on which new-user registration has been disabled. ([\#8867](https://github.com/matrix-org/synapse/issues/8867)) - Fix a bug where `PUT /_synapse/admin/v2/users/<user_id>` failed to create a new user when `avatar_url` is specified. Bug introduced in Synapse v1.9.0. ([\#8872](https://github.com/matrix-org/synapse/issues/8872)) - Fix a 500 error when attempting to preview an empty HTML file. ([\#8883](https://github.com/matrix-org/synapse/issues/8883)) - Fix occasional deadlock when handling SIGHUP. ([\#8918](https://github.com/matrix-org/synapse/issues/8918)) - Fix login API to not ratelimit application services that have ratelimiting disabled. ([\#8920](https://github.com/matrix-org/synapse/issues/8920)) - Fix bug where we ratelimited auto joining of rooms on registration (using `auto_join_rooms` config). ([\#8921](https://github.com/matrix-org/synapse/issues/8921)) - Fix a bug where deactivated users appeared in the user directory when their profile information was updated. ([\#8933](https://github.com/matrix-org/synapse/issues/8933), [\#8964](https://github.com/matrix-org/synapse/issues/8964)) - Fix bug introduced in Synapse v1.24.0 which would cause an exception on startup if both `enabled` and `localdb_enabled` were set to `False` in the `password_config` setting of the configuration file. ([\#8937](https://github.com/matrix-org/synapse/issues/8937)) - Fix a bug where 500 errors would be returned if the `m.room_history_visibility` event had invalid content. ([\#8945](https://github.com/matrix-org/synapse/issues/8945)) - Fix a bug causing common English words to not be considered for a user directory search. ([\#8959](https://github.com/matrix-org/synapse/issues/8959)) - Fix bug where application services couldn't register new ghost users if the server had reached its MAU limit. ([\#8962](https://github.com/matrix-org/synapse/issues/8962)) - Fix a long-standing bug where a `m.image` event without a `url` would cause errors on push. ([\#8965](https://github.com/matrix-org/synapse/issues/8965)) - Fix a small bug in v2 state resolution algorithm, which could also cause performance issues for rooms with large numbers of power levels. ([\#8971](https://github.com/matrix-org/synapse/issues/8971)) - Add validation to the `sendToDevice` API to raise a missing parameters error instead of a 500 error. ([\#8975](https://github.com/matrix-org/synapse/issues/8975)) - Add validation of group IDs to raise a 400 error instead of a 500 eror. ([\#8977](https://github.com/matrix-org/synapse/issues/8977)) Improved Documentation ---------------------- - Fix the "Event persist rate" section of the included grafana dashboard by adding missing prometheus rules. ([\#8802](https://github.com/matrix-org/synapse/issues/8802)) - Combine related media admin API docs. ([\#8839](https://github.com/matrix-org/synapse/issues/8839)) - Fix an error in the documentation for the SAML username mapping provider. ([\#8873](https://github.com/matrix-org/synapse/issues/8873)) - Clarify comments around template directories in `sample_config.yaml`. ([\#8891](https://github.com/matrix-org/synapse/issues/8891)) - Moved instructions for database setup, adjusted heading levels and improved syntax highlighting in [INSTALL.md](../INSTALL.md). Contributed by fossterer. ([\#8987](https://github.com/matrix-org/synapse/issues/8987)) - Update the example value of `group_creation_prefix` in the sample configuration. ([\#8992](https://github.com/matrix-org/synapse/issues/8992)) - Link the Synapse developer room to the development section in the docs. ([\#9002](https://github.com/matrix-org/synapse/issues/9002)) Deprecations and Removals ------------------------- - Deprecate Shutdown Room and Purge Room Admin APIs. ([\#8829](https://github.com/matrix-org/synapse/issues/8829)) Internal Changes ---------------- - Properly store the mapping of external ID to Matrix ID for CAS users. ([\#8856](https://github.com/matrix-org/synapse/issues/8856), [\#8958](https://github.com/matrix-org/synapse/issues/8958)) - Remove some unnecessary stubbing from unit tests. ([\#8861](https://github.com/matrix-org/synapse/issues/8861)) - Remove unused `FakeResponse` class from unit tests. ([\#8864](https://github.com/matrix-org/synapse/issues/8864)) - Pass `room_id` to `get_auth_chain_difference`. ([\#8879](https://github.com/matrix-org/synapse/issues/8879)) - Add type hints to push module. ([\#8880](https://github.com/matrix-org/synapse/issues/8880), [\#8882](https://github.com/matrix-org/synapse/issues/8882), [\#8901](https://github.com/matrix-org/synapse/issues/8901), [\#8940](https://github.com/matrix-org/synapse/issues/8940), [\#8943](https://github.com/matrix-org/synapse/issues/8943), [\#9020](https://github.com/matrix-org/synapse/issues/9020)) - Simplify logic for handling user-interactive-auth via single-sign-on servers. ([\#8881](https://github.com/matrix-org/synapse/issues/8881)) - Skip the SAML tests if the requirements (`pysaml2` and `xmlsec1`) aren't available. ([\#8905](https://github.com/matrix-org/synapse/issues/8905)) - Fix multiarch docker image builds. ([\#8906](https://github.com/matrix-org/synapse/issues/8906)) - Don't publish `latest` docker image until all archs are built. ([\#8909](https://github.com/matrix-org/synapse/issues/8909)) - Various clean-ups to the structured logging and logging context code. ([\#8916](https://github.com/matrix-org/synapse/issues/8916), [\#8935](https://github.com/matrix-org/synapse/issues/8935)) - Automatically drop stale forward-extremities under some specific conditions. ([\#8929](https://github.com/matrix-org/synapse/issues/8929)) - Refactor test utilities for injecting HTTP requests. ([\#8946](https://github.com/matrix-org/synapse/issues/8946)) - Add a maximum size of 50 kilobytes to .well-known lookups. ([\#8950](https://github.com/matrix-org/synapse/issues/8950)) - Fix bug in `generate_log_config` script which made it write empty files. ([\#8952](https://github.com/matrix-org/synapse/issues/8952)) - Clean up tox.ini file; disable coverage checking for non-test runs. ([\#8963](https://github.com/matrix-org/synapse/issues/8963)) - Add type hints to the admin and room list handlers. ([\#8973](https://github.com/matrix-org/synapse/issues/8973)) - Add type hints to the receipts and user directory handlers. ([\#8976](https://github.com/matrix-org/synapse/issues/8976)) - Drop the unused `local_invites` table. ([\#8979](https://github.com/matrix-org/synapse/issues/8979)) - Add type hints to the base storage code. ([\#8980](https://github.com/matrix-org/synapse/issues/8980)) - Support using PyJWT v2.0.0 in the test suite. ([\#8986](https://github.com/matrix-org/synapse/issues/8986)) - Fix `tests.federation.transport.RoomDirectoryFederationTests` and ensure it runs in CI. ([\#8998](https://github.com/matrix-org/synapse/issues/8998)) - Add type hints to the crypto module. ([\#8999](https://github.com/matrix-org/synapse/issues/8999))	2021-01-06 07:42:38 -05:00
Patrick Cloke	0248409bfa	Handle a display name / avatar URL not included in a federation request. (#9023 ) These may be omitted if not set, but Synapse assumed they would be in the response.	2021-01-06 07:29:03 -05:00
Patrick Cloke	2fe0fb21f6	1.25.0rc1	2021-01-06 07:08:13 -05:00
Patrick Cloke	37eaf9c272	Fix-up assertions about last stream token in push (#9020 ) The last stream token is always known and we do not need to handle none.	2021-01-05 10:53:15 -05:00
Eric Eastwood	c027a199f3	Ignore date-rotated logs (#9018 ) Ex. - homeserver.log.2020-12-29 - homeserver.log.2020-12-31	2021-01-05 13:09:15 +00:00
Patrick Cloke	06fefe0bb1	Add type hints to the logging context code. (#8939 )	2021-01-05 08:06:55 -05:00
Patrick Cloke	9dde9c9f01	Implement MSC2176: Updated redaction rules (#8984 ) An experimental room version ("org.matrix.msc2176") contains the new redaction rules for testing.	2021-01-05 07:41:48 -05:00
Richard van der Hoff	111b673fc1	Add initial support for a "pick your IdP" page (#9017 ) During login, if there are multiple IdPs enabled, offer the user a choice of IdPs.	2021-01-05 11:25:28 +00:00
Richard van der Hoff	d2c616a413	Combine the SSO Redirect Servlets (#9015 ) * Implement CasHandler.handle_redirect_request ... to make it match OidcHandler and SamlHandler * Clean up interface for OidcHandler.handle_redirect_request Make it accept `client_redirect_url=None`. * Clean up interface for `SamlHandler.handle_redirect_request` ... bring it into line with CAS and OIDC by making it take a Request parameter, move the magic for `client_redirect_url` for UIA into the handler, and fix the return type to be a `str` rather than a `bytes`. * Define a common protocol for SSO auth provider impls * Give SsoIdentityProvider an ID and register them * Combine the SSO Redirect servlets Now that the SsoHandler knows about the identity providers, we can combine the various RedirectServlets into a single implementation which delegates to the right IdP. changelog	2021-01-04 18:13:49 +00:00
Patrick Cloke	31b1905e13	Add type hints to the receipts and user directory handlers. (#8976 )	2021-01-04 10:05:12 -05:00
Patrick Cloke	1c9a850562	Add type hints to the crypto module. (#8999 )	2021-01-04 10:04:50 -05:00
Eric Eastwood	a685bbb018	Add link to Synapse dev room to the relevant README section (#9002 )	2021-01-04 08:59:19 -05:00
Patrick Cloke	0eccf53146	Use the SSO handler helpers for CAS registration/login. (#8856 )	2021-01-03 16:25:44 +00:00
Andrew Morgan	168ba00d01	Fix RoomDirectoryFederationTests and make them actually run (#8998 ) The `RoomDirectoryFederationTests` tests were not being run unless explicitly called as an `__init__.py` file was not present in `tests/federation/transport/`. Thus the folder was not a python module, and `trial` did not look inside for any test cases to run. This was found while working on #6739. This PR adds a `__init__.py` and also fixes the test in a couple ways: - Switch to subclassing `unittest.FederatingHomeserverTestCase` instead, which sets up federation endpoints for us. - Supply a `federation_auth_origin` to `make_request` in order to more act like the request is coming from another server, instead of just an unauthenicated client requesting a federation endpoint. I found that the second point makes no difference to the test passing, but felt like the right thing to do if we're testing over federation.	2020-12-30 19:27:32 +00:00
Patrick Cloke	b7c580e333	Check if group IDs are valid before using them. (#8977 )	2020-12-30 08:39:59 -05:00
Patrick Cloke	637282bb50	Add additional type hints to the storage module. (#8980 )	2020-12-30 08:09:53 -05:00
Shashank Sabniveesu	b8591899ab	Doc/move database setup instructions in install md (#8987 )	2020-12-30 11:33:03 +00:00
Patrick Cloke	9999eb2d02	Add type hints to admin and room list handlers. (#8973 )	2020-12-29 17:42:10 -05:00
Patrick Cloke	14a7371375	Validate input parameters for the sendToDevice API. (#8975 ) This makes the "messages" key in the content required. This is currently optional in the spec, but that seems to be an error.	2020-12-29 12:47:45 -05:00
Jerin J Titus	cfcf5541b4	Update the value of group_creation_prefix in sample config. (#8992 ) Removes the trailing slash with causes issues with matrix.to/Element.	2020-12-29 09:30:48 -05:00
Patrick Cloke	68bb26da69	Allow redacting events on workers (#8994 ) Adds the redacts endpoint to workers that have the client listener.	2020-12-29 07:40:12 -05:00
Patrick Cloke	d0c3c24eb2	Drop the unused local_invites table. (#8979 ) This table has been unused since Synapse v1.17.0.	2020-12-29 07:26:29 -05:00
Patrick Cloke	a802606475	Support PyJWT v2.0.0. (#8986 ) Tests were broken due to an API changing. The code used in Synapse proper should be compatible with both versions already.	2020-12-22 13:00:14 -05:00
Patrick Cloke	4218473f9e	Refactor the CAS handler in prep for using the abstracted SSO code. (#8958 ) This makes the CAS handler look more like the SAML/OIDC handlers: * Render errors to users instead of throwing JSON errors. * Internal reorganization.	2020-12-18 13:09:45 -05:00
Patrick Cloke	56e00ca85e	Send the location of the web client to the IS when inviting via 3PIDs. (#8930 ) Adds a new setting `email.invite_client_location` which, if defined, is passed to the identity server during invites.	2020-12-18 11:01:57 -05:00
Erik Johnston	d781a81e69	Allow server admin to get admin bit in rooms where local user is an admin (#8756 ) This adds an admin API that allows a server admin to get power in a room if a local user has power in a room. Will also invite the user if they're not in the room and its a private room. Can specify another user (rather than the admin user) to be granted power. Co-authored-by: Matthew Hodgson <matthew@matrix.org>	2020-12-18 15:37:19 +00:00
Erik Johnston	5e7d75daa2	Fix mainline ordering in state res v2 (#8971 ) This had two effects 1) it'd give the wrong answer and b) would iterate all power levels in the auth chain of each event. The latter of which can be very expensive for certain types of IRC bridge rooms that have large numbers of power level changes.	2020-12-18 15:00:34 +00:00
Richard van der Hoff	28877fade9	Implement a username picker for synapse (#8942 ) The final part (for now) of my work to implement a username picker in synapse itself. The idea is that we allow `UsernameMappingProvider`s to return `localpart=None`, in which case, rather than redirecting the browser back to the client, we redirect to a username-picker resource, which allows the user to enter a username. We then complete the SSO flow (including doing the client permission checks). The static resources for the username picker itself (in https://github.com/matrix-org/synapse/tree/rav/username_picker/synapse/res/username_picker) are essentially lifted wholesale from https://github.com/matrix-org/matrix-synapse-saml-mozilla/tree/master/matrix_synapse_saml_mozilla/res. As the comment says, we might want to think about making them customisable, but that can be a follow-up. Fixes #8876.	2020-12-18 14:19:46 +00:00
Patrick Cloke	5d4c330ed9	Allow re-using a UI auth validation for a period of time (#8970 )	2020-12-18 07:33:57 -05:00
Patrick Cloke	4136255d3c	Ensure that a URL exists in the content during push. (#8965 ) This fixes an KeyError exception, after this PR the content is just considered unknown.	2020-12-18 07:26:15 -05:00
Erik Johnston	a7a913918c	Merge remote-tracking branch 'origin/erikj/as_mau_block' into develop	2020-12-18 09:51:56 +00:00
Erik Johnston	70586aa63e	Try and drop stale extremities. (#8929 ) If we see stale extremities while persisting events, and notice that they don't change the result of state resolution, we drop them.	2020-12-18 09:49:18 +00:00
Richard van der Hoff	f1db20b5a5	Clean up tox.ini (#8963 ) ... and disable coverage tracking for mypy and friends.	2020-12-17 22:58:00 +00:00
Richard van der Hoff	c9c1c9d82f	Fix `UsersListTestCase` (#8964 )	2020-12-17 10:46:40 -05:00
Brendan Abolivier	f2783fc201	Use the simple dictionary in full text search for the user directory (#8959 ) * Use the simple dictionary in fts for the user directory * Clarify naming	2020-12-17 14:42:30 +01:00
Dirk Klimpel	c07022303e	Fix a bug that deactivated users appear in the directory (#8933 ) Fixes a bug that deactivated users appear in the directory when their profile information was updated. To change profile information of deactivated users is neccesary for example you will remove displayname or avatar. But they should not appear in directory. They are deactivated. Co-authored-by: Erik Johnston <erikj@jki.re>	2020-12-17 12:05:39 +00:00
Erik Johnston	35be260090	Newsfile	2020-12-17 12:05:18 +00:00
Dirk Klimpel	06006058d7	Make search statement in List Room and User Admin API case-insensitive (#8931 )	2020-12-17 10:43:37 +00:00
Patrick Cloke	ff5c4da128	Add a maximum size for well-known lookups. (#8950 )	2020-12-16 17:25:24 -05:00
Richard van der Hoff	e1b8e37f93	Push login completion down into SsoHandler (#8941 ) This is another part of my work towards fixing #8876. It moves some of the logic currently in the SAML and OIDC handlers - in particular the call to `AuthHandler.complete_sso_login` down into the `SsoHandler`.	2020-12-16 20:01:53 +00:00
Patrick Cloke	44b7d4c6d6	Fix the sample config location for the ip_range_whitelist setting. (#8954 ) Move it from the federation section to the server section to match ip_range_blacklist.	2020-12-16 14:40:47 -05:00
Patrick Cloke	bd30cfe86a	Convert internal pusher dicts to attrs classes. (#8940 ) This improves type hinting and should use less memory.	2020-12-16 11:25:30 -05:00
Richard van der Hoff	7a332850e6	Merge pull request #8951 from matrix-org/rav/username_picker_2 More preparatory refactoring of the OidcHandler tests	2020-12-16 14:53:26 +00:00
Richard van der Hoff	651e1ae534	Merge pull request #8946 from matrix-org/rav/refactor_send_request Remove `Request` return value from `make_request`	2020-12-16 14:53:01 +00:00
Richard van der Hoff	3ad699cc65	Fix generate_log_config script (#8952 ) It used to write an empty file if you gave it a -o arg.	2020-12-16 14:52:04 +00:00
Patrick Cloke	be2db93b3c	Do not assume that the contents dictionary includes history_visibility. (#8945 )	2020-12-16 08:46:37 -05:00
Richard van der Hoff	757b5a0bf6	changelog	2020-12-15 23:11:42 +00:00
Richard van der Hoff	ed61fe4ada	changelog	2020-12-15 22:35:50 +00:00
Richard van der Hoff	01333681bc	Preparatory refactoring of the SamlHandlerTestCase (#8938 ) * move simple_async_mock to test_utils ... so that it can be re-used * Remove references to `SamlHandler._map_saml_response_to_user` from tests This method is going away, so we can no longer use it as a test point. Instead, factor out a higher-level method which takes a SAML object, and verify correct behaviour by mocking out `AuthHandler.complete_sso_login`. * changelog	2020-12-15 20:56:10 +00:00
Patrick Cloke	b3a4b53587	Fix handling of stream tokens for push. (#8943 ) Removes faulty assertions and fixes the logic to ensure the max stream token is always set.	2020-12-15 10:41:34 -05:00
Richard van der Hoff	6d02eb22df	Fix startup failure with localdb_enabled: False (#8937 )	2020-12-14 20:42:03 +00:00
Patrick Cloke	1619802228	Various clean-ups to the logging context code (#8935 )	2020-12-14 14:19:47 -05:00
Richard van der Hoff	895e04319b	Preparatory refactoring of the OidcHandlerTestCase (#8911 ) * Remove references to handler._auth_handler (and replace them with hs.get_auth_handler) * Factor out a utility function for building Requests * Remove mocks of `OidcHandler._map_userinfo_to_user` This method is going away, so mocking it out is no longer a valid approach. Instead, we mock out lower-level methods (eg _remote_id_from_userinfo), or simply allow the regular implementation to proceed and update the expectations accordingly. * Remove references to `OidcHandler._map_userinfo_to_user` from tests This method is going away, so we can no longer use it as a test point. Instead we build mock "callback" requests which we pass into `handle_oidc_callback`, and verify correct behaviour by mocking out `AuthHandler.complete_sso_login`.	2020-12-14 11:38:50 +00:00
David Teller	f14428b25c	Allow spam-checker modules to be provide async methods. (#8890 ) Spam checker modules can now provide async methods. This is implemented in a backwards-compatible manner.	2020-12-11 14:05:15 -05:00
Patrick Cloke	5d34f40d49	Add type hints to the push module. (#8901 )	2020-12-11 11:43:53 -05:00
Erik Johnston	a8eceb01e5	Honour AS ratelimit settings for /login requests (#8920 ) Fixes #8846.	2020-12-11 16:33:31 +00:00
Patrick Cloke	3af0672350	Improve tests for structured logging. (#8916 )	2020-12-11 07:25:01 -05:00
Dirk Klimpel	0a34cdfc66	Add number of local devices to Room Details Admin API (#8886 )	2020-12-11 10:42:47 +00:00
Erik Johnston	1d55c7b567	Don't ratelimit autojoining of rooms (#8921 ) Fixes #8866	2020-12-11 10:17:49 +00:00
Richard van der Hoff	dc016c66ae	Don't publish `latest` docker image until all archs are built (#8909 )	2020-12-10 17:00:29 +00:00
Erik Johnston	80a992d7b9	Fix deadlock on SIGHUP (#8918 ) Fixes #8892	2020-12-10 16:56:05 +00:00
Richard van der Hoff	c64002e1c1	Refactor `SsoHandler.get_mxid_from_sso` (#8900 ) * Factor out _call_attribute_mapper and _register_mapped_user This is mostly an attempt to simplify `get_mxid_from_sso`. * Move mapping_lock down into SsoHandler.	2020-12-10 12:43:58 +00:00
Richard van der Hoff	1821f7cc26	Fix buglet in DirectRenderJsonResource (#8897 ) this was using `canonical_json` without setting it, so when you used it as a standalone class, you would get exceptions.	2020-12-10 12:42:55 +00:00
Dirk Klimpel	a5f7aff5e5	Deprecate Shutdown Room and Purge Room Admin API (#8829 ) Deprecate both APIs in favour of the Delete Room API. Related: #8663 and #8810	2020-12-10 11:42:48 +00:00
Patrick Cloke	344ab0b53a	Default to blacklisting reserved IP ranges and add a whitelist. (#8870 ) This defaults `ip_range_blacklist` to reserved IP ranges and also adds an `ip_range_whitelist` setting to override it.	2020-12-09 13:56:06 -05:00
Patrick Cloke	6ff34e00d9	Skip the SAML tests if xmlsec1 isn't available. (#8905 )	2020-12-09 12:23:30 -05:00
Dirk Klimpel	43bf3c5178	Combine related media admin API docs (#8839 ) Related: #8810 Also a few small improvements. Signed-off-by: Dirk Klimpel dirk@klimpel.org	2020-12-09 16:19:57 +00:00
Richard van der Hoff	a4a5c7a35e	Merge remote-tracking branch 'origin/master' into develop	2020-12-09 16:13:52 +00:00
Richard van der Hoff	9bbbb11ac2	Pin the docker version for multiarch builds It seems that letting CircleCI use its default docker version (17.09.0-ce, apparently) did not interact well with multiarch builds: in particular, we saw weird effects where running an amd64 build at the same time as an arm64 build caused the arm64 builds to fail with: Error while loading /usr/sbin/dpkg-deb: No such file or directory	2020-12-09 15:51:11 +00:00
Erik Johnston	9b26a4ac87	1.24.0	2020-12-09 11:07:24 +00:00
Aaron Raimist	cd9e72b185	Add X-Robots-Tag header to stop crawlers from indexing media (#8887 ) Fixes / related to: https://github.com/matrix-org/synapse/issues/6533 This should do essentially the same thing as a robots.txt file telling robots to not index the media repo. https://developers.google.com/search/reference/robots_meta_tag Signed-off-by: Aaron Raimist <aaron@raim.ist>	2020-12-08 22:51:03 +00:00
Patrick Cloke	1a9553045c	Fix installing pysaml2 on Python 3.5. (#8898 ) This pins pysaml2 to < 6.4.0 on Python 3.5, as the last known working version.	2020-12-08 13:41:25 -05:00
Richard van der Hoff	ab7a24cc6b	Better formatting for config errors from modules (#8874 ) The idea is that the parse_config method of extension modules can raise either a ConfigError or a JsonValidationError, and it will be magically turned into a legible error message. There's a few components to it: * Separating the "path" and the "message" parts of a ConfigError, so that we can fiddle with the path bit to turn it into an absolute path. * Generally improving the way ConfigErrors get printed. * Passing in the config path to load_module so that it can wrap any exceptions that get caught appropriately.	2020-12-08 14:04:35 +00:00
Richard van der Hoff	36ba73f53d	Simplify the flow for SSO UIA (#8881 ) * SsoHandler: remove inheritance from BaseHandler * Simplify the flow for SSO UIA We don't need to do all the magic for mapping users when we are doing UIA, so let's factor that out.	2020-12-08 14:03:38 +00:00
Richard van der Hoff	025fa06fc7	Clarify config template comments (#8891 )	2020-12-08 14:03:08 +00:00
Will Hunt	ff1f0ee094	Call set_avatar_url with target_user, not user_id (#8872 ) * Call set_avatar_url with target_user, not user_id Fixes https://github.com/matrix-org/synapse/issues/8871 * Create 8872.bugfix * Update synapse/rest/admin/users.py Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Testing * Update changelog.d/8872.bugfix Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2020-12-07 19:13:07 +00:00
Patrick Cloke	1f3748f033	Do not raise a 500 exception when previewing empty media. (#8883 )	2020-12-07 10:00:08 -05:00
Patrick Cloke	92d87c6882	Add type hints for HTTP and email pushers. (#8880 )	2020-12-07 09:59:38 -05:00
Patrick Cloke	02e588856a	Add type hints to the push mailer module. (#8882 )	2020-12-07 07:10:22 -05:00
Patrick Cloke	96358cb424	Add authentication to replication endpoints. (#8853 ) Authentication is done by checking a shared secret provided in the Synapse configuration file.	2020-12-04 10:56:28 -05:00
Erik Johnston	df4b1e9c74	Pass room_id to get_auth_chain_difference (#8879 ) This is so that we can choose which algorithm to use based on the room ID.	2020-12-04 15:52:49 +00:00
Patrick Cloke	b774c555d8	Add additional validation to pusher URLs. (#8865 ) Pusher URLs now must end in `/_matrix/push/v1/notify` per the specification.	2020-12-04 10:51:56 -05:00
Patrick Cloke	df3e6a23a7	Do not 500 if the content-length is not provided when uploading media. (#8862 ) Instead return the proper 400 error.	2020-12-04 10:26:09 -05:00
Patrick Cloke	693dab487c	1.24.0rc2	2020-12-04 08:48:04 -05:00
Patrick Cloke	22c6c19f91	Fix a regression that mapping providers should be able to redirect users. (#8878 ) This was broken in #8801.	2020-12-04 08:25:15 -05:00
Jordan Bancino	295c209cdd	Remove version pin prometheus_client dependency (#8875 ) This removes the version pin of the `prometheus_client` dependency, in direct response to #8831. If merged, this will close #8831 As far as I can tell, no other changes are needed, but as I'm no synapse expert, I'm relying heavily on CI and maintainer reviews for this. My very primitive test of synapse with prometheus_client v0.9.0 on my home server didn't bring up any issues, so we'll see what happens. Signed-off-by: Jordan Bancino	2020-12-04 13:01:06 +00:00
Richard van der Hoff	6e4f71c057	Fix a buglet in the SAML username mapping provider doc (#8873 ) the constructor is called with a `module_api`.	2020-12-04 10:14:15 +00:00
Richard van der Hoff	cf3b8156be	Fix errorcode for disabled registration (#8867 ) The spec says we should return `M_FORBIDDEN` when someone tries to register and registration is disabled.	2020-12-03 15:41:19 +00:00
Richard van der Hoff	269ba1bc84	Merge remote-tracking branch 'origin/develop' into rav/remove_unused_mocks	2020-12-02 20:08:46 +00:00
Richard van der Hoff	ed5172852a	Merge pull request #8858 from matrix-org/rav/sso_uia UIA: offer only available auth flows	2020-12-02 20:06:53 +00:00
Richard van der Hoff	f347f0cd58	remove unused FakeResponse (#8864 )	2020-12-02 18:58:25 +00:00
Richard van der Hoff	935732768c	newsfile	2020-12-02 18:54:15 +00:00
Richard van der Hoff	92ce4a5258	changelog	2020-12-02 18:38:29 +00:00
Patrick Cloke	30fba62108	Apply an IP range blacklist to push and key revocation requests. (#8821 ) Replaces the `federation_ip_range_blacklist` configuration setting with an `ip_range_blacklist` setting with wider scope. It now applies to: * Federation * Identity servers * Push notifications * Checking key validitity for third-party invite events The old `federation_ip_range_blacklist` setting is still honored if present, but with reduced scope (it only applies to federation and identity servers).	2020-12-02 11:09:24 -05:00
Erik Johnston	c5b6abd53d	Correctly handle unpersisted events when calculating auth chain difference. (#8827 ) We do state res with unpersisted events when calculating the new current state of the room, so that should be the only thing impacted. I don't think this is tooooo big of a deal as: 1. the next time a state event happens in the room the current state should correct itself; 2. in the common case all the unpersisted events' auth events will be pulled in by other state, so will still return the correct result (or one which is sufficiently close to not affect the result); and 3. we mostly use the state at an event to do important operations, which isn't affected by this.	2020-12-02 15:22:37 +00:00
Johanna Dorothea Reichmann	0fed46ebe5	Add missing prometheus rules for persisted events (#8802 ) The official dashboard uses data from these rules, but they were never added to the synapse-v2.rules. They are mentioned in this issue: https://github.com/matrix-org/synapse/issues/7917#issuecomment-661330409, but never got added to the rules. Adding them results in all graphs in the "Event persist rate" section to function as intended. Signed-off-by: Johanna Dorothea Reichmann <transcaffeine@finallycoffee.eu>	2020-12-02 15:18:41 +00:00
David Florness	c4675e1b24	Add additional validation for the admin register endpoint. (#8837 ) Raise a proper 400 error if the `mac` field is missing.	2020-12-02 10:01:15 -05:00
Patrick Cloke	53b12688dd	1.24.0rc1	2020-12-02 08:57:51 -05:00
Patrick Cloke	8388384a64	Fix a regression when grandfathering SAML users. (#8855 ) This was broken in #8801 when abstracting code shared with OIDC. After this change both SAML and OIDC have a concept of grandfathering users, but with different implementations.	2020-12-02 07:45:42 -05:00
Patrick Cloke	c21bdc813f	Add basic SAML tests for mapping users. (#8800 )	2020-12-02 07:09:21 -05:00
Richard van der Hoff	d3ed93504b	Create a `PasswordProvider` wrapper object (#8849 ) The idea here is to abstract out all the conditional code which tests which methods a given password provider has, to provide a consistent interface.	2020-12-02 10:38:50 +00:00
Andrew Morgan	edb3d3f827	Allow specifying room version in 'RestHelper.create_room_as' and add typing (#8854 ) This PR adds a `room_version` argument to the `RestHelper`'s `create_room_as` function for tests. I plan to use this for testing knocking, which currently uses an unstable room version.	2020-12-02 10:38:18 +00:00
Richard van der Hoff	4d9496559d	Support "identifier" dicts in UIA (#8848 ) The spec requires synapse to support `identifier` dicts for `m.login.password` user-interactive auth, which it did not (instead, it required an undocumented `user` parameter.) To fix this properly, we need to pull the code that interprets `identifier` into `AuthHandler.validate_login` so that it can be called from the UIA code. Fixes #5665.	2020-12-01 17:42:26 +00:00
Richard van der Hoff	9edff901d1	Add missing `ordering` to background updates (#8850 ) It's important that we make sure our background updates happen in a defined order, to avoid disasters like #6923. Add an ordering to all of the background updates that have landed since #7190.	2020-12-01 15:52:49 +00:00
Nicolas Chamo	3f0cba657c	Allow Date header through CORS (#8804 )	2020-12-01 13:24:56 +00:00
Richard van der Hoff	89f7930730	Don't offer password login when it is disabled (#8835 ) Fix a minor bug where we would offer "m.login.password" login if a custom auth provider supported it, even if password login was disabled.	2020-12-01 13:04:03 +00:00
Richard van der Hoff	ddc4343683	Add some tests for `password_auth_providers` (#8819 ) These things seemed to be completely untested, so I added a load of tests for them.	2020-12-01 11:10:42 +00:00
Richard van der Hoff	09ac0569fe	Fix broken testcase (#8851 ) This test was broken by #8565. It doesn't need to set set `self.clock` here anyway - that is done by `setUp`.	2020-12-01 11:04:57 +00:00
Richard van der Hoff	59e18a1333	Simplify appservice login code (#8847 ) we don't need to support legacy login dictionaries here.	2020-11-30 19:20:56 +00:00
Mathieu Velten	9f0f274fe0	Allow per-room profile to be used for server notice user (#8799 ) This applies even if the feature is disabled at the server level with `allow_per_room_profiles`. The server notice not being a real user it doesn't have an user profile.	2020-11-30 18:59:29 +00:00
Richard van der Hoff	f8d13ca13d	Drop (almost) unused index on event_json (#8845 )	2020-11-30 18:44:09 +00:00
Andrew Morgan	17fa58bdd1	Add a config option to change whether unread push notification counts are per-message or per-room (#8820 ) This PR adds a new config option to the `push` section of the homeserver config, `group_unread_count_by_room`. By default Synapse will group push notifications by room (so if you have 1000 unread messages, if they lie in 55 rooms, you'll see an unread count on your phone of 55). However, it is also useful to be able to send out the true count of unread messages if desired. If `group_unread_count_by_room` is set to `false`, then with the above example, one would see an unread count of 1000 (email anyone?).	2020-11-30 18:43:54 +00:00
Jonathan de Jong	ca60822b34	Simplify the way the `HomeServer` object caches its internal attributes. (#8565 ) Changes `@cache_in_self` to use underscore-prefixed attributes.	2020-11-30 13:28:44 -05:00
Richard van der Hoff	a090b86209	Add `force_purge` option to delete-room admin api. (#8843 )	2020-11-30 16:48:12 +00:00
Tulir Asokan	856eab606b	Remove special case of pretty printing JSON responses for curl (#8833 ) * Remove special case of pretty printing JSON responses for curl Signed-off-by: Tulir Asokan <tulir@maunium.net>	2020-11-27 12:37:55 +00:00
Andrew Morgan	5cbe8d93fe	Add typing to membership Replication class methods (#8809 ) This PR grew out of #6739, and adds typing to some method arguments You'll notice that there are a lot of `# type: ignores` in here. This is due to the base methods not matching the overloads here. This is necessary to stop mypy complaining, but a better solution is #8828.	2020-11-27 10:49:38 +00:00
Dirk Klimpel	1cd356765e	Update example prometheus console (#8824 ) Signed-off-by: Dirk Klimpel dirk@klimpel.org	2020-11-26 17:41:20 +00:00
Erik Johnston	382b4e83f1	Defer SIGHUP handlers to reactor. (#8817 ) We can get a SIGHUP at any point, including times where we are not in a sane state. By deferring calling the handlers until the next reactor tick we ensure that we don't get unexpected conflicts, e.g. trying to flush logs from the signal handler while the code was in the process of writing a log entry. Fixes #8769.	2020-11-26 11:18:10 +00:00
Dmitry Borodaenko	7c43447477	Strip trailing / from server_url in register_new_matrix_user (#8823 ) When server URL provided to register_new_matrix_user includes path component (e.g. "http://localhost:8008/"), the command fails with "ERROR! Received 400 Bad Request". Stripping trailing slash from the server_url command argument makes sure combined endpoint URL remains valid. Signed-off-by: Dmitry Borodaenko angdraug@debian.org	2020-11-26 10:57:26 +00:00
Dirk Klimpel	14f81a6d24	Improve documentation how to configure prometheus for workers (#8822 )	2020-11-26 10:42:55 +00:00
Dirk Klimpel	3f0ff53158	Remove deprecated `/_matrix/client/*/admin` endpoints (#8785 ) These are now only available via `/_synapse/admin/v1`.	2020-11-25 16:26:11 -05:00
Andrew Morgan	2b110dda2a	Fix the formatting of push config section (#8818 ) This PR updates the push config's formatting to better align with our [code style guidelines](https://github.com/matrix-org/synapse/blob/develop/docs/code_style.md#configuration-file-format).	2020-11-25 21:02:53 +00:00
Andrew Morgan	d963c69ba5	Speed up remote invite rejection database call (#8815 ) This is another PR that grew out of #6739. The existing code for checking whether a user is currently invited to a room when they want to leave the room looks like the following: `f737368a26/synapse/handlers/room_member.py (L518-L540)` It calls `get_invite_for_local_user_in_room`, which will actually query all rooms the user has been invited to, before iterating over them and matching via the room ID. It will then return a tuple of a lot of information which we pull the event ID out of. I need to do a similar check for knocking, but this code wasn't very efficient. I then tried to write a different implementation using `StateHandler.get_current_state` but this actually didn't work as we haven't joined the room yet - we've only been invited to it. That means that only certain tables in Synapse have our desired `invite` membership state. One of those tables is `local_current_membership`. So I wrote a store method that just queries that table instead	2020-11-25 20:06:13 +00:00
Patrick Cloke	968939bdac	Add additional type hints to HTTP client. (#8812 ) This also removes some duplicated code between the simple HTTP client and matrix federation client.	2020-11-25 13:30:47 -05:00
Patrick Cloke	4fd222ad70	Support trying multiple localparts for OpenID Connect. (#8801 ) Abstracts the SAML and OpenID Connect code which attempts to regenerate the localpart of a matrix ID if it is already in use.	2020-11-25 10:04:22 -05:00
Patrick Cloke	f38676d161	Add type hints to matrix federation client / agent. (#8806 )	2020-11-25 07:07:21 -05:00
Dirk Klimpel	b08dc7effe	Clarify documentation of the admin list media API (#8795 ) Clarify that the list media API only shows media from unencrypted events.	2020-11-24 09:04:51 -05:00
Richard van der Hoff	97b35ee259	Add a script to sign arbitrary json objects. (#8772 )	2020-11-24 12:53:00 +00:00
Richard van der Hoff	e3d7806704	Update turn-howto (#8779 ) Some hopefully-useful notes on setting up a turnserver.	2020-11-24 12:52:22 +00:00
Patrick Cloke	6fde6aa9c0	Properly report user-agent/IP during registration of SSO users. (#8784 ) This also expands type-hints to the SSO and registration code. Refactors the CAS code to more closely match OIDC/SAML.	2020-11-23 13:28:03 -05:00
Waylon Cude	7127855741	Fix synctl and duplicate worker spawning (#8798 ) Synctl did not check if a worker thread was already running when using `synctl start` and would naively start a fresh copy. This would sometimes lead to cases where many duplicate copies of a single worker would run. This fix adds a pid check when starting worker threads and synctl will now refuse to start individual workers if they're already running.	2020-11-23 15:20:49 +00:00
Andrew Morgan	59a995f38d	Improve logging of the mapping from SSO IDs to Matrix IDs. (#8773 )	2020-11-23 08:45:23 -05:00
Daniele Sluijters	8ca120df7c	INSTALL: Fix setting content-type on well-known (#8793 ) When using `add_header` nginx will literally add a header. If a `content-type` header is already configured (for example through a server wide default), this means we end up with 2 content-type headers, like so: ``` content-type: text/html content-type: application/json access-control-allow-origin: * ``` That doesn't make sense. Instead, we want the content type of that block to only be `application/json` which we can achieve using `default_type` instead. Signed-off-by: Daniele Sluijters <daenney@users.noreply.github.com>	2020-11-23 13:01:18 +00:00
Patrick Cloke	79bfe966e0	Improve error checking for OIDC/SAML mapping providers (#8774 ) Checks that the localpart returned by mapping providers for SAML and OIDC are valid before registering new users. Extends the OIDC tests for existing users and invalid data.	2020-11-19 14:25:17 -05:00
Ben Banfield-Zanin	53a6f5ddf0	SAML: Allow specifying the IdP entityid to use. (#8630 ) If the SAML metadata includes multiple IdPs it is necessary to specify which IdP to redirect users to for authentication.	2020-11-19 09:57:13 -05:00
Richard van der Hoff	950bb0305f	Consistently use room_id from federation request body (#8776 ) * Consistently use room_id from federation request body Some federation APIs have a redundant `room_id` path param (see https://github.com/matrix-org/matrix-doc/issues/2330). We should make sure we consistently use either the path param or the body param, and the body param is easier. * Kill off some references to "context" Once upon a time, "rooms" were known as "contexts". I think this kills of the last references to "contexts".	2020-11-19 10:05:33 +00:00
Will Hunt	51338491c9	Improve appservice handler to send only the most recent read receipts when no stream_id is stored. (#8744 ) * Make this line debug (it's noisy) * Don't include from_key for presence if we are at 0 * Limit read receipts for all rooms to 100 * changelog.d/8744.bugfix * Allow from_key to be None * Update 8744.bugfix * The from_key is superflous * Update comment	2020-11-18 18:54:09 +00:00
Erik Johnston	03e392f787	Fix tests on develop (#8777 ) This was broken due to #8617 and #8761.	2020-11-18 15:43:11 +00:00
Marcus Schopen	d356588339	SAML: Document allowing a clock/time difference from IdP (#8731 ) Updates the sample configuration with the pysaml2 configuration for accepting clock skew/drift between the homeserver and IdP.	2020-11-18 07:36:28 -05:00
Erik Johnston	ef366720d5	1.23.0	2020-11-18 11:41:41 +00:00
Andrew Morgan	c087f68053	Cap the version of prometheus_client to <v0.9.0 in the dockerfile (#8767 ) Short-term fix for https://github.com/matrix-org/synapse/issues/8766.	2020-11-17 16:01:33 +00:00
Richard van der Hoff	deff8f628d	Merge pull request #8761 from matrix-org/rav/test_request_rendering Make `make_request` actually render the request	2020-11-17 15:17:04 +00:00
Patrick Cloke	ee382025b0	Abstract shared SSO code. (#8765 ) De-duplicates code between the SAML and OIDC implementations.	2020-11-17 09:46:23 -05:00
chagai95	e487d9fabc	a comma too much (#8771 ) Signed-off-by: Chagai Friedlander chagai95@gmail.com	2020-11-17 14:13:56 +00:00
Patrick Cloke	473dfec1e5	Use TYPE_CHECKING instead of magic MYPY variable. (#8770 )	2020-11-17 09:09:40 -05:00
Erik Johnston	f737368a26	Add admin API for logging in as a user (#8617 )	2020-11-17 10:51:25 +00:00
Richard van der Hoff	0ce31ef614	changelog	2020-11-16 18:24:08 +00:00
Richard van der Hoff	3dc1871219	Merge pull request #8757 from matrix-org/rav/pass_site_to_make_request Pass a Site into `make_request`	2020-11-16 18:22:24 +00:00
Richard van der Hoff	f125895475	Move `wait_until_result` into `FakeChannel` (#8758 ) FakeChannel has everything we need, and this more accurately models the real flow.	2020-11-16 18:21:47 +00:00
Andrew Morgan	4f76eef0e8	Generalise _locally_reject_invite (#8751 ) `_locally_reject_invite` generates an out-of-band membership event which can be passed to clients, but not other homeservers. This is used when we fail to reject an invite over federation. If this happens, we instead just generate a leave event locally and send it down /sync, allowing clients to reject invites even if we can't reach the remote homeserver. A similar flow needs to be put in place for rescinding knocks. If we're unable to contact any remote server from the room we've tried to knock on, we'd still like to generate and store the leave event locally. Hence the need to reuse, and thus generalise, this method. Separated from #6739.	2020-11-16 15:37:36 +00:00
Richard van der Hoff	bebfb9a97b	Merge branch 'develop' into rav/pass_site_to_make_request	2020-11-16 15:22:40 +00:00
Richard van der Hoff	791d7cd6f0	Rename `create_test_json_resource` to `create_test_resource` (#8759 ) The root resource isn't necessarily a JsonResource, so rename this method accordingly, and update a couple of test classes to use the method rather than directly manipulating self.resource.	2020-11-16 14:45:52 +00:00
Richard van der Hoff	ebc405446e	Add a `custom_headers` param to `make_request` (#8760 ) Some tests want to set some custom HTTP request headers, so provide a way to do that before calling requestReceived().	2020-11-16 14:45:22 +00:00
Richard van der Hoff	0d33c53534	changelog	2020-11-15 23:09:03 +00:00
Adrian Wannenmacher	f1de4bb58b	Clarify the usecase for an msisdn delegate (#8734 ) Signed-off-by: Adrian Wannenmacher <tfld@tfld.dev>	2020-11-14 23:09:36 +00:00
Andrew Morgan	e8d0853739	Generalise _maybe_store_room_on_invite (#8754 ) There's a handy function called maybe_store_room_on_invite which allows us to create an entry in the rooms table for a room and its version for which we aren't joined to yet, but we can reference when ingesting events about. This is currently used for invites where we receive some stripped state about the room and pass it down via /sync to the client, without us being in the room yet. There is a similar requirement for knocking, where we will eventually do the same thing, and need an entry in the rooms table as well. Thus, reusing this function works, however its name needs to be generalised a bit. Separated out from #6739.	2020-11-13 16:24:04 +00:00
Erik Johnston	4a54b821bb	1.23.0rc1	2020-11-13 13:59:58 +00:00
Dirk Klimpel	023f791143	Migrate documentation `docs/admin_api/event_reports` to markdown (#8742 ) Related to #8714. `event_reports.rst` was introduced in Synapse 1.21.0.	2020-11-13 13:57:55 +00:00
Marcus Schopen	68fc0dcb5a	SAML: add <mdui:UIInfo> element examples (#8718 ) add some mdui:UIInfo element examples for saml2_config in homeserver.yaml	2020-11-13 12:07:50 +00:00
chagai95	69147ed158	Updating README.rst (#8746 ) Minor corrections and advice... Should help beginners.	2020-11-13 12:07:09 +00:00
Erik Johnston	427ede619f	Add metrics for tracking 3PID /requestToken requests. (#8712 ) The main use case is to see how many requests are being made, and how many are second/third/etc attempts. If there are large number of retries then that likely indicates a delivery problem.	2020-11-13 12:03:51 +00:00
Erik Johnston	1b15a3d92c	Fix port script so that it can be run again after failure. (#8755 ) If the script fails (or is CTRL-C'ed) between porting some of the events table and copying of the sequences then the port script will immediately die if run again due to the postgres DB having inconsistencies between sequences and tables. The fix is to move the porting of sequences to before porting the tables, so that there is never a period where the Postgres DB is inconsistent. To do that we need to change how we port the sequences so that it calculates the values from the SQLite DB rather than the Postgres DB. Fixes #8619	2020-11-13 11:53:51 +00:00
Erik Johnston	4cb00d297f	Cache event ID to auth event IDs lookups (#8752 ) This should hopefully speed up `get_auth_chain_difference` a bit in the case of repeated state res on the same rooms. `get_auth_chain_difference` does a breadth first walk of the auth graphs by repeatedly looking up events' auth events. Different state resolutions on the same room will end up doing a lot of the same event to auth events lookups, so by caching them we should speed things up in cases of repeated state resolutions on the same room.	2020-11-13 11:29:18 +00:00
Erik Johnston	c2d4467cd4	Enable reconnection in DB pool (#8726 ) `adbapi.ConnectionPool` let's you turn on auto reconnect of DB connections. This is off by default. As far as I can tell if its not enabled dead connections never get removed from the pool. Maybe helps #8574	2020-11-12 14:26:24 +00:00
Erik Johnston	41a389934e	Fix port script fails when DB has no backfilled events. (#8729 ) Fixes #8618	2020-11-11 15:08:03 +00:00
Erik Johnston	5829872bec	Fix port script to handle foreign key constraints (#8730 )	2020-11-11 15:07:34 +00:00
Will Hunt	89700dfb8c	Check support room has only two users before sending a notice (#8728 ) * Check support room has only two users * Create 8728.bugfix * Update synapse/server_notices/server_notices_manager.py Co-authored-by: Erik Johnston <erik@matrix.org> Co-authored-by: Erik Johnston <erik@matrix.org>	2020-11-11 14:23:16 +00:00
Andrew Morgan	eedaf90c84	Better error message when a remote resource uses invalid Content-Type (#8719 )	2020-11-11 14:22:40 +00:00
Nicolai Søborg	4c7587ef99	Catch exceptions in password_providers (#8636 ) Signed-off-by: Nicolai Søborg <git@xn--sb-lka.org>	2020-11-11 13:24:53 +00:00
Marcus Schopen	c059413001	Notes on SSO logins and media_repository worker (#8701 ) If SSO login is used (e.g. SAML) in a multi worker setup, it should be mentioned that currently all SAML logins must run on the same worker, see https://github.com/matrix-org/synapse/issues/7530 Also, if you are using different ports (for example 443 and 8448) in a reverse proxy for client and federation, the path `/_matrix/media` on the client and federation port must point to the listener of the `media_repository` worker, otherwise you'll get a 404 on the federation port for the path `/_matrix/media`, if a remote server is trying to get the media object on federation port, see https://github.com/matrix-org/synapse/issues/8695	2020-11-06 14:33:07 +00:00
Andrew Morgan	2a6b685294	Add documentation about documentation to CONTRIBUTING.md (#8714 ) This PR adds some documentation that: * Describes who the audience for the `docs/`, `docs/dev/` and `docs/admin/` directories are, as well as Synapse's wiki page. * Stresses that we'd like all documentation to be down in markdown.	2020-11-06 11:59:22 +00:00
Richard van der Hoff	fb56dfdccd	Fix SIGHUP handler (#8697 ) Fixes: ``` builtins.TypeError: _reload_logging_config() takes 1 positional argument but 2 were given ```	2020-11-06 11:42:07 +00:00
Dirk Klimpel	c3119d1536	Add an admin API for users' media statistics (#8700 ) Add `GET /_synapse/admin/v1/statistics/users/media` to get statisics about local media usage by users. Related to #6094 It is the first API for statistics. Goal is to avoid/reduce usage of sql queries like [Wiki analyzing Synapse](https://github.com/matrix-org/synapse/wiki/SQL-for-analyzing-Synapse-PostgreSQL-database-stats) Signed-off-by: Dirk Klimpel dirk@klimpel.org	2020-11-05 18:59:12 +00:00
Dirk Klimpel	e4676bd877	Add `displayname` to Shared-Secret Registration for admins (#8722 ) Add `displayname` to Shared-Secret Registration for admins to `POST /_synapse/admin/v1/register`	2020-11-05 13:55:45 +00:00
Andrew Morgan	6abb1ad0be	Consolidate purge table lists to prevent desyncronisation (#8713 ) I idly noticed that these lists were out of sync with each other, causing us to miss a table in a test case (`local_invites`). Let's consolidate this list instead to prevent this from happening in the future.	2020-11-04 11:26:05 +00:00
Dirk Klimpel	4fda58ddd2	Remove the "draft" status of the Room Details Admin API (#8702 ) Fixes #8550	2020-11-03 12:48:25 +00:00
Erik Johnston	243d427fbc	Block clients from sending server ACLs that lock the local server out. (#8708 ) Fixes #4042	2020-11-03 12:13:48 +00:00
Erik Johnston	4b09b7438e	Document how to set up multiple event persisters (#8706 )	2020-11-03 10:27:11 +00:00
Andrew Morgan	e89bd3ea92	Improve error messages of non-str displayname/avatar_url (#8705 ) This PR fixes two things: * Corrects the copy/paste error of telling the client their displayname is wrong when they are submitting an `avatar_url`. * Returns a `M_INVALID_PARAM` instead of `M_UNKNOWN` for non-str type parameters. Reported by @t3chguy.	2020-11-02 18:01:09 +00:00
David Baker	59cc2472b3	Add base pushrule to notify for jitsi conferences (#8286 ) This could be customised to trigger a different kind of notification in the future, but for now it's a normal non-highlight one.	2020-11-02 16:36:14 +00:00
Dan Callahan	ca39e67f3d	Use Python 3.8 in Docker images by default (#8698 ) This bumps us closer to current Python without going all the way to 3.9. Fixes #8674 Signed-off-by: Dan Callahan <danc@element.io>	2020-11-02 16:33:06 +00:00
Erik Johnston	1eb9de90c0	Improve start time by adding index to e2e_cross_signing_keys (#8694 ) We do a `SELECT MAX(stream_id) FROM e2e_cross_signing_keys` on startup.	2020-11-02 13:55:56 +00:00
Brendan Abolivier	7a0fd6f98d	Fix error handling around when completing an AS transaction (#8693 )	2020-10-30 16:50:48 +00:00
Erik Johnston	f27a789697	Merge branch 'master' into develop	2020-10-30 16:27:02 +00:00
Erik Johnston	b4289795ea	1.22.1	2020-10-30 15:25:44 +00:00
Richard van der Hoff	90c900a8ff	Merge pull request #8678 from matrix-org/rav/fix_frozen_events Fix serialisation errors when using third-party event rules.	2020-10-30 15:24:10 +00:00
Will Hunt	b37aa1643b	Tie together matches_user_in_member_list and get_users_in_room caches (#8676 ) * Tie together matches_user_in_member_list and get_users_in_room * changelog * Remove type to fix mypy * Add `on_invalidate` to the function signature in the hopes that may make things work well * Remove *kwargs Update 8676.bugfix	2020-10-30 15:23:16 +00:00
Patrick Cloke	8f1aefa694	Improve the sample config for SSO (OIDC, SAML, and CAS). (#8635 )	2020-10-30 10:01:59 -04:00
Richard van der Hoff	cbc82aa09f	Implement and use an @lru_cache decorator (#8595 ) We don't always need the full power of a DeferredCache.	2020-10-30 11:43:17 +00:00
Patrick Cloke	fd7c743445	Fail test cases if they fail to await all awaitables (#8690 )	2020-10-30 07:15:07 -04:00
Erik Johnston	46f4be94b4	Fix race for concurrent downloads of remote media. (#8682 ) Fixes #6755	2020-10-30 10:55:24 +00:00
Andrew Morgan	4504151546	Fix optional parameter in stripped state storage method (#8688 ) Missed in #8671.	2020-10-30 00:22:31 +00:00
Erik Johnston	ef2d627015	Fix unit tests (#8689 ) * Fix unit tests * Newsfile	2020-10-29 18:21:49 +00:00
Will Hunt	70269fbd18	Tie together matches_user_in_member_list and get_users_in_room caches (#8676 ) * Tie together matches_user_in_member_list and get_users_in_room * changelog * Remove type to fix mypy * Add `on_invalidate` to the function signature in the hopes that may make things work well * Remove *kwargs Update 8676.bugfix	2020-10-29 16:58:16 +00:00
Patrick Cloke	8b42a4eefd	Gracefully handle a pending logging connection during shutdown. (#8685 )	2020-10-29 12:53:57 -04:00
Erik Johnston	f21e24ffc2	Add ability for access tokens to belong to one user but grant access to another user. (#8616 ) We do it this way round so that only the "owner" can delete the access token (i.e. `/logout/all` by the "owner" also deletes that token, but `/logout/all` by the "target user" doesn't). A future PR will add an API for creating such a token. When the target user and authenticated entity are different the `Processed request` log line will be logged with a: `{@admin:server as @bob:server} ...`. I'm not convinced by that format (especially since it adds spaces in there, making it harder to use `cut -d ' '` to chop off the start of log lines). Suggestions welcome.	2020-10-29 15:58:44 +00:00
Erik Johnston	22eeb6bc54	Fix cache call signature to accept `on_invalidate`. (#8684 ) Cached functions accept an `on_invalidate` function, which we failed to add to the type signature. It's rarely used in the files that we have typed, which is why we haven't noticed it before.	2020-10-29 15:18:17 +00:00
Richard van der Hoff	0073fe914a	Use `%r` rather than `%s` for stringifying events (#8679 ) otherwise non-state events get written as `<FrozenEvent ... state_key='None'>` which is indistinguishable from state events with the actual state_key `None`.	2020-10-29 12:16:49 +00:00
Richard van der Hoff	56f0ee78a9	Optimise createRoom with multiple invites (#8559 ) By not dropping the membership lock between invites, we can stop joins from grabbing the lock when we're half-done and slowing the whole thing down.	2020-10-29 11:48:39 +00:00
Patrick Cloke	00b24aa545	Support generating structured logs in addition to standard logs. (#8607 ) This modifies the configuration of structured logging to be usable from the standard Python logging configuration. This also separates the formatting of logs from the transport allowing JSON logs to files or standard logs to sockets.	2020-10-29 07:27:37 -04:00
Erik Johnston	9a7e0d2ea6	Don't require hiredis to run unit tests (#8680 )	2020-10-29 11:17:35 +00:00
Richard van der Hoff	c97da1e45d	Merge pull request #8678 from matrix-org/rav/fix_frozen_events Fix serialisation errors when using third-party event rules.	2020-10-28 20:41:42 +00:00
Richard van der Hoff	b6ca69e4f1	Remove frozendict_json_encoder and support frozendicts everywhere Not being able to serialise `frozendicts` is fragile, and it's annoying to have to think about which serialiser you want. There's no real downside to supporting frozendicts, so let's just have one json encoder.	2020-10-28 15:56:57 +00:00
Patrick Cloke	31d721fbf6	Add type hints to application services. (#8655 )	2020-10-28 11:12:21 -04:00
Dirk Klimpel	2239813278	Add an admin APIs to allow server admins to list users' pushers (#8610 ) Add an admin API `GET /_synapse/admin/v1/users/<user_id>/pushers` like https://matrix.org/docs/spec/client_server/latest#get-matrix-client-r0-pushers	2020-10-28 15:02:42 +00:00
kleph	29ce6d43b5	Run mypy as part of the lint.sh script. (#8633 )	2020-10-28 08:49:08 -04:00
Erik Johnston	a6ea1a957e	Don't pull event from DB when handling replication traffic. (#8669 ) I was trying to make it so that we didn't have to start a background task when handling RDATA, but that is a bigger job (due to all the code in `generic_worker`). However I still think not pulling the event from the DB may help reduce some DB usage due to replication, even if most workers will simply go and pull that event from the DB later anyway. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2020-10-28 12:11:45 +00:00
Dan Callahan	aff1eb7c67	Tell Black to format code for Python 3.5 (#8664 ) This allows trailing commas in multi-line arg lists. Minor, but we might as well keep our formatting current with regard to our minimum supported Python version. Signed-off-by: Dan Callahan <danc@element.io>	2020-10-27 23:26:36 +00:00
Dan Callahan	e90fad5cba	Minor updates to docs on how to run tests (#8666 ) The test runner isn't present in the `[all]` set of extras, so the previous instructions did not work without also installing `[test]`. Note that this does not include the `[lint]` extras, since those do not install on all supported Python versions (specifically, isort 5.x requires Python 3.6, while we still support 3.5). Instructions for that are included in our pull request template, so we should be fine there. I've also dropped the `--no-use-pep517` arg to `pip install` since it seems to have been added to address a temporary regression in pip 19.1 which was fixed in pip 19.1.1 the following month. Lastly, updated the example output of the test suite to set more realistic expectations around run time. Signed-off-by: Dan Callahan <danc@element.io>	2020-10-27 23:26:00 +00:00
Dan Callahan	88e1d0c52b	Note support for Python 3.9 (#8665 ) As expected, all tests pass locally without modification. Signed-off-by: Dan Callahan <danc@element.io>	2020-10-27 23:24:33 +00:00
Michael Kaye	f49c2093b5	Cross-link documentation to the prometheus recording rules. (#8667 )	2020-10-27 15:29:50 -04:00
Andrew Morgan	a699c044b6	Abstract code for stripping room state into a separate method (#8671 ) This is a requirement for [knocking](https://github.com/matrix-org/synapse/pull/6739), and is abstracting some code that was originally used by the invite flow. I'm separating it out into this PR as it's a fairly contained change. For a bit of context: when you invite a user to a room, you send them [stripped state events](https://matrix.org/docs/spec/server_server/unstable#put-matrix-federation-v2-invite-roomid-eventid) as part of `invite_room_state`. This is so that their client can display useful information such as the room name and avatar. The same requirement applies to knocking, as it would be nice for clients to be able to display a list of rooms you've knocked on - room name and avatar included. The reason we're sending membership events down as well is in the case that you are invited to a room that does not have an avatar or name set. In that case, the client should use the displayname/avatar of the inviter. That information is located in the inviter's membership event. This is optional as knocks don't really have any user in the room to link up to. When you knock on a room, your knock is sent by you and inserted into the room. It wouldn't really make sense to show the avatar of a random user - plus it'd be a data leak. So I've opted not to send membership events to the client here. The UX on the client for when you knock on a room without a name/avatar is a separate problem. In essence this is just moving some inline code to a reusable store method.	2020-10-27 18:42:46 +00:00
Erik Johnston	4215a3acd4	Don't unnecessarily start bg process in replication sending loop. (#8670 )	2020-10-27 17:37:08 +00:00
Erik Johnston	0c7f9cb81f	Don't unnecessarily start bg process while handling typing. (#8668 ) There's no point starting a background process when all its going to do is bail if federation isn't enabled.	2020-10-27 15:32:19 +00:00
Dirk Klimpel	9b7c28283a	Add admin API to list users' local media (#8647 ) Add admin API `GET /_synapse/admin/v1/users/<user_id>/media` to get information of users' uploaded files.	2020-10-27 14:12:31 +00:00
Jonas Jelten	2e380f0f18	e2e: ensure we have both master and self-signing key (#8455 ) it seems to be possible that only one of them ends up to be cached. when this was the case, the missing one was not fetched via federation, and clients then failed to validate cross-signed devices. Signed-off-by: Jonas Jelten <jj@sft.lol>	2020-10-26 18:37:47 +00:00
Patrick Cloke	10f45d85bb	Add type hints for account validity handler (#8620 ) This also fixes a bug by fixing handling of an account which doesn't expire.	2020-10-26 14:17:31 -04:00
Dirk Klimpel	66e6801c3e	Split admin API for reported events into a detail and a list view (#8539 ) Split admin API for reported events in detail und list view. API was introduced with #8217 in synapse v.1.21.0. It makes the list (`GET /_synapse/admin/v1/event_reports`) less complex and provides a better overview. The details can be queried with: `GET /_synapse/admin/v1/event_reports/<report_id>`. It is similar to room and users API. It is a kind of regression in `GET /_synapse/admin/v1/event_reports`. `event_json` was removed. But the api was introduced one version before and it is an admin API (not under spec). Signed-off-by: Dirk Klimpel dirk@klimpel.org	2020-10-26 18:16:37 +00:00
Peter Krantz	6c9ab61df5	Added basic instructions for Azure AD to OpenId documentation (#8582 ) Signed-off-by: Peter Krantz peter.krantz@gmail.com	2020-10-26 17:49:55 +00:00
Dirk Klimpel	49d72dea2a	Add an admin api to delete local media. (#8519 ) Related to: #6459, #3479 Add `DELETE /_synapse/admin/v1/media/<server_name>/<media_id>` to delete a single file from server.	2020-10-26 17:02:28 +00:00
Andrew Morgan	f6a3859a73	Fix filepath of Dex example config (#8657 )	2020-10-26 16:53:11 +00:00
Dirk Klimpel	4ac3a8c5dc	Fix a bug in the joined_rooms admin API (#8643 ) If the user was not in any rooms then the API returned the same error as if the user did not exist.	2020-10-26 12:25:48 -04:00
Erik Johnston	cf9a17a2b3	Synapse 1.22.0rc2 (2020-10-26) ============================== Bugfixes -------- - Fix bugs where ephemeral events were not sent to appservices. Broke in v1.22.0rc1. ([\#8648](https://github.com/matrix-org/synapse/issues/8648), [\#8656](https://github.com/matrix-org/synapse/issues/8656)) - Fix `user_daily_visits` table to not have duplicate rows per user/device due to multiple user agents. Broke in v1.22.0rc1. ([\#8654](https://github.com/matrix-org/synapse/issues/8654)) -----BEGIN PGP SIGNATURE----- iQFEBAABCgAuFiEEBTGR3/RnAzBGUif3pULk7RsPrAkFAl+W6QIQHGVyaWtAbWF0 cml4Lm9yZwAKCRClQuTtGw+sCR/EB/9Afs/QiqD7uJ7XtAASwlOxcpSrvB6xSMzU VIiYLrUSCvHe8SwcPG6nToy69hHmwLBPu9e8gvlQkOY4nJpW9VTGvhFcP5eCgeKd vDp+elVD6BPg+6S3RaI/F5hyQ7gn9qZ/WexkVixDkVs5eAL3gNlZcjw9RwaT9ei9 fEOYlMi1CRSRzKVBPMEFCAvOpJJ8rA/iq4JK7+P0TplkhD+HydG0cYr6OoL7CmaD L/au565Ynp6o0hSpNpTFqW6C5W5JRvz/TyG9/N95h9+WqubZzsPPDUzh98B3eBoX 43Wu9Qoc3mNamf0++HbHGUPI8dRV1gssxL01hs/iLUZz7CxXY+Ir =Z3sQ -----END PGP SIGNATURE----- Merge tag 'v1.22.0rc2' into develop Synapse 1.22.0rc2 (2020-10-26) ============================== Bugfixes -------- - Fix bugs where ephemeral events were not sent to appservices. Broke in v1.22.0rc1. ([\#8648](https://github.com/matrix-org/synapse/issues/8648), [\#8656](https://github.com/matrix-org/synapse/issues/8656)) - Fix `user_daily_visits` table to not have duplicate rows per user/device due to multiple user agents. Broke in v1.22.0rc1. ([\#8654](https://github.com/matrix-org/synapse/issues/8654))	2020-10-26 15:23:13 +00:00
Erik Johnston	7a3adbd7af	1.22.0rc2	2020-10-26 15:11:03 +00:00
Erik Johnston	ff7f0e8a14	Merge branch 'release-v1.22.0' into develop	2020-10-26 15:02:55 +00:00
Will Hunt	9e0f5a0ac4	Fix get\|set_type_stream_id_for_appservice store functions (#8648 )	2020-10-26 15:00:56 +00:00
Will Hunt	e8dbbcb64c	Fix get\|set_type_stream_id_for_appservice store functions (#8648 )	2020-10-26 10:51:33 -04:00
Andrew Morgan	73d8209694	Correct the package name in OpenID Connect install instructions (#8634 ) The OpenID Connect install instructions suggested installing `synapse[oidc]`, but our PyPI package is called `matrix-synapse`.	2020-10-26 14:45:33 +00:00
Dirk Klimpel	913f8a06e4	Add field `total` to device list in admin API (#8644 )	2020-10-26 14:07:51 +00:00
LEdoian	7b13780c54	Check status codes that profile handler returns (#8580 ) Fixes #8520 Signed-off-by: Pavel Turinsky <pavel.turinsky@matfyz.cz> Co-authored-by: Erik Johnston <erikj@jki.re>	2020-10-26 13:55:21 +00:00
Patrick Cloke	5eda018561	Properly handle presence events for application services. (#8656 )	2020-10-26 09:19:07 -04:00
Erik Johnston	437a99fb99	Fix user_daily_visits to not have duplicate rows for UA. (#8654 ) * Fix user_daily_visits to not have duplicate rows for UA. Fixes #8641. * Newsfile * Fix typo. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2020-10-26 13:16:32 +00:00
Erik Johnston	2b7c180879	Start fewer opentracing spans (#8640 ) #8567 started a span for every background process. This is good as it means all Synapse code that gets run should be in a span (unless in the sentinel logging context), but it means we generate about 15x the number of spans as we did previously. This PR attempts to reduce that number by a) not starting one for send commands to Redis, and b) deferring starting background processes until after we're sure they're necessary. I don't really know how much this will help.	2020-10-26 09:30:19 +00:00
Patrick Cloke	34a5696f93	Fix typos and spelling errors. (#8639 )	2020-10-23 12:38:40 -04:00
Erik Johnston	c850dd9a8e	Fix handling of User-Agent headers with bad utf-8. (#8632 )	2020-10-23 17:12:59 +01:00
Erik Johnston	db9ef792f0	Fix email notifications for invites without local state. (#8627 ) This can happen if e.g. the room invited into is no longer on the server (or if all users left the room).	2020-10-23 10:41:32 +01:00
Andrew Morgan	f28756bb40	Changelog	2020-10-22 18:33:02 +01:00
Erik Johnston	054a6b9538	Synapse 1.22.0rc1 (2020-10-22) ============================== Features -------- - Add a configuration option for always using the "userinfo endpoint" for OpenID Connect. This fixes support for some identity providers, e.g. GitLab. Contributed by Benjamin Koch. ([\#7658](https://github.com/matrix-org/synapse/issues/7658)) - Add ability for `ThirdPartyEventRules` modules to query and manipulate whether a room is in the public rooms directory. ([\#8292](https://github.com/matrix-org/synapse/issues/8292), [\#8467](https://github.com/matrix-org/synapse/issues/8467)) - Add support for olm fallback keys ([MSC2732](https://github.com/matrix-org/matrix-doc/pull/2732)). ([\#8312](https://github.com/matrix-org/synapse/issues/8312), [\#8501](https://github.com/matrix-org/synapse/issues/8501)) - Add support for running background tasks in a separate worker process. ([\#8369](https://github.com/matrix-org/synapse/issues/8369), [\#8458](https://github.com/matrix-org/synapse/issues/8458), [\#8489](https://github.com/matrix-org/synapse/issues/8489), [\#8513](https://github.com/matrix-org/synapse/issues/8513), [\#8544](https://github.com/matrix-org/synapse/issues/8544), [\#8599](https://github.com/matrix-org/synapse/issues/8599)) - Add support for device dehydration ([MSC2697](https://github.com/matrix-org/matrix-doc/pull/2697)). ([\#8380](https://github.com/matrix-org/synapse/issues/8380)) - Add support for [MSC2409](https://github.com/matrix-org/matrix-doc/pull/2409), which allows sending typing, read receipts, and presence events to appservices. ([\#8437](https://github.com/matrix-org/synapse/issues/8437), [\#8590](https://github.com/matrix-org/synapse/issues/8590)) - Change default room version to "6", per [MSC2788](https://github.com/matrix-org/matrix-doc/pull/2788). ([\#8461](https://github.com/matrix-org/synapse/issues/8461)) - Add the ability to send non-membership events into a room via the `ModuleApi`. ([\#8479](https://github.com/matrix-org/synapse/issues/8479)) - Increase default upload size limit from 10M to 50M. Contributed by @Akkowicz. ([\#8502](https://github.com/matrix-org/synapse/issues/8502)) - Add support for modifying event content in `ThirdPartyRules` modules. ([\#8535](https://github.com/matrix-org/synapse/issues/8535), [\#8564](https://github.com/matrix-org/synapse/issues/8564)) Bugfixes -------- - Fix a longstanding bug where invalid ignored users in account data could break clients. ([\#8454](https://github.com/matrix-org/synapse/issues/8454)) - Fix a bug where backfilling a room with an event that was missing the `redacts` field would break. ([\#8457](https://github.com/matrix-org/synapse/issues/8457)) - Don't attempt to respond to some requests if the client has already disconnected. ([\#8465](https://github.com/matrix-org/synapse/issues/8465)) - Fix message duplication if something goes wrong after persisting the event. ([\#8476](https://github.com/matrix-org/synapse/issues/8476)) - Fix incremental sync returning an incorrect `prev_batch` token in timeline section, which when used to paginate returned events that were included in the incremental sync. Broken since v0.16.0. ([\#8486](https://github.com/matrix-org/synapse/issues/8486)) - Expose the `uk.half-shot.msc2778.login.application_service` to clients from the login API. This feature was added in v1.21.0, but was not exposed as a potential login flow. ([\#8504](https://github.com/matrix-org/synapse/issues/8504)) - Fix error code for `/profile/{userId}/displayname` to be `M_BAD_JSON`. ([\#8517](https://github.com/matrix-org/synapse/issues/8517)) - Fix a bug introduced in v1.7.0 that could cause Synapse to insert values from non-state `m.room.retention` events into the `room_retention` database table. ([\#8527](https://github.com/matrix-org/synapse/issues/8527)) - Fix not sending events over federation when using sharded event writers. ([\#8536](https://github.com/matrix-org/synapse/issues/8536)) - Fix a long standing bug where email notifications for encrypted messages were blank. ([\#8545](https://github.com/matrix-org/synapse/issues/8545)) - Fix increase in the number of `There was no active span...` errors logged when using OpenTracing. ([\#8567](https://github.com/matrix-org/synapse/issues/8567)) - Fix a bug that prevented errors encountered during execution of the `synapse_port_db` from being correctly printed. ([\#8585](https://github.com/matrix-org/synapse/issues/8585)) - Fix appservice transactions to only include a maximum of 100 persistent and 100 ephemeral events. ([\#8606](https://github.com/matrix-org/synapse/issues/8606)) Updates to the Docker image --------------------------- - Added multi-arch support (arm64,arm/v7) for the docker images. Contributed by @maquis196. ([\#7921](https://github.com/matrix-org/synapse/issues/7921)) - Add support for passing commandline args to the synapse process. Contributed by @samuel-p. ([\#8390](https://github.com/matrix-org/synapse/issues/8390)) Improved Documentation ---------------------- - Update the directions for using the manhole with coroutines. ([\#8462](https://github.com/matrix-org/synapse/issues/8462)) - Improve readme by adding new shield.io badges. ([\#8493](https://github.com/matrix-org/synapse/issues/8493)) - Added note about docker in manhole.md regarding which ip address to bind to. Contributed by @Maquis196. ([\#8526](https://github.com/matrix-org/synapse/issues/8526)) - Document the new behaviour of the `allowed_lifetime_min` and `allowed_lifetime_max` settings in the room retention configuration. ([\#8529](https://github.com/matrix-org/synapse/issues/8529)) Deprecations and Removals ------------------------- - Drop unused `device_max_stream_id` table. ([\#8589](https://github.com/matrix-org/synapse/issues/8589)) Internal Changes ---------------- - Check for unreachable code with mypy. ([\#8432](https://github.com/matrix-org/synapse/issues/8432)) - Add unit test for event persister sharding. ([\#8433](https://github.com/matrix-org/synapse/issues/8433)) - Allow events to be sent to clients sooner when using sharded event persisters. ([\#8439](https://github.com/matrix-org/synapse/issues/8439), [\#8488](https://github.com/matrix-org/synapse/issues/8488), [\#8496](https://github.com/matrix-org/synapse/issues/8496), [\#8499](https://github.com/matrix-org/synapse/issues/8499)) - Configure `public_baseurl` when using demo scripts. ([\#8443](https://github.com/matrix-org/synapse/issues/8443)) - Add SQL logging on queries that happen during startup. ([\#8448](https://github.com/matrix-org/synapse/issues/8448)) - Speed up unit tests when using PostgreSQL. ([\#8450](https://github.com/matrix-org/synapse/issues/8450)) - Remove redundant database loads of stream_ordering for events we already have. ([\#8452](https://github.com/matrix-org/synapse/issues/8452)) - Reduce inconsistencies between codepaths for membership and non-membership events. ([\#8463](https://github.com/matrix-org/synapse/issues/8463)) - Combine `SpamCheckerApi` with the more generic `ModuleApi`. ([\#8464](https://github.com/matrix-org/synapse/issues/8464)) - Additional testing for `ThirdPartyEventRules`. ([\#8468](https://github.com/matrix-org/synapse/issues/8468)) - Add `-d` option to `./scripts-dev/lint.sh` to lint files that have changed since the last git commit. ([\#8472](https://github.com/matrix-org/synapse/issues/8472)) - Unblacklist some sytests. ([\#8474](https://github.com/matrix-org/synapse/issues/8474)) - Include the log level in the phone home stats. ([\#8477](https://github.com/matrix-org/synapse/issues/8477)) - Remove outdated sphinx documentation, scripts and configuration. ([\#8480](https://github.com/matrix-org/synapse/issues/8480)) - Clarify error message when plugin config parsers raise an error. ([\#8492](https://github.com/matrix-org/synapse/issues/8492)) - Remove the deprecated `Handlers` object. ([\#8494](https://github.com/matrix-org/synapse/issues/8494)) - Fix a threadsafety bug in unit tests. ([\#8497](https://github.com/matrix-org/synapse/issues/8497)) - Add user agent to user_daily_visits table. ([\#8503](https://github.com/matrix-org/synapse/issues/8503)) - Add type hints to various parts of the code base. ([\#8407](https://github.com/matrix-org/synapse/issues/8407), [\#8505](https://github.com/matrix-org/synapse/issues/8505), [\#8507](https://github.com/matrix-org/synapse/issues/8507), [\#8547](https://github.com/matrix-org/synapse/issues/8547), [\#8562](https://github.com/matrix-org/synapse/issues/8562), [\#8609](https://github.com/matrix-org/synapse/issues/8609)) - Remove unused code from the test framework. ([\#8514](https://github.com/matrix-org/synapse/issues/8514)) - Apply some internal fixes to the `HomeServer` class to make its code more idiomatic and statically-verifiable. ([\#8515](https://github.com/matrix-org/synapse/issues/8515)) - Factor out common code between `RoomMemberHandler._locally_reject_invite` and `EventCreationHandler.create_event`. ([\#8537](https://github.com/matrix-org/synapse/issues/8537)) - Improve database performance by executing more queries without starting transactions. ([\#8542](https://github.com/matrix-org/synapse/issues/8542)) - Rename `Cache` to `DeferredCache`, to better reflect its purpose. ([\#8548](https://github.com/matrix-org/synapse/issues/8548)) - Move metric registration code down into `LruCache`. ([\#8561](https://github.com/matrix-org/synapse/issues/8561), [\#8591](https://github.com/matrix-org/synapse/issues/8591)) - Replace `DeferredCache` with the lighter-weight `LruCache` where possible. ([\#8563](https://github.com/matrix-org/synapse/issues/8563)) - Add virtualenv-generated folders to `.gitignore`. ([\#8566](https://github.com/matrix-org/synapse/issues/8566)) - Add `get_immediate` method to `DeferredCache`. ([\#8568](https://github.com/matrix-org/synapse/issues/8568)) - Fix mypy not properly checking across the codebase, additionally, fix a typing assertion error in `handlers/auth.py`. ([\#8569](https://github.com/matrix-org/synapse/issues/8569)) - Fix `synmark` benchmark runner. ([\#8571](https://github.com/matrix-org/synapse/issues/8571)) - Modify `DeferredCache.get()` to return `Deferred`s instead of `ObservableDeferred`s. ([\#8572](https://github.com/matrix-org/synapse/issues/8572)) - Adjust a protocol-type definition to fit `sqlite3` assertions. ([\#8577](https://github.com/matrix-org/synapse/issues/8577)) - Support macOS on the `synmark` benchmark runner. ([\#8578](https://github.com/matrix-org/synapse/issues/8578)) - Update `mypy` static type checker to 0.790. ([\#8583](https://github.com/matrix-org/synapse/issues/8583), [\#8600](https://github.com/matrix-org/synapse/issues/8600)) - Re-organize the structured logging code to separate the TCP transport handling from the JSON formatting. ([\#8587](https://github.com/matrix-org/synapse/issues/8587)) - Remove extraneous unittest logging decorators from unit tests. ([\#8592](https://github.com/matrix-org/synapse/issues/8592)) - Minor optimisations in caching code. ([\#8593](https://github.com/matrix-org/synapse/issues/8593), [\#8594](https://github.com/matrix-org/synapse/issues/8594)) -----BEGIN PGP SIGNATURE----- iQFEBAABCgAuFiEEBTGR3/RnAzBGUif3pULk7RsPrAkFAl+RfFAQHGVyaWtAbWF0 cml4Lm9yZwAKCRClQuTtGw+sCZI4CACibRDTo+DFIp787ZMErW0xFc3S8DOA6K4u G8J2GCrBT0pfWAi7jqfQO9GySlvS5ixqbWYxud9jG0elXtnVgjIcbToSCYvNFxzH TDaQAaOwFVe/7fhZG6TvO2EcAXYXNfoqQKwc8xvTOcBOhObfLAzchV6t7mRTRYE4 +C3kM8BUJUnSp+OAY0zxRrUIVjX4W280BQ/+UxvPBLIi0IUQz/BufvTtgEhRBb6B eK2qjDMTud3/WAzM/TYDoA/LmdAcFCogfkRRHYqDPw0gUIXm1tdHyLWdgHoV+WhX 6p/kacnKxqonKW5/UrqheYT8J0SMA1AlkSm2niy/K+Tde3Nga+Sw =TLb5 -----END PGP SIGNATURE----- Merge tag 'v1.22.0rc1' into develop Synapse 1.22.0rc1 (2020-10-22) ============================== Features -------- - Add a configuration option for always using the "userinfo endpoint" for OpenID Connect. This fixes support for some identity providers, e.g. GitLab. Contributed by Benjamin Koch. ([\#7658](https://github.com/matrix-org/synapse/issues/7658)) - Add ability for `ThirdPartyEventRules` modules to query and manipulate whether a room is in the public rooms directory. ([\#8292](https://github.com/matrix-org/synapse/issues/8292), [\#8467](https://github.com/matrix-org/synapse/issues/8467)) - Add support for olm fallback keys ([MSC2732](https://github.com/matrix-org/matrix-doc/pull/2732)). ([\#8312](https://github.com/matrix-org/synapse/issues/8312), [\#8501](https://github.com/matrix-org/synapse/issues/8501)) - Add support for running background tasks in a separate worker process. ([\#8369](https://github.com/matrix-org/synapse/issues/8369), [\#8458](https://github.com/matrix-org/synapse/issues/8458), [\#8489](https://github.com/matrix-org/synapse/issues/8489), [\#8513](https://github.com/matrix-org/synapse/issues/8513), [\#8544](https://github.com/matrix-org/synapse/issues/8544), [\#8599](https://github.com/matrix-org/synapse/issues/8599)) - Add support for device dehydration ([MSC2697](https://github.com/matrix-org/matrix-doc/pull/2697)). ([\#8380](https://github.com/matrix-org/synapse/issues/8380)) - Add support for [MSC2409](https://github.com/matrix-org/matrix-doc/pull/2409), which allows sending typing, read receipts, and presence events to appservices. ([\#8437](https://github.com/matrix-org/synapse/issues/8437), [\#8590](https://github.com/matrix-org/synapse/issues/8590)) - Change default room version to "6", per [MSC2788](https://github.com/matrix-org/matrix-doc/pull/2788). ([\#8461](https://github.com/matrix-org/synapse/issues/8461)) - Add the ability to send non-membership events into a room via the `ModuleApi`. ([\#8479](https://github.com/matrix-org/synapse/issues/8479)) - Increase default upload size limit from 10M to 50M. Contributed by @Akkowicz. ([\#8502](https://github.com/matrix-org/synapse/issues/8502)) - Add support for modifying event content in `ThirdPartyRules` modules. ([\#8535](https://github.com/matrix-org/synapse/issues/8535), [\#8564](https://github.com/matrix-org/synapse/issues/8564)) Bugfixes -------- - Fix a longstanding bug where invalid ignored users in account data could break clients. ([\#8454](https://github.com/matrix-org/synapse/issues/8454)) - Fix a bug where backfilling a room with an event that was missing the `redacts` field would break. ([\#8457](https://github.com/matrix-org/synapse/issues/8457)) - Don't attempt to respond to some requests if the client has already disconnected. ([\#8465](https://github.com/matrix-org/synapse/issues/8465)) - Fix message duplication if something goes wrong after persisting the event. ([\#8476](https://github.com/matrix-org/synapse/issues/8476)) - Fix incremental sync returning an incorrect `prev_batch` token in timeline section, which when used to paginate returned events that were included in the incremental sync. Broken since v0.16.0. ([\#8486](https://github.com/matrix-org/synapse/issues/8486)) - Expose the `uk.half-shot.msc2778.login.application_service` to clients from the login API. This feature was added in v1.21.0, but was not exposed as a potential login flow. ([\#8504](https://github.com/matrix-org/synapse/issues/8504)) - Fix error code for `/profile/{userId}/displayname` to be `M_BAD_JSON`. ([\#8517](https://github.com/matrix-org/synapse/issues/8517)) - Fix a bug introduced in v1.7.0 that could cause Synapse to insert values from non-state `m.room.retention` events into the `room_retention` database table. ([\#8527](https://github.com/matrix-org/synapse/issues/8527)) - Fix not sending events over federation when using sharded event writers. ([\#8536](https://github.com/matrix-org/synapse/issues/8536)) - Fix a long standing bug where email notifications for encrypted messages were blank. ([\#8545](https://github.com/matrix-org/synapse/issues/8545)) - Fix increase in the number of `There was no active span...` errors logged when using OpenTracing. ([\#8567](https://github.com/matrix-org/synapse/issues/8567)) - Fix a bug that prevented errors encountered during execution of the `synapse_port_db` from being correctly printed. ([\#8585](https://github.com/matrix-org/synapse/issues/8585)) - Fix appservice transactions to only include a maximum of 100 persistent and 100 ephemeral events. ([\#8606](https://github.com/matrix-org/synapse/issues/8606)) Updates to the Docker image --------------------------- - Added multi-arch support (arm64,arm/v7) for the docker images. Contributed by @maquis196. ([\#7921](https://github.com/matrix-org/synapse/issues/7921)) - Add support for passing commandline args to the synapse process. Contributed by @samuel-p. ([\#8390](https://github.com/matrix-org/synapse/issues/8390)) Improved Documentation ---------------------- - Update the directions for using the manhole with coroutines. ([\#8462](https://github.com/matrix-org/synapse/issues/8462)) - Improve readme by adding new shield.io badges. ([\#8493](https://github.com/matrix-org/synapse/issues/8493)) - Added note about docker in manhole.md regarding which ip address to bind to. Contributed by @Maquis196. ([\#8526](https://github.com/matrix-org/synapse/issues/8526)) - Document the new behaviour of the `allowed_lifetime_min` and `allowed_lifetime_max` settings in the room retention configuration. ([\#8529](https://github.com/matrix-org/synapse/issues/8529)) Deprecations and Removals ------------------------- - Drop unused `device_max_stream_id` table. ([\#8589](https://github.com/matrix-org/synapse/issues/8589)) Internal Changes ---------------- - Check for unreachable code with mypy. ([\#8432](https://github.com/matrix-org/synapse/issues/8432)) - Add unit test for event persister sharding. ([\#8433](https://github.com/matrix-org/synapse/issues/8433)) - Allow events to be sent to clients sooner when using sharded event persisters. ([\#8439](https://github.com/matrix-org/synapse/issues/8439), [\#8488](https://github.com/matrix-org/synapse/issues/8488), [\#8496](https://github.com/matrix-org/synapse/issues/8496), [\#8499](https://github.com/matrix-org/synapse/issues/8499)) - Configure `public_baseurl` when using demo scripts. ([\#8443](https://github.com/matrix-org/synapse/issues/8443)) - Add SQL logging on queries that happen during startup. ([\#8448](https://github.com/matrix-org/synapse/issues/8448)) - Speed up unit tests when using PostgreSQL. ([\#8450](https://github.com/matrix-org/synapse/issues/8450)) - Remove redundant database loads of stream_ordering for events we already have. ([\#8452](https://github.com/matrix-org/synapse/issues/8452)) - Reduce inconsistencies between codepaths for membership and non-membership events. ([\#8463](https://github.com/matrix-org/synapse/issues/8463)) - Combine `SpamCheckerApi` with the more generic `ModuleApi`. ([\#8464](https://github.com/matrix-org/synapse/issues/8464)) - Additional testing for `ThirdPartyEventRules`. ([\#8468](https://github.com/matrix-org/synapse/issues/8468)) - Add `-d` option to `./scripts-dev/lint.sh` to lint files that have changed since the last git commit. ([\#8472](https://github.com/matrix-org/synapse/issues/8472)) - Unblacklist some sytests. ([\#8474](https://github.com/matrix-org/synapse/issues/8474)) - Include the log level in the phone home stats. ([\#8477](https://github.com/matrix-org/synapse/issues/8477)) - Remove outdated sphinx documentation, scripts and configuration. ([\#8480](https://github.com/matrix-org/synapse/issues/8480)) - Clarify error message when plugin config parsers raise an error. ([\#8492](https://github.com/matrix-org/synapse/issues/8492)) - Remove the deprecated `Handlers` object. ([\#8494](https://github.com/matrix-org/synapse/issues/8494)) - Fix a threadsafety bug in unit tests. ([\#8497](https://github.com/matrix-org/synapse/issues/8497)) - Add user agent to user_daily_visits table. ([\#8503](https://github.com/matrix-org/synapse/issues/8503)) - Add type hints to various parts of the code base. ([\#8407](https://github.com/matrix-org/synapse/issues/8407), [\#8505](https://github.com/matrix-org/synapse/issues/8505), [\#8507](https://github.com/matrix-org/synapse/issues/8507), [\#8547](https://github.com/matrix-org/synapse/issues/8547), [\#8562](https://github.com/matrix-org/synapse/issues/8562), [\#8609](https://github.com/matrix-org/synapse/issues/8609)) - Remove unused code from the test framework. ([\#8514](https://github.com/matrix-org/synapse/issues/8514)) - Apply some internal fixes to the `HomeServer` class to make its code more idiomatic and statically-verifiable. ([\#8515](https://github.com/matrix-org/synapse/issues/8515)) - Factor out common code between `RoomMemberHandler._locally_reject_invite` and `EventCreationHandler.create_event`. ([\#8537](https://github.com/matrix-org/synapse/issues/8537)) - Improve database performance by executing more queries without starting transactions. ([\#8542](https://github.com/matrix-org/synapse/issues/8542)) - Rename `Cache` to `DeferredCache`, to better reflect its purpose. ([\#8548](https://github.com/matrix-org/synapse/issues/8548)) - Move metric registration code down into `LruCache`. ([\#8561](https://github.com/matrix-org/synapse/issues/8561), [\#8591](https://github.com/matrix-org/synapse/issues/8591)) - Replace `DeferredCache` with the lighter-weight `LruCache` where possible. ([\#8563](https://github.com/matrix-org/synapse/issues/8563)) - Add virtualenv-generated folders to `.gitignore`. ([\#8566](https://github.com/matrix-org/synapse/issues/8566)) - Add `get_immediate` method to `DeferredCache`. ([\#8568](https://github.com/matrix-org/synapse/issues/8568)) - Fix mypy not properly checking across the codebase, additionally, fix a typing assertion error in `handlers/auth.py`. ([\#8569](https://github.com/matrix-org/synapse/issues/8569)) - Fix `synmark` benchmark runner. ([\#8571](https://github.com/matrix-org/synapse/issues/8571)) - Modify `DeferredCache.get()` to return `Deferred`s instead of `ObservableDeferred`s. ([\#8572](https://github.com/matrix-org/synapse/issues/8572)) - Adjust a protocol-type definition to fit `sqlite3` assertions. ([\#8577](https://github.com/matrix-org/synapse/issues/8577)) - Support macOS on the `synmark` benchmark runner. ([\#8578](https://github.com/matrix-org/synapse/issues/8578)) - Update `mypy` static type checker to 0.790. ([\#8583](https://github.com/matrix-org/synapse/issues/8583), [\#8600](https://github.com/matrix-org/synapse/issues/8600)) - Re-organize the structured logging code to separate the TCP transport handling from the JSON formatting. ([\#8587](https://github.com/matrix-org/synapse/issues/8587)) - Remove extraneous unittest logging decorators from unit tests. ([\#8592](https://github.com/matrix-org/synapse/issues/8592)) - Minor optimisations in caching code. ([\#8593](https://github.com/matrix-org/synapse/issues/8593), [\#8594](https://github.com/matrix-org/synapse/issues/8594))	2020-10-22 13:37:08 +01:00
Patrick Cloke	514a240aed	Remove unused OPTIONS handlers. (#8621 ) The handling of OPTIONS requests was consolidated in #7534, but the endpoint specific handlers were not removed.	2020-10-22 08:35:55 -04:00
Erik Johnston	b19b63e6b4	Don't 500 for invalid group IDs (#8628 )	2020-10-22 13:19:06 +01:00
Erik Johnston	ec0e9c4695	1.22.0rc1	2020-10-22 13:08:42 +01:00
Erik Johnston	a9f90fa73a	Type hints for RegistrationStore (#8615 )	2020-10-22 11:56:58 +01:00
Erik Johnston	2ac908f377	Don't instansiate Requester directly (#8614 )	2020-10-22 10:11:06 +01:00
Richard van der Hoff	b28aaeb3a5	Optimise CacheDescriptor (#8594 ) don't bother constricting a CacheContext unless we need one.	2020-10-21 22:57:45 +01:00
Richard van der Hoff	2b3af01791	optimise DeferredCache.set	2020-10-21 17:55:53 +01:00
Richard van der Hoff	9146a8a691	Merge pull request #8572 from matrix-org/rav/cache_hacking/2 Push some deferred wrangling down into DeferredCache	2020-10-21 17:55:04 +01:00
Richard van der Hoff	1f4269700c	Push some deferred wrangling down into DeferredCache	2020-10-21 15:39:25 +01:00
Will Hunt	70259d8c8c	Limit AS transactions to 100 events (#8606 ) * Limit AS transactions to 100 events * Update changelog.d/8606.feature Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Add tests * Update synapse/appservice/scheduler.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2020-10-21 15:36:53 +01:00
Patrick Cloke	20a67aa70d	Separate the TCP and terse JSON formatting code. (#8587 ) This should (theoretically) allow for using the TCP code with a different output type and make it easier to use the JSON code with files / console.	2020-10-21 06:59:54 -04:00
Patrick Cloke	654cc9470e	Pin mypy-zope for compatibility with mypy. (#8600 )	2020-10-21 06:45:01 -04:00
Patrick Cloke	de5cafe980	Add type hints to profile and base handlers. (#8609 )	2020-10-21 06:44:31 -04:00
Patrick Cloke	9e0f22874f	Consistently use wrap_as_background_task in more places (#8599 )	2020-10-20 11:29:38 -04:00
Jonathan de Jong	84c0e46cce	Update mypy to 0.790, and move dependencies to extras (#8583 )	2020-10-20 07:55:21 -04:00
Andrew Morgan	74f29284aa	Remove some extraneous @unittest.INFOs on unit tests (#8592 )	2020-10-20 11:49:15 +01:00
Andrew Morgan	a312e890f5	Cast errors generated during synapse_port_db to str (#8585 ) I noticed in https://github.com/matrix-org/synapse/issues/8575 that the `end_error` variable in `synapse_port_db` is set to an `Exception`, even though later we expect it to be a `str`. This PR simply casts an exception raised to a string. I'm doing this instead of having `end_error` be of type exception as we explicitly set `end_error` to a str here: `d25eb8f370/scripts/synapse_port_db (L542-L547)` This whole file could probably use some heavy refactoring, but until then at least this fix will prevent exception contents from being hidden from us and users.	2020-10-20 11:47:24 +01:00
Will Hunt	626b8f0846	Move schema file for as_device_stream (#8590 ) * Move schema file * Add a . * Add matching changelog entry * Fix sqlite	2020-10-20 10:18:55 +01:00
Richard van der Hoff	96e7d3c4a0	Fix 'LruCache' object has no attribute '_on_resize' (#8591 ) We need to make sure we are readu for the `set_cache_factor` callback.	2020-10-19 21:13:50 +01:00
Vasilis Gerakaris	34c20493b9	Drop unused `device_max_stream_id` table (#8589 ) Signed-off-by: Vasilis Gerakaris <vasilis.gerakaris@navarino.gr>	2020-10-19 19:06:54 +01:00
Jonathan de Jong	21bb50ca3f	Fix mypy error: auth handler "checkpw" internal function type mismatch (#8569 )	2020-10-19 18:32:24 +01:00
Patrick Cloke	8f27b7fde1	Expose the experimental appservice login flow to clients. (#8504 )	2020-10-19 13:03:55 -04:00
Richard van der Hoff	903d11c43a	Add `DeferredCache.get_immediate` method (#8568 ) * Add `DeferredCache.get_immediate` method A bunch of things that are currently calling `DeferredCache.get` are only really interested in the result if it's completed. We can optimise and simplify this case. * Remove unused 'default' parameter to DeferredCache.get() * another get_immediate instance	2020-10-19 15:00:12 +01:00
Patrick Cloke	c356b4bf42	Include a simple message in email notifications that include encrypted content (#8545 )	2020-10-19 09:12:39 -04:00
Patrick Cloke	85c56445fb	Support running synmark on macOS. (#8578 ) By using the "poll" reactor since macOS doesn't support epoll.	2020-10-19 07:27:46 -04:00
Erik Johnston	1fcdbeb3ab	Start an opentracing span for background processes. (#8567 ) This should reduce the number of `There was no active span` errors we see. Fixes #8510.	2020-10-19 12:26:26 +01:00
Richard van der Hoff	97647b33c2	Replace DeferredCache with LruCache where possible (#8563 ) Most of these uses don't need a full-blown DeferredCache; LruCache is lighter and more appropriate.	2020-10-19 12:20:29 +01:00
Jonathan de Jong	79c1f973ce	Pre-emptively fix synapse.storage.types.Connection for future mypy release (#8577 ) Fix the Connection protocol according to typeshed's assertions about sqlite3.Connection	2020-10-17 09:51:38 +01:00
Richard van der Hoff	0afd83584b	Fix synmark (#8571 ) This seems to have been broken since #6513.	2020-10-16 21:45:31 +01:00
Richard van der Hoff	d6094176d1	Type annotations for LruCache (#8562 ) * type annotations for LruCache * changelog * Apply suggestions from code review Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * review comments Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2020-10-16 17:06:50 +01:00
Patrick Cloke	1b70662be9	Clean-up old transaction IDs on the background worker. (#8544 )	2020-10-16 12:06:17 -04:00
Jonathan de Jong	c8e9dc4cf4	Add .venv* to .gitignore (#8566 ) Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>	2020-10-16 17:03:38 +01:00
Richard van der Hoff	402213bf41	changelog	2020-10-16 15:56:47 +01:00
Richard van der Hoff	3ee17585cd	Make LruCache register its own metrics (#8561 ) rather than have everything that instantiates an LruCache manage metrics separately, have LruCache do it itself.	2020-10-16 15:51:57 +01:00
Richard van der Hoff	da0090fdff	Fix modifying events in `ThirdPartyRules` modules (#8564 ) EventBuilder.build wants auth events these days	2020-10-16 13:39:46 +01:00
Richard van der Hoff	5649669c3c	Merge pull request #8535 from matrix-org/rav/third_party_events_updates Support modifying event content from ThirdPartyRules modules	2020-10-15 20:55:41 +01:00
Jonathan de Jong	6b5a115c0a	Solidify the HomeServer constructor. (#8515 ) This implements a more standard API for instantiating a homeserver and moves some of the dependency injection into the test suite. More concretely this stops using `setattr` on all `kwargs` passed to `HomeServer`.	2020-10-15 15:29:13 -04:00
Will Hunt	c276bd9969	Send some ephemeral events to appservices (#8437 ) Optionally sends typing, presence, and read receipt information to appservices.	2020-10-15 12:33:28 -04:00
Andrew Morgan	654e239b25	Add option to scripts-dev/lint.sh to only lint files changed since the last git commit (#8472 ) This PR makes several changes to the `./scripts-dev/lint.sh` script, which lints the codebase with a number of tools: * Adds usage information, with `-h` flag to show it. Otherwise it will show when providing an unknown flag. * Adds option `-d` which will check both staged and unstaged files that have changed since the last commit and add them to the list of files to lint. - Note that only files without an extension, or with a `.py` extension will be allowed. This prevents editing bash scripts causing the linters to break on non-python files. * Improves the print-out of which files/directories are being linted.	2020-10-15 15:45:13 +01:00
Patrick Cloke	74976a8e43	Merge branch 'master' into develop	2020-10-15 10:43:54 -04:00
Patrick Cloke	9991aaa49c	1.21.2	2020-10-15 09:24:10 -04:00
Erik Johnston	20fa83f374	Remove racey assertion in MultiWriterIDGenerator (#8530 ) We asserted that the IDs returned by postgres sequence was greater than any we had seen, however this is technically racey as we may update the current positions out of order. We now assert that the sequences are correct on startup, so the assertion is no longer really required, so we remove them.	2020-10-15 09:14:29 -04:00
Richard van der Hoff	8075504a60	Enable mypy for synapse.util.caches (#8547 ) This seemed to entail dragging in a type stub for SortedList.	2020-10-15 11:44:39 +01:00
Richard van der Hoff	0a08cd1065	Merge pull request #8548 from matrix-org/rav/deferred_cache Rename Cache to DeferredCache, and related changes	2020-10-15 11:42:07 +01:00
Neil Johnson	1f39155071	Include user agent in user daily visits table (#8503 ) Include user agent in user daily visits table.	2020-10-15 10:36:40 +01:00
Richard van der Hoff	4433d01519	Merge pull request #8537 from matrix-org/rav/simplify_locally_reject_invite Simplify `_locally_reject_invite`	2020-10-15 10:20:19 +01:00
Richard van der Hoff	27cfd712b3	changelog	2020-10-14 23:49:27 +01:00
Erik Johnston	19b15d63e8	Use autocommit mode for single statement DB functions. (#8542 ) Autocommit means that we don't wrap the functions in transactions, and instead get executed directly. Introduced in #8456. This will help: 1. reduce the number of `could not serialize access due to concurrent delete` errors that we see (though there are a few functions that often cause serialization errors that we don't fix here); 2. improve the DB performance, as it no longer needs to deal with the overhead of `REPEATABLE READ` isolation levels; and 3. improve wall clock speed of these functions, as we no longer need to send `BEGIN` and `COMMIT` to the DB. Some notes about the differences between autocommit mode and our default `REPEATABLE READ` transactions: 1. Currently `autocommit` only applies when using PostgreSQL, and is ignored when using SQLite (due to silliness with [Twisted DB classes](https://twistedmatrix.com/trac/ticket/9998)). 2. Autocommit functions may get retried on error, which means they can get applied twice (or more) to the DB (since they are not in a transaction the previous call would not get rolled back). This means that the functions need to be idempotent (or otherwise not care about being called multiple times). Read queries, simple deletes, and updates/upserts that replace rows (rather than generating new values from existing rows) are all idempotent. 3. Autocommit functions no longer get executed in [`REPEATABLE READ`](https://www.postgresql.org/docs/current/transaction-iso.html) isolation level, and so data can change queries, which is fine for single statement queries.	2020-10-14 15:50:59 +01:00
Erik Johnston	618d405a32	Remove racey assertion in MultiWriterIDGenerator (#8530 ) We asserted that the IDs returned by postgres sequence was greater than any we had seen, however this is technically racey as we may update the current positions out of order. We now assert that the sequences are correct on startup, so the assertion is no longer really required, so we remove them.	2020-10-14 15:40:06 +01:00
Christopher May-Townsend	1cf4a68108	Add note to manhole.md about bind_address when using with docker (#8526 ) Signed-off-by: Christopher May-Townsend <chris@maytownsend.co.uk>	2020-10-14 15:28:59 +01:00
Brendan Abolivier	9e66f3761c	Update documentation on retention policies limits (#8529 ) * Update documentation on retention policies limits Document the changes from https://github.com/matrix-org/synapse/pull/8104	2020-10-14 15:00:49 +01:00
Erik Johnston	1264c8ac89	Add basic tests for sync/pagination with vector clock tokens. (#8488 ) These are tests for #8439	2020-10-14 13:53:20 +01:00
Erik Johnston	921a3f8a59	Fix not sending events over federation when using sharded event persisters (#8536 ) * Fix outbound federaion with multiple event persisters. We incorrectly notified federation senders that the minimum persisted stream position had advanced when we got an `RDATA` from an event persister. Notifying of federation senders already correctly happens in the notifier, so we just delete the offending line. * Change some interfaces to use RoomStreamToken. By enforcing use of `RoomStreamTokens` we make it less likely that people pass in random ints that they got from somewhere random.	2020-10-14 13:27:51 +01:00
Brendan Abolivier	3ee97a2748	Make sure a retention policy is a state event (#8527 ) * Make sure a retention policy is a state event * Changelog	2020-10-14 12:00:52 +01:00
Aaron Raimist	ec606ea9e3	Add correct M_BAD_JSON error code to /profile/{userId}/displayname (#8517 ) Fixes #8029	2020-10-14 11:24:58 +01:00
Richard van der Hoff	d9dc6185d3	changelog	2020-10-13 23:58:48 +01:00
Richard van der Hoff	091e9482af	changelog	2020-10-13 23:24:50 +01:00
Patrick Cloke	629a951b49	Move additional tasks to the background worker, part 4 (#8513 )	2020-10-13 08:20:32 -04:00
Erik Johnston	b2486f6656	Fix message duplication if something goes wrong after persisting the event (#8476 ) Should fix #3365.	2020-10-13 12:07:56 +01:00
Christopher May-Townsend	b76f53bb79	Multi arch docker support: add arm/v7 and arm64 to our docker images (#7921 ) Signed-off-by: Christopher May-Townsend (chris@maytownsend.co.uk)	2020-10-12 22:00:33 +01:00
Erik Johnston	8de3703d21	Make event persisters periodically announce position over replication. (#8499 ) Currently background proccesses stream the events stream use the "minimum persisted position" (i.e. `get_current_token()`) rather than the vector clock style tokens. This is broadly fine as it doesn't matter if the background processes lag a small amount. However, in extreme cases (i.e. SyTests) where we only write to one event persister the background processes will never make progress. This PR changes it so that the `MultiWriterIDGenerator` keeps the current position of a given instance as up to date as possible (i.e using the latest token it sees if its not in the process of persisting anything), and then periodically announces that over replication. This then allows the "minimum persisted position" to advance, albeit with a small lag.	2020-10-12 15:51:41 +01:00
Samuel Philipp	6905f5751a	Docker: support passing additional commandline args to synapse (#8390 )	2020-10-11 20:51:11 +01:00
Patrick Cloke	d35a451399	Clean-up some broken/unused code in the test framework (#8514 )	2020-10-09 14:19:29 -04:00
Richard van der Hoff	9789b1fba5	Fix threadsafety in ThreadedMemoryReactorClock (#8497 ) This could, very occasionally, cause: ``` tests.test_visibility.FilterEventsForServerTestCase.test_large_room =============================================================================== [ERROR] Traceback (most recent call last): File "/src/tests/rest/media/v1/test_media_storage.py", line 86, in test_ensure_media_is_in_local_cache self.wait_on_thread(x) File "/src/tests/unittest.py", line 296, in wait_on_thread self.reactor.advance(0.01) File "/src/.tox/py35/lib/python3.5/site-packages/twisted/internet/task.py", line 826, in advance self._sortCalls() File "/src/.tox/py35/lib/python3.5/site-packages/twisted/internet/task.py", line 787, in _sortCalls self.calls.sort(key=lambda a: a.getTime()) builtins.ValueError: list modified during sort tests.rest.media.v1.test_media_storage.MediaStorageTests.test_ensure_media_is_in_local_cache ```	2020-10-09 17:22:25 +01:00
Mateusz Przybyłowicz	ca2db5dd0c	Increase default max_upload_size from 10M to 50M (#8502 ) Signed-off-by: Mateusz Przybyłowicz <uamfhq@gmail.com>	2020-10-09 16:58:23 +01:00
Patrick Cloke	1781bbe319	Add type hints to response cache. (#8507 )	2020-10-09 11:35:11 -04:00
Andrew Morgan	66ac4b1e34	Allow modules to create and send events into rooms (#8479 ) This PR allows Synapse modules making use of the `ModuleApi` to create and send non-membership events into a room. This can useful to have modules send messages, or change power levels in a room etc. Note that they must send event through a user that's already in the room. The non-membership event limitation is currently arbitrary, as it's another chunk of work and not necessary at the moment.	2020-10-09 13:46:36 +01:00
Erik Johnston	5009ffcaa4	Only send RDATA for instance local events. (#8496 ) When pulling events out of the DB to send over replication we were not filtering by instance name, and so we were sending events for other instances.	2020-10-09 13:10:33 +01:00
Patrick Cloke	fe0f4a3591	Move additional tasks to the background worker, part 3 (#8489 )	2020-10-09 07:37:51 -04:00
Patrick Cloke	c9c0ad5e20	Remove the deprecated Handlers object (#8494 ) All handlers now available via get_*_handler() methods on the HomeServer.	2020-10-09 07:24:34 -04:00
Patrick Cloke	a93f3121f8	Add type hints to some handlers (#8505 )	2020-10-09 07:20:51 -04:00
Hubert Chathi	a97cec18bb	Invalidate the cache when an olm fallback key is uploaded (#8501 )	2020-10-08 13:24:46 -04:00
Erik Johnston	7859c4d079	Synapse 1.21.0rc3 (2020-10-08) ============================== Bugfixes -------- - Fix duplication of events on high traffic servers, caused by PostgreSQL `could not serialize access due to concurrent update` errors. ([\#8456](https://github.com/matrix-org/synapse/issues/8456)) Internal Changes ---------------- - Add Groovy Gorilla to the list of distributions we build `.deb`s for. ([\#8475](https://github.com/matrix-org/synapse/issues/8475)) -----BEGIN PGP SIGNATURE----- iQFEBAABCgAuFiEEBTGR3/RnAzBGUif3pULk7RsPrAkFAl9+7JIQHGVyaWtAbWF0 cml4Lm9yZwAKCRClQuTtGw+sCUc1B/9Bz8uAEJWX9qahuWZGrsvj0ukF/9O6YWrU ZZGHnyaAXg4MF0lR6DVCV2NhW/l3RWO01G/LgGT//0vac+EFxWDbjuaHP9pRVBln 02TQpn12ceZtW/n+X+8wmQzfSn1zNWRUycV43MyGu49z3IAG7KVjjVDQPkY0mEHC h6THy30SYIOKDCdXUUL9i+sV1JLzKPX0NlzO3ONKe2LbfLiBTvdfDRlZGq6rJu5H GAsIPwgadhanhXBPhG4WrealG31TkcPbZCwFMv9aFzltU841jps+QN6OKvbGFVer FboD2df0ZJqKNJOJVVlOMs7I5uSYbrg+n1zolZfrbo0lk/xEyIAT =F5cw -----END PGP SIGNATURE----- Merge tag 'v1.21.0rc3' into develop Synapse 1.21.0rc3 (2020-10-08) ============================== Bugfixes -------- - Fix duplication of events on high traffic servers, caused by PostgreSQL `could not serialize access due to concurrent update` errors. ([\#8456](https://github.com/matrix-org/synapse/issues/8456)) Internal Changes ---------------- - Add Groovy Gorilla to the list of distributions we build `.deb`s for. ([\#8475](https://github.com/matrix-org/synapse/issues/8475))	2020-10-08 11:43:21 +01:00
Erik Johnston	31fe46e0a3	1.21.0rc3	2020-10-08 11:19:22 +01:00
Mateusz Przybyłowicz	719474cae0	Add useful shields to readme (#8493 ) Added shields directing to synapse-dev room, showing license, latest version on PyPi and supported Python versions. I've moved substitution definitions to the bottom to improve readability. Signed-off-by: Mateusz Przybyłowicz <uamfhq@gmail.com>	2020-10-08 11:16:56 +01:00
Richard van der Hoff	b28bfd905d	Clarify error message when plugin config parsers raise an error (#8492 ) This turns: Failed to parse config for 'myplugin': Exception('error message') into: Failed to parse config for 'myplugin': error message.	2020-10-08 11:10:15 +01:00
Erik Johnston	1baa895310	Merge remote-tracking branch 'origin/release-v1.21.0' into develop	2020-10-07 17:20:24 +01:00
Erik Johnston	fa8934b175	Reduce serialization errors in MultiWriterIdGen (#8456 ) We call `_update_stream_positions_table_txn` a lot, which is an UPSERT that can conflict in `REPEATABLE READ` isolation level. Instead of doing a transaction consisting of a single query we may as well run it outside of a transaction.	2020-10-07 17:08:58 +01:00
Patrick Cloke	e4f72ddc44	Move additional tasks to the background worker (#8458 )	2020-10-07 11:27:56 -04:00
Patrick Cloke	8dbf62fada	Include the configured log level in phone home stats. (#8477 ) By reporting the log level of the synapse logger as a string.	2020-10-07 11:13:38 -04:00
Erik Johnston	ae5b2a72c0	Reduce serialization errors in MultiWriterIdGen (#8456 ) We call `_update_stream_positions_table_txn` a lot, which is an UPSERT that can conflict in `REPEATABLE READ` isolation level. Instead of doing a transaction consisting of a single query we may as well run it outside of a transaction.	2020-10-07 15:15:57 +01:00
Erik Johnston	52a50e8686	Use vector clocks for room stream tokens. (#8439 ) Currently when using multiple event persisters we (in the worst case) don't tell clients about events until all event persisters have persisted new events after the original event. This is a suboptimal, especially if one of the event persisters goes down. To handle this, we encode the position of each event persister in the room tokens so that we can send events to clients immediately. To reduce the size of the token we do two things: 1. We create a unique immutable persistent mapping between instance names and a generated small integer ID, which we can encode in the tokens instead of the instance name; and 2. We encode the "persisted upto position" of the room token and then only explicitly include instances that have positions strictly greater than that. The new tokens look something like: `m3478~1.3488~2.3489`, where the first number is the min position, and the subsequent `-` separated pairs are the instance ID to positions map. (We use `.` and `~` as separators as they're URL safe and not already used by `StreamToken`).	2020-10-07 15:15:33 +01:00
Patrick Cloke	b460a088c6	Add typing information to the device handler. (#8407 )	2020-10-07 08:58:21 -04:00
Erik Johnston	9ca6341969	Fix returning incorrect prev_batch token in incremental sync (#8486 )	2020-10-07 13:49:40 +01:00
Patrick Cloke	d9b55bd830	Add Ubuntu 20.10 (Groovy Gorilla) to build scripts. (#8475 )	2020-10-07 08:48:54 -04:00
Richard van der Hoff	d373ec2f72	unblacklist some tests (#8474 ) It seems most of these blacklisted tests do actually pass most of the time. I'm of the opinion that having them blacklisted here means there is very little incentive for us to deflake any flaky tests, and meanwhile any value in those tests is completely lost.	2020-10-07 13:39:50 +01:00
Hubert Chathi	4cb44a1585	Add support for MSC2697: Dehydrated devices (#8380 ) This allows a user to store an offline device on the server and then restore it at a subsequent login.	2020-10-07 08:00:17 -04:00
Richard van der Hoff	43c622885c	Merge pull request #8463 from matrix-org/rav/clean_up_event_handling Reduce inconsistencies between codepaths for membership and non-membership events.	2020-10-07 12:20:44 +01:00
Richard van der Hoff	4f0637346a	Combine `SpamCheckerApi` with the more generic `ModuleApi`. (#8464 ) Lots of different module apis is not easy to maintain. Rather than adding yet another ModuleApi(hs, hs.get_auth_handler()) incantation, first add an hs.get_module_api() method and use it where possible.	2020-10-07 12:03:26 +01:00
Andrew Morgan	01f82bfe32	Remove docs/sphinx and related references (#8480 ) https://github.com/matrix-org/synapse/tree/develop/docs/sphinx doesn't seem to really be utilised or changed recently since the initial commit. I like the idea of exportable documentation of the codebase, but at the moment after running through the build instructions the generated website wasn't very useful...	2020-10-07 11:45:31 +01:00
Hubert Chathi	3cd78bbe9e	Add support for MSC2732: olm fallback keys (#8312 )	2020-10-06 13:26:29 -04:00
Richard van der Hoff	a024461130	Additional tests for third-party event rules (#8468 ) * Optimise and test state fetching for 3p event rules Getting all the events at once is much more efficient than getting them individually * Test that 3p event rules can modify events	2020-10-06 16:31:31 +01:00
Richard van der Hoff	9c0b168cff	Merge pull request #8467 from matrix-org/rav/fix_3pevent_rules Fix third-party event modules for `check_visibility_can_be_modified` check	2020-10-06 11:32:53 +01:00
Andrew Morgan	3e58ce72b4	Don't bother responding to client requests that have already disconnected (#8465 ) This PR ports the quick fix from https://github.com/matrix-org/synapse/pull/2796 to further methods which handle media, URL preview and `/key/v2/server` requests. This prevents a harmless `ERROR` that comes up in the logs when we were unable to respond to a client request when the client had already disconnected. In this case we simply bail out if the client has already done so. This is the 'simple fix' as suggested by https://github.com/matrix-org/synapse/issues/5304#issuecomment-574740003. Fixes https://github.com/matrix-org/synapse/issues/6700 Fixes https://github.com/matrix-org/synapse/issues/5304	2020-10-06 10:03:39 +01:00
Richard van der Hoff	785437dc0d	Update default room version to 6 (#8461 ) Per https://github.com/matrix-org/matrix-doc/pull/2788	2020-10-05 21:40:51 +01:00
Richard van der Hoff	4cd1448d0e	Fix third-party event modules for `check_visibility_can_be_modified` check PR #8292 tried to maintain backwards compat with modules which don't provide a `check_visibility_can_be_modified` method, but the tests weren't being run, and the check didn't work.	2020-10-05 20:29:52 +01:00
Richard van der Hoff	103f72929a	changelog	2020-10-05 19:04:13 +01:00
Patrick Cloke	da11cc22be	Ensure that event.redacts is the proper type before handling it (#8457 ) This fixes a bug when backfilling invalid events.	2020-10-05 10:24:17 -04:00
Andrew Morgan	0991a2da93	Allow ThirdPartyEventRules modules to manipulate public room state (#8292 ) This PR allows `ThirdPartyEventRules` modules to view, manipulate and block changes to the state of whether a room is published in the public rooms directory. While the idea of whether a room is in the public rooms list is not kept within an event in the room, `ThirdPartyEventRules` generally deal with controlling which modifications can happen to a room. Public rooms fits within that idea, even if its toggle state isn't controlled through a state event.	2020-10-05 14:57:46 +01:00
Richard van der Hoff	f31f8e6319	Remove stream ordering from Metadata dict (#8452 ) There's no need for it to be in the dict as well as the events table. Instead, we store it in a separate attribute in the EventInternalMetadata object, and populate that on load. This means that we can rely on it being correctly populated for any event which has been persited to the database.	2020-10-05 14:43:14 +01:00
Patrick Cloke	f64c6aae68	Update manhole documentation for async/await. (#8462 )	2020-10-05 09:40:19 -04:00
Patrick Cloke	c5251c6fbd	Do not assume that account data is of the correct form. (#8454 ) This fixes a bug where `m.ignored_user_list` was assumed to be a dict, leading to odd behavior for users who set it to something else.	2020-10-05 09:28:05 -04:00
Erik Johnston	e3debf9682	Add logging on startup/shutdown (#8448 ) This is so we can tell what is going on when things are taking a while to start up. The main change here is to ensure that transactions that are created during startup get correctly logged like normal transactions.	2020-10-02 15:20:45 +01:00
Erik Johnston	ec10bdd32b	Speed up unit tests when using PostgreSQL (#8450 )	2020-10-02 15:09:31 +01:00
Patrick Cloke	62894673e6	Allow background tasks to be run on a separate worker. (#8369 )	2020-10-02 08:23:15 -04:00
Richard van der Hoff	f6c526ce67	1.21.0rc2	2020-10-02 12:46:58 +01:00
Richard van der Hoff	73d93039ff	Fix bug in remote thumbnail search (#8438 ) #7124 changed the behaviour of remote thumbnails so that the thumbnailing method was included in the filename of the thumbnail. To support existing files, it included a fallback so that we would check the old filename if the new filename didn't exist. Unfortunately, it didn't apply this logic to storage providers, so any thumbnails stored on such a storage provider was broken.	2020-10-02 12:29:29 +01:00
Patrick Cloke	3bd2a2cbb1	Include a public_baseurl in configs generated by the demo script. (#8443 )	2020-10-02 07:24:07 -04:00
Erik Johnston	695240d34a	Fix DB query on startup for negative streams. (#8447 ) For negative streams we have to negate the internal stream ID before querying the DB. The effect of this bug was to query far too many rows, slowing start up time, but we would correctly filter the results afterwards so there was no ill effect.	2020-10-02 12:22:19 +01:00
Patrick Cloke	34ff8da83b	Convert additional templates to Jinja (#8444 ) This converts a few more of our inline HTML templates to Jinja. This is somewhat part of #7280 and should make it a bit easier to customize these in the future.	2020-10-02 11:15:53 +01:00
Richard van der Hoff	3bd3707cb9	Fix malformed log line in new federation "catch up" logic (#8442 )	2020-10-02 11:05:29 +01:00
Erik Johnston	6c5d5e507e	Add unit test for event persister sharding (#8433 )	2020-10-02 09:57:12 +01:00
BBBSnowball	05ee048f2c	Add config option for always using "userinfo endpoint" for OIDC (#7658 ) This allows for connecting to certain IdPs, e.g. GitLab.	2020-10-01 13:54:35 -04:00
Patrick Cloke	61aaf36a1c	Do not expose the experimental appservice login flow to clients. (#8440 )	2020-10-01 13:38:20 -04:00
Richard van der Hoff	0b68577ed6	Synapse 1.21.0rc1 (2020-10-01) ============================== Features -------- - Require the user to confirm that their password should be reset after clicking the email confirmation link. ([\#8004](https://github.com/matrix-org/synapse/issues/8004)) - Add an admin API `GET /_synapse/admin/v1/event_reports` to read entries of table `event_reports`. Contributed by @dklimpel. ([\#8217](https://github.com/matrix-org/synapse/issues/8217)) - Consolidate the SSO error template across all configuration. ([\#8248](https://github.com/matrix-org/synapse/issues/8248), [\#8405](https://github.com/matrix-org/synapse/issues/8405)) - Add a configuration option to specify a whitelist of domains that a user can be redirected to after validating their email or phone number. ([\#8275](https://github.com/matrix-org/synapse/issues/8275), [\#8417](https://github.com/matrix-org/synapse/issues/8417)) - Add experimental support for sharding event persister. ([\#8294](https://github.com/matrix-org/synapse/issues/8294), [\#8387](https://github.com/matrix-org/synapse/issues/8387), [\#8396](https://github.com/matrix-org/synapse/issues/8396), [\#8419](https://github.com/matrix-org/synapse/issues/8419)) - Add the room topic and avatar to the room details admin API. ([\#8305](https://github.com/matrix-org/synapse/issues/8305)) - Add an admin API for querying rooms where a user is a member. Contributed by @dklimpel. ([\#8306](https://github.com/matrix-org/synapse/issues/8306)) - Add `uk.half-shot.msc2778.login.application_service` login type to allow appservices to login. ([\#8320](https://github.com/matrix-org/synapse/issues/8320)) - Add a configuration option that allows existing users to log in with OpenID Connect. Contributed by @BBBSnowball and @OmmyZhang. ([\#8345](https://github.com/matrix-org/synapse/issues/8345)) - Add prometheus metrics for replication requests. ([\#8406](https://github.com/matrix-org/synapse/issues/8406)) - Support passing additional single sign-on parameters to the client. ([\#8413](https://github.com/matrix-org/synapse/issues/8413)) - Add experimental reporting of metrics on expensive rooms for state-resolution. ([\#8420](https://github.com/matrix-org/synapse/issues/8420)) - Add experimental prometheus metric to track numbers of "large" rooms for state resolutiom. ([\#8425](https://github.com/matrix-org/synapse/issues/8425)) - Add prometheus metrics to track federation delays. ([\#8430](https://github.com/matrix-org/synapse/issues/8430)) Bugfixes -------- - Fix a bug in the media repository where remote thumbnails with the same size but different crop methods would overwrite each other. Contributed by @deepbluev7. ([\#7124](https://github.com/matrix-org/synapse/issues/7124)) - Fix inconsistent handling of non-existent push rules, and stop tracking the `enabled` state of removed push rules. ([\#7796](https://github.com/matrix-org/synapse/issues/7796)) - Fix a longstanding bug when storing a media file with an empty `upload_name`. ([\#7905](https://github.com/matrix-org/synapse/issues/7905)) - Fix messages not being sent over federation until an event is sent into the same room. ([\#8230](https://github.com/matrix-org/synapse/issues/8230), [\#8247](https://github.com/matrix-org/synapse/issues/8247), [\#8258](https://github.com/matrix-org/synapse/issues/8258), [\#8272](https://github.com/matrix-org/synapse/issues/8272), [\#8322](https://github.com/matrix-org/synapse/issues/8322)) - Fix a longstanding bug where files that could not be thumbnailed would result in an Internal Server Error. ([\#8236](https://github.com/matrix-org/synapse/issues/8236), [\#8435](https://github.com/matrix-org/synapse/issues/8435)) - Upgrade minimum version of `canonicaljson` to version 1.4.0, to fix an unicode encoding issue. ([\#8262](https://github.com/matrix-org/synapse/issues/8262)) - Fix longstanding bug which could lead to incomplete database upgrades on SQLite. ([\#8265](https://github.com/matrix-org/synapse/issues/8265)) - Fix stack overflow when stderr is redirected to the logging system, and the logging system encounters an error. ([\#8268](https://github.com/matrix-org/synapse/issues/8268)) - Fix a bug which cause the logging system to report errors, if `DEBUG` was enabled and no `context` filter was applied. ([\#8278](https://github.com/matrix-org/synapse/issues/8278)) - Fix edge case where push could get delayed for a user until a later event was pushed. ([\#8287](https://github.com/matrix-org/synapse/issues/8287)) - Fix fetching malformed events from remote servers. ([\#8324](https://github.com/matrix-org/synapse/issues/8324)) - Fix `UnboundLocalError` from occuring when appservices send a malformed register request. ([\#8329](https://github.com/matrix-org/synapse/issues/8329)) - Don't send push notifications to expired user accounts. ([\#8353](https://github.com/matrix-org/synapse/issues/8353)) - Fix a regression in v1.19.0 with reactivating users through the admin API. ([\#8362](https://github.com/matrix-org/synapse/issues/8362)) - Fix a bug where during device registration the length of the device name wasn't limited. ([\#8364](https://github.com/matrix-org/synapse/issues/8364)) - Include `guest_access` in the fields that are checked for null bytes when updating `room_stats_state`. Broke in v1.7.2. ([\#8373](https://github.com/matrix-org/synapse/issues/8373)) - Fix theoretical race condition where events are not sent down `/sync` if the synchrotron worker is restarted without restarting other workers. ([\#8374](https://github.com/matrix-org/synapse/issues/8374)) - Fix a bug which could cause errors in rooms with malformed membership events, on servers using sqlite. ([\#8385](https://github.com/matrix-org/synapse/issues/8385)) - Fix "Re-starting finished log context" warning when receiving an event we already had over federation. ([\#8398](https://github.com/matrix-org/synapse/issues/8398)) - Fix incorrect handling of timeouts on outgoing HTTP requests. ([\#8400](https://github.com/matrix-org/synapse/issues/8400)) - Fix a regression in v1.20.0 in the `synapse_port_db` script regarding the `ui_auth_sessions_ips` table. ([\#8410](https://github.com/matrix-org/synapse/issues/8410)) - Remove unnecessary 3PID registration check when resetting password via an email address. Bug introduced in v0.34.0rc2. ([\#8414](https://github.com/matrix-org/synapse/issues/8414)) Improved Documentation ---------------------- - Add `/_synapse/client` to the reverse proxy documentation. ([\#8227](https://github.com/matrix-org/synapse/issues/8227)) - Add note to the reverse proxy settings documentation about disabling Apache's mod_security2. Contributed by Julian Fietkau (@jfietkau). ([\#8375](https://github.com/matrix-org/synapse/issues/8375)) - Improve description of `server_name` config option in `homserver.yaml`. ([\#8415](https://github.com/matrix-org/synapse/issues/8415)) Deprecations and Removals ------------------------- - Drop support for `prometheus_client` older than 0.4.0. ([\#8426](https://github.com/matrix-org/synapse/issues/8426)) Internal Changes ---------------- - Fix tests on distros which disable TLSv1.0. Contributed by @danc86. ([\#8208](https://github.com/matrix-org/synapse/issues/8208)) - Simplify the distributor code to avoid unnecessary work. ([\#8216](https://github.com/matrix-org/synapse/issues/8216)) - Remove the `populate_stats_process_rooms_2` background job and restore functionality to `populate_stats_process_rooms`. ([\#8243](https://github.com/matrix-org/synapse/issues/8243)) - Clean up type hints for `PaginationConfig`. ([\#8250](https://github.com/matrix-org/synapse/issues/8250), [\#8282](https://github.com/matrix-org/synapse/issues/8282)) - Track the latest event for every destination and room for catch-up after federation outage. ([\#8256](https://github.com/matrix-org/synapse/issues/8256)) - Fix non-user visible bug in implementation of `MultiWriterIdGenerator.get_current_token_for_writer`. ([\#8257](https://github.com/matrix-org/synapse/issues/8257)) - Switch to the JSON implementation from the standard library. ([\#8259](https://github.com/matrix-org/synapse/issues/8259)) - Add type hints to `synapse.util.async_helpers`. ([\#8260](https://github.com/matrix-org/synapse/issues/8260)) - Simplify tests that mock asynchronous functions. ([\#8261](https://github.com/matrix-org/synapse/issues/8261)) - Add type hints to `StreamToken` and `RoomStreamToken` classes. ([\#8279](https://github.com/matrix-org/synapse/issues/8279)) - Change `StreamToken.room_key` to be a `RoomStreamToken` instance. ([\#8281](https://github.com/matrix-org/synapse/issues/8281)) - Refactor notifier code to correctly use the max event stream position. ([\#8288](https://github.com/matrix-org/synapse/issues/8288)) - Use slotted classes where possible. ([\#8296](https://github.com/matrix-org/synapse/issues/8296)) - Support testing the local Synapse checkout against the [Complement homeserver test suite](https://github.com/matrix-org/complement/). ([\#8317](https://github.com/matrix-org/synapse/issues/8317)) - Update outdated usages of `metaclass` to python 3 syntax. ([\#8326](https://github.com/matrix-org/synapse/issues/8326)) - Move lint-related dependencies to package-extra field, update CONTRIBUTING.md to utilise this. ([\#8330](https://github.com/matrix-org/synapse/issues/8330), [\#8377](https://github.com/matrix-org/synapse/issues/8377)) - Use the `admin_patterns` helper in additional locations. ([\#8331](https://github.com/matrix-org/synapse/issues/8331)) - Fix test logging to allow braces in log output. ([\#8335](https://github.com/matrix-org/synapse/issues/8335)) - Remove `__future__` imports related to Python 2 compatibility. ([\#8337](https://github.com/matrix-org/synapse/issues/8337)) - Simplify `super()` calls to Python 3 syntax. ([\#8344](https://github.com/matrix-org/synapse/issues/8344)) - Fix bad merge from `release-v1.20.0` branch to `develop`. ([\#8354](https://github.com/matrix-org/synapse/issues/8354)) - Factor out a `_send_dummy_event_for_room` method. ([\#8370](https://github.com/matrix-org/synapse/issues/8370)) - Improve logging of state resolution. ([\#8371](https://github.com/matrix-org/synapse/issues/8371)) - Add type annotations to `SimpleHttpClient`. ([\#8372](https://github.com/matrix-org/synapse/issues/8372)) - Refactor ID generators to use `async with` syntax. ([\#8383](https://github.com/matrix-org/synapse/issues/8383)) - Add `EventStreamPosition` type. ([\#8388](https://github.com/matrix-org/synapse/issues/8388)) - Create a mechanism for marking tests "logcontext clean". ([\#8399](https://github.com/matrix-org/synapse/issues/8399)) - A pair of tiny cleanups in the federation request code. ([\#8401](https://github.com/matrix-org/synapse/issues/8401)) - Add checks on startup that PostgreSQL sequences are consistent with their associated tables. ([\#8402](https://github.com/matrix-org/synapse/issues/8402)) - Do not include appservice users when calculating the total MAU for a server. ([\#8404](https://github.com/matrix-org/synapse/issues/8404)) - Typing fixes for `synapse.handlers.federation`. ([\#8422](https://github.com/matrix-org/synapse/issues/8422)) - Various refactors to simplify stream token handling. ([\#8423](https://github.com/matrix-org/synapse/issues/8423)) - Make stream token serializing/deserializing async. ([\#8427](https://github.com/matrix-org/synapse/issues/8427)) -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEv27Axt/F4vrTL/8QOSor00I9eP8FAl91zj8ACgkQOSor00I9 eP84zQf+MfDhlPVxIs1B5vx05Sq8m2beSGL/Z6eNuHdQim7qjaZ8rKQiS3dQ3IvZ bCMbAJcappurwkG8xfSmTmVoeX+2RL1uV69mQRkswCOGFKN07+3aLg1sIzQSHCEd beVEVtaHnoBMzcx98KFIiLurD/uJ0zKA+blIaS9kMQ2uBFEhSQBZgLZChs+VB7JG 6XZzQOvVsvig3P42XfTowdCCPcWPOOchXuv3dHoFxkpZ5/6xmjR8E0lQthbUNJ4O nDlWZD+MYorhcoWaze04K+v8Z3l011gUYrhTpoj6q6diCP2gGtYegOKe+oyO7aMA X9xTlSxRVFixf1ml/jAwAWqZRBscxA== =me3I -----END PGP SIGNATURE----- Merge tag 'v1.21.0rc1' into develop Synapse 1.21.0rc1 (2020-10-01) ============================== Features -------- - Require the user to confirm that their password should be reset after clicking the email confirmation link. ([\#8004](https://github.com/matrix-org/synapse/issues/8004)) - Add an admin API `GET /_synapse/admin/v1/event_reports` to read entries of table `event_reports`. Contributed by @dklimpel. ([\#8217](https://github.com/matrix-org/synapse/issues/8217)) - Consolidate the SSO error template across all configuration. ([\#8248](https://github.com/matrix-org/synapse/issues/8248), [\#8405](https://github.com/matrix-org/synapse/issues/8405)) - Add a configuration option to specify a whitelist of domains that a user can be redirected to after validating their email or phone number. ([\#8275](https://github.com/matrix-org/synapse/issues/8275), [\#8417](https://github.com/matrix-org/synapse/issues/8417)) - Add experimental support for sharding event persister. ([\#8294](https://github.com/matrix-org/synapse/issues/8294), [\#8387](https://github.com/matrix-org/synapse/issues/8387), [\#8396](https://github.com/matrix-org/synapse/issues/8396), [\#8419](https://github.com/matrix-org/synapse/issues/8419)) - Add the room topic and avatar to the room details admin API. ([\#8305](https://github.com/matrix-org/synapse/issues/8305)) - Add an admin API for querying rooms where a user is a member. Contributed by @dklimpel. ([\#8306](https://github.com/matrix-org/synapse/issues/8306)) - Add `uk.half-shot.msc2778.login.application_service` login type to allow appservices to login. ([\#8320](https://github.com/matrix-org/synapse/issues/8320)) - Add a configuration option that allows existing users to log in with OpenID Connect. Contributed by @BBBSnowball and @OmmyZhang. ([\#8345](https://github.com/matrix-org/synapse/issues/8345)) - Add prometheus metrics for replication requests. ([\#8406](https://github.com/matrix-org/synapse/issues/8406)) - Support passing additional single sign-on parameters to the client. ([\#8413](https://github.com/matrix-org/synapse/issues/8413)) - Add experimental reporting of metrics on expensive rooms for state-resolution. ([\#8420](https://github.com/matrix-org/synapse/issues/8420)) - Add experimental prometheus metric to track numbers of "large" rooms for state resolutiom. ([\#8425](https://github.com/matrix-org/synapse/issues/8425)) - Add prometheus metrics to track federation delays. ([\#8430](https://github.com/matrix-org/synapse/issues/8430)) Bugfixes -------- - Fix a bug in the media repository where remote thumbnails with the same size but different crop methods would overwrite each other. Contributed by @deepbluev7. ([\#7124](https://github.com/matrix-org/synapse/issues/7124)) - Fix inconsistent handling of non-existent push rules, and stop tracking the `enabled` state of removed push rules. ([\#7796](https://github.com/matrix-org/synapse/issues/7796)) - Fix a longstanding bug when storing a media file with an empty `upload_name`. ([\#7905](https://github.com/matrix-org/synapse/issues/7905)) - Fix messages not being sent over federation until an event is sent into the same room. ([\#8230](https://github.com/matrix-org/synapse/issues/8230), [\#8247](https://github.com/matrix-org/synapse/issues/8247), [\#8258](https://github.com/matrix-org/synapse/issues/8258), [\#8272](https://github.com/matrix-org/synapse/issues/8272), [\#8322](https://github.com/matrix-org/synapse/issues/8322)) - Fix a longstanding bug where files that could not be thumbnailed would result in an Internal Server Error. ([\#8236](https://github.com/matrix-org/synapse/issues/8236), [\#8435](https://github.com/matrix-org/synapse/issues/8435)) - Upgrade minimum version of `canonicaljson` to version 1.4.0, to fix an unicode encoding issue. ([\#8262](https://github.com/matrix-org/synapse/issues/8262)) - Fix longstanding bug which could lead to incomplete database upgrades on SQLite. ([\#8265](https://github.com/matrix-org/synapse/issues/8265)) - Fix stack overflow when stderr is redirected to the logging system, and the logging system encounters an error. ([\#8268](https://github.com/matrix-org/synapse/issues/8268)) - Fix a bug which cause the logging system to report errors, if `DEBUG` was enabled and no `context` filter was applied. ([\#8278](https://github.com/matrix-org/synapse/issues/8278)) - Fix edge case where push could get delayed for a user until a later event was pushed. ([\#8287](https://github.com/matrix-org/synapse/issues/8287)) - Fix fetching malformed events from remote servers. ([\#8324](https://github.com/matrix-org/synapse/issues/8324)) - Fix `UnboundLocalError` from occuring when appservices send a malformed register request. ([\#8329](https://github.com/matrix-org/synapse/issues/8329)) - Don't send push notifications to expired user accounts. ([\#8353](https://github.com/matrix-org/synapse/issues/8353)) - Fix a regression in v1.19.0 with reactivating users through the admin API. ([\#8362](https://github.com/matrix-org/synapse/issues/8362)) - Fix a bug where during device registration the length of the device name wasn't limited. ([\#8364](https://github.com/matrix-org/synapse/issues/8364)) - Include `guest_access` in the fields that are checked for null bytes when updating `room_stats_state`. Broke in v1.7.2. ([\#8373](https://github.com/matrix-org/synapse/issues/8373)) - Fix theoretical race condition where events are not sent down `/sync` if the synchrotron worker is restarted without restarting other workers. ([\#8374](https://github.com/matrix-org/synapse/issues/8374)) - Fix a bug which could cause errors in rooms with malformed membership events, on servers using sqlite. ([\#8385](https://github.com/matrix-org/synapse/issues/8385)) - Fix "Re-starting finished log context" warning when receiving an event we already had over federation. ([\#8398](https://github.com/matrix-org/synapse/issues/8398)) - Fix incorrect handling of timeouts on outgoing HTTP requests. ([\#8400](https://github.com/matrix-org/synapse/issues/8400)) - Fix a regression in v1.20.0 in the `synapse_port_db` script regarding the `ui_auth_sessions_ips` table. ([\#8410](https://github.com/matrix-org/synapse/issues/8410)) - Remove unnecessary 3PID registration check when resetting password via an email address. Bug introduced in v0.34.0rc2. ([\#8414](https://github.com/matrix-org/synapse/issues/8414)) Improved Documentation ---------------------- - Add `/_synapse/client` to the reverse proxy documentation. ([\#8227](https://github.com/matrix-org/synapse/issues/8227)) - Add note to the reverse proxy settings documentation about disabling Apache's mod_security2. Contributed by Julian Fietkau (@jfietkau). ([\#8375](https://github.com/matrix-org/synapse/issues/8375)) - Improve description of `server_name` config option in `homserver.yaml`. ([\#8415](https://github.com/matrix-org/synapse/issues/8415)) Deprecations and Removals ------------------------- - Drop support for `prometheus_client` older than 0.4.0. ([\#8426](https://github.com/matrix-org/synapse/issues/8426)) Internal Changes ---------------- - Fix tests on distros which disable TLSv1.0. Contributed by @danc86. ([\#8208](https://github.com/matrix-org/synapse/issues/8208)) - Simplify the distributor code to avoid unnecessary work. ([\#8216](https://github.com/matrix-org/synapse/issues/8216)) - Remove the `populate_stats_process_rooms_2` background job and restore functionality to `populate_stats_process_rooms`. ([\#8243](https://github.com/matrix-org/synapse/issues/8243)) - Clean up type hints for `PaginationConfig`. ([\#8250](https://github.com/matrix-org/synapse/issues/8250), [\#8282](https://github.com/matrix-org/synapse/issues/8282)) - Track the latest event for every destination and room for catch-up after federation outage. ([\#8256](https://github.com/matrix-org/synapse/issues/8256)) - Fix non-user visible bug in implementation of `MultiWriterIdGenerator.get_current_token_for_writer`. ([\#8257](https://github.com/matrix-org/synapse/issues/8257)) - Switch to the JSON implementation from the standard library. ([\#8259](https://github.com/matrix-org/synapse/issues/8259)) - Add type hints to `synapse.util.async_helpers`. ([\#8260](https://github.com/matrix-org/synapse/issues/8260)) - Simplify tests that mock asynchronous functions. ([\#8261](https://github.com/matrix-org/synapse/issues/8261)) - Add type hints to `StreamToken` and `RoomStreamToken` classes. ([\#8279](https://github.com/matrix-org/synapse/issues/8279)) - Change `StreamToken.room_key` to be a `RoomStreamToken` instance. ([\#8281](https://github.com/matrix-org/synapse/issues/8281)) - Refactor notifier code to correctly use the max event stream position. ([\#8288](https://github.com/matrix-org/synapse/issues/8288)) - Use slotted classes where possible. ([\#8296](https://github.com/matrix-org/synapse/issues/8296)) - Support testing the local Synapse checkout against the [Complement homeserver test suite](https://github.com/matrix-org/complement/). ([\#8317](https://github.com/matrix-org/synapse/issues/8317)) - Update outdated usages of `metaclass` to python 3 syntax. ([\#8326](https://github.com/matrix-org/synapse/issues/8326)) - Move lint-related dependencies to package-extra field, update CONTRIBUTING.md to utilise this. ([\#8330](https://github.com/matrix-org/synapse/issues/8330), [\#8377](https://github.com/matrix-org/synapse/issues/8377)) - Use the `admin_patterns` helper in additional locations. ([\#8331](https://github.com/matrix-org/synapse/issues/8331)) - Fix test logging to allow braces in log output. ([\#8335](https://github.com/matrix-org/synapse/issues/8335)) - Remove `__future__` imports related to Python 2 compatibility. ([\#8337](https://github.com/matrix-org/synapse/issues/8337)) - Simplify `super()` calls to Python 3 syntax. ([\#8344](https://github.com/matrix-org/synapse/issues/8344)) - Fix bad merge from `release-v1.20.0` branch to `develop`. ([\#8354](https://github.com/matrix-org/synapse/issues/8354)) - Factor out a `_send_dummy_event_for_room` method. ([\#8370](https://github.com/matrix-org/synapse/issues/8370)) - Improve logging of state resolution. ([\#8371](https://github.com/matrix-org/synapse/issues/8371)) - Add type annotations to `SimpleHttpClient`. ([\#8372](https://github.com/matrix-org/synapse/issues/8372)) - Refactor ID generators to use `async with` syntax. ([\#8383](https://github.com/matrix-org/synapse/issues/8383)) - Add `EventStreamPosition` type. ([\#8388](https://github.com/matrix-org/synapse/issues/8388)) - Create a mechanism for marking tests "logcontext clean". ([\#8399](https://github.com/matrix-org/synapse/issues/8399)) - A pair of tiny cleanups in the federation request code. ([\#8401](https://github.com/matrix-org/synapse/issues/8401)) - Add checks on startup that PostgreSQL sequences are consistent with their associated tables. ([\#8402](https://github.com/matrix-org/synapse/issues/8402)) - Do not include appservice users when calculating the total MAU for a server. ([\#8404](https://github.com/matrix-org/synapse/issues/8404)) - Typing fixes for `synapse.handlers.federation`. ([\#8422](https://github.com/matrix-org/synapse/issues/8422)) - Various refactors to simplify stream token handling. ([\#8423](https://github.com/matrix-org/synapse/issues/8423)) - Make stream token serializing/deserializing async. ([\#8427](https://github.com/matrix-org/synapse/issues/8427))	2020-10-01 13:51:52 +01:00
Richard van der Hoff	2eb947e0ee	update changelog	2020-10-01 13:38:26 +01:00
Richard van der Hoff	b1f4e6e4fc	fix a logging error in thumbnailer (#8435 ) Introduced in #8236	2020-10-01 13:34:24 +01:00
Richard van der Hoff	cc40a59b4a	1.21.0	2020-10-01 13:14:56 +01:00
Patrick Cloke	4ff0201e62	Enable mypy checking for unreachable code and fix instances. (#8432 )	2020-10-01 08:09:18 -04:00
Richard van der Hoff	c1ef579b63	Add prometheus metrics to track federation delays (#8430 ) Add a pair of federation metrics to track the delays in sending PDUs to/from particular servers.	2020-10-01 11:09:12 +01:00
Erik Johnston	7941372ec8	Make token serializing/deserializing async (#8427 ) The idea is that in future tokens will encode a mapping of instance to position. However, we don't want to include the full instance name in the string representation, so instead we'll have a mapping between instance name and an immutable integer ID in the DB that we can use instead. We'll then do the lookup when we serialize/deserialize the token (we could alternatively pass around an `Instance` type that includes both the name and ID, but that turns out to be a lot more invasive).	2020-09-30 20:29:19 +01:00
Richard van der Hoff	a0a1ba6973	Merge pull request #8425 from matrix-org/rav/extremity_metrics Add an improved "forward extremities" metric	2020-09-30 19:33:27 +01:00
Patrick Cloke	8b40843392	Allow additional SSO properties to be passed to the client (#8413 )	2020-09-30 13:02:43 -04:00
Richard van der Hoff	32acab3fa2	changelog	2020-09-30 16:49:15 +01:00
Richard van der Hoff	ceafb5a1c6	Drop support for ancient prometheus_client (#8426 ) Drop compatibility hacks for prometheus-client pre 0.4.0. Debian stretch and Fedora 31 both have newer versions, so hopefully this will be ok.	2020-09-30 16:42:05 +01:00
Richard van der Hoff	c429dfc300	Merge pull request #8420 from matrix-org/rav/state_res_stats Report metrics on expensive rooms for state res	2020-09-30 10:37:52 +01:00
Erik Johnston	ea70f1c362	Various clean ups to room stream tokens. (#8423 )	2020-09-29 21:48:33 +01:00
Aaron Raimist	8238b55e08	Update description of server_name config option (#8415 )	2020-09-29 13:50:25 -04:00
Richard van der Hoff	d4274dd17e	changelog	2020-09-29 17:35:20 +01:00
Will Hunt	c2bdf040aa	Discard an empty upload_name before persisting an uploaded file (#7905 )	2020-09-29 12:15:27 -04:00
Andrew Morgan	e154f7ccb5	Don't check whether a 3pid is allowed to register during password reset (#8414 ) * Don't check whether a 3pid is allowed to register during password reset This endpoint should only deal with emails that have already been approved, and are attached with user's account. There's no need to re-check them here. * Changelog	2020-09-29 16:42:25 +01:00
Erik Johnston	b1433bf231	Don't table scan events on worker startup (#8419 ) * Fix table scan of events on worker startup. This happened because we assumed "new" writers had an initial stream position of 0, so the replication code tried to fetch all events written by the instance between 0 and the current position. Instead, set the initial position of new writers to the current persisted up to position, on the assumption that new writers won't have written anything before that point. * Consider old writers coming back as "new". Otherwise we'd try and fetch entries between the old stale token and the current position, even though it won't have written any rows. Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2020-09-29 16:42:19 +01:00
Richard van der Hoff	2649d545a5	Mypy fixes for `synapse.handlers.federation` (#8422 ) For some reason, an apparently unrelated PR upset mypy about this module. Here are a number of little fixes.	2020-09-29 15:57:36 +01:00
Andrew Morgan	f43c66d23b	Merge branch 'develop' of github.com:matrix-org/synapse into anoa/info-mainline-no-check-password-reset	2020-09-29 14:21:41 +01:00
Andrew Morgan	12f0d18611	Add support for running Complement against the local checkout (#8317 ) This PR adds a script that: * Builds the local Synapse checkout using our existing `docker/Dockerfile` image. * Downloads [Complement](https://github.com/matrix-org/complement/)'s source code. * Builds the [Synapse.Dockerfile](https://github.com/matrix-org/complement/blob/master/dockerfiles/Synapse.Dockerfile) using the above dockerfile as a base. * Builds and runs Complement against it. This set up differs slightly from [that of the dendrite repo](https://github.com/matrix-org/dendrite/blob/master/build/scripts/complement.sh) (`complement.sh`, `Complement.Dockerfile`), which instead stores a separate, but slightly modified, dockerfile in Dendrite's repo rather than running the one stored in Complement's repo. That synapse equivalent to that dockerfile (`Synapse.Dockerfile`) in Complement's repo is just based on top of `matrixdotorg/synapse:latest`, which we opt to build here locally. Thus copying over the files from Complement's repo wouldn't change any functionality, and would result in two instances of the same files. So just using the dockerfile in Complement's repo was decided upon instead.	2020-09-29 13:47:47 +01:00
Will Hunt	8676d8ab2e	Filter out appservices from mau count (#8404 ) This is an attempt to fix #8403.	2020-09-29 13:11:02 +01:00
Andrew Morgan	1c6b8752b8	Only assert valid next_link params when provided (#8417 ) Broken in https://github.com/matrix-org/synapse/pull/8275 and has yet to be put in a release. Fixes https://github.com/matrix-org/synapse/issues/8418. `next_link` is an optional parameter. However, we were checking whether the `next_link` param was valid, even if it wasn't provided. In that case, `next_link` was `None`, which would clearly not be a valid URL. This would prevent password reset and other operations if `next_link` was not provided, and the `next_link_domain_whitelist` config option was set.	2020-09-29 12:36:44 +01:00
Richard van der Hoff	866c84da8d	Add metrics to track success/otherwise of replication requests (#8406 ) One hope is that this might provide some insights into #3365.	2020-09-29 11:06:11 +01:00
Richard van der Hoff	1c262431f9	Fix handling of connection timeouts in outgoing http requests (#8400 ) * Remove `on_timeout_cancel` from `timeout_deferred` The `on_timeout_cancel` param to `timeout_deferred` wasn't always called on a timeout (in particular if the canceller raised an exception), so it was unreliable. It was also only used in one place, and to be honest it's easier to do what it does a different way. * Fix handling of connection timeouts in outgoing http requests Turns out that if we get a timeout during connection, then a different exception is raised, which wasn't always handled correctly. To fix it, catch the exception in SimpleHttpClient and turn it into a RequestTimedOutError (which is already a documented exception). Also add a description to RequestTimedOutError so that we can see which stage it failed at. * Fix incorrect handling of timeouts reading federation responses This was trapping the wrong sort of TimeoutError, so was never being hit. The effect was relatively minor, but we should fix this so that it does the expected thing. * Fix inconsistent handling of `timeout` param between methods `get_json`, `put_json` and `delete_json` were applying a different timeout to the response body to `post_json`; bring them in line and test. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	2020-09-29 10:29:21 +01:00
Andrew Morgan	fe443acaee	Changelog	2020-09-28 18:51:41 +01:00
Erik Johnston	bd380d942f	Add checks for postgres sequence consistency (#8402 )	2020-09-28 18:00:30 +01:00
Richard van der Hoff	5e3ca12b15	Create a mechanism for marking tests "logcontext clean" (#8399 )	2020-09-28 17:58:33 +01:00
Dagfinn Ilmari Mannsåker	bd715e1278	Add `ui_auth_sessions_ips` table to `synapse_port_db` ignore list (#8410 ) This table was created in #8034 (1.20.0). It references `ui_auth_sessions`, which is ignored, so this one should be too. Signed-off-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>	2020-09-28 15:35:02 +01:00
Richard van der Hoff	450ec48445	A pair of tiny cleanups in the federation request code. (#8401 )	2020-09-28 13:15:00 +01:00
Patrick Cloke	31acc5c309	Escape the error description on the sso_error template. (#8405 )	2020-09-25 11:05:54 -04:00
Richard van der Hoff	fec6f9ac17	Fix occasional "Re-starting finished log context" from keyring (#8398 ) * Fix test_verify_json_objects_for_server_awaits_previous_requests It turns out that this wasn't really testing what it thought it was testing (in particular, `check_context` was turning failures into success, which was making the tests pass even though it wasn't clear they should have been. It was also somewhat overcomplex - we can test what it was trying to test without mocking out perspectives servers. * Fix warnings about finished logcontexts in the keyring We need to make sure that we finish the key fetching magic before we run the verifying code, to ensure that we don't mess up our logcontexts.	2020-09-25 12:29:54 +01:00
Tdxdxoz	abd04b6af0	Allow existing users to login via OpenID Connect. (#8345 ) Co-authored-by: Benjamin Koch <bbbsnowball@gmail.com> This adds configuration flags that will match a user to pre-existing users when logging in via OpenID Connect. This is useful when switching to an existing SSO system.	2020-09-25 07:01:45 -04:00
Erik Johnston	3e87d79e1c	Fix schema delta for servers that have not backfilled (#8396 ) Fixes #8395.	2020-09-25 09:58:32 +01:00
Erik Johnston	f112cfe5bb	Fix MultiWriteIdGenerator's handling of restarts. (#8374 ) On startup `MultiWriteIdGenerator` fetches the maximum stream ID for each instance from the table and uses that as its initial "current position" for each writer. This is problematic as a) it involves either a scan of events table or an index (neither of which is ideal), and b) if rows are being persisted out of order elsewhere while the process restarts then using the maximum stream ID is not correct. This could theoretically lead to race conditions where e.g. events that are persisted out of order are not sent down sync streams. We fix this by creating a new table that tracks the current positions of each writer to the stream, and update it each time we finish persisting a new entry. This is a relatively small overhead when persisting events. However for the cache invalidation stream this is a much bigger relative overhead, so instead we note that for invalidation we don't actually care about reliability over restarts (as there's no caches to invalidate) and simply don't bother reading and writing to the new table in that particular case.	2020-09-24 16:53:51 +01:00
Richard van der Hoff	11c9e17738	Add type annotations to SimpleHttpClient (#8372 )	2020-09-24 15:47:20 +01:00
Erik Johnston	6fdf577593	Add new sequences to port DB script (#8387 )	2020-09-24 13:43:49 +01:00
Erik Johnston	ac11fcbbb8	Add EventStreamPosition type (#8388 ) The idea is to remove some of the places we pass around `int`, where it can represent one of two things: 1. the position of an event in the stream; or 2. a token that partitions the stream, used as part of the stream tokens. The valid operations are then: 1. did a position happen before or after a token; 2. get all events that happened before or after a token; and 3. get all events between two tokens. (Note that we don't want to allow other operations as we want to change the tokens to be vector clocks rather than simple ints)	2020-09-24 13:24:17 +01:00
Patrick Cloke	13099ae431	Mark the shadow_banned column as boolean in synapse_port_db. (#8386 )	2020-09-24 08:13:55 -04:00
Richard van der Hoff	2983049a77	Factor out `_send_dummy_event_for_room` (#8370 ) this makes it possible to use from the manhole, and seems cleaner anyway.	2020-09-23 18:18:43 +01:00
Richard van der Hoff	91c60f3042	Improve logging of state resolution (#8371 ) I'd like to get a better insight into what we are doing with respect to state res. The list of state groups we are resolving across should be short (if it isn't, that's a massive problem in itself), so it should be fine to log it in ite entiretly. I've done some grepping and found approximately zero cases in which the "shortcut" code delivered the result, so I've ripped that out too.	2020-09-23 16:42:44 +01:00
Richard van der Hoff	302dc89f6a	Fix bug which caused failure on join with malformed membership events (#8385 )	2020-09-23 16:42:14 +01:00
Erik Johnston	cbabb312e0	Use `async with` for ID gens (#8383 ) This will allow us to hit the DB after we've finished using the generated stream ID.	2020-09-23 16:11:18 +01:00
Mathieu Velten	916bb9d0d1	Don't push if an user account has expired (#8353 )	2020-09-23 16:06:28 +01:00
Andrew Morgan	4bb203ea4f	Fix missing null character check on guest_access room state (#8373 ) When updating the `room_stats_state` table, we try to check for null bytes slipping in to the content for state events. It turns out we had added `guest_access` as a field to room_stats_state without including it in the null byte check. Lo and behold, a null byte in a `m.room.guest_access` event then breaks `room_stats_state` updates. This PR adds the check for `guest_access`.	2020-09-23 15:58:20 +01:00
Patrick Cloke	bbde4038df	Do not check lint/test dependencies at runtime. (#8377 ) moves non-runtime dependencies out of synapse.python_dependencies (test and lint)	2020-09-23 11:45:37 +01:00
Julian Fietkau	a4e63e5a47	Add note to reverse_proxy.md about disabling Apache's mod_security2 (#8375 ) This change adds a note and a few lines of configuration settings for Apache users to disable ModSecurity for Synapse's virtual hosts. With ModSecurity enabled and running with its default settings, Matrix clients are unable to send chat messages through the Synapse installation. With this change, ModSecurity can be disabled only for the Synapse virtual hosts.	2020-09-23 11:14:08 +01:00
Andrew Morgan	48336eeb85	Changelog	2020-09-22 19:39:57 +01:00
Dirk Klimpel	8998217540	Fixed a bug with reactivating users with the admin API (#8362 ) Fixes: #8359 Trying to reactivate a user with the admin API (`PUT /_synapse/admin/v2/users/<user_name>`) causes an internal server error. Seems to be a regression in #8033.	2020-09-22 18:19:01 +01:00
Dirk Klimpel	4da01f9c61	Admin API for reported events (#8217 ) Add an admin API to read entries of table `event_reports`. API: `GET /_synapse/admin/v1/event_reports`	2020-09-22 18:15:04 +01:00
Dionysis Grigoropoulos	37ca5924bd	Create function to check for long names in devices (#8364 ) * Create a new function to verify that the length of a device name is under a certain threshold. * Refactor old code and tests to use said function. * Verify device name length during registration of device * Add a test for the above Signed-off-by: Dionysis Grigoropoulos <dgrig@erethon.com>	2020-09-22 11:42:55 +01:00
Patrick Cloke	babc027543	Fix a bad merge from release-v1.20.0. (#8354 )	2020-09-18 12:54:04 -04:00
Patrick Cloke	00db7786de	Synapse 1.20.0rc5 (2020-09-18) ============================== In addition to the below, Synapse 1.20.0rc5 also includes the bug fix that was included in 1.19.3. Features -------- - Add flags to the `/versions` endpoint for whether new rooms default to using E2EE. ([\#8343](https://github.com/matrix-org/synapse/issues/8343)) Bugfixes -------- - Fix rate limiting of federation `/send` requests. ([\#8342](https://github.com/matrix-org/synapse/issues/8342)) - Fix a longstanding bug where back pagination over federation could get stuck if it failed to handle a received event. ([\#8349](https://github.com/matrix-org/synapse/issues/8349)) Internal Changes ---------------- - Blacklist [MSC2753](https://github.com/matrix-org/matrix-doc/pull/2753) SyTests until it is implemented. ([\#8285](https://github.com/matrix-org/synapse/issues/8285)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEF3tZXk38tRDFVnUIM/xY9qcRMEgFAl9kzk8ACgkQM/xY9qcR MEim6A//aERkhyLGRlGpLd37lCyFQCeffTMH1rTvu04iIBQBaUZ6g7CYWOpK43zT U8kt379+5OShjdAXs/X4XP+ucdHVbrwsRSP3hBS/fFLiDT0fJgP8uiSf5QqO6NnT OqDyXYjcXvj/c6tMKglVtsdh8u4hFwNZjGPMGG68IzJu14uEhnD100cL9jSB9bLB ongWpsQzzdGBpJPSFRjv9dCUSeRbzyUdl1t0uqzrNqyN9s/JnzFTn7ZYo6y3lnSS dHGVMMo/12M2PkbBHnbJVvDY5Q/R7ZxyXlpz0gvSNOQIw8FqYFnuB0Niy5dQhXSR Sy5h4qbczLxqbql1x+lmzeQm4ZMORsW/Tl4C3z6yK6OYaOCJHIf9en4DplTSTqp1 t+85JxWR2wH10d99YHBpaYKmkVovpwgchrO4YWrtXljUFAhhavzf+YiAdOHYT52s RDsDLsvjMbxEHsz4cHfycmshYhjzjb340wkoDXuQpj0zrO99d+Zd83xdK8pS0UQn OaljLRAd/5iBjTSyZPSrB1U5141OzlM3QZVJzaYAnP12yhR9eaX2twSCk+lPYOWd nhLJjNnj1B1XSGArthuE5NLyEiCPz6KyN2RhO0EOx5YjZN9TwH7LS9upyNFe1nN1 GIhO5gz+jWLuBZE3xzRNjJyCx/I/LolpCwGMvKDu6638rpsbrPs= =tT5/ -----END PGP SIGNATURE----- Merge tag 'v1.20.0rc5' into develop Synapse 1.20.0rc5 (2020-09-18) ============================== In addition to the below, Synapse 1.20.0rc5 also includes the bug fix that was included in 1.19.3. Features -------- - Add flags to the `/versions` endpoint for whether new rooms default to using E2EE. ([\#8343](https://github.com/matrix-org/synapse/issues/8343)) Bugfixes -------- - Fix rate limiting of federation `/send` requests. ([\#8342](https://github.com/matrix-org/synapse/issues/8342)) - Fix a longstanding bug where back pagination over federation could get stuck if it failed to handle a received event. ([\#8349](https://github.com/matrix-org/synapse/issues/8349)) Internal Changes ---------------- - Blacklist [MSC2753](https://github.com/matrix-org/matrix-doc/pull/2753) SyTests until it is implemented. ([\#8285](https://github.com/matrix-org/synapse/issues/8285))	2020-09-18 11:17:58 -04:00
Patrick Cloke	d5f7182ba1	1.20.0rc5	2020-09-18 10:56:50 -04:00
Dirk Klimpel	d688b4bafc	Admin API for querying rooms where a user is a member (#8306 ) Add a new admin API `GET /_synapse/admin/v1/users/<user_id>/joined_rooms` to list all rooms where a user is a member.	2020-09-18 15:26:36 +01:00
reivilibre	36efbcaf51	Catch-up after Federation Outage (bonus): Catch-up on Synapse Startup (#8322 ) Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Fix _set_destination_retry_timings This came about because the code assumed that retry_interval could not be NULL — which has been challenged by catch-up.	2020-09-18 14:59:13 +01:00
Patrick Cloke	8a4a4186de	Simplify super() calls to Python 3 syntax. (#8344 ) This converts calls like super(Foo, self) -> super(). Generated with: sed -i "" -Ee 's/super\([^\(]+\)/super()/g' */.py	2020-09-18 09:56:44 -04:00
Will Hunt	68c7a6936f	Allow appservice users to /login (#8320 ) Add ability for ASes to /login using the `uk.half-shot.msc2778.login.application_service` login `type`. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2020-09-18 14:55:13 +01:00
Erik Johnston	43f2b67e4d	Intelligently select extremities used in backfill. (#8349 ) Instead of just using the most recent extremities let's pick the ones that will give us results that the pagination request cares about, i.e. pick extremities only if they have a smaller depth than the pagination token. This is useful when we fail to backfill an extremity, as we no longer get stuck requesting that same extremity repeatedly.	2020-09-18 14:25:52 +01:00
Jonathan de Jong	7c407efdc8	Update test logging to be able to accept braces (#8335 )	2020-09-18 07:56:40 -04:00
Patrick Cloke	9db4c1b175	Add flags to /versions about whether new rooms are encrypted by default. (#8343 )	2020-09-18 07:56:20 -04:00
Erik Johnston	5e42e61609	Merge remote-tracking branch 'origin/release-v1.20.0' into develop	2020-09-18 10:50:04 +01:00
Erik Johnston	14b5b48a22	Fix ratelimiting for federation `/send` requests. (#8342 ) c.f. #8295 for rationale	2020-09-18 10:49:29 +01:00
Jonathan de Jong	efb6b6629c	Move lint dependencies to extras_require (#8330 ) Lint dependencies can now be installed with pip install -e ".[lint]" This should help keep the version in sync between tox and documentation.	2020-09-17 16:45:22 -04:00
Matthew Hodgson	ad055ea4cc	blacklist MSC2753 sytests until it's implemented in synapse (#8285 ) Dendrite's implementing MSC2753 over at https://github.com/matrix-org/dendrite/pull/1370 to prove the implementation for MSC purposes, and so sytest has sprouted tests for it over at https://github.com/matrix-org/sytest/pull/944. But we don't want them to run on synapse until synapse implements it.	2020-09-17 14:02:20 -04:00
Jonathan de Jong	837293c314	Remove obsolete __future__ imports (#8337 )	2020-09-17 08:37:01 -04:00
Patrick Cloke	c3c9732c53	Use admin_patterns for all admin APIs. (#8331 ) This reduces duplication of the admin prefix in regular expressions.	2020-09-17 07:04:15 -04:00
Jonathan de Jong	53284c425e	Fix a potential bug of UnboundLocalError (#8329 ) Replaced with less buggier control flow	2020-09-17 11:54:56 +01:00
Jonathan de Jong	a3f124b821	Switch metaclass initialization to python 3-compatible syntax (#8326 )	2020-09-16 15:15:55 -04:00
Erik Johnston	5ffd68dca1	1.19.2	2020-09-16 13:37:03 +01:00
Erik Johnston	5dd051acae	Merge branch 'erikj/fix_origin_check' into develop	2020-09-16 12:43:02 +01:00
Erik Johnston	97659b7489	Newsfile	2020-09-16 12:05:01 +01:00
reivilibre	576bc37d31	Catch-up after Federation Outage (split, 4): catch-up loop (#8272 )	2020-09-15 09:07:19 +01:00
Patrick Cloke	aec294ee0d	Use slots in attrs classes where possible (#8296 ) slots use less memory (and attribute access is faster) while slightly limiting the flexibility of the class attributes. This focuses on objects which are instantiated "often" and for short periods of time.	2020-09-14 12:50:06 -04:00
Tulir Asokan	b82d68c0bd	Add the topic and avatar to the room details admin API (#8305 )	2020-09-14 10:07:04 -04:00
Patrick Cloke	6605470bfb	Improve SAML error messages (#8248 )	2020-09-14 09:05:36 -04:00
Erik Johnston	04cc249b43	Add experimental support for sharding event persister. Again. (#8294 ) This is not ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.	2020-09-14 10:16:41 +01:00
Erik Johnston	fe8ed1b46f	Make `StreamToken.room_key` be a `RoomStreamToken` instance. (#8281 )	2020-09-11 12:22:55 +01:00
Dan Callaghan	c312ee3cde	Use TLSv1.2 for fake servers in tests (#8208 ) Some Linux distros have begun disabling TLSv1.0 and TLSv1.1 by default for security reasons, for example in Fedora 33 onwards: https://fedoraproject.org/wiki/Changes/StrongCryptoSettings2 Use TLSv1.2 for the fake TLS servers created in the test suite, to avoid failures due to OpenSSL disallowing TLSv1.0: <twisted.python.failure.Failure OpenSSL.SSL.Error: [('SSL routines', 'ssl_choose_client_version', 'unsupported protocol')]> Signed-off-by: Dan Callaghan <djc@djc.id.au>	2020-09-10 19:49:08 +01:00
Andrew Morgan	95d869c357	Add /_synapse/client to the reverse proxy docs (#8227 ) This PR adds a information about forwarding `/_synapse/client` endpoints through your reverse proxy. The first of these endpoints are introduced in https://github.com/matrix-org/synapse/pull/8004.	2020-09-10 13:26:34 +01:00
Erik Johnston	5d3e306d9f	Clean up `Notifier.on_new_room_event` code path (#8288 ) The idea here is that we pass the `max_stream_id` to everything, and only use the stream ID of the particular event to figure out when the max stream position has caught up to the event and we can notify people about it. This is to maintain the distinction between the position of an item in the stream (i.e. event A has stream ID 513) and a token that can be used to partition the stream (i.e. give me all events after stream ID 352). This distinction becomes important when the tokens are more complicated than a single number, which they will be once we start tracking the position of multiple writers in the tokens. The valid operations here are: 1. Is a position before or after a token 2. Fetching all events between two tokens 3. Merging multiple tokens to get the "max", i.e. `C = max(A, B)` means that for all positions P where P is before A or before B, then P is before C. Future PR will change the token type to a dedicated type.	2020-09-10 13:24:43 +01:00
Andrew Morgan	a3a90ee031	Show a confirmation page during user password reset (#8004 ) This PR adds a confirmation step to resetting your user password between clicking the link in your email and your password actually being reset. This is to better align our password reset flow with the industry standard of requiring a confirmation from the user after email validation.	2020-09-10 11:45:12 +01:00
Patrick Cloke	b312769c0e	Do not error when thumbnailing invalid files (#8236 ) If a file cannot be thumbnailed for some reason (e.g. the file is empty), then catch the exception and convert it to a reasonable error message for the client.	2020-09-09 12:59:41 -04:00
Patrick Cloke	2ea1c68249	Remove some unused distributor signals (#8216 ) Removes the `user_joined_room` and stops calling it since there are no observers. Also cleans-up some other unused signals and related code.	2020-09-09 12:22:00 -04:00
Erik Johnston	c9dbee50ae	Fixup pusher pool notifications (#8287 ) `pusher_pool.on_new_notifications` expected a min and max stream ID, however that was not what we were passing in. Instead, let's just pass it the current max stream ID and have it track the last stream ID it got passed. I believe that it mostly worked as we called the function for every event. However, it would break for events that got persisted out of order, i.e, that were persisted but the max stream ID wasn't incremented as not all preceding events had finished persisting, and push for that event would be delayed until another event got pushed to the effected users.	2020-09-09 16:56:08 +01:00
Matthew Hodgson	453dfe210b	blacklist MSC2753 sytests until it's implemented in synapse (#8285 ) Dendrite's implementing MSC2753 over at https://github.com/matrix-org/dendrite/pull/1370 to prove the implementation for MSC purposes, and so sytest has sprouted tests for it over at https://github.com/matrix-org/sytest/pull/944. But we don't want them to run on synapse until synapse implements it.	2020-09-09 13:25:59 +01:00
reivilibre	a5370072b5	Don't remember `enabled` of deleted push rules and properly return 404 for missing push rules in `.../actions` and `.../enabled` (#7796 ) Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-09-09 11:39:39 +01:00
Patrick Cloke	e45b834119	Add types to async_helpers (#8260 )	2020-09-08 16:50:51 -04:00
Erik Johnston	1553adc831	Fix mypy error on develop (#8282 )	2020-09-08 17:43:31 +01:00
DeepBlueV7.X	560f3b8609	Include method in thumbnail media name (#7124 ) This fixes an issue where different methods (crop/scale) overwrite each other. This first tries the new path. If that fails and we are looking for a remote thumbnail, it tries the old path. If that still isn't found, it continues as normal. This should probably be removed in the future, after some of the newer thumbnails were generated with the new path on most deployments. Then the overhead should be minimal if the other thumbnails need to be regenerated. Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>	2020-09-08 17:19:50 +01:00
Erik Johnston	63c0e9e195	Add types to StreamToken and RoomStreamToken (#8279 ) The intention here is to change `StreamToken.room_key` to be a `RoomStreamToken` in a future PR, but that is a big enough change without this refactoring too.	2020-09-08 16:48:15 +01:00
Andrew Morgan	094896a69d	Add a config option for validating 'next_link' parameters against a domain whitelist (#8275 ) This is a config option ported over from DINUM's Sydent: https://github.com/matrix-org/sydent/pull/285 They've switched to validating 3PIDs via Synapse rather than Sydent, and would like to retain this functionality. This original purpose for this change is phishing prevention. This solution could also potentially be replaced by a similar one to https://github.com/matrix-org/synapse/pull/8004, but across all `*/submit_token` endpoint. This option may still be useful to enterprise even with that safeguard in place though, if they want to be absolutely sure that their employees don't follow links to other domains.	2020-09-08 16:03:09 +01:00
Erik Johnston	0f545e6b96	Clean up types for PaginationConfig (#8250 ) This removes `SourcePaginationConfig` and `get_pagination_rows`. The reasoning behind this is that these generic classes/functions erased the types of the IDs it used (i.e. instead of passing around `StreamToken` it'd pass in e.g. `token.room_key`, which don't have uniform types).	2020-09-08 15:00:17 +01:00
Richard van der Hoff	703e2b8a96	Use the right constructor for log records (#8278 ) Update `log_function` to use the right factory to create log records, to make sure that they have `request` attributes. Fixes: #8267.	2020-09-08 14:52:51 +01:00
Erik Johnston	deedb91732	Fix `MultiWriterIdGenerator.current_position`. (#8257 ) It did not correctly handle IDs finishing being persisted out of order, resulting in the `current_position` lagging until new IDs are persisted.	2020-09-08 14:26:54 +01:00
Richard van der Hoff	cca03dbec8	Synapse 1.20.0rc1 (2020-09-08) ============================== Removal warning --------------- Some older clients used a [disallowed character](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-register-email-requesttoken) (`:`) in the `client_secret` parameter of various endpoints. The incorrect behaviour was allowed for backwards compatibility, but is now being removed from Synapse as most users have updated their client. Further context can be found at [\#6766](https://github.com/matrix-org/synapse/issues/6766). Features -------- - Add an endpoint to query your shared rooms with another user as an implementation of [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666). ([\#7785](https://github.com/matrix-org/synapse/issues/7785)) - Iteratively encode JSON to avoid blocking the reactor. ([\#8013](https://github.com/matrix-org/synapse/issues/8013), [\#8116](https://github.com/matrix-org/synapse/issues/8116)) - Add support for shadow-banning users (ignoring any message send requests). ([\#8034](https://github.com/matrix-org/synapse/issues/8034), [\#8092](https://github.com/matrix-org/synapse/issues/8092), [\#8095](https://github.com/matrix-org/synapse/issues/8095), [\#8142](https://github.com/matrix-org/synapse/issues/8142), [\#8152](https://github.com/matrix-org/synapse/issues/8152), [\#8157](https://github.com/matrix-org/synapse/issues/8157), [\#8158](https://github.com/matrix-org/synapse/issues/8158), [\#8176](https://github.com/matrix-org/synapse/issues/8176)) - Use the default template file when its equivalent is not found in a custom template directory. ([\#8037](https://github.com/matrix-org/synapse/issues/8037), [\#8107](https://github.com/matrix-org/synapse/issues/8107), [\#8252](https://github.com/matrix-org/synapse/issues/8252)) - Add unread messages count to sync responses, as specified in [MSC2654](https://github.com/matrix-org/matrix-doc/pull/2654). ([\#8059](https://github.com/matrix-org/synapse/issues/8059), [\#8254](https://github.com/matrix-org/synapse/issues/8254), [\#8270](https://github.com/matrix-org/synapse/issues/8270), [\#8274](https://github.com/matrix-org/synapse/issues/8274)) - Optimise `/federation/v1/user/devices/` API by only returning devices with encryption keys. ([\#8198](https://github.com/matrix-org/synapse/issues/8198)) Bugfixes -------- - Fix a memory leak by limiting the length of time that messages will be queued for a remote server that has been unreachable. ([\#7864](https://github.com/matrix-org/synapse/issues/7864)) - Fix `Re-starting finished log context PUT-nnnn` warning when event persistence failed. ([\#8081](https://github.com/matrix-org/synapse/issues/8081)) - Synapse now correctly enforces the valid characters in the `client_secret` parameter used in various endpoints. ([\#8101](https://github.com/matrix-org/synapse/issues/8101)) - Fix a bug introduced in v1.7.2 impacting message retention policies that would allow federated homeservers to dictate a retention period that's lower than the configured minimum allowed duration in the configuration file. ([\#8104](https://github.com/matrix-org/synapse/issues/8104)) - Fix a long-standing bug where invalid JSON would be accepted by Synapse. ([\#8106](https://github.com/matrix-org/synapse/issues/8106)) - Fix a bug introduced in Synapse v1.12.0 which could cause `/sync` requests to fail with a 404 if you had a very old outstanding room invite. ([\#8110](https://github.com/matrix-org/synapse/issues/8110)) - Return a proper error code when the rooms of an invalid group are requested. ([\#8129](https://github.com/matrix-org/synapse/issues/8129)) - Fix a bug which could cause a leaked postgres connection if synapse was set to daemonize. ([\#8131](https://github.com/matrix-org/synapse/issues/8131)) - Clarify the error code if a user tries to register with a numeric ID. This bug was introduced in v1.15.0. ([\#8135](https://github.com/matrix-org/synapse/issues/8135)) - Fix a bug where appservices with ratelimiting disabled would still be ratelimited when joining rooms. This bug was introduced in v1.19.0. ([\#8139](https://github.com/matrix-org/synapse/issues/8139)) - Fix logging in via OpenID Connect with a provider that uses integer user IDs. ([\#8190](https://github.com/matrix-org/synapse/issues/8190)) - Fix a longstanding bug where user directory updates could break when unexpected profile data was included in events. ([\#8223](https://github.com/matrix-org/synapse/issues/8223)) - Fix a longstanding bug where stats updates could break when unexpected profile data was included in events. ([\#8226](https://github.com/matrix-org/synapse/issues/8226)) - Fix slow start times for large servers by removing a table scan of the `users` table from startup code. ([\#8271](https://github.com/matrix-org/synapse/issues/8271)) Updates to the Docker image --------------------------- - Fix builds of the Docker image on non-x86 platforms. ([\#8144](https://github.com/matrix-org/synapse/issues/8144)) - Added curl for healthcheck support and readme updates for the change. Contributed by @maquis196. ([\#8147](https://github.com/matrix-org/synapse/issues/8147)) Improved Documentation ---------------------- - Link to matrix-synapse-rest-password-provider in the password provider documentation. ([\#8111](https://github.com/matrix-org/synapse/issues/8111)) - Updated documentation to note that Synapse does not follow `HTTP 308` redirects due to an upstream library not supporting them. Contributed by Ryan Cole. ([\#8120](https://github.com/matrix-org/synapse/issues/8120)) - Explain better what GDPR-erased means when deactivating a user. ([\#8189](https://github.com/matrix-org/synapse/issues/8189)) Internal Changes ---------------- - Add filter `name` to the `/users` admin API, which filters by user ID or displayname. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7377](https://github.com/matrix-org/synapse/issues/7377), [\#8163](https://github.com/matrix-org/synapse/issues/8163)) - Reduce run times of some unit tests by advancing the reactor a fewer number of times. ([\#7757](https://github.com/matrix-org/synapse/issues/7757)) - Don't fail `/submit_token` requests on incorrect session ID if `request_token_inhibit_3pid_errors` is turned on. ([\#7991](https://github.com/matrix-org/synapse/issues/7991)) - Convert various parts of the codebase to async/await. ([\#8071](https://github.com/matrix-org/synapse/issues/8071), [\#8072](https://github.com/matrix-org/synapse/issues/8072), [\#8074](https://github.com/matrix-org/synapse/issues/8074), [\#8075](https://github.com/matrix-org/synapse/issues/8075), [\#8076](https://github.com/matrix-org/synapse/issues/8076), [\#8087](https://github.com/matrix-org/synapse/issues/8087), [\#8100](https://github.com/matrix-org/synapse/issues/8100), [\#8119](https://github.com/matrix-org/synapse/issues/8119), [\#8121](https://github.com/matrix-org/synapse/issues/8121), [\#8133](https://github.com/matrix-org/synapse/issues/8133), [\#8156](https://github.com/matrix-org/synapse/issues/8156), [\#8162](https://github.com/matrix-org/synapse/issues/8162), [\#8166](https://github.com/matrix-org/synapse/issues/8166), [\#8168](https://github.com/matrix-org/synapse/issues/8168), [\#8173](https://github.com/matrix-org/synapse/issues/8173), [\#8191](https://github.com/matrix-org/synapse/issues/8191), [\#8192](https://github.com/matrix-org/synapse/issues/8192), [\#8193](https://github.com/matrix-org/synapse/issues/8193), [\#8194](https://github.com/matrix-org/synapse/issues/8194), [\#8195](https://github.com/matrix-org/synapse/issues/8195), [\#8197](https://github.com/matrix-org/synapse/issues/8197), [\#8199](https://github.com/matrix-org/synapse/issues/8199), [\#8200](https://github.com/matrix-org/synapse/issues/8200), [\#8201](https://github.com/matrix-org/synapse/issues/8201), [\#8202](https://github.com/matrix-org/synapse/issues/8202), [\#8207](https://github.com/matrix-org/synapse/issues/8207), [\#8213](https://github.com/matrix-org/synapse/issues/8213), [\#8214](https://github.com/matrix-org/synapse/issues/8214)) - Remove some unused database functions. ([\#8085](https://github.com/matrix-org/synapse/issues/8085)) - Add type hints to various parts of the codebase. ([\#8090](https://github.com/matrix-org/synapse/issues/8090), [\#8127](https://github.com/matrix-org/synapse/issues/8127), [\#8187](https://github.com/matrix-org/synapse/issues/8187), [\#8241](https://github.com/matrix-org/synapse/issues/8241), [\#8140](https://github.com/matrix-org/synapse/issues/8140), [\#8183](https://github.com/matrix-org/synapse/issues/8183), [\#8232](https://github.com/matrix-org/synapse/issues/8232), [\#8235](https://github.com/matrix-org/synapse/issues/8235), [\#8237](https://github.com/matrix-org/synapse/issues/8237), [\#8244](https://github.com/matrix-org/synapse/issues/8244)) - Return the previous stream token if a non-member event is a duplicate. ([\#8093](https://github.com/matrix-org/synapse/issues/8093), [\#8112](https://github.com/matrix-org/synapse/issues/8112)) - Separate `get_current_token` into two since there are two different use cases for it. ([\#8113](https://github.com/matrix-org/synapse/issues/8113)) - Remove `ChainedIdGenerator`. ([\#8123](https://github.com/matrix-org/synapse/issues/8123)) - Reduce the amount of whitespace in JSON stored and sent in responses. ([\#8124](https://github.com/matrix-org/synapse/issues/8124)) - Update the test federation client to handle streaming responses. ([\#8130](https://github.com/matrix-org/synapse/issues/8130)) - Micro-optimisations to `get_auth_chain_ids`. ([\#8132](https://github.com/matrix-org/synapse/issues/8132)) - Refactor `StreamIdGenerator` and `MultiWriterIdGenerator` to have the same interface. ([\#8161](https://github.com/matrix-org/synapse/issues/8161)) - Add functions to `MultiWriterIdGen` used by events stream. ([\#8164](https://github.com/matrix-org/synapse/issues/8164), [\#8179](https://github.com/matrix-org/synapse/issues/8179)) - Fix tests that were broken due to the merge of 1.19.1. ([\#8167](https://github.com/matrix-org/synapse/issues/8167)) - Make `SlavedIdTracker.advance` have the same interface as `MultiWriterIDGenerator`. ([\#8171](https://github.com/matrix-org/synapse/issues/8171)) - Remove unused `is_guest` parameter from, and add safeguard to, `MessageHandler.get_room_data`. ([\#8174](https://github.com/matrix-org/synapse/issues/8174), [\#8181](https://github.com/matrix-org/synapse/issues/8181)) - Standardize the mypy configuration. ([\#8175](https://github.com/matrix-org/synapse/issues/8175)) - Refactor some of `LoginRestServlet`'s helper methods, and move them to `AuthHandler` for easier reuse. ([\#8182](https://github.com/matrix-org/synapse/issues/8182)) - Fix `wait_for_stream_position` to allow multiple waiters on same stream ID. ([\#8196](https://github.com/matrix-org/synapse/issues/8196)) - Make `MultiWriterIDGenerator` work for streams that use negative values. ([\#8203](https://github.com/matrix-org/synapse/issues/8203)) - Refactor queries for device keys and cross-signatures. ([\#8204](https://github.com/matrix-org/synapse/issues/8204), [\#8205](https://github.com/matrix-org/synapse/issues/8205), [\#8222](https://github.com/matrix-org/synapse/issues/8222), [\#8224](https://github.com/matrix-org/synapse/issues/8224), [\#8225](https://github.com/matrix-org/synapse/issues/8225), [\#8231](https://github.com/matrix-org/synapse/issues/8231), [\#8233](https://github.com/matrix-org/synapse/issues/8233), [\#8234](https://github.com/matrix-org/synapse/issues/8234)) - Fix type hints for functions decorated with `@cached`. ([\#8240](https://github.com/matrix-org/synapse/issues/8240)) - Remove obsolete `order` field from federation send queues. ([\#8245](https://github.com/matrix-org/synapse/issues/8245)) - Stop sub-classing from object. ([\#8249](https://github.com/matrix-org/synapse/issues/8249)) - Add more logging to debug slow startup. ([\#8264](https://github.com/matrix-org/synapse/issues/8264)) - Do not attempt to upgrade database schema on worker processes. ([\#8266](https://github.com/matrix-org/synapse/issues/8266), [\#8276](https://github.com/matrix-org/synapse/issues/8276)) -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEv27Axt/F4vrTL/8QOSor00I9eP8FAl9XgG0ACgkQOSor00I9 eP9k9gf8DqxUoYYGGvKrUC0NW5XLLE6qiLI+a+3QqsnWvvAjCzJOPH5xsFWl0YkR phUmz0KyuIvYokr6RYEG37l7U0hWQKck1/LrgBDOtEWTO+n/bacxNawhJyFOXATc AZgnCVyhklALUre43QzwlFL1cGQnIBuAHuHa+etj5AO+9eC/QPuJBMryzUVH8dGY 37B2lLTv4ULpSsQ+neQULSyu1EOEyurxNY/RydYaC8bgrOCQgkWPbssQX6MSdHWz ua+GZ36KAQT6jUmjuTqJXbRKtewjN2anmTb5LrHz1W5GATOY7hH3xsnwHd1oikwW 56vhm1tJZExkWvqfB9XteJcIEZ0epQ== =JecA -----END PGP SIGNATURE----- Merge tag 'v1.20.0rc1' into develop Synapse 1.20.0rc1 (2020-09-08) ============================== Removal warning --------------- Some older clients used a [disallowed character](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-register-email-requesttoken) (`:`) in the `client_secret` parameter of various endpoints. The incorrect behaviour was allowed for backwards compatibility, but is now being removed from Synapse as most users have updated their client. Further context can be found at [\#6766](https://github.com/matrix-org/synapse/issues/6766). Features -------- - Add an endpoint to query your shared rooms with another user as an implementation of [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666). ([\#7785](https://github.com/matrix-org/synapse/issues/7785)) - Iteratively encode JSON to avoid blocking the reactor. ([\#8013](https://github.com/matrix-org/synapse/issues/8013), [\#8116](https://github.com/matrix-org/synapse/issues/8116)) - Add support for shadow-banning users (ignoring any message send requests). ([\#8034](https://github.com/matrix-org/synapse/issues/8034), [\#8092](https://github.com/matrix-org/synapse/issues/8092), [\#8095](https://github.com/matrix-org/synapse/issues/8095), [\#8142](https://github.com/matrix-org/synapse/issues/8142), [\#8152](https://github.com/matrix-org/synapse/issues/8152), [\#8157](https://github.com/matrix-org/synapse/issues/8157), [\#8158](https://github.com/matrix-org/synapse/issues/8158), [\#8176](https://github.com/matrix-org/synapse/issues/8176)) - Use the default template file when its equivalent is not found in a custom template directory. ([\#8037](https://github.com/matrix-org/synapse/issues/8037), [\#8107](https://github.com/matrix-org/synapse/issues/8107), [\#8252](https://github.com/matrix-org/synapse/issues/8252)) - Add unread messages count to sync responses, as specified in [MSC2654](https://github.com/matrix-org/matrix-doc/pull/2654). ([\#8059](https://github.com/matrix-org/synapse/issues/8059), [\#8254](https://github.com/matrix-org/synapse/issues/8254), [\#8270](https://github.com/matrix-org/synapse/issues/8270), [\#8274](https://github.com/matrix-org/synapse/issues/8274)) - Optimise `/federation/v1/user/devices/` API by only returning devices with encryption keys. ([\#8198](https://github.com/matrix-org/synapse/issues/8198)) Bugfixes -------- - Fix a memory leak by limiting the length of time that messages will be queued for a remote server that has been unreachable. ([\#7864](https://github.com/matrix-org/synapse/issues/7864)) - Fix `Re-starting finished log context PUT-nnnn` warning when event persistence failed. ([\#8081](https://github.com/matrix-org/synapse/issues/8081)) - Synapse now correctly enforces the valid characters in the `client_secret` parameter used in various endpoints. ([\#8101](https://github.com/matrix-org/synapse/issues/8101)) - Fix a bug introduced in v1.7.2 impacting message retention policies that would allow federated homeservers to dictate a retention period that's lower than the configured minimum allowed duration in the configuration file. ([\#8104](https://github.com/matrix-org/synapse/issues/8104)) - Fix a long-standing bug where invalid JSON would be accepted by Synapse. ([\#8106](https://github.com/matrix-org/synapse/issues/8106)) - Fix a bug introduced in Synapse v1.12.0 which could cause `/sync` requests to fail with a 404 if you had a very old outstanding room invite. ([\#8110](https://github.com/matrix-org/synapse/issues/8110)) - Return a proper error code when the rooms of an invalid group are requested. ([\#8129](https://github.com/matrix-org/synapse/issues/8129)) - Fix a bug which could cause a leaked postgres connection if synapse was set to daemonize. ([\#8131](https://github.com/matrix-org/synapse/issues/8131)) - Clarify the error code if a user tries to register with a numeric ID. This bug was introduced in v1.15.0. ([\#8135](https://github.com/matrix-org/synapse/issues/8135)) - Fix a bug where appservices with ratelimiting disabled would still be ratelimited when joining rooms. This bug was introduced in v1.19.0. ([\#8139](https://github.com/matrix-org/synapse/issues/8139)) - Fix logging in via OpenID Connect with a provider that uses integer user IDs. ([\#8190](https://github.com/matrix-org/synapse/issues/8190)) - Fix a longstanding bug where user directory updates could break when unexpected profile data was included in events. ([\#8223](https://github.com/matrix-org/synapse/issues/8223)) - Fix a longstanding bug where stats updates could break when unexpected profile data was included in events. ([\#8226](https://github.com/matrix-org/synapse/issues/8226)) - Fix slow start times for large servers by removing a table scan of the `users` table from startup code. ([\#8271](https://github.com/matrix-org/synapse/issues/8271)) Updates to the Docker image --------------------------- - Fix builds of the Docker image on non-x86 platforms. ([\#8144](https://github.com/matrix-org/synapse/issues/8144)) - Added curl for healthcheck support and readme updates for the change. Contributed by @maquis196. ([\#8147](https://github.com/matrix-org/synapse/issues/8147)) Improved Documentation ---------------------- - Link to matrix-synapse-rest-password-provider in the password provider documentation. ([\#8111](https://github.com/matrix-org/synapse/issues/8111)) - Updated documentation to note that Synapse does not follow `HTTP 308` redirects due to an upstream library not supporting them. Contributed by Ryan Cole. ([\#8120](https://github.com/matrix-org/synapse/issues/8120)) - Explain better what GDPR-erased means when deactivating a user. ([\#8189](https://github.com/matrix-org/synapse/issues/8189)) Internal Changes ---------------- - Add filter `name` to the `/users` admin API, which filters by user ID or displayname. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7377](https://github.com/matrix-org/synapse/issues/7377), [\#8163](https://github.com/matrix-org/synapse/issues/8163)) - Reduce run times of some unit tests by advancing the reactor a fewer number of times. ([\#7757](https://github.com/matrix-org/synapse/issues/7757)) - Don't fail `/submit_token` requests on incorrect session ID if `request_token_inhibit_3pid_errors` is turned on. ([\#7991](https://github.com/matrix-org/synapse/issues/7991)) - Convert various parts of the codebase to async/await. ([\#8071](https://github.com/matrix-org/synapse/issues/8071), [\#8072](https://github.com/matrix-org/synapse/issues/8072), [\#8074](https://github.com/matrix-org/synapse/issues/8074), [\#8075](https://github.com/matrix-org/synapse/issues/8075), [\#8076](https://github.com/matrix-org/synapse/issues/8076), [\#8087](https://github.com/matrix-org/synapse/issues/8087), [\#8100](https://github.com/matrix-org/synapse/issues/8100), [\#8119](https://github.com/matrix-org/synapse/issues/8119), [\#8121](https://github.com/matrix-org/synapse/issues/8121), [\#8133](https://github.com/matrix-org/synapse/issues/8133), [\#8156](https://github.com/matrix-org/synapse/issues/8156), [\#8162](https://github.com/matrix-org/synapse/issues/8162), [\#8166](https://github.com/matrix-org/synapse/issues/8166), [\#8168](https://github.com/matrix-org/synapse/issues/8168), [\#8173](https://github.com/matrix-org/synapse/issues/8173), [\#8191](https://github.com/matrix-org/synapse/issues/8191), [\#8192](https://github.com/matrix-org/synapse/issues/8192), [\#8193](https://github.com/matrix-org/synapse/issues/8193), [\#8194](https://github.com/matrix-org/synapse/issues/8194), [\#8195](https://github.com/matrix-org/synapse/issues/8195), [\#8197](https://github.com/matrix-org/synapse/issues/8197), [\#8199](https://github.com/matrix-org/synapse/issues/8199), [\#8200](https://github.com/matrix-org/synapse/issues/8200), [\#8201](https://github.com/matrix-org/synapse/issues/8201), [\#8202](https://github.com/matrix-org/synapse/issues/8202), [\#8207](https://github.com/matrix-org/synapse/issues/8207), [\#8213](https://github.com/matrix-org/synapse/issues/8213), [\#8214](https://github.com/matrix-org/synapse/issues/8214)) - Remove some unused database functions. ([\#8085](https://github.com/matrix-org/synapse/issues/8085)) - Add type hints to various parts of the codebase. ([\#8090](https://github.com/matrix-org/synapse/issues/8090), [\#8127](https://github.com/matrix-org/synapse/issues/8127), [\#8187](https://github.com/matrix-org/synapse/issues/8187), [\#8241](https://github.com/matrix-org/synapse/issues/8241), [\#8140](https://github.com/matrix-org/synapse/issues/8140), [\#8183](https://github.com/matrix-org/synapse/issues/8183), [\#8232](https://github.com/matrix-org/synapse/issues/8232), [\#8235](https://github.com/matrix-org/synapse/issues/8235), [\#8237](https://github.com/matrix-org/synapse/issues/8237), [\#8244](https://github.com/matrix-org/synapse/issues/8244)) - Return the previous stream token if a non-member event is a duplicate. ([\#8093](https://github.com/matrix-org/synapse/issues/8093), [\#8112](https://github.com/matrix-org/synapse/issues/8112)) - Separate `get_current_token` into two since there are two different use cases for it. ([\#8113](https://github.com/matrix-org/synapse/issues/8113)) - Remove `ChainedIdGenerator`. ([\#8123](https://github.com/matrix-org/synapse/issues/8123)) - Reduce the amount of whitespace in JSON stored and sent in responses. ([\#8124](https://github.com/matrix-org/synapse/issues/8124)) - Update the test federation client to handle streaming responses. ([\#8130](https://github.com/matrix-org/synapse/issues/8130)) - Micro-optimisations to `get_auth_chain_ids`. ([\#8132](https://github.com/matrix-org/synapse/issues/8132)) - Refactor `StreamIdGenerator` and `MultiWriterIdGenerator` to have the same interface. ([\#8161](https://github.com/matrix-org/synapse/issues/8161)) - Add functions to `MultiWriterIdGen` used by events stream. ([\#8164](https://github.com/matrix-org/synapse/issues/8164), [\#8179](https://github.com/matrix-org/synapse/issues/8179)) - Fix tests that were broken due to the merge of 1.19.1. ([\#8167](https://github.com/matrix-org/synapse/issues/8167)) - Make `SlavedIdTracker.advance` have the same interface as `MultiWriterIDGenerator`. ([\#8171](https://github.com/matrix-org/synapse/issues/8171)) - Remove unused `is_guest` parameter from, and add safeguard to, `MessageHandler.get_room_data`. ([\#8174](https://github.com/matrix-org/synapse/issues/8174), [\#8181](https://github.com/matrix-org/synapse/issues/8181)) - Standardize the mypy configuration. ([\#8175](https://github.com/matrix-org/synapse/issues/8175)) - Refactor some of `LoginRestServlet`'s helper methods, and move them to `AuthHandler` for easier reuse. ([\#8182](https://github.com/matrix-org/synapse/issues/8182)) - Fix `wait_for_stream_position` to allow multiple waiters on same stream ID. ([\#8196](https://github.com/matrix-org/synapse/issues/8196)) - Make `MultiWriterIDGenerator` work for streams that use negative values. ([\#8203](https://github.com/matrix-org/synapse/issues/8203)) - Refactor queries for device keys and cross-signatures. ([\#8204](https://github.com/matrix-org/synapse/issues/8204), [\#8205](https://github.com/matrix-org/synapse/issues/8205), [\#8222](https://github.com/matrix-org/synapse/issues/8222), [\#8224](https://github.com/matrix-org/synapse/issues/8224), [\#8225](https://github.com/matrix-org/synapse/issues/8225), [\#8231](https://github.com/matrix-org/synapse/issues/8231), [\#8233](https://github.com/matrix-org/synapse/issues/8233), [\#8234](https://github.com/matrix-org/synapse/issues/8234)) - Fix type hints for functions decorated with `@cached`. ([\#8240](https://github.com/matrix-org/synapse/issues/8240)) - Remove obsolete `order` field from federation send queues. ([\#8245](https://github.com/matrix-org/synapse/issues/8245)) - Stop sub-classing from object. ([\#8249](https://github.com/matrix-org/synapse/issues/8249)) - Add more logging to debug slow startup. ([\#8264](https://github.com/matrix-org/synapse/issues/8264)) - Do not attempt to upgrade database schema on worker processes. ([\#8266](https://github.com/matrix-org/synapse/issues/8266), [\#8276](https://github.com/matrix-org/synapse/issues/8276))	2020-09-08 14:04:20 +01:00
Richard van der Hoff	525efab612	1.20.0rc1	2020-09-08 12:58:37 +01:00
Patrick Cloke	72bec36d50	Directly import json from the standard library. (#8259 ) By importing from canonicaljson the simplejson module was still being used in some situations. After this change the std lib json is consistenty used throughout Synapse.	2020-09-08 07:33:48 -04:00
Patrick Cloke	cef00211c8	Allow for make_awaitable's return value to be re-used. (#8261 )	2020-09-08 07:26:55 -04:00
Andrew Morgan	68cdb3708e	Rename 'populate_stats_process_rooms_2' background job back to 'populate_stats_process_rooms' again (#8243 ) Fixes https://github.com/matrix-org/synapse/issues/8238 Alongside the delta file, some changes were also necessary to the codebase to remove references to the now defunct `populate_stats_process_rooms_2` background job. Thankfully the latter doesn't seem to have made it into any documentation yet :)	2020-09-08 11:05:59 +01:00
Richard van der Hoff	ad28030c12	Systemd docs: configure workers to start after main process. (#8276 )	2020-09-08 10:57:43 +01:00
Richard van der Hoff	8d6f97f932	Merge remote-tracking branch 'origin/release-v1.20.0' into develop	2020-09-08 09:58:07 +01:00
Brendan Abolivier	d8762cc116	Only add rows to the push actions table if the event notifies or should be marked unread (#8274 )	2020-09-07 16:56:27 +01:00
Richard van der Hoff	77794ebc77	Fix stack overflow when logging system encounters an error (#8268 )	2020-09-07 16:54:30 +01:00
Richard van der Hoff	ef2804d27c	Avoid table-scanning users at startup (#8271 ) This takes about 10 seconds in the best case; often more.	2020-09-07 16:48:52 +01:00
Brendan Abolivier	a55e2707d7	Fix unread count failing on NULL values (#8270 ) Fix unread counts making sync fail if the value of the `unread_count` column in `event_push_summary` is `None`.	2020-09-07 15:15:06 +01:00
Richard van der Hoff	0dae7d80bf	Add more logging to debug slow startup (#8264 ) I'm hoping this will provide some pointers for debugging https://github.com/matrix-org/synapse/issues/7968.	2020-09-07 13:36:02 +01:00
Richard van der Hoff	96312536f2	Refuse to upgrade database on worker processes (#8266 )	2020-09-07 13:04:10 +01:00
Alexandre Morignot	7586fdf1e8	Bump canonicaljson to version 1.4.0 (#8262 ) The version 1.3.0 has a bug with unicode charecters: ``` >>> from canonicaljson import encode_pretty_printed_json >>> encode_pretty_printed_json({'a': 'à'}) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/erdnaxeli/.pyenv/versions/3.6.7/lib/python3.6/site-packages/canonicaljson.py", line 96, in encode_pretty_printed_json return _pretty_encoder.encode(json_object).encode("ascii") UnicodeEncodeError: 'ascii' codec can't encode character '\xe0' in position 12: ordinal not in range(128) ``` Signed-off-by: Alexandre Morignot <erdnaxeli@cervoi.se> Co-authored-by: Alexandre Morignot <erdnaxeli@cervoi.se>	2020-09-07 12:21:38 +01:00
Richard van der Hoff	5b452df23b	Run database updates in a transaction (#8265 ) Fixes: #6467	2020-09-07 11:41:50 +01:00
reivilibre	765437df54	Add tests for `last_successful_stream_ordering` (#8258 )	2020-09-07 10:11:38 +01:00
Richard van der Hoff	77b4711bc2	Merge branch 'release-v1.20.0' into develop	2020-09-06 23:32:28 +01:00
reivilibre	7513006b09	In light of #8255 , use BIGINTs for destination_rooms (#8256 )	2020-09-04 15:07:29 +01:00
reivilibre	17fa4c7ca7	Catch up after Federation Outage (split, 2): Track last successful stream ordering after transmission (#8247 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-09-04 15:06:51 +01:00
Richard van der Hoff	f25af1f9c7	Add cross-signing sigs to the `keys` object (#8234 ) All the callers want this info in the same place, so let's reduce the duplication by doing it here.	2020-09-04 15:06:05 +01:00
Brendan Abolivier	041ee971c9	Unread counts fixes (#8254 ) * Fixup `ALTER TABLE` database queries Make the new columns nullable, because doing otherwise can wedge a server with a big database, as setting a default value rewrites the table. * Switch back to using the notifications count in the push badge Clients are likely to be confused if we send a push but the badge count is the unread messages one, and not the notifications one. * Changelog	2020-09-04 14:14:22 +01:00
Patrick Cloke	db7de4d182	Fix a regression from calling read_templates. (#8252 ) Regressed in #8037.	2020-09-04 09:10:33 -04:00
reivilibre	58f61f10f7	Catch-up after Federation Outage (split, 1) (#8230 ) Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>	2020-09-04 12:22:23 +01:00
reivilibre	e351298444	Fix type signature in simple_select_one_onecol and friends (#8241 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2020-09-04 12:02:29 +01:00
Patrick Cloke	c619253db8	Stop sub-classing object (#8249 )	2020-09-04 06:54:56 -04:00
Brendan Abolivier	9f8abdcc38	Revert "Add experimental support for sharding event persister. (#8170 )" (#8242 ) * Revert "Add experimental support for sharding event persister. (#8170)" This reverts commit `82c1ee1c22`. * Changelog	2020-09-04 10:19:42 +01:00
Erik Johnston	be16ee59a8	Add type hints to more handlers (#8244 )	2020-09-03 22:02:29 +01:00
reivilibre	4535e849d7	Remove obsolete order field in `send_new_transaction` (#8245 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-09-03 19:23:07 +01:00
Richard van der Hoff	f97f9485ee	Split fetching device keys and signatures into two transactions (#8233 ) I think this is simpler (and moves stuff out of the db threads)	2020-09-03 18:27:26 +01:00
Erik Johnston	208e1d3eb3	Fix typing for `@cached` wrapped functions (#8240 ) This requires adding a mypy plugin to fiddle with the type signatures a bit.	2020-09-03 15:38:32 +01:00
Patrick Cloke	15c35c250c	Remove useless changelog about reverting a #8239 .	2020-09-03 09:47:41 -04:00
Patrick Cloke	2aa127c207	Revert pinning of setuptools (#8239 )	2020-09-03 09:45:36 -04:00
Erik Johnston	5bfc79486d	Fix typing for SyncHandler (#8237 )	2020-09-03 12:54:10 +01:00
Richard van der Hoff	6f6f371a87	wrap `_get_e2e_device_keys_and_signatures_txn` in a non-txn method (#8231 ) We have three things which all call `_get_e2e_device_keys_and_signatures_txn` with their own `runInteraction`. Factor out the common code.	2020-09-03 11:50:49 +01:00
Patrick Cloke	c8758cb72f	Add an overload for simple_select_one_onecol_txn. (#8235 )	2020-09-02 15:03:12 -04:00
Patrick Cloke	912e024913	Convert runInteraction to async/await (#8156 )	2020-09-02 13:11:02 -04:00
Erik Johnston	112266eafd	Add StreamStore to mypy (#8232 )	2020-09-02 17:52:38 +01:00
Brendan Abolivier	5a1dd297c3	Re-implement unread counts (again) (#8059 )	2020-09-02 17:19:37 +01:00
Richard van der Hoff	0d4f614fda	Refactor `_get_e2e_device_keys_for_federation_query_txn` (#8225 ) We can use the existing `_get_e2e_device_keys_and_signatures_txn` instead of creating our own txn function	2020-09-02 15:53:26 +01:00
Erik Johnston	82c1ee1c22	Add experimental support for sharding event persister. (#8170 ) This is not ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.	2020-09-02 15:48:37 +01:00
Will Hunt	b257c788c0	Add /user/{user_id}/shared_rooms/ api (#7785 ) * Add shared_rooms api * Add changelog * Add . * Wrap response in {"rooms": } * linting * Add unstable_features key * Remove options from isort that aren't part of 5.x `-y` and `-rc` are now default behaviour and no longer exist. `dont-skip` is no longer required https://timothycrosley.github.io/isort/CHANGELOG/#500-penny-july-4-2020 * Update imports to make isort happy * Add changelog * Update tox.ini file with correct invocation * fix linting again for isort * Vendor prefix unstable API * Fix to match spec * import Codes * import Codes * Use FORBIDDEN * Update changelog.d/7785.feature Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Implement get_shared_rooms_for_users * a comma * trailing whitespace * Handle the easy feedback * Switch to using runInteraction * Add tests * Feedback * Seperate unstable endpoint from v2 * Add upgrade node * a line * Fix style by adding a blank line at EOF. * Update synapse/storage/databases/main/user_directory.py Co-authored-by: Tulir Asokan <tulir@maunium.net> * Update synapse/storage/databases/main/user_directory.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Update UPGRADE.rst Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Fix UPGRADE/CHANGELOG unstable paths unstable unstable unstable Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net>	2020-09-02 13:18:40 +01:00
Patrick Cloke	9356656e67	Do not try to store invalid data in the stats table (#8226 )	2020-09-02 07:59:39 -04:00
Patrick Cloke	d250521cf5	Convert the main methods run by the reactor to async. (#8213 )	2020-09-02 07:44:50 -04:00
Richard van der Hoff	abeab964d5	Make _get_e2e_device_keys_and_signatures_txn return an attrs (#8224 ) this makes it a bit clearer what's going on.	2020-09-02 11:47:26 +01:00
Patrick Cloke	b939251c37	Fix errors when updating the user directory with invalid data (#8223 )	2020-09-01 13:02:41 -04:00
Brendan Abolivier	b5133dd97f	Explain better what GDPR-erased means (#8189 ) Fixes https://github.com/matrix-org/synapse/issues/8185	2020-09-01 16:31:59 +01:00
Patrick Cloke	37db6252b7	Convert additional databases to async/await part 3 (#8201 )	2020-09-01 11:04:17 -04:00
Patrick Cloke	7d103a594e	Convert appservice code to async/await. (#8207 )	2020-09-01 11:03:49 -04:00
Richard van der Hoff	5615eb5cb4	Rename `_get_e2e_device_keys_txn` (#8222 ) ... to `_get_e2e_device_keys_and_signatures_txn`, to better reflect what it does.	2020-09-01 16:02:17 +01:00
Patrick Cloke	54f8d73c00	Convert additional databases to async/await (#8199 )	2020-09-01 09:21:48 -04:00
Patrick Cloke	5bf8e5f55b	Convert the well known resolver to async (#8214 )	2020-09-01 09:15:22 -04:00
Patrick Cloke	da77520cd1	Convert additional databases to async/await part 2 (#8200 )	2020-09-01 08:39:04 -04:00
Erik Johnston	bbb3c8641c	Make MultiWriterIDGenerator work for streams that use negative stream IDs (#8203 ) This is so that we can use it for the backfill events stream.	2020-09-01 13:36:25 +01:00
Patrick Cloke	318245eaa6	Do not install setuptools 50.0. (#8212 ) This is due to compatibility issues with old Python versions.	2020-09-01 08:16:58 -04:00
Richard van der Hoff	aa07c37cf0	Move and rename `get_devices_with_keys_by_user` (#8204 ) * Move `get_devices_with_keys_by_user` to `EndToEndKeyWorkerStore` this seems a better fit for it. This commit simply moves the existing code: no other changes at all. * Rename `get_devices_with_keys_by_user` to better reflect what it does. * get_device_stream_token abstract method To avoid referencing fields which are declared in the derived classes, make `get_device_stream_token` abstract, and define that in the classes which define `_device_list_id_gen`.	2020-09-01 12:41:21 +01:00
Richard van der Hoff	45e8f7726f	Rename `get_e2e_device_keys` to better reflect its purpose (#8205 ) ... and to show that it does something slightly different to `_get_e2e_device_keys_txn`. `include_all_devices` and `include_deleted_devices` were never used (and `include_deleted_devices` was broken, since that would cause `None`s in the result which were not handled in the loop below. Add some typing too.	2020-08-29 00:14:17 +01:00
Patrick Cloke	d2ac767de2	Convert ReadWriteLock to async/await. (#8202 )	2020-08-28 16:47:11 -04:00
Erik Johnston	3b4556cf87	Fix `wait_for_stream_position` for multiple waiters. (#8196 ) This fixes a bug where having multiple callers waiting on the same stream and position will cause it to try and compare two deferreds, which fails (due to the sorted list having an entry of `Tuple[int, Deferred]`).	2020-08-28 17:12:45 +01:00
Patrick Cloke	d58fda99ff	Convert `event_push_actions`, `registration`, and `roommember` datastores to async (#8197 )	2020-08-28 11:34:50 -04:00
Richard van der Hoff	22b926c284	Only return devices with keys from `/federation/v1/user/devices/` (#8198 ) There's not much point in returning all the others, and some people have a silly number of devices.	2020-08-28 15:59:28 +01:00
Patrick Cloke	aec7085179	Convert state and stream stores and related code to async (#8194 )	2020-08-28 09:37:55 -04:00
Patrick Cloke	b055dc9322	Ensure that the OpenID Connect remote ID is a string. (#8190 )	2020-08-28 08:56:36 -04:00
Patrick Cloke	5c03134d0f	Convert additional database code to async/await. (#8195 )	2020-08-28 07:54:27 -04:00
Patrick Cloke	d5e73cb6aa	Define StateMap as immutable and add a MutableStateMap type. (#8183 )	2020-08-28 07:28:53 -04:00
Andrew Morgan	2c2e649be2	Move and refactor LoginRestServlet helper methods (#8182 ) This is split out from https://github.com/matrix-org/synapse/pull/7438, which had gotten rather large. `LoginRestServlet` has a couple helper methods, `login_submission_legacy_convert` and `login_id_thirdparty_from_phone`. They're primarily used for converting legacy user login submissions to "identifier" dicts ([see spec](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-login)). Identifying information such as usernames or 3PID information used to be top-level in the login body. They're now supposed to be put inside an [identifier](https://matrix.org/docs/spec/client_server/r0.6.1#identifier-types) parameter instead. #7438's purpose is to allow using the new identifier parameter during User-Interactive Authentication, which is currently handled in AuthHandler. That's why I've moved these helper methods there. I also moved the refactoring of these method from #7438 as they're relevant.	2020-08-28 09:58:17 +01:00
Patrick Cloke	e00816ad98	Do not yield on awaitables in tests. (#8193 )	2020-08-27 17:24:46 -04:00
Patrick Cloke	b49a5b9307	Convert stats and related calls to async/await (#8192 )	2020-08-27 17:24:37 -04:00
Patrick Cloke	b71d4a094c	Convert simple_delete to async/await. (#8191 )	2020-08-27 14:16:41 -04:00
Patrick Cloke	9b7ac03af3	Convert calls of async database methods to async (#8166 )	2020-08-27 13:38:41 -04:00
Patrick Cloke	c9fa696ea2	simple_search_list_txn should return None, not 0. (#8187 )	2020-08-27 12:07:13 -04:00
Erik Johnston	5649b7f3d0	Fix missing _add_persisted_position (#8179 ) This was forgotten in #8164.	2020-08-27 13:20:34 +01:00
Patrick Cloke	30426c7063	Convert additional database methods to async (select list, search, insert_many, delete_*) (#8168 )	2020-08-27 07:41:01 -04:00
Patrick Cloke	4a739c73b4	Convert simple_update* and simple_select* to async (#8173 )	2020-08-27 07:08:38 -04:00
Andrew Morgan	a466b67972	Reduce run-times of tests by advancing the reactor less (#7757 )	2020-08-27 11:39:53 +01:00
Andrew Morgan	b8f20e4276	Remove remaining is_guest argument uses from get_room_data calls (#8181 ) #8174 removed the `is_guest` parameter from `get_room_data`, at the same time that #8157 was merged using it, colliding together to break unit tests on develop. This PR removes the `is_guest` parameter from the call in the broken test. Uses the same changelog as #8174.	2020-08-26 17:26:56 +01:00
Patrick Cloke	6fe12c9512	Do not propagate typing notifications from shadow-banned users. (#8176 )	2020-08-26 12:05:36 -04:00
Andrew Morgan	e0d6244beb	Remove unused parameter from, and add safeguard in, get_room_data (#8174 ) Small cleanup PR. * Removed the unused `is_guest` argument * Added a safeguard to a (currently) impossible code path, fixing static checking at the same time.	2020-08-26 15:07:35 +01:00
Christopher May-Townsend	ed18f32e1b	Add required Debian dependencies to allow docker builds on the arm platform (#8144 ) Signed-off-by: Christopher May-Townsend <chris@maytownsend.co.uk>	2020-08-26 15:03:20 +01:00
Patrick Cloke	98125bba7a	Allow running mypy directly. (#8175 )	2020-08-26 09:59:37 -04:00
Richard van der Hoff	88b9807ba4	Update the test federation client to handle streaming responses (#8130 ) Now that the server supports streaming back JSON responses, it would be nice to show the response as it is streamed, in the test tool.	2020-08-26 14:11:38 +01:00
Patrick Cloke	2e6c90ff84	Do not propagate profile changes of shadow-banned users into rooms. (#8157 )	2020-08-26 08:49:01 -04:00
Erik Johnston	e3c91a3c55	Make SlavedIdTracker.advance have same interface as MultiWriterIDGenerator (#8171 )	2020-08-26 13:15:20 +01:00
Patrick Cloke	4c6c56dc58	Convert simple_select_one and simple_select_one_onecol to async (#8162 )	2020-08-26 07:19:32 -04:00
Patrick Cloke	56efa9ec71	Fix rate limiting unit tests. (#8167 ) These were passing on the release-v1.19.1 branch but started failing once merged to develop.	2020-08-26 07:19:20 -04:00
Erik Johnston	eba98fb024	Add functions to `MultiWriterIdGen` used by events stream (#8164 )	2020-08-25 17:32:30 +01:00
Patrick Cloke	5099bd68da	Do not allow send_nonmember_event to be called with shadow-banned users. (#8158 )	2020-08-25 10:52:15 -04:00
Brendan Abolivier	b79d69796c	1.19.1rc1	2020-08-25 15:24:39 +01:00
Erik Johnston	2231dffee6	Make StreamIdGen `get_next` and `get_next_mult` async (#8161 ) This is mainly so that `StreamIdGenerator` and `MultiWriterIdGenerator` will have the same interface, allowing them to be used interchangeably.	2020-08-25 15:10:08 +01:00
Andrew Morgan	74bf8d4d06	Wording fixes to 'name' user admin api filter (#8163 ) Some fixes to wording I noticed after merging #7377.	2020-08-25 15:03:24 +01:00
Manuel Stahl	97962ad17b	Search in columns 'name' and 'displayname' in the admin users endpoint (#7377 ) * Search in columns 'name' and 'displayname' in the admin users endpoint Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>	2020-08-25 14:18:14 +01:00
Patrick Cloke	5758dcf30c	Add type hints for state. (#8140 )	2020-08-24 14:25:27 -04:00
Patrick Cloke	cbd8d83da7	Stop shadow-banned users from sending non-member events. (#8142 )	2020-08-24 13:58:56 -04:00
Brendan Abolivier	420484a334	Allow capping a room's retention policy (#8104 )	2020-08-24 18:21:04 +01:00
Christopher May-Townsend	64e8a4697a	Add healthcheck for default localhost 8008 port on /health endpoint. (#8147 )	2020-08-24 18:15:18 +01:00
Patrick Cloke	3f8f96be00	Fix flaky shadow-ban tests. (#8152 )	2020-08-24 13:08:33 -04:00
Brendan Abolivier	393a811a41	Fix join ratelimiter breaking profile updates and idempotency (#8153 )	2020-08-24 18:06:04 +01:00
Will Hunt	2df82ae451	Do not apply ratelimiting on joins to appservices (#8139 ) Add new method ratelimiter.can_requester_do_action and ensure that appservices are exempt from being ratelimited. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	2020-08-24 14:53:53 +01:00
Brendan Abolivier	3f49f74610	Don't fail /submit_token requests on incorrect session ID if request_token_inhibit_3pid_errors is turned on (#7991 ) * Don't raise session_id errors on submit_token if request_token_inhibit_3pid_errors is set * Changelog * Also wait some time before responding to /requestToken * Incorporate review * Update synapse/storage/databases/main/registration.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Incorporate review Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2020-08-24 11:33:55 +01:00
Will Hunt	cbbf9126cb	Do not apply ratelimiting on joins to appservices (#8139 ) Add new method ratelimiter.can_requester_do_action and ensure that appservices are exempt from being ratelimited. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	2020-08-21 15:07:56 +01:00
Richard van der Hoff	09fd0eda81	Micro-optimisations to get_auth_chain_ids (#8132 )	2020-08-21 10:06:45 +01:00
Patrick Cloke	3f91638da6	Allow denying or shadow banning registrations via the spam checker (#8034 )	2020-08-20 15:42:58 -04:00
Patrick Cloke	e259d63f73	Stop shadow-banned users from sending invites. (#8095 )	2020-08-20 15:07:42 -04:00
Richard van der Hoff	318f4e738e	Be more tolerant of membership events in unknown rooms (#8110 ) It turns out that not all out-of-band membership events are labelled as such, so we need to be more accepting here.	2020-08-20 16:42:12 +01:00
Patrick Cloke	592cdf73be	Improve the error code when trying to register using a name reserved for guests. (#8135 )	2020-08-20 10:39:41 -04:00
Patrick Cloke	dbc630a628	Use the JSON encoder without whitespace in more places. (#8124 )	2020-08-20 10:32:33 -04:00
Patrick Cloke	5eac0b7e76	Add more types to synapse.storage.database. (#8127 )	2020-08-20 09:00:59 -04:00
Patrick Cloke	731dfff347	Ensure a group ID is valid before trying to get rooms for it. (#8129 )	2020-08-20 06:41:32 -04:00
Patrick Cloke	76c43f086a	Do not assume calls to runInteraction return Deferreds. (#8133 )	2020-08-20 06:39:55 -04:00
Richard van der Hoff	12aebdfa5a	Close the database connection we create during startup (#8131 ) ... otherwise it gets leaked.	2020-08-19 20:41:53 +01:00
Erik Johnston	c9c544cda5	Remove `ChainedIdGenerator`. (#8123 ) It's just a thin wrapper around two ID gens to make `get_current_token` and `get_next` return tuples. This can easily be replaced by calling the appropriate methods on the underlying ID gens directly.	2020-08-19 13:41:51 +01:00
Patrick Cloke	f594e434c3	Switch the JSON byte producer from a pull to a push producer. (#8116 )	2020-08-19 08:07:57 -04:00
Ryan Cole	cfeb37f039	Updated docs: Added note about missing 308 redirect support. (#8120 ) * Updated docs: Added note about missing 308 redirect support. * Added changelog	2020-08-19 12:26:50 +01:00
Patrick Cloke	eebf52be06	Be stricter about JSON that is accepted by Synapse (#8106 )	2020-08-19 07:26:03 -04:00
Patrick Cloke	d89692ea84	Convert runWithConnection to async. (#8121 )	2020-08-19 07:09:24 -04:00
Patrick Cloke	d294f0e7e1	Remove the unused inlineCallbacks code-paths in the caching code (#8119 )	2020-08-19 07:09:07 -04:00
Erik Johnston	76d21d14a0	Separate `get_current_token` into two. (#8113 ) The function is used for two purposes: 1) for subscribers of streams to get a token they can use to get further updates with, and 2) for replication to track position of the writers of the stream. For streams with a single writer the two scenarios produce the same result, however the situation becomes complicated for streams with multiple writers. The current `MultiWriterIdGenerator` does not correctly handle the first case (which is not an issue as its only used for the `caches` stream which nothing subscribes to outside of replication).	2020-08-19 10:39:31 +01:00
Patrick Cloke	f40645e60b	Convert events worker database to async/await. (#8071 )	2020-08-18 16:20:49 -04:00
Patrick Cloke	acfb7c3b5d	Add a link to the matrix-synapse-rest-password-provider. (#8111 )	2020-08-18 09:54:35 -04:00
Patrick Cloke	3c01724b33	Fix the return type of send_nonmember_events. (#8112 )	2020-08-18 09:53:13 -04:00
Andrew Morgan	5cf7c12995	Remove : from allowed client_secret chars (#8101 ) Closes: https://github.com/matrix-org/synapse/issues/6766 Equivalent Sydent PR: https://github.com/matrix-org/sydent/pull/309 I believe it's now time to remove the extra allowed `:` from `client_secret` parameters.	2020-08-18 14:14:27 +01:00
Patrick Cloke	408aef8276	Rename changelog from bugfix to misc.	2020-08-18 09:09:11 -04:00
Patrick Cloke	2f4d60a5ba	Iteratively encode JSON responses to avoid blocking the reactor. (#8013 )	2020-08-18 08:49:59 -04:00
Patrick Cloke	25e55d2598	Return the previous stream token if a non-member event is a duplicate. (#8093 )	2020-08-18 07:53:23 -04:00
Andrew Morgan	8b6c176aee	Add resources.consent conditional dependency back (#8107 ) Turns out that part of the codebase (synapse.config.server) checks for this key explicitly. Remove that check.	2020-08-18 10:59:54 +01:00
Patrick Cloke	050e20e7ca	Convert some of the general database methods to async (#8100 )	2020-08-17 12:18:01 -04:00
Andrew Morgan	e04e465b4d	Use the default templates when a custom template file cannot be found (#8037 ) Fixes https://github.com/matrix-org/synapse/issues/6583	2020-08-17 17:05:00 +01:00
Patrick Cloke	ad6190c925	Convert stream database to async/await. (#8074 )	2020-08-17 07:24:46 -04:00
Patrick Cloke	ac77cdb64e	Add a shadow-banned flag to users. (#8092 )	2020-08-14 12:37:59 -04:00
Patrick Cloke	b069b78bb4	Convert pusher databases to async/await. (#8075 )	2020-08-14 10:30:16 -04:00
Patrick Cloke	e8861957d9	Convert receipts and events databases to async/await. (#8076 )	2020-08-14 10:05:19 -04:00
Erik Johnston	dc22090a67	Add type hints to synapse.handlers.room (#8090 )	2020-08-14 14:47:53 +01:00
Patrick Cloke	6b7ce1d332	Remove some unused database functions. (#8085 )	2020-08-14 09:25:40 -04:00
Patrick Cloke	894dae74fe	Convert misc database code to async (#8087 )	2020-08-14 07:24:26 -04:00
Patrick Cloke	7bdf9828d5	Remove a space at the start of a changelog entry.	2020-08-13 14:16:18 -04:00
Olivier Wilkinson (reivilibre)	bfd79c2988	Synapse 1.19.0rc1 (2020-08-13) ============================== Removal warning --------------- As outlined in the [previous release](https://github.com/matrix-org/synapse/releases/tag/v1.18.0), we are no longer publishing Docker images with the `-py3` tag suffix. On top of that, we have also removed the `latest-py3` tag. Please see [the announcement in the upgrade notes for 1.18.0](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). Features -------- - Add option to allow server admins to join rooms which fail complexity checks. Contributed by @lugino-emeritus. ([\#7902](https://github.com/matrix-org/synapse/issues/7902)) - Add an option to purge room or not with delete room admin endpoint (`POST /_synapse/admin/v1/rooms/<room_id>/delete`). Contributed by @dklimpel. ([\#7964](https://github.com/matrix-org/synapse/issues/7964)) - Add rate limiting to users joining rooms. ([\#8008](https://github.com/matrix-org/synapse/issues/8008)) - Add a `/health` endpoint to every configured HTTP listener that can be used as a health check endpoint by load balancers. ([\#8048](https://github.com/matrix-org/synapse/issues/8048)) - Allow login to be blocked based on the values of SAML attributes. ([\#8052](https://github.com/matrix-org/synapse/issues/8052)) - Allow guest access to the `GET /_matrix/client/r0/rooms/{room_id}/members` endpoint, according to MSC2689. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7314](https://github.com/matrix-org/synapse/issues/7314)) Bugfixes -------- - Fix a bug introduced in Synapse v1.7.2 which caused inaccurate membership counts in the room directory. ([\#7977](https://github.com/matrix-org/synapse/issues/7977)) - Fix a long standing bug: 'Duplicate key value violates unique constraint "event_relations_id"' when message retention is configured. ([\#7978](https://github.com/matrix-org/synapse/issues/7978)) - Fix "no create event in auth events" when trying to reject invitation after inviter leaves. Bug introduced in Synapse v1.10.0. ([\#7980](https://github.com/matrix-org/synapse/issues/7980)) - Fix various comments and minor discrepencies in server notices code. ([\#7996](https://github.com/matrix-org/synapse/issues/7996)) - Fix a long standing bug where HTTP HEAD requests resulted in a 400 error. ([\#7999](https://github.com/matrix-org/synapse/issues/7999)) - Fix a long-standing bug which caused two copies of some log lines to be written when synctl was used along with a MemoryHandler logger. ([\#8011](https://github.com/matrix-org/synapse/issues/8011), [\#8012](https://github.com/matrix-org/synapse/issues/8012)) Updates to the Docker image --------------------------- - We no longer publish Docker images with the `-py3` tag suffix, as [announced in the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). ([\#8056](https://github.com/matrix-org/synapse/issues/8056)) Improved Documentation ---------------------- - Document how to set up a client .well-known file and fix several pieces of outdated documentation. ([\#7899](https://github.com/matrix-org/synapse/issues/7899)) - Improve workers docs. ([\#7990](https://github.com/matrix-org/synapse/issues/7990), [\#8000](https://github.com/matrix-org/synapse/issues/8000)) - Fix typo in `docs/workers.md`. ([\#7992](https://github.com/matrix-org/synapse/issues/7992)) - Add documentation for how to undo a room shutdown. ([\#7998](https://github.com/matrix-org/synapse/issues/7998), [\#8010](https://github.com/matrix-org/synapse/issues/8010)) Internal Changes ---------------- - Reduce the amount of whitespace in JSON stored and sent in responses. Contributed by David Vo. ([\#7372](https://github.com/matrix-org/synapse/issues/7372)) - Switch to the JSON implementation from the standard library and bump the minimum version of the canonicaljson library to 1.2.0. ([\#7936](https://github.com/matrix-org/synapse/issues/7936), [\#7979](https://github.com/matrix-org/synapse/issues/7979)) - Convert various parts of the codebase to async/await. ([\#7947](https://github.com/matrix-org/synapse/issues/7947), [\#7948](https://github.com/matrix-org/synapse/issues/7948), [\#7949](https://github.com/matrix-org/synapse/issues/7949), [\#7951](https://github.com/matrix-org/synapse/issues/7951), [\#7963](https://github.com/matrix-org/synapse/issues/7963), [\#7973](https://github.com/matrix-org/synapse/issues/7973), [\#7975](https://github.com/matrix-org/synapse/issues/7975), [\#7976](https://github.com/matrix-org/synapse/issues/7976), [\#7981](https://github.com/matrix-org/synapse/issues/7981), [\#7987](https://github.com/matrix-org/synapse/issues/7987), [\#7989](https://github.com/matrix-org/synapse/issues/7989), [\#8003](https://github.com/matrix-org/synapse/issues/8003), [\#8014](https://github.com/matrix-org/synapse/issues/8014), [\#8016](https://github.com/matrix-org/synapse/issues/8016), [\#8027](https://github.com/matrix-org/synapse/issues/8027), [\#8031](https://github.com/matrix-org/synapse/issues/8031), [\#8032](https://github.com/matrix-org/synapse/issues/8032), [\#8035](https://github.com/matrix-org/synapse/issues/8035), [\#8042](https://github.com/matrix-org/synapse/issues/8042), [\#8044](https://github.com/matrix-org/synapse/issues/8044), [\#8045](https://github.com/matrix-org/synapse/issues/8045), [\#8061](https://github.com/matrix-org/synapse/issues/8061), [\#8062](https://github.com/matrix-org/synapse/issues/8062), [\#8063](https://github.com/matrix-org/synapse/issues/8063), [\#8066](https://github.com/matrix-org/synapse/issues/8066), [\#8069](https://github.com/matrix-org/synapse/issues/8069), [\#8070](https://github.com/matrix-org/synapse/issues/8070)) - Move some database-related log lines from the default logger to the database/transaction loggers. ([\#7952](https://github.com/matrix-org/synapse/issues/7952)) - Add a script to detect source code files using non-unix line terminators. ([\#7965](https://github.com/matrix-org/synapse/issues/7965), [\#7970](https://github.com/matrix-org/synapse/issues/7970)) - Log the SAML session ID during creation. ([\#7971](https://github.com/matrix-org/synapse/issues/7971)) - Implement new experimental push rules for some users. ([\#7997](https://github.com/matrix-org/synapse/issues/7997)) - Remove redundant and unreliable signature check for v1 Identity Service lookup responses. ([\#8001](https://github.com/matrix-org/synapse/issues/8001)) - Improve the performance of the register endpoint. ([\#8009](https://github.com/matrix-org/synapse/issues/8009)) - Reduce less useful output in the newsfragment CI step. Add a link to the changelog section of the contributing guide on error. ([\#8024](https://github.com/matrix-org/synapse/issues/8024)) - Rename storage layer objects to be more sensible. ([\#8033](https://github.com/matrix-org/synapse/issues/8033)) - Change the default log config to reduce disk I/O and storage for new servers. ([\#8040](https://github.com/matrix-org/synapse/issues/8040)) - Add an assertion on `prev_events` in `create_new_client_event`. ([\#8041](https://github.com/matrix-org/synapse/issues/8041)) - Add a comment to `ServerContextFactory` about the use of `SSLv23_METHOD`. ([\#8043](https://github.com/matrix-org/synapse/issues/8043)) - Log `OPTIONS` requests at `DEBUG` rather than `INFO` level to reduce amount logged at `INFO`. ([\#8049](https://github.com/matrix-org/synapse/issues/8049)) - Reduce amount of outbound request logging at `INFO` level. ([\#8050](https://github.com/matrix-org/synapse/issues/8050)) - It is no longer necessary to explicitly define `filters` in the logging configuration. (Continuing to do so is redundant but harmless.) ([\#8051](https://github.com/matrix-org/synapse/issues/8051)) - Add and improve type hints. ([\#8058](https://github.com/matrix-org/synapse/issues/8058), [\#8064](https://github.com/matrix-org/synapse/issues/8064), [\#8060](https://github.com/matrix-org/synapse/issues/8060), [\#8067](https://github.com/matrix-org/synapse/issues/8067)) -----BEGIN PGP SIGNATURE----- iQJKBAABCgA0FiEEnGyN+jjiKnCf/nYCBnFee20mPkIFAl81c5QWHG9saXZpZXJA bGlicmVwdXNoLm5ldAAKCRAGcV57bSY+QvA7D/9qMkvldt24XZymcY9WV3Po+SzC Ijb+ZXdbUq/ZmhqJWeK7NRwiYLPuJHOUZ1Bk2GF6U8OOYQLoz+UmtShXxSu32cwc /0UUxsF+CAuxs6NowUq2d4n/5Hkl4A2Oi0NP7sjU4k7TJU9s5wWrG0l20EBUfx0r XPxDjZUPNoVH+Ecj3l3jt8+ixNeyWHPOmJsZmzOYEnfA8eAmHEozJ7ymh6qiR5qQ apfK9VeWR1bLJ/zUv+U4mTWRL8YSkswdtU6PamJjf86lMfEZJPp32l5ydEmq+4KV MaljYo20QuxkOrdQghtjiPakxhxCJAQRDBNMcMFTclicexlwEwoRgT9XjXhujd7G D58q6x+Nsy7YaZdE92ZGqaok3taoV1rmAQOV1qm/7SnmPyomOamlTnuIknvkJdys i5Vir0HcbcStNlVIWAYJdO7/t0JoEerI/eH1j2PJu35d8/Q4RFbuLSwUCaKErmPl BuGPrSGztEfRu604JJn5lpHQKBsI+oS/F68Xet6mlzNeidnY0AYxjyyYj7qJo4X7 z9EX4UY1PTIGHQ13l4iG4wb4KgRk9APPw4G8xwhWDJQWvNVuePOHGM+sw4fV22wP FDKxb4+r2Sa9hnKpUzlGj+AJWbSwldF1Cdyo1l8b/fzo3UJbzeG8216xVfE+K91o pxrQoiSqq0Isn8dtmw== =pUup -----END PGP SIGNATURE----- Merge tag 'v1.19.0rc1' into develop Synapse 1.19.0rc1 (2020-08-13) ============================== Removal warning --------------- As outlined in the [previous release](https://github.com/matrix-org/synapse/releases/tag/v1.18.0), we are no longer publishing Docker images with the `-py3` tag suffix. On top of that, we have also removed the `latest-py3` tag. Please see [the announcement in the upgrade notes for 1.18.0](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). Features -------- - Add option to allow server admins to join rooms which fail complexity checks. Contributed by @lugino-emeritus. ([\#7902](https://github.com/matrix-org/synapse/issues/7902)) - Add an option to purge room or not with delete room admin endpoint (`POST /_synapse/admin/v1/rooms/<room_id>/delete`). Contributed by @dklimpel. ([\#7964](https://github.com/matrix-org/synapse/issues/7964)) - Add rate limiting to users joining rooms. ([\#8008](https://github.com/matrix-org/synapse/issues/8008)) - Add a `/health` endpoint to every configured HTTP listener that can be used as a health check endpoint by load balancers. ([\#8048](https://github.com/matrix-org/synapse/issues/8048)) - Allow login to be blocked based on the values of SAML attributes. ([\#8052](https://github.com/matrix-org/synapse/issues/8052)) - Allow guest access to the `GET /_matrix/client/r0/rooms/{room_id}/members` endpoint, according to MSC2689. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7314](https://github.com/matrix-org/synapse/issues/7314)) Bugfixes -------- - Fix a bug introduced in Synapse v1.7.2 which caused inaccurate membership counts in the room directory. ([\#7977](https://github.com/matrix-org/synapse/issues/7977)) - Fix a long standing bug: 'Duplicate key value violates unique constraint "event_relations_id"' when message retention is configured. ([\#7978](https://github.com/matrix-org/synapse/issues/7978)) - Fix "no create event in auth events" when trying to reject invitation after inviter leaves. Bug introduced in Synapse v1.10.0. ([\#7980](https://github.com/matrix-org/synapse/issues/7980)) - Fix various comments and minor discrepencies in server notices code. ([\#7996](https://github.com/matrix-org/synapse/issues/7996)) - Fix a long standing bug where HTTP HEAD requests resulted in a 400 error. ([\#7999](https://github.com/matrix-org/synapse/issues/7999)) - Fix a long-standing bug which caused two copies of some log lines to be written when synctl was used along with a MemoryHandler logger. ([\#8011](https://github.com/matrix-org/synapse/issues/8011), [\#8012](https://github.com/matrix-org/synapse/issues/8012)) Updates to the Docker image --------------------------- - We no longer publish Docker images with the `-py3` tag suffix, as [announced in the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). ([\#8056](https://github.com/matrix-org/synapse/issues/8056)) Improved Documentation ---------------------- - Document how to set up a client .well-known file and fix several pieces of outdated documentation. ([\#7899](https://github.com/matrix-org/synapse/issues/7899)) - Improve workers docs. ([\#7990](https://github.com/matrix-org/synapse/issues/7990), [\#8000](https://github.com/matrix-org/synapse/issues/8000)) - Fix typo in `docs/workers.md`. ([\#7992](https://github.com/matrix-org/synapse/issues/7992)) - Add documentation for how to undo a room shutdown. ([\#7998](https://github.com/matrix-org/synapse/issues/7998), [\#8010](https://github.com/matrix-org/synapse/issues/8010)) Internal Changes ---------------- - Reduce the amount of whitespace in JSON stored and sent in responses. Contributed by David Vo. ([\#7372](https://github.com/matrix-org/synapse/issues/7372)) - Switch to the JSON implementation from the standard library and bump the minimum version of the canonicaljson library to 1.2.0. ([\#7936](https://github.com/matrix-org/synapse/issues/7936), [\#7979](https://github.com/matrix-org/synapse/issues/7979)) - Convert various parts of the codebase to async/await. ([\#7947](https://github.com/matrix-org/synapse/issues/7947), [\#7948](https://github.com/matrix-org/synapse/issues/7948), [\#7949](https://github.com/matrix-org/synapse/issues/7949), [\#7951](https://github.com/matrix-org/synapse/issues/7951), [\#7963](https://github.com/matrix-org/synapse/issues/7963), [\#7973](https://github.com/matrix-org/synapse/issues/7973), [\#7975](https://github.com/matrix-org/synapse/issues/7975), [\#7976](https://github.com/matrix-org/synapse/issues/7976), [\#7981](https://github.com/matrix-org/synapse/issues/7981), [\#7987](https://github.com/matrix-org/synapse/issues/7987), [\#7989](https://github.com/matrix-org/synapse/issues/7989), [\#8003](https://github.com/matrix-org/synapse/issues/8003), [\#8014](https://github.com/matrix-org/synapse/issues/8014), [\#8016](https://github.com/matrix-org/synapse/issues/8016), [\#8027](https://github.com/matrix-org/synapse/issues/8027), [\#8031](https://github.com/matrix-org/synapse/issues/8031), [\#8032](https://github.com/matrix-org/synapse/issues/8032), [\#8035](https://github.com/matrix-org/synapse/issues/8035), [\#8042](https://github.com/matrix-org/synapse/issues/8042), [\#8044](https://github.com/matrix-org/synapse/issues/8044), [\#8045](https://github.com/matrix-org/synapse/issues/8045), [\#8061](https://github.com/matrix-org/synapse/issues/8061), [\#8062](https://github.com/matrix-org/synapse/issues/8062), [\#8063](https://github.com/matrix-org/synapse/issues/8063), [\#8066](https://github.com/matrix-org/synapse/issues/8066), [\#8069](https://github.com/matrix-org/synapse/issues/8069), [\#8070](https://github.com/matrix-org/synapse/issues/8070)) - Move some database-related log lines from the default logger to the database/transaction loggers. ([\#7952](https://github.com/matrix-org/synapse/issues/7952)) - Add a script to detect source code files using non-unix line terminators. ([\#7965](https://github.com/matrix-org/synapse/issues/7965), [\#7970](https://github.com/matrix-org/synapse/issues/7970)) - Log the SAML session ID during creation. ([\#7971](https://github.com/matrix-org/synapse/issues/7971)) - Implement new experimental push rules for some users. ([\#7997](https://github.com/matrix-org/synapse/issues/7997)) - Remove redundant and unreliable signature check for v1 Identity Service lookup responses. ([\#8001](https://github.com/matrix-org/synapse/issues/8001)) - Improve the performance of the register endpoint. ([\#8009](https://github.com/matrix-org/synapse/issues/8009)) - Reduce less useful output in the newsfragment CI step. Add a link to the changelog section of the contributing guide on error. ([\#8024](https://github.com/matrix-org/synapse/issues/8024)) - Rename storage layer objects to be more sensible. ([\#8033](https://github.com/matrix-org/synapse/issues/8033)) - Change the default log config to reduce disk I/O and storage for new servers. ([\#8040](https://github.com/matrix-org/synapse/issues/8040)) - Add an assertion on `prev_events` in `create_new_client_event`. ([\#8041](https://github.com/matrix-org/synapse/issues/8041)) - Add a comment to `ServerContextFactory` about the use of `SSLv23_METHOD`. ([\#8043](https://github.com/matrix-org/synapse/issues/8043)) - Log `OPTIONS` requests at `DEBUG` rather than `INFO` level to reduce amount logged at `INFO`. ([\#8049](https://github.com/matrix-org/synapse/issues/8049)) - Reduce amount of outbound request logging at `INFO` level. ([\#8050](https://github.com/matrix-org/synapse/issues/8050)) - It is no longer necessary to explicitly define `filters` in the logging configuration. (Continuing to do so is redundant but harmless.) ([\#8051](https://github.com/matrix-org/synapse/issues/8051)) - Add and improve type hints. ([\#8058](https://github.com/matrix-org/synapse/issues/8058), [\#8064](https://github.com/matrix-org/synapse/issues/8064), [\#8060](https://github.com/matrix-org/synapse/issues/8060), [\#8067](https://github.com/matrix-org/synapse/issues/8067))	2020-08-13 18:22:58 +01:00
Olivier Wilkinson (reivilibre)	091ca3910d	1.19.0rc1	2020-08-13 17:12:21 +01:00
Richard van der Hoff	53834bb9c4	Run `remove_push_actions_from_staging` in foreground (#8081 ) If we got an error persisting an event, we would try to remove the push actions asynchronously, which would lead to a 'Re-starting finished log context' warning. I don't think there's any need for this to be asynchronous.	2020-08-13 17:05:31 +01:00
reivilibre	ff0e894656	Drop federation transmission queues during a significant remote outage. (#7864 ) * Empty federation transmission queues when we are backing off. Fixes #7828. Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Address feedback Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Reword newsfile	2020-08-13 12:35:04 +01:00
Patrick Cloke	dd8f28bd3f	Fix unawaited coroutine error in tests. (#8072 )	2020-08-13 07:11:39 -04:00
Patrick Cloke	fbe930dad2	Convert the roommember database to async/await. (#8070 )	2020-08-12 12:14:34 -04:00
Patrick Cloke	5ecc8b5825	Convert devices database to async/await. (#8069 )	2020-08-12 10:51:42 -04:00
Erik Johnston	5dd73d029e	Add type hints to handlers.message and events.builder (#8067 )	2020-08-12 15:05:50 +01:00
Patrick Cloke	d68e10f308	Convert account data, device inbox, and censor events databases to async/await (#8063 )	2020-08-12 09:29:06 -04:00
Patrick Cloke	a3a59bab7b	Convert appservice, group server, profile and more databases to async (#8066 )	2020-08-12 09:28:48 -04:00
Erik Johnston	9d1e4942ab	Fix typing for notifier (#8064 )	2020-08-12 14:03:08 +01:00
Erik Johnston	6ba621d786	Merge pull request #8060 from matrix-org/erikj/type_server Change HomeServer definition to work with typing.	2020-08-11 22:32:14 +01:00
Patrick Cloke	04faa0bfa9	Convert tags and metrics databases to async/await (#8062 )	2020-08-11 17:21:20 -04:00
Patrick Cloke	a0acdfa9e9	Converts event_federation and registration databases to async/await (#8061 )	2020-08-11 17:21:13 -04:00
Erik Johnston	fdb46b5442	Merge remote-tracking branch 'origin/develop' into erikj/type_server	2020-08-11 22:03:14 +01:00
Erik Johnston	61d8ff0d44	Auto set logging filter (#8051 ) We do this to prevent foot guns. The default config uses a MemoryFilter, but users are free to change to logging to files directly. If they do then they have to ensure to set the `filters: [context]` on the right handler, otherwise records get written with the wrong context. Instead we move the logic to happen when we generate a record, which is when we log rather than handle. (It's possible to add filters to loggers in the config, however they don't apply to descendant loggers and so they have to be manually set on every logger used in the code base)	2020-08-11 21:58:56 +01:00
Erik Johnston	3c796e4159	Update changelog.d/8051.misc Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-08-11 21:08:43 +01:00
Erik Johnston	a1e9bb9eae	Add typing info to Notifier (#8058 )	2020-08-11 19:40:02 +01:00
Erik Johnston	e1af09dccb	Newsfile	2020-08-11 18:10:46 +01:00
Erik Johnston	a0f574f3c2	Reduce INFO logging (#8050 ) c.f. #8021 A lot of the code here is to change the `Completed 200 OK` logging to include the request URI so that we can drop the `Sending request...` log line. Some notes: 1. We won't log retries, which may be confusing considering the time taken log line includes retries and sleeps. 2. The `_send_request_with_optional_trailing_slash` will always be logged without the forward slash, even if it succeeded only with the forward slash.	2020-08-11 18:10:07 +01:00
Erik Johnston	db131b6b22	Change the default log config to reduce disk I/O and storage (#8040 ) * Change default log config to buffer by default. This batches up writes to the filesystem, which is more efficient for disk I/O. This means that it can take some time for logs to get written to disk. Note that ERROR logs (and above) immediately flush the buffer. This only effects new installs, as we only write the log config if started with `--generate-config` (in the same way we do for generating signing keys). * Default to keeping last 4 days of logs. This hopefully reduces the amount of logs kept for new servers. Keeping the last 1GB of logs is likely overkill for new servers, but equally may not be enough for busy ones. Instead, we keep the last four days worth of logs, enough so that admins can investigate any problems that happened over e.g. a long weekend.	2020-08-11 18:09:46 +01:00
Erik Johnston	64e5bb0dc8	Newsfile	2020-08-11 18:03:26 +01:00
Richard van der Hoff	0cb169900e	Implement login blocking based on SAML attributes (#8052 ) Hopefully this mostly speaks for itself. I also did a bit of cleaning up of the error handling. Fixes #8047	2020-08-11 16:08:10 +01:00
Richard van der Hoff	aa827b6ad7	Merge remote-tracking branch 'origin/master' into develop	2020-08-10 23:42:12 +01:00
Richard van der Hoff	39c3f68758	Stop uploading -py3 docker images (#8056 )	2020-08-10 23:41:50 +01:00
Richard van der Hoff	fcbab08cbd	Add an assertion on prev_events in create_new_client_event (#8041 ) I think this would have caught all the cases in https://github.com/matrix-org/synapse/issues/7642 - and I think a 500 makes more sense here than a 403	2020-08-10 12:29:47 +01:00
Brendan Abolivier	cdbb8e6d6e	Implement new experimental push rules (#7997 ) With an undocumented configuration setting to enable them for specific users.	2020-08-10 11:48:01 +01:00
Patrick Cloke	7f837959ea	Convert directory, e2e_room_keys, end_to_end_keys, monthly_active_users database to async (#8042 )	2020-08-07 13:36:29 -04:00
Patrick Cloke	f3fe6961b2	Convert additional database stores to async/await (#8045 )	2020-08-07 12:17:17 -04:00
Travis Ralston	1048ed2afa	Clarify that undoing a shutdown might not be possible (#8010 )	2020-08-07 17:16:24 +01:00
Richard van der Hoff	de6f892065	Add a comment about SSLv23_METHOD (#8043 )	2020-08-07 15:14:29 +01:00
Erik Johnston	2f9fd5ab00	Don't log OPTIONS request at INFO (#8049 )	2020-08-07 14:53:05 +01:00
Patrick Cloke	4e874ed593	Remove unnecessary maybeDeferred calls (#8044 )	2020-08-07 09:44:48 -04:00
Erik Johnston	7620912d84	Add health check endpoint (#8048 )	2020-08-07 14:21:24 +01:00
David Vo	4dd27e6d11	Reduce unnecessary whitespace in JSON. (#7372 )	2020-08-07 08:02:55 -04:00
Brendan Abolivier	2ffd6783c7	Revert #7736 (#8039 )	2020-08-06 17:15:35 +01:00
Patrick Cloke	fe6cfc80ec	Convert some util functions to async (#8035 )	2020-08-06 08:39:35 -04:00
Patrick Cloke	d4a7829b12	Convert synapse.api to async/await (#8031 )	2020-08-06 08:30:06 -04:00
Patrick Cloke	c36228c403	Convert run_as_background_process inner function to async. (#8032 )	2020-08-06 08:20:42 -04:00
Patrick Cloke	66f24449dd	Improve performance of the register endpoint (#8009 )	2020-08-06 08:09:55 -04:00
Brendan Abolivier	118a9eafb3	Merge branch 'develop' of github.com:matrix-org/synapse into babolivier/new_push_rules	2020-08-06 10:52:50 +01:00
Erik Johnston	079bc3c8e3	Fixup worker doc (again) (#8000 )	2020-08-06 10:35:59 +01:00
Erik Johnston	a7bdf98d01	Rename database classes to make some sense (#8033 )	2020-08-05 21:38:57 +01:00
Richard van der Hoff	0a86850ba3	Stop the parent process flushing the logs on exit (#8012 ) This solves the problem that the first few lines are logged twice on matrix.org. Hopefully the comments explain it.	2020-08-05 09:35:17 +01:00
Andrew Morgan	7cac9006d6	Spruce up the check-newsfragment CI output (#8024 ) This PR: * Reduces the amount of noise in the `check-newsfragment` CI output by hiding the dependency installation output by default. * Prints a link to the changelog/debian changelog section of the contributing guide if an error is found.	2020-08-04 22:10:23 +01:00
Patrick Cloke	8ff2deda72	Fix async/await calls for broken media providers. (#8027 )	2020-08-04 09:44:25 -04:00
Patrick Cloke	88a3ff12f0	Convert the SimpleHttpClient to async. (#8016 )	2020-08-04 07:22:04 -04:00
Patrick Cloke	e19de43eb5	Convert streams to async. (#8014 )	2020-08-04 07:21:47 -04:00

... 13 14 15 16 17 ...

4629 commits