5633 commits

Author	SHA1	Message	Date
David Robertson	36071d39f7	Changelog (#12153)	2022-03-04 12:01:51 +00:00
David Robertson	4aeb00ca20	Move synctl into synapse._scripts and expose as an entrypoint (#12140)	2022-03-04 11:58:49 +00:00
Erik Johnston	423cca9efe	Spread out sending device lists to remote hosts (#12132)	2022-03-04 11:48:15 +00:00
Richard van der Hoff	87c230c27c	Update client-visibility filtering for outlier events (#12155) ... Avoid trying to get the state for outliers, which isn't a sensible thing to do.	2022-03-04 10:31:19 +00:00
Richard van der Hoff	d56202b038	Fix type of events in StateGroupStorage and StateHandler (#12156) ... We make multiple passes over this, so a regular iterable won't do.	2022-03-04 10:25:18 +00:00
Richard van der Hoff	8533c8b03d	Avoid generating state groups for local out-of-band leaves (#12154) ... If we locally generate a rejection for an invite received over federation, it is stored as an outlier (because we probably don't have the state for the room). However, currently we still generate a state group for it (even though the state in that state group will be nonsense). By setting the `outlier` param on `create_event`, we avoid the nonsensical state.	2022-03-03 19:58:08 +00:00
Andrew Morgan	fb0ffa9676	Rename various ApplicationServices interested methods (#11915)	2022-03-03 18:14:09 +00:00
David Robertson	9297d040a7	Detox, part 2 of N (#12152) ... I've argued in #11537 that poetry and tox don't cooperate well at the moment. (See also #12119.) Therefore I'm pruning away bits of tox to make the transition to poetry easier. This change removes the commands for coverage. We don't use coverage in anger at the moment. It shouldn't be too hard to add coverage as a dev-dependency and reintroduce this if we really want it.	2022-03-03 17:14:09 +00:00
Dirk Klimpel	7e91107be1	Add type hints to tests/rest (#12146) ... * Add type hints to `tests/rest` * newsfile * change import from `SigningKey`	2022-03-03 16:05:44 +00:00
Patrick Cloke	1d11b452b7	Use the proper serialization format when bundling aggregations. (#12090) ... This ensures that the `latest_event` field of the bundled aggregation for threads uses the same format as the other events in the response.	2022-03-03 10:43:06 -05:00
David Robertson	cea1b58c4a	Don't impose version checks on dev extras at runtime (#12129) ... * Fix incorrect argument in test case * Add copyright header * Docstring and __all__ * Exclude dev depenencies * Use changelog from #12088 * Include version in error messages This will hopefully distinguish between the version of the source code and the version of the distribution package that is installed. * Linter script is your friend	2022-03-03 12:47:55 +00:00
Eric Eastwood	a511a890d7	Enable MSC2716 Complement tests in Synapse (#12145) ... Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-03-03 11:19:20 +00:00
Erik Johnston	61fd2a8f59	Limit the size of the aggregation_key (#12101) ... There's no reason to let people use long keys.	2022-03-03 10:52:35 +00:00
Eric Eastwood	31b125ccec	Enable MSC3030 Complement tests in Synapse (#12144) ... The Complement tests for MSC3030 are now merged, https://github.com/matrix-org/complement/pull/178 Synapse implmentation: https://github.com/matrix-org/synapse/pull/9445	2022-03-03 11:45:23 +01:00
Brendan Abolivier	ae8a616b49	Correctly register deactivation and profile update module callbacks (#12141)	2022-03-03 11:39:58 +01:00
David Robertson	11282ade1d	Move the snapcraft configuration to contrib. (#12142) ... * Move the `snapcraft` configuration to `contrib`. We're happy for people to package this as a snap image if it's useful, but we don't support or maintain it. I'd like to move the config to `contrib` to reflect this state of affairs. * Changelog	2022-03-02 19:22:44 +00:00
David Robertson	1fbe0316a9	Add suffices to scripts in scripts-dev (#12137) ... * Rename scripts-dev to have suffices * Update references to `scripts-dev` * Changelog * These scripts don't pass mypy	2022-03-02 18:00:26 +00:00
David Robertson	106959b3cf	Remove unused mocks from test_typing (#12136) ... * Remove unused mocks from `test_typing` It's not clear what these do. `get_user_by_access_token` has the wrong signature, including the return type. Tests all pass without these. I think we should nuke them. * Changelog * Fixup imports	2022-03-02 17:24:52 +00:00
Dirk Klimpel	2ffaf30803	Add type hints to tests/rest/client (#12108) ... * Add type hints to `tests/rest/client` * newsfile * fix imports * add `test_account.py` * Remove one type hint in `test_report_event.py` * change `on_create_room` to `async` * update new functions in `test_third_party_rules.py` * Add `test_filter.py` * add `test_rooms.py` * change to `assertEquals` to `assertEqual` * lint	2022-03-02 16:34:14 +00:00
Andrew Morgan	b4461e7d8a	Enable complexity checking in complexity checking docs example (#11998)	2022-03-02 16:11:16 +00:00
Olivier Wilkinson (reivilibre)	594a07ede4	Synapse 1.54.0rc1 (2022-03-02) ... ============================== Please note that this will be the last release of Synapse that is compatible with Mjolnir 1.3.1 and earlier. Administrators of servers which have the Mjolnir module installed are advised to upgrade Mjolnir to version 1.3.2 or later. Features -------- - Add support for [MSC3202](https://github.com/matrix-org/matrix-doc/pull/3202): sending one-time key counts and fallback key usage states to Application Services. ([\#11617](https://github.com/matrix-org/synapse/issues/11617)) - Improve the generated URL previews for some web pages. Contributed by @AndrewRyanChama. ([\#11985](https://github.com/matrix-org/synapse/issues/11985)) - Track cache invalidations in Prometheus metrics, as already happens for cache eviction based on size or time. ([\#12000](https://github.com/matrix-org/synapse/issues/12000)) - Implement experimental support for [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) (account status endpoints). ([\#12001](https://github.com/matrix-org/synapse/issues/12001), [\#12067](https://github.com/matrix-org/synapse/issues/12067)) - Enable modules to set a custom display name when registering a user. ([\#12009](https://github.com/matrix-org/synapse/issues/12009)) - Advertise Matrix 1.1 and 1.2 support on `/_matrix/client/versions`. ([\#12020](https://github.com/matrix-org/synapse/issues/12020), ([\#12022](https://github.com/matrix-org/synapse/issues/12022)) - Support only the stable identifier for [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069)'s `is_guest` on `/_matrix/client/v3/account/whoami`. ([\#12021](https://github.com/matrix-org/synapse/issues/12021)) - Use room version 9 as the default room version (per [MSC3589](https://github.com/matrix-org/matrix-doc/pull/3589)). ([\#12058](https://github.com/matrix-org/synapse/issues/12058)) - Add module callbacks to react to user deactivation status changes (i.e. deactivations and reactivations) and profile updates. ([\#12062](https://github.com/matrix-org/synapse/issues/12062)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where an edit of the latest event in a thread would not be properly applied to the thread summary. ([\#11992](https://github.com/matrix-org/synapse/issues/11992)) - Fix long-standing bug where the `get_rooms_for_user` cache was not correctly invalidated for remote users when the server left a room. ([\#11999](https://github.com/matrix-org/synapse/issues/11999)) - Fix a 500 error with Postgres when looking backwards with the [MSC3030](https://github.com/matrix-org/matrix-doc/pull/3030) `/timestamp_to_event?dir=b` endpoint. ([\#12024](https://github.com/matrix-org/synapse/issues/12024)) - Properly fix a long-standing bug where wrong data could be inserted into the `event_search` table when using SQLite. This could block running `synapse_port_db` with an `argument of type 'int' is not iterable` error. This bug was partially fixed by a change in Synapse 1.44.0. ([\#12037](https://github.com/matrix-org/synapse/issues/12037)) - Fix slow performance of `/logout` in some cases where refresh tokens are in use. The slowness existed since the initial implementation of refresh tokens in version 1.38.0. ([\#12056](https://github.com/matrix-org/synapse/issues/12056)) - Fix a long-standing bug where Synapse would make additional failing requests over federation for missing data. ([\#12077](https://github.com/matrix-org/synapse/issues/12077)) - Fix occasional `Unhandled error in Deferred` error message. ([\#12089](https://github.com/matrix-org/synapse/issues/12089)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#12098](https://github.com/matrix-org/synapse/issues/12098)) - Fix a long-standing bug which could cause push notifications to malfunction if `use_frozen_dicts` was set in the configuration. ([\#12100](https://github.com/matrix-org/synapse/issues/12100)) - Fix an extremely rare, long-standing bug in `ReadWriteLock` that would cause an error when a newly unblocked writer completes instantly. ([\#12105](https://github.com/matrix-org/synapse/issues/12105)) - Make a `POST` to `/rooms/<room_id>/receipt/m.read/<event_id>` only trigger a push notification if the count of unread messages is different to the one in the last successfully sent push. This reduces server load and load on the receiving device. ([\#11835](https://github.com/matrix-org/synapse/issues/11835)) Updates to the Docker image --------------------------- - The Docker image no longer automatically creates a temporary volume at `/data`. This is not expected to affect normal usage. ([\#11997](https://github.com/matrix-org/synapse/issues/11997)) - Use Python 3.9 in Docker images by default. ([\#12112](https://github.com/matrix-org/synapse/issues/12112)) Improved Documentation ---------------------- - Document support for the `to_device`, `account_data`, `receipts`, and `presence` stream writers for workers. ([\#11599](https://github.com/matrix-org/synapse/issues/11599)) - Explain the meaning of spam checker callbacks' return values. ([\#12003](https://github.com/matrix-org/synapse/issues/12003)) - Clarify information about external Identity Provider IDs. ([\#12004](https://github.com/matrix-org/synapse/issues/12004)) Deprecations and Removals ------------------------- - Deprecate using `synctl` with the config option `synctl_cache_factor` and print a warning if a user still uses this option. ([\#11865](https://github.com/matrix-org/synapse/issues/11865)) - Remove support for the legacy structured logging configuration (please see the the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#legacy-structured-logging-configuration-removal) if you are using `structured: true` in the Synapse configuration). ([\#12008](https://github.com/matrix-org/synapse/issues/12008)) - Drop support for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283) unstable flags now that the stable flags are supported. ([\#12018](https://github.com/matrix-org/synapse/issues/12018)) - Remove the unstable `/spaces` endpoint from [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946). ([\#12073](https://github.com/matrix-org/synapse/issues/12073)) Internal Changes ---------------- - Make the `get_room_version` method use `get_room_version_id` to benefit from caching. ([\#11808](https://github.com/matrix-org/synapse/issues/11808)) - Remove unnecessary condition on knock -> leave auth rule check. ([\#11900](https://github.com/matrix-org/synapse/issues/11900)) - Add tests for device list changes between local users. ([\#11972](https://github.com/matrix-org/synapse/issues/11972)) - Optimise calculating `device_list` changes in `/sync`. ([\#11974](https://github.com/matrix-org/synapse/issues/11974)) - Add missing type hints to storage classes. ([\#11984](https://github.com/matrix-org/synapse/issues/11984)) - Refactor the search code for improved readability. ([\#11991](https://github.com/matrix-org/synapse/issues/11991)) - Move common deduplication code down into `_auth_and_persist_outliers`. ([\#11994](https://github.com/matrix-org/synapse/issues/11994)) - Limit concurrent joins from applications services. ([\#11996](https://github.com/matrix-org/synapse/issues/11996)) - Preparation for faster-room-join work: when parsing the `send_join` response, get the `m.room.create` event from `state`, not `auth_chain`. ([\#12005](https://github.com/matrix-org/synapse/issues/12005), [\#12039](https://github.com/matrix-org/synapse/issues/12039)) - Preparation for faster-room-join work: parse MSC3706 fields in send_join response. ([\#12011](https://github.com/matrix-org/synapse/issues/12011)) - Preparation for faster-room-join work: persist information on which events and rooms have partial state to the database. ([\#12012](https://github.com/matrix-org/synapse/issues/12012)) - Preparation for faster-room-join work: Support for calling `/federation/v1/state` on a remote server. ([\#12013](https://github.com/matrix-org/synapse/issues/12013)) - Configure `tox` to use `venv` rather than `virtualenv`. ([\#12015](https://github.com/matrix-org/synapse/issues/12015)) - Fix bug in `StateFilter.return_expanded()` and add some tests. ([\#12016](https://github.com/matrix-org/synapse/issues/12016)) - Use Matrix v1.1 endpoints (`/_matrix/client/v3/auth/...`) in fallback auth HTML forms. ([\#12019](https://github.com/matrix-org/synapse/issues/12019)) - Update the `olddeps` CI job to use an old version of `markupsafe`. ([\#12025](https://github.com/matrix-org/synapse/issues/12025)) - Upgrade Mypy to version 0.931. ([\#12030](https://github.com/matrix-org/synapse/issues/12030)) - Remove legacy `HomeServer.get_datastore()`. ([\#12031](https://github.com/matrix-org/synapse/issues/12031), [\#12070](https://github.com/matrix-org/synapse/issues/12070)) - Minor typing fixes. ([\#12034](https://github.com/matrix-org/synapse/issues/12034), [\#12069](https://github.com/matrix-org/synapse/issues/12069)) - After joining a room, create a dedicated logcontext to process the queued events. ([\#12041](https://github.com/matrix-org/synapse/issues/12041)) - Tidy up GitHub Actions config which builds distributions for PyPI. ([\#12051](https://github.com/matrix-org/synapse/issues/12051)) - Move configuration out of `setup.cfg`. ([\#12052](https://github.com/matrix-org/synapse/issues/12052), [\#12059](https://github.com/matrix-org/synapse/issues/12059)) - Fix error message when a worker process fails to talk to another worker process. ([\#12060](https://github.com/matrix-org/synapse/issues/12060)) - Fix using the `complement.sh` script without specifying a directory or a branch. Contributed by Nico on behalf of Famedly. ([\#12063](https://github.com/matrix-org/synapse/issues/12063)) - Add type hints to `tests/rest/client`. ([\#12066](https://github.com/matrix-org/synapse/issues/12066), [\#12072](https://github.com/matrix-org/synapse/issues/12072), [\#12084](https://github.com/matrix-org/synapse/issues/12084), [\#12094](https://github.com/matrix-org/synapse/issues/12094)) - Add some logging to `/sync` to try and track down #11916. ([\#12068](https://github.com/matrix-org/synapse/issues/12068)) - Inspect application dependencies using `importlib.metadata` or its backport. ([\#12088](https://github.com/matrix-org/synapse/issues/12088)) - Use `assertEqual` instead of the deprecated `assertEquals` in test code. ([\#12092](https://github.com/matrix-org/synapse/issues/12092)) - Move experimental support for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440) to `/versions`. ([\#12099](https://github.com/matrix-org/synapse/issues/12099)) - Add `stop_cancellation` utility function to stop `Deferred`s from being cancelled. ([\#12106](https://github.com/matrix-org/synapse/issues/12106)) - Improve exception handling for concurrent execution. ([\#12109](https://github.com/matrix-org/synapse/issues/12109)) - Advertise support for Python 3.10 in packaging files. ([\#12111](https://github.com/matrix-org/synapse/issues/12111)) - Move CI checks out of tox, to facilitate a move to using poetry. ([\#12119](https://github.com/matrix-org/synapse/issues/12119)) -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE8SRSDO7gYkSP4chELS76LzL74EcFAmIffxUACgkQLS76LzL7 4EefXxAAvnJb1BxzWwlYyKaDULjmNfsKilRWlT/A1/7VaumB84H4gFQklLuMbJdR pyktlkmVZrnLG+Vz2JfgFm4wTXvLGieACvlAodQWztQX2szqPAHeq0A0vuMgJEay mVKVnU6b83CONBr021/lm6NOBetbUqOVyiFsnuBKlLPs4WdSt+3DvBRZ3hsQTrCV zEOSdzVM67yr0xo3/vmT+nzlfcegJ64EOT+dFwMfKnoWbRK0lMwnob1WZbiOE0+9 9hoqEucbmzf/4IKgURxmNmrUDIPGUlGq4BnKMGMNyrwWv9v+8pXuIqzOYEUnWVBh upvS88OBswk2EXIIk22/rf5gohNShQDmki41CVTH32G+dP72YxCfTGsafwUpS+Hm KlojCRccmo2y2sQnLzrhswsOPFiYP0AORPIp3hO1mVTMZ7EgjsP4Y8C/S54Oe03F 6U3M5pv6aqURiAHAnyC4KbPOVqUbEzthUuRINEDp5QhNSFyvtwV9DTaFixMpMdR0 OJU8tMaGmCtqdsqNOZ4vGhzPVD/1kJ0KapPyJbkVSGoRdlI01sqO7Nu+k8AZ1oEc nkoR5zMTysCAuGCIOtCWB8NOFBNyEgcCdz3356e+wvWx4PazIFsfyEXskzZY50iK dAIdr+w+kyf4d/e9JpK7YHrPP5uP2s0V8Y4MvDx3wUXJ6VZ834Y= =jw9M -----END PGP SIGNATURE----- Merge tag 'v1.54.0rc1' into develop Synapse 1.54.0rc1 (2022-03-02) ============================== Please note that this will be the last release of Synapse that is compatible with Mjolnir 1.3.1 and earlier. Administrators of servers which have the Mjolnir module installed are advised to upgrade Mjolnir to version 1.3.2 or later. Features -------- - Add support for [MSC3202](https://github.com/matrix-org/matrix-doc/pull/3202): sending one-time key counts and fallback key usage states to Application Services. ([\#11617](https://github.com/matrix-org/synapse/issues/11617)) - Improve the generated URL previews for some web pages. Contributed by @AndrewRyanChama. ([\#11985](https://github.com/matrix-org/synapse/issues/11985)) - Track cache invalidations in Prometheus metrics, as already happens for cache eviction based on size or time. ([\#12000](https://github.com/matrix-org/synapse/issues/12000)) - Implement experimental support for [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) (account status endpoints). ([\#12001](https://github.com/matrix-org/synapse/issues/12001), [\#12067](https://github.com/matrix-org/synapse/issues/12067)) - Enable modules to set a custom display name when registering a user. ([\#12009](https://github.com/matrix-org/synapse/issues/12009)) - Advertise Matrix 1.1 and 1.2 support on `/_matrix/client/versions`. ([\#12020](https://github.com/matrix-org/synapse/issues/12020), ([\#12022](https://github.com/matrix-org/synapse/issues/12022)) - Support only the stable identifier for [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069)'s `is_guest` on `/_matrix/client/v3/account/whoami`. ([\#12021](https://github.com/matrix-org/synapse/issues/12021)) - Use room version 9 as the default room version (per [MSC3589](https://github.com/matrix-org/matrix-doc/pull/3589)). ([\#12058](https://github.com/matrix-org/synapse/issues/12058)) - Add module callbacks to react to user deactivation status changes (i.e. deactivations and reactivations) and profile updates. ([\#12062](https://github.com/matrix-org/synapse/issues/12062)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where an edit of the latest event in a thread would not be properly applied to the thread summary. ([\#11992](https://github.com/matrix-org/synapse/issues/11992)) - Fix long-standing bug where the `get_rooms_for_user` cache was not correctly invalidated for remote users when the server left a room. ([\#11999](https://github.com/matrix-org/synapse/issues/11999)) - Fix a 500 error with Postgres when looking backwards with the [MSC3030](https://github.com/matrix-org/matrix-doc/pull/3030) `/timestamp_to_event?dir=b` endpoint. ([\#12024](https://github.com/matrix-org/synapse/issues/12024)) - Properly fix a long-standing bug where wrong data could be inserted into the `event_search` table when using SQLite. This could block running `synapse_port_db` with an `argument of type 'int' is not iterable` error. This bug was partially fixed by a change in Synapse 1.44.0. ([\#12037](https://github.com/matrix-org/synapse/issues/12037)) - Fix slow performance of `/logout` in some cases where refresh tokens are in use. The slowness existed since the initial implementation of refresh tokens in version 1.38.0. ([\#12056](https://github.com/matrix-org/synapse/issues/12056)) - Fix a long-standing bug where Synapse would make additional failing requests over federation for missing data. ([\#12077](https://github.com/matrix-org/synapse/issues/12077)) - Fix occasional `Unhandled error in Deferred` error message. ([\#12089](https://github.com/matrix-org/synapse/issues/12089)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#12098](https://github.com/matrix-org/synapse/issues/12098)) - Fix a long-standing bug which could cause push notifications to malfunction if `use_frozen_dicts` was set in the configuration. ([\#12100](https://github.com/matrix-org/synapse/issues/12100)) - Fix an extremely rare, long-standing bug in `ReadWriteLock` that would cause an error when a newly unblocked writer completes instantly. ([\#12105](https://github.com/matrix-org/synapse/issues/12105)) - Make a `POST` to `/rooms/<room_id>/receipt/m.read/<event_id>` only trigger a push notification if the count of unread messages is different to the one in the last successfully sent push. This reduces server load and load on the receiving device. ([\#11835](https://github.com/matrix-org/synapse/issues/11835)) Updates to the Docker image --------------------------- - The Docker image no longer automatically creates a temporary volume at `/data`. This is not expected to affect normal usage. ([\#11997](https://github.com/matrix-org/synapse/issues/11997)) - Use Python 3.9 in Docker images by default. ([\#12112](https://github.com/matrix-org/synapse/issues/12112)) Improved Documentation ---------------------- - Document support for the `to_device`, `account_data`, `receipts`, and `presence` stream writers for workers. ([\#11599](https://github.com/matrix-org/synapse/issues/11599)) - Explain the meaning of spam checker callbacks' return values. ([\#12003](https://github.com/matrix-org/synapse/issues/12003)) - Clarify information about external Identity Provider IDs. ([\#12004](https://github.com/matrix-org/synapse/issues/12004)) Deprecations and Removals ------------------------- - Deprecate using `synctl` with the config option `synctl_cache_factor` and print a warning if a user still uses this option. ([\#11865](https://github.com/matrix-org/synapse/issues/11865)) - Remove support for the legacy structured logging configuration (please see the the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#legacy-structured-logging-configuration-removal) if you are using `structured: true` in the Synapse configuration). ([\#12008](https://github.com/matrix-org/synapse/issues/12008)) - Drop support for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283) unstable flags now that the stable flags are supported. ([\#12018](https://github.com/matrix-org/synapse/issues/12018)) - Remove the unstable `/spaces` endpoint from [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946). ([\#12073](https://github.com/matrix-org/synapse/issues/12073)) Internal Changes ---------------- - Make the `get_room_version` method use `get_room_version_id` to benefit from caching. ([\#11808](https://github.com/matrix-org/synapse/issues/11808)) - Remove unnecessary condition on knock -> leave auth rule check. ([\#11900](https://github.com/matrix-org/synapse/issues/11900)) - Add tests for device list changes between local users. ([\#11972](https://github.com/matrix-org/synapse/issues/11972)) - Optimise calculating `device_list` changes in `/sync`. ([\#11974](https://github.com/matrix-org/synapse/issues/11974)) - Add missing type hints to storage classes. ([\#11984](https://github.com/matrix-org/synapse/issues/11984)) - Refactor the search code for improved readability. ([\#11991](https://github.com/matrix-org/synapse/issues/11991)) - Move common deduplication code down into `_auth_and_persist_outliers`. ([\#11994](https://github.com/matrix-org/synapse/issues/11994)) - Limit concurrent joins from applications services. ([\#11996](https://github.com/matrix-org/synapse/issues/11996)) - Preparation for faster-room-join work: when parsing the `send_join` response, get the `m.room.create` event from `state`, not `auth_chain`. ([\#12005](https://github.com/matrix-org/synapse/issues/12005), [\#12039](https://github.com/matrix-org/synapse/issues/12039)) - Preparation for faster-room-join work: parse MSC3706 fields in send_join response. ([\#12011](https://github.com/matrix-org/synapse/issues/12011)) - Preparation for faster-room-join work: persist information on which events and rooms have partial state to the database. ([\#12012](https://github.com/matrix-org/synapse/issues/12012)) - Preparation for faster-room-join work: Support for calling `/federation/v1/state` on a remote server. ([\#12013](https://github.com/matrix-org/synapse/issues/12013)) - Configure `tox` to use `venv` rather than `virtualenv`. ([\#12015](https://github.com/matrix-org/synapse/issues/12015)) - Fix bug in `StateFilter.return_expanded()` and add some tests. ([\#12016](https://github.com/matrix-org/synapse/issues/12016)) - Use Matrix v1.1 endpoints (`/_matrix/client/v3/auth/...`) in fallback auth HTML forms. ([\#12019](https://github.com/matrix-org/synapse/issues/12019)) - Update the `olddeps` CI job to use an old version of `markupsafe`. ([\#12025](https://github.com/matrix-org/synapse/issues/12025)) - Upgrade Mypy to version 0.931. ([\#12030](https://github.com/matrix-org/synapse/issues/12030)) - Remove legacy `HomeServer.get_datastore()`. ([\#12031](https://github.com/matrix-org/synapse/issues/12031), [\#12070](https://github.com/matrix-org/synapse/issues/12070)) - Minor typing fixes. ([\#12034](https://github.com/matrix-org/synapse/issues/12034), [\#12069](https://github.com/matrix-org/synapse/issues/12069)) - After joining a room, create a dedicated logcontext to process the queued events. ([\#12041](https://github.com/matrix-org/synapse/issues/12041)) - Tidy up GitHub Actions config which builds distributions for PyPI. ([\#12051](https://github.com/matrix-org/synapse/issues/12051)) - Move configuration out of `setup.cfg`. ([\#12052](https://github.com/matrix-org/synapse/issues/12052), [\#12059](https://github.com/matrix-org/synapse/issues/12059)) - Fix error message when a worker process fails to talk to another worker process. ([\#12060](https://github.com/matrix-org/synapse/issues/12060)) - Fix using the `complement.sh` script without specifying a directory or a branch. Contributed by Nico on behalf of Famedly. ([\#12063](https://github.com/matrix-org/synapse/issues/12063)) - Add type hints to `tests/rest/client`. ([\#12066](https://github.com/matrix-org/synapse/issues/12066), [\#12072](https://github.com/matrix-org/synapse/issues/12072), [\#12084](https://github.com/matrix-org/synapse/issues/12084), [\#12094](https://github.com/matrix-org/synapse/issues/12094)) - Add some logging to `/sync` to try and track down #11916. ([\#12068](https://github.com/matrix-org/synapse/issues/12068)) - Inspect application dependencies using `importlib.metadata` or its backport. ([\#12088](https://github.com/matrix-org/synapse/issues/12088)) - Use `assertEqual` instead of the deprecated `assertEquals` in test code. ([\#12092](https://github.com/matrix-org/synapse/issues/12092)) - Move experimental support for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440) to `/versions`. ([\#12099](https://github.com/matrix-org/synapse/issues/12099)) - Add `stop_cancellation` utility function to stop `Deferred`s from being cancelled. ([\#12106](https://github.com/matrix-org/synapse/issues/12106)) - Improve exception handling for concurrent execution. ([\#12109](https://github.com/matrix-org/synapse/issues/12109)) - Advertise support for Python 3.10 in packaging files. ([\#12111](https://github.com/matrix-org/synapse/issues/12111)) - Move CI checks out of tox, to facilitate a move to using poetry. ([\#12119](https://github.com/matrix-org/synapse/issues/12119))	2022-03-02 15:26:43 +00:00
Erik Johnston	6d282a9c89	Make release script write correct no-op changelog (#12127) ... As we want to include the previous version in the "No new changes..." string.	2022-03-02 14:28:18 +00:00
Patrick Cloke	1103c5fe8a	Check if instances are lists, not sequences. (#12128) ... As a str is a sequence, the checks were not granular enough and would allow lists or strings, when only lists were valid.	2022-03-02 13:18:51 +00:00
David Robertson	f3f0ab10fe	Move scripts directory inside synapse, exposing as setuptools entry_points (#12118) ... * Two scripts are basically entry_points already * Move and rename scripts/* to synapse/_scripts/*.py * Delete sync_room_to_group.pl * Expose entry points in setup.py * Update linter script and config * Fixup scripts & docs mentioning scripts that moved Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2022-03-02 13:00:16 +00:00
Patrick Cloke	6adb89ff00	Improve and refactor the tests for relations. (#12113) ... * Modernizes code (f-strings, etc.) * Fixes incorrect comments. * Splits the test case into two. * Factors out some duplicated code.	2022-03-02 06:56:16 -05:00
Olivier Wilkinson (reivilibre)	879e4a7bd7	1.54.0rc1	2022-03-02 10:45:16 +00:00
Olivier Wilkinson (reivilibre)	a43a5ea5bf	Remove misleading newsfile from #12126 which backs out an unreleased change.	2022-03-02 10:38:10 +00:00
reivilibre	c7b2f1ccdc	Back out in-flight state caching changes. (#12126)	2022-03-02 10:37:04 +00:00
lukasdenk	8e56a1b73c	Make get_room_version use cached get_room_version_id. (#11808)	2022-03-02 10:35:34 +00:00
David Robertson	5f62a094de	Detox, part 1 of N (#12119) ... * Don't use `tox` for `check-sampleconfig` * Don't use `tox` for check-newsfragment	2022-03-01 19:47:02 +00:00
David Robertson	313581e4e9	Use importlib.metadata to read requirements (#12088) ... * Pull runtime dep checks into their own module * Reimplement `check_requirements` using `importlib` I've tried to make this clearer. We start by working out which of Synapse's requirements we need to be installed here and now. I was surprised that there wasn't an easier way to see which packages were installed by a given extra. I've pulled out the error messages into functions that deal with "is this for an extra or not". And I've rearranged the loop over two different sets of requirements into one loop with a "must be instaled" flag. I hope you agree that this is clearer. * Test cases	2022-03-01 17:44:41 +00:00
Sean Quah	4d6b6c17c8	Fix rare error in ReadWriteLock when writers complete immediately (#12105) ... Signed-off-by: Sean Quah <seanq@element.io>	2022-03-01 15:27:15 +00:00
Brendan Abolivier	300ed0b8a6	Add module callbacks called for reacting to deactivation status change and profile update (#12062)	2022-03-01 15:00:03 +00:00
Andrew Morgan	f26e390a40	Use Python 3.9 in Synapse dockerfiles by default (#12112)	2022-03-01 13:55:18 +00:00
Sean Quah	91bc15c772	Add stop_cancellation utility function (#12106)	2022-03-01 13:51:03 +00:00
reivilibre	c893632319	Order in-flight state group queries in biggest-first order (#11610) ... Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-01 13:41:57 +00:00
Richard van der Hoff	e2e1d90a5e	Faster joins: persist to database (#12012) ... When we get a partial_state response from send_join, store information in the database about it: * store a record about the room as a whole having partial state, and stash the list of member servers too. * flag the join event itself as having partial state * also, for any new events whose prev-events are partial-stated, note that they will *also* be partial-stated. We don't yet make any attempt to interpret this data, so API calls (and a bunch of other things) are just going to get incorrect data.	2022-03-01 12:49:54 +00:00
Andrew Morgan	4ccc2d09aa	Advertise Python 3.10 support in setup.py (#12111)	2022-03-01 12:35:32 +00:00
Richard van der Hoff	5458eb8551	Fix 'Unhandled error in Deferred' (#12089) ... * Fix 'Unhandled error in Deferred' Fixes a CRITICAL "Unhandled error in Deferred" log message which happened when a function wrapped with `@cachedList` failed * Minor optimisation to cachedListDescriptor we can avoid re-using `missing`, which saves looking up entries in `deferreds_map`, and means we don't need to copy it. * Improve type annotation on CachedListDescriptor	2022-03-01 09:51:38 +00:00
Richard van der Hoff	9d11fee8f2	Improve exception handling for concurrent execution (#12109) ... * fix incorrect unwrapFirstError import this was being imported from the wrong place * Refactor `concurrently_execute` to use `yieldable_gather_results` * Improve exception handling in `yieldable_gather_results` Try to avoid swallowing so many stack traces. * mark unwrapFirstError deprecated * changelog	2022-03-01 09:34:30 +00:00
Dirk Klimpel	952efd0bca	Add type hints to tests/rest/client (#12094) ... * Add type hints to `tests/rest/client` * update `mypy.ini` * newsfile * add `test_register.py`	2022-02-28 18:59:00 +00:00
Patrick Cloke	7754af24ab	Remove the unstable /spaces endpoint. (#12073) ... ...and various code supporting it. The /spaces endpoint was from an old version of MSC2946 and included both a Client-Server and Server-Server API. Note that the unstable /hierarchy endpoint (from the final version of MSC2946) is not yet removed.	2022-02-28 18:33:00 +00:00
Patrick Cloke	1866fb39d7	Move experimental support for MSC3440 to /versions. (#12099) ... Instead of being part of /capabilities, this matches a change to MSC3440 to properly use these endpoints.	2022-02-28 18:29:09 +00:00
Dirk Klimpel	1901cb1d4a	Add type hints to tests/rest/client (#12084)	2022-02-28 17:47:37 +00:00
Richard van der Hoff	6c0b44a3d7	Fix PushRuleEvaluator and Filter to work on frozendicts (#12100) ... * Fix `PushRuleEvaluator` to work on frozendicts frozendicts do not (necessarily) inherit from dict, so this needs to handle them correctly. * Fix event filtering for frozen events Looks like this one was introduced by #11194.	2022-02-28 17:40:24 +00:00
David Robertson	5565f454e1	Actually fix bad debug logging rejecting device list & signing key transactions (#12098)	2022-02-28 14:10:36 +00:00
Patrick Cloke	9e83521af8	Properly failover for unknown endpoints from Conduit/Dendrite. (#12077) ... Before this fix, a legitimate 404 from a federation endpoint (e.g. due to an unknown room) would be treated as an unknown endpoint. This could cause unnecessary federation traffic.	2022-02-28 07:52:44 -05:00
Patrick Cloke	02d708568b	Replace assertEquals and friends with non-deprecated versions. (#12092)	2022-02-28 07:12:29 -05:00
lukasdenk	ab3ef49059	synctl: print warning if synctl_cache_factor is set in config (#11865) ... Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2022-02-28 11:42:13 +00:00
Sean Quah	b43c3ef8e2	Ensure that get_datastores().main is typed (#12070) ... Signed-off-by: Sean Quah <seanq@element.io>	2022-02-25 10:20:40 +00:00
Sean Quah	f3fd8558cd	Minor typing fixes for synapse/storage/persist_events.py (#12069) ... Signed-off-by: Sean Quah <seanq@element.io>	2022-02-25 10:19:49 +00:00
Dirk Klimpel	54e74cc15f	Add type hints to tests/rest/client (#12072)	2022-02-24 13:56:38 -05:00
reivilibre	2cc5ea933d	Add support for MSC3202: sending one-time key counts and fallback key usage states to Application Services. (#11617) ... Co-authored-by: Erik Johnston <erik@matrix.org>	2022-02-24 17:55:45 +00:00
Sean Quah	41cf4c2cf6	Fix non-strings in the event_search table (#12037) ... Don't attempt to add non-string `value`s to `event_search` and add a background update to clear out bad rows from `event_search` when using sqlite. Signed-off-by: Sean Quah <seanq@element.io>	2022-02-24 11:52:28 +00:00
Patrick Cloke	c56bfb08bc	Add documentation for missing worker types. (#11599) ... And clean-up the endpoints which should be routed to workers.	2022-02-23 22:49:04 +00:00
Erik Johnston	a711ae78a8	Add logging to /sync for debugging #11916 (#12068)	2022-02-23 14:22:22 +00:00
Dirk Klimpel	64c73c6ac8	Add type hints to tests/rest/client (#12066)	2022-02-23 08:33:19 -05:00
Richard van der Hoff	5b2b36809f	Remove more references to get_datastore (#12067) ... These have snuck in since #12031 was started. Also a couple of other cleanups while we're in the area.	2022-02-23 12:35:53 +00:00
Richard van der Hoff	e24ff8ebe3	Remove HomeServer.get_datastore() (#12031) ... The presence of this method was confusing, and mostly present for backwards compatibility. Let's get rid of it. Part of #11733	2022-02-23 11:04:02 +00:00
Nicolas Werner	c1ac2a8135	Rename default branch of complement.sh to main (#12063) ... The complement.sh script relies on the name of the ref matching the name of the unpacked folder. The branch redirect from renaming the default branch breaks that assumption. Signed-off-by: Nicolas Werner <n.werner@famedly.com>	2022-02-23 10:06:18 +00:00
Travis Ralston	e3fe6347be	Remove excess condition on knock->leave check (#11900)	2022-02-22 18:35:01 +00:00
Erik Johnston	6d14b3dabf	Better error message when failing to request from another process (#12060)	2022-02-22 15:52:08 +00:00
Brendan Abolivier	250104d357	Implement account status endpoints (MSC3720) (#12001) ... See matrix-org/matrix-doc#3720 Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-02-22 15:10:10 +00:00
David Robertson	94a396e7c4	Prune setup.cfg some more (#12059) ... * Remove `trial` section from setup.cfg This was added in the initial commit from 2014. I can't see that it does anything. Maybe it's there so that you can run `trial` without any extra args, but if I do that then I just get the `--help` message. * Move flake8's config to its own file	2022-02-22 14:52:56 +00:00
reivilibre	dcb6a37837	Cap the number of in-flight requests for state from a single group (#11608)	2022-02-22 14:24:31 +00:00
Patrick Cloke	7bcc28f82f	Use room version 9 as the default room version (per MSC3589). (#12058)	2022-02-22 14:09:40 +00:00
Richard van der Hoff	81364db49b	Run _handle_queued_pdus as a background process (#12041) ... ... to ensure it gets a proper log context, mostly.	2022-02-22 13:33:22 +00:00
reivilibre	235d2916ce	Fix slow performance of /logout in some cases where refresh tokens are in use. The slowness existed since the initial implementation of refresh tokens. (#12056)	2022-02-22 13:29:04 +00:00
Richard van der Hoff	7273011f60	Faster joins: Support for calling /federation/v1/state (#12013) ... This is an endpoint that we have server-side support for, but no client-side support. It's going to be useful for resyncing partial-stated rooms, so let's introduce it.	2022-02-22 12:17:10 +00:00
AndrewRyanChama	066171643b	Fetch images when previewing Twitter URLs. (#11985) ... By including "bot" in the User-Agent, which some sites use to decide whether to include additional Open Graph information.	2022-02-22 07:11:39 -05:00
reivilibre	546b9c9e64	Add more tests for in-flight state query duplication. (#12033)	2022-02-22 11:44:11 +00:00
David Robertson	af2c1e3d2a	Tidy the building of sdists and wheels (#12051) ... * Don't build distribution pkgs in tests.yml * Run `release-artifacts` on release branches * Use backend-meta workflow for packaging	2022-02-22 11:33:37 +00:00
David Robertson	1ae492c8c0	Move isort config to pyproject.toml (#12052)	2022-02-22 11:30:19 +00:00
Travis Ralston	d7cb0dcbaa	Use v3 endpoints for fallback auth (Matrix 1.1) (#12019)	2022-02-22 11:20:45 +00:00
Richard van der Hoff	3070af4809	remote join processing: get create event from state, not auth_chain (#12039) ... A follow-up to #12005, in which I apparently missed that there are a bunch of other places that assume the create event is in the auth chain.	2022-02-21 19:27:35 +00:00
Richard van der Hoff	a85dde3445	Minor typing fixes (#12034) ... These started failing in https://github.com/matrix-org/synapse/pull/12031... I'm a bit mystified by how they ever worked.	2022-02-21 18:37:04 +00:00
Dirk Klimpel	7c82da27aa	Add type hints to synapse/storage/databases/main (#11984)	2022-02-21 16:03:06 +00:00
Travis Ralston	99f6d79fe1	Advertise Matrix 1.2 in /_matrix/client/versions (#12022) ... Co-authored-by: Patrick Cloke <patrickc@matrix.org>	2022-02-21 08:59:29 -07:00
Patrick Cloke	444b04058b	Document why auth providers aren't validated in the admin API. (#12004) ... Since it is reasonable to give a future or past auth provider, which might not be in the current configuration.	2022-02-18 17:24:25 +00:00
reivilibre	284ea2025a	Track and deduplicate in-flight requests to _get_state_for_groups. (#10870) ... Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-02-18 17:23:31 +00:00
Sean Quah	e6acd3cf4f	Upgrade mypy to version 0.931 (#12030) ... Upgrade mypy to 0.931, mypy-zope to 0.3.5 and fix new complaints.	2022-02-18 15:57:26 +00:00
reivilibre	eb609c65d0	Fix bug in StateFilter.return_expanded() and add some tests. (#12016)	2022-02-18 14:54:31 +00:00
Travis Ralston	31a298fec7	Advertise Matrix 1.1 in /_matrix/client/versions (#12020)	2022-02-18 07:49:53 -05:00
Travis Ralston	19bd9cff1a	Use stable MSC3069 is_guest flag on /whoami. (#12021) ... Keeping backwards compatibility with the unstable flag for now.	2022-02-18 07:48:23 -05:00
Eric Eastwood	5a6911598a	Fix 500 error with Postgres when looking backwards with the MSC3030 /timestamp_to_event endpoint (#12024)	2022-02-18 12:11:18 +00:00
Brendan Abolivier	40e256e7aa	Update the olddeps CI check to use an old version of markupsafe (#12025)	2022-02-18 11:38:48 +00:00
Erik Johnston	3f4d25a48b	Remove unstable MSC3283 flags (#12018) ... Fixes #11962	2022-02-17 17:22:55 +00:00
Brendan Abolivier	707049c6ff	Allow modules to set a display name on registration (#12009) ... Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-02-17 16:54:16 +00:00
Richard van der Hoff	da0e9f8efd	Faster joins: parse msc3706 fields in send_join response (#12011) ... Part of my work on #11249: add code to handle the new fields added in MSC3706.	2022-02-17 16:11:59 +00:00
Richard van der Hoff	6127c4b9f1	Configure tox to use venv (#12015) ... As the comment says, virtualenv is a pile of fail.	2022-02-17 15:55:14 +00:00
Patrick Cloke	e69f8f0a8e	Remove support for the legacy structured logging configuration. (#12008)	2022-02-17 13:32:18 +00:00
Richard van der Hoff	696acd3515	send_join response: get create event from state, not auth_chain (#12005) ... msc3706 proposes changing the `/send_join` response: > Any events returned within `state` can be omitted from `auth_chain`. Currently, we rely on `m.room.create` being returned in `auth_chain`, but since the `m.room.create` event must necessarily be part of the state, the above change will break this. In short, let's look for `m.room.create` in `state` rather than `auth_chain`.	2022-02-17 11:59:26 +00:00
lukasdenk	4077177390	Prevent duplicate push notifications for room reads (#11835)	2022-02-17 10:23:54 +00:00
David Robertson	73fc488783	Explain the meaning of spam checker callbacks' return values (#12003) ... Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-02-16 12:25:43 +00:00
Brendan Abolivier	130fd45393	Limit concurrent AS joins (#11996) ... Initially introduced in matrix-org-hotfixes by e5537cf (and tweaked by later commits). Fixes #11995 See also #4826	2022-02-16 11:16:48 +00:00
Erik Johnston	2b5643b3af	Optimise calculating device_list changes in /sync. (#11974) ... For users with large accounts it is inefficient to calculate the set of users they share a room with (and takes a lot of space in the cache). Instead we can look at users whose devices have changed since the last sync and check if they share a room with the syncing user.	2022-02-15 15:01:00 +00:00
Richard van der Hoff	bab2394aa9	_auth_and_persist_outliers: drop events we have already seen (#11994) ... We already have two copies of this code, in 2/3 of the callers of `_auth_and_persist_outliers`. Before I add a third, let's push it down.	2022-02-15 14:33:28 +00:00
Erik Johnston	0dbbe33a65	Track cache invalidations (#12000) ... Currently we only track evictions due to size or time constraints.	2022-02-15 14:31:04 +00:00
Erik Johnston	dc9fe61050	Fix incorrect get_rooms_for_user for remote user (#11999) ... When the server leaves a room the `get_rooms_for_user` cache is not correctly invalidated for the remote users in the room. This means that subsequent calls to `get_rooms_for_user` for the remote users would incorrectly include the room (it shouldn't be included because the server no longer knows anything about the room).	2022-02-15 14:26:28 +00:00
Richard van der Hoff	5598556b77	Docker: remove VOLUME directive (#11997) ... The driver for this is to stop Complement complaining about it, but as far as I can tell it was pointless and needed to go away anyway. I'm a bit unclear about what exactly VOLUME does, but I think what it means is that, if you don't override it with an explicit -v argument, then docker run will create a temporary volume, and copy things into it. The temporary volume is then deleted when the container finishes. That only sounds useful if your image has something to copy into it (otherwise you may as well just use the default root filesystem), and our image notably doesn't copy anything into /data. So... this wasn't doing anything, except annoying Complement?	2022-02-15 13:59:15 +00:00
Patrick Cloke	e44f91d678	Refactor search code to reduce function size. (#11991) ... Splits the search code into a few logical functions instead of a single unreadable function. There are also a few additional changes for readability. After refactoring it was clear to see there were some unused and unnecessary variables, which were simplified.	2022-02-15 13:47:05 +00:00
Patrick Cloke	45f45404de	Fix incorrect thread summaries when the latest event is edited. (#11992) ... If the latest event in a thread was edited than the original event content was included in bundled aggregation for threads instead of the edited event content.	2022-02-15 08:26:57 -05:00
Sean Quah	85e24d9d2b	Synapse 1.53.0rc1 (2022-02-15) ... ============================== Features -------- - Add experimental support for sending to-device messages to application services, as specified by [MSC2409](https://github.com/matrix-org/matrix-doc/pull/2409). ([\#11215](https://github.com/matrix-org/synapse/issues/11215), [\#11966](https://github.com/matrix-org/synapse/issues/11966)) - Remove account data (including client config, push rules and ignored users) upon user deactivation. ([\#11655](https://github.com/matrix-org/synapse/issues/11655)) - Experimental support for [MSC3666](https://github.com/matrix-org/matrix-doc/pull/3666): including bundled aggregations in server side search results. ([\#11837](https://github.com/matrix-org/synapse/issues/11837)) - Enable cache time-based expiry by default. The `expiry_time` config flag has been superseded by `expire_caches` and `cache_entry_ttl`. ([\#11849](https://github.com/matrix-org/synapse/issues/11849)) - Add a callback to allow modules to allow or forbid a 3PID (email address, phone number) from being associated to a local account. ([\#11854](https://github.com/matrix-org/synapse/issues/11854)) - Stabilize support and remove unstable endpoints for [MSC3231](https://github.com/matrix-org/matrix-doc/pull/3231). Clients must switch to the stable identifier and endpoint. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#stablisation-of-msc3231) for more information. ([\#11867](https://github.com/matrix-org/synapse/issues/11867)) - Allow modules to retrieve the current instance's server name and worker name. ([\#11868](https://github.com/matrix-org/synapse/issues/11868)) - Use a dedicated configurable rate limiter for 3PID invites. ([\#11892](https://github.com/matrix-org/synapse/issues/11892)) - Support the stable API endpoint for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283): new settings in `/capabilities` endpoint. ([\#11933](https://github.com/matrix-org/synapse/issues/11933), [\#11989](https://github.com/matrix-org/synapse/issues/11989)) - Support the `dir` parameter on the `/relations` endpoint, per [MSC3715](https://github.com/matrix-org/matrix-doc/pull/3715). ([\#11941](https://github.com/matrix-org/synapse/issues/11941)) - Experimental implementation of [MSC3706](https://github.com/matrix-org/matrix-doc/pull/3706): extensions to `/send_join` to support reduced response size. ([\#11967](https://github.com/matrix-org/synapse/issues/11967)) Bugfixes -------- - Fix [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) historical messages backfilling in random order on remote homeservers. ([\#11114](https://github.com/matrix-org/synapse/issues/11114)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#11890](https://github.com/matrix-org/synapse/issues/11890)) - Fix a long-standing bug where some unknown endpoints would return HTML error pages instead of JSON `M_UNRECOGNIZED` errors. ([\#11930](https://github.com/matrix-org/synapse/issues/11930)) - Implement an allow list of content types for which we will attempt to preview a URL. This prevents Synapse from making useless longer-lived connections to streaming media servers. ([\#11936](https://github.com/matrix-org/synapse/issues/11936)) - Fix a long-standing bug where pagination tokens from `/sync` and `/messages` could not be provided to the `/relations` API. ([\#11952](https://github.com/matrix-org/synapse/issues/11952)) - Require that modules register their callbacks using keyword arguments. ([\#11975](https://github.com/matrix-org/synapse/issues/11975)) - Fix a long-standing bug where `M_WRONG_ROOM_KEYS_VERSION` errors would not include the specced `current_version` field. ([\#11988](https://github.com/matrix-org/synapse/issues/11988)) Improved Documentation ---------------------- - Fix typo in User Admin API: unpind -> unbind. ([\#11859](https://github.com/matrix-org/synapse/issues/11859)) - Document images returned by the User List Media Admin API can include those generated by URL previews. ([\#11862](https://github.com/matrix-org/synapse/issues/11862)) - Remove outdated MSC1711 FAQ document. ([\#11907](https://github.com/matrix-org/synapse/issues/11907)) - Correct the structured logging configuration example. Contributed by Brad Jones. ([\#11946](https://github.com/matrix-org/synapse/issues/11946)) - Add information on the Synapse release cycle. ([\#11954](https://github.com/matrix-org/synapse/issues/11954)) - Fix broken link in the README to the admin API for password reset. ([\#11955](https://github.com/matrix-org/synapse/issues/11955)) Deprecations and Removals ------------------------- - Drop support for `webclient` listeners and configuring `web_client_location` to a non-HTTP(S) URL. Deprecated configurations are a configuration error. ([\#11895](https://github.com/matrix-org/synapse/issues/11895)) - Remove deprecated `user_may_create_room_with_invites` spam checker callback. See the [upgrade notes](https://matrix-org.github.io/synapse/latest/upgrade.html#removal-of-user_may_create_room_with_invites) for more information. ([\#11950](https://github.com/matrix-org/synapse/issues/11950)) - No longer build `.deb` packages for Ubuntu 21.04 Hirsute Hippo, which has now EOLed. ([\#11961](https://github.com/matrix-org/synapse/issues/11961)) Internal Changes ---------------- - Enhance user registration test helpers to make them more useful for tests involving application services and devices. ([\#11615](https://github.com/matrix-org/synapse/issues/11615), [\#11616](https://github.com/matrix-org/synapse/issues/11616)) - Improve performance when fetching bundled aggregations for multiple events. ([\#11660](https://github.com/matrix-org/synapse/issues/11660), [\#11752](https://github.com/matrix-org/synapse/issues/11752)) - Fix type errors introduced by new annotations in the Prometheus Client library. ([\#11832](https://github.com/matrix-org/synapse/issues/11832)) - Add missing type hints to replication code. ([\#11856](https://github.com/matrix-org/synapse/issues/11856), [\#11938](https://github.com/matrix-org/synapse/issues/11938)) - Ensure that `opentracing` scopes are activated and closed at the right time. ([\#11869](https://github.com/matrix-org/synapse/issues/11869)) - Improve opentracing for incoming federation requests. ([\#11870](https://github.com/matrix-org/synapse/issues/11870)) - Improve internal docstrings in `synapse.util.caches`. ([\#11876](https://github.com/matrix-org/synapse/issues/11876)) - Do not needlessly clear the `get_users_in_room` and `get_users_in_room_with_profiles` caches when any room state changes. ([\#11878](https://github.com/matrix-org/synapse/issues/11878)) - Convert `ApplicationServiceTestCase` to use `simple_async_mock`. ([\#11880](https://github.com/matrix-org/synapse/issues/11880)) - Remove experimental changes to the default push rules which were introduced in Synapse 1.19.0 but never enabled. ([\#11884](https://github.com/matrix-org/synapse/issues/11884)) - Disable coverage calculation for olddeps build. ([\#11888](https://github.com/matrix-org/synapse/issues/11888)) - Preparation to support sending device list updates to application services. ([\#11905](https://github.com/matrix-org/synapse/issues/11905)) - Add a test that checks users receive their own device list updates down `/sync`. ([\#11909](https://github.com/matrix-org/synapse/issues/11909)) - Run Complement tests sequentially. ([\#11910](https://github.com/matrix-org/synapse/issues/11910)) - Various refactors to the application service notifier code. ([\#11911](https://github.com/matrix-org/synapse/issues/11911), [\#11912](https://github.com/matrix-org/synapse/issues/11912)) - Tests: replace mocked `Authenticator` with the real thing. ([\#11913](https://github.com/matrix-org/synapse/issues/11913)) - Various refactors to the typing notifications code. ([\#11914](https://github.com/matrix-org/synapse/issues/11914)) - Use the proper type for the `Content-Length` header in the `UploadResource`. ([\#11927](https://github.com/matrix-org/synapse/issues/11927)) - Remove an unnecessary ignoring of type hints due to fixes in upstream packages. ([\#11939](https://github.com/matrix-org/synapse/issues/11939)) - Add missing type hints. ([\#11953](https://github.com/matrix-org/synapse/issues/11953)) - Fix an import cycle in `synapse.event_auth`. ([\#11965](https://github.com/matrix-org/synapse/issues/11965)) - Unpin `frozendict` but exclude the known bad version 2.1.2. ([\#11969](https://github.com/matrix-org/synapse/issues/11969)) - Prepare for rename of default Complement branch. ([\#11971](https://github.com/matrix-org/synapse/issues/11971)) - Fetch Synapse's version using a helper from `matrix-common`. ([\#11979](https://github.com/matrix-org/synapse/issues/11979)) -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEWMTnW8Z8khaaf90R+84KzgcyGG8FAmILmzYACgkQ+84Kzgcy GG8e7gwAsbDeek7v14ezJwETabXpw957fOe2CVA9DfU1yrORrATy38dIe1ppbzEQ OzSPehykBg7+z+eDRQ1b8tjfTfDlOSuBmjfBm1qdYYPTPwc1LP5K62uOG3QDbOVw YlxNB21Yp3m+yhp4VhSZzx2b5H+noYyll9rlamQ1tW3EOruJEdwAXyhlXfx2azLC qHVn1UF+q2htD65VaoF3XQSP6cmzWtEG7BFtmDCwIGCTdc+WENN9HJuWp1axwBs6 V6lVosiHxQzo38dk6ZYwsnHO5ObcuYsPzhuLgJVt9X9sE03YAXLknmQdizIJBy0f nz1GESZ1osuokU8v88k5Y5Z5RiCeauD/75RdORk9070sPyedY2rFVdyWcq42pjpP mWJ7DpQsGZQG5c2tPJTyfMpPg+KcXY02WpIvmUvced5iT/FGfCx7xSaA3JOsFrtp 2s8LWanaIKhU0XZ2MkXoH3ZdZPfQmzyVSCwIQOE04kio/3tmbRE90Fn1DAK9a+O6 WVOTWMGK =8tcJ -----END PGP SIGNATURE----- Merge tag 'v1.53.0rc1' into develop Synapse 1.53.0rc1 (2022-02-15) ============================== Features -------- - Add experimental support for sending to-device messages to application services, as specified by [MSC2409](https://github.com/matrix-org/matrix-doc/pull/2409). ([\#11215](https://github.com/matrix-org/synapse/issues/11215), [\#11966](https://github.com/matrix-org/synapse/issues/11966)) - Remove account data (including client config, push rules and ignored users) upon user deactivation. ([\#11655](https://github.com/matrix-org/synapse/issues/11655)) - Experimental support for [MSC3666](https://github.com/matrix-org/matrix-doc/pull/3666): including bundled aggregations in server side search results. ([\#11837](https://github.com/matrix-org/synapse/issues/11837)) - Enable cache time-based expiry by default. The `expiry_time` config flag has been superseded by `expire_caches` and `cache_entry_ttl`. ([\#11849](https://github.com/matrix-org/synapse/issues/11849)) - Add a callback to allow modules to allow or forbid a 3PID (email address, phone number) from being associated to a local account. ([\#11854](https://github.com/matrix-org/synapse/issues/11854)) - Stabilize support and remove unstable endpoints for [MSC3231](https://github.com/matrix-org/matrix-doc/pull/3231). Clients must switch to the stable identifier and endpoint. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#stablisation-of-msc3231) for more information. ([\#11867](https://github.com/matrix-org/synapse/issues/11867)) - Allow modules to retrieve the current instance's server name and worker name. ([\#11868](https://github.com/matrix-org/synapse/issues/11868)) - Use a dedicated configurable rate limiter for 3PID invites. ([\#11892](https://github.com/matrix-org/synapse/issues/11892)) - Support the stable API endpoint for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283): new settings in `/capabilities` endpoint. ([\#11933](https://github.com/matrix-org/synapse/issues/11933), [\#11989](https://github.com/matrix-org/synapse/issues/11989)) - Support the `dir` parameter on the `/relations` endpoint, per [MSC3715](https://github.com/matrix-org/matrix-doc/pull/3715). ([\#11941](https://github.com/matrix-org/synapse/issues/11941)) - Experimental implementation of [MSC3706](https://github.com/matrix-org/matrix-doc/pull/3706): extensions to `/send_join` to support reduced response size. ([\#11967](https://github.com/matrix-org/synapse/issues/11967)) Bugfixes -------- - Fix [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) historical messages backfilling in random order on remote homeservers. ([\#11114](https://github.com/matrix-org/synapse/issues/11114)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#11890](https://github.com/matrix-org/synapse/issues/11890)) - Fix a long-standing bug where some unknown endpoints would return HTML error pages instead of JSON `M_UNRECOGNIZED` errors. ([\#11930](https://github.com/matrix-org/synapse/issues/11930)) - Implement an allow list of content types for which we will attempt to preview a URL. This prevents Synapse from making useless longer-lived connections to streaming media servers. ([\#11936](https://github.com/matrix-org/synapse/issues/11936)) - Fix a long-standing bug where pagination tokens from `/sync` and `/messages` could not be provided to the `/relations` API. ([\#11952](https://github.com/matrix-org/synapse/issues/11952)) - Require that modules register their callbacks using keyword arguments. ([\#11975](https://github.com/matrix-org/synapse/issues/11975)) - Fix a long-standing bug where `M_WRONG_ROOM_KEYS_VERSION` errors would not include the specced `current_version` field. ([\#11988](https://github.com/matrix-org/synapse/issues/11988)) Improved Documentation ---------------------- - Fix typo in User Admin API: unpind -> unbind. ([\#11859](https://github.com/matrix-org/synapse/issues/11859)) - Document images returned by the User List Media Admin API can include those generated by URL previews. ([\#11862](https://github.com/matrix-org/synapse/issues/11862)) - Remove outdated MSC1711 FAQ document. ([\#11907](https://github.com/matrix-org/synapse/issues/11907)) - Correct the structured logging configuration example. Contributed by Brad Jones. ([\#11946](https://github.com/matrix-org/synapse/issues/11946)) - Add information on the Synapse release cycle. ([\#11954](https://github.com/matrix-org/synapse/issues/11954)) - Fix broken link in the README to the admin API for password reset. ([\#11955](https://github.com/matrix-org/synapse/issues/11955)) Deprecations and Removals ------------------------- - Drop support for `webclient` listeners and configuring `web_client_location` to a non-HTTP(S) URL. Deprecated configurations are a configuration error. ([\#11895](https://github.com/matrix-org/synapse/issues/11895)) - Remove deprecated `user_may_create_room_with_invites` spam checker callback. See the [upgrade notes](https://matrix-org.github.io/synapse/latest/upgrade.html#removal-of-user_may_create_room_with_invites) for more information. ([\#11950](https://github.com/matrix-org/synapse/issues/11950)) - No longer build `.deb` packages for Ubuntu 21.04 Hirsute Hippo, which has now EOLed. ([\#11961](https://github.com/matrix-org/synapse/issues/11961)) Internal Changes ---------------- - Enhance user registration test helpers to make them more useful for tests involving application services and devices. ([\#11615](https://github.com/matrix-org/synapse/issues/11615), [\#11616](https://github.com/matrix-org/synapse/issues/11616)) - Improve performance when fetching bundled aggregations for multiple events. ([\#11660](https://github.com/matrix-org/synapse/issues/11660), [\#11752](https://github.com/matrix-org/synapse/issues/11752)) - Fix type errors introduced by new annotations in the Prometheus Client library. ([\#11832](https://github.com/matrix-org/synapse/issues/11832)) - Add missing type hints to replication code. ([\#11856](https://github.com/matrix-org/synapse/issues/11856), [\#11938](https://github.com/matrix-org/synapse/issues/11938)) - Ensure that `opentracing` scopes are activated and closed at the right time. ([\#11869](https://github.com/matrix-org/synapse/issues/11869)) - Improve opentracing for incoming federation requests. ([\#11870](https://github.com/matrix-org/synapse/issues/11870)) - Improve internal docstrings in `synapse.util.caches`. ([\#11876](https://github.com/matrix-org/synapse/issues/11876)) - Do not needlessly clear the `get_users_in_room` and `get_users_in_room_with_profiles` caches when any room state changes. ([\#11878](https://github.com/matrix-org/synapse/issues/11878)) - Convert `ApplicationServiceTestCase` to use `simple_async_mock`. ([\#11880](https://github.com/matrix-org/synapse/issues/11880)) - Remove experimental changes to the default push rules which were introduced in Synapse 1.19.0 but never enabled. ([\#11884](https://github.com/matrix-org/synapse/issues/11884)) - Disable coverage calculation for olddeps build. ([\#11888](https://github.com/matrix-org/synapse/issues/11888)) - Preparation to support sending device list updates to application services. ([\#11905](https://github.com/matrix-org/synapse/issues/11905)) - Add a test that checks users receive their own device list updates down `/sync`. ([\#11909](https://github.com/matrix-org/synapse/issues/11909)) - Run Complement tests sequentially. ([\#11910](https://github.com/matrix-org/synapse/issues/11910)) - Various refactors to the application service notifier code. ([\#11911](https://github.com/matrix-org/synapse/issues/11911), [\#11912](https://github.com/matrix-org/synapse/issues/11912)) - Tests: replace mocked `Authenticator` with the real thing. ([\#11913](https://github.com/matrix-org/synapse/issues/11913)) - Various refactors to the typing notifications code. ([\#11914](https://github.com/matrix-org/synapse/issues/11914)) - Use the proper type for the `Content-Length` header in the `UploadResource`. ([\#11927](https://github.com/matrix-org/synapse/issues/11927)) - Remove an unnecessary ignoring of type hints due to fixes in upstream packages. ([\#11939](https://github.com/matrix-org/synapse/issues/11939)) - Add missing type hints. ([\#11953](https://github.com/matrix-org/synapse/issues/11953)) - Fix an import cycle in `synapse.event_auth`. ([\#11965](https://github.com/matrix-org/synapse/issues/11965)) - Unpin `frozendict` but exclude the known bad version 2.1.2. ([\#11969](https://github.com/matrix-org/synapse/issues/11969)) - Prepare for rename of default Complement branch. ([\#11971](https://github.com/matrix-org/synapse/issues/11971)) - Fetch Synapse's version using a helper from `matrix-common`. ([\#11979](https://github.com/matrix-org/synapse/issues/11979))	2022-02-15 13:14:52 +00:00
Andrew Morgan	87f2005713	Add some tests for propagation of device list changes between local users (#11972)	2022-02-15 11:27:56 +00:00
Sean Quah	7c05599041	1.53.0rc1	2022-02-15 10:44:24 +00:00
Pascal Bach	c4c98c7518	Revert "Pin to frozendict<2.1.2 (#11625)" and allow frozendict>2.1.2 (#11969) ... This reverts commit 2bf31f7807. Signed-off-by: Pascal Bach <pascal.bach@nextrem.ch>	2022-02-14 21:18:01 +00:00
Michael Telatynski	54e74f8bde	Fix M_WRONG_ROOM_KEYS_VERSION error not including current_version field (#11988) ... Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>	2022-02-14 19:28:00 +00:00
Andrew Morgan	7812fe9edd	Note when unstable MSC3283 prefixes will be removed (#11989)	2022-02-14 19:07:59 +00:00
H. Shay	9c4563c5cd	remove empty file, reword/rename newsfragment, and add line to upgrade doc	2022-02-14 10:21:00 -08:00
Patrick Cloke	738e569ed2	Require that modules register their callbacks using keyword arguments. (#11975) ... To allow for easier backwards/forwards compatibility by making it easier to add/remove callbacks.	2022-02-14 09:18:44 -05:00
David Robertson	4ae956c8bb	Use version string helper from matrix-common (#11979) ... * Require latest matrix-common * Use the common function	2022-02-14 13:12:22 +00:00
Andrew Morgan	55113dd5e8	Notify users, rather than rooms, of device list updates (#11905) ... Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-02-12 09:33:49 -05:00
Richard van der Hoff	63c46349c4	Implement MSC3706: partial state in /send_join response (#11967) ... * Make `get_auth_chain_ids` return a Set It has a set internally, and a set is often useful where it gets used, so let's avoid converting to an intermediate list. * Minor refactors in `on_send_join_request` A little bit of non-functional groundwork * Implement MSC3706: partial state in /send_join response	2022-02-12 10:44:16 +00:00
Shay	b2b971f28a	Enable cache time-based expiry by default (#11849)	2022-02-11 11:05:20 -08:00
Patrick Cloke	4d7e74b2e5	Support the MSC3715 for /relations. (#11941) ... This adds an unstable org.matrix.msc3715.dir parameter which acts like dir on /mesages.	2022-02-11 11:20:27 -05:00
Patrick Cloke	b65acead42	Fetch thread summaries for multiple events in a single query (#11752) ... This should reduce database usage when fetching bundled aggregations as the number of individual queries (and round trips to the database) are reduced.	2022-02-11 09:50:14 -05:00
Richard van der Hoff	bb98c593a5	Prepare for rename of default complement branch (#11971) ... use `HEAD` rather than hardcoding `master`	2022-02-11 14:43:34 +00:00
Brendan Abolivier	0171fa5226	Remove deprecated user_may_create_room_with_invites callback (#11950) ... Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-02-11 13:58:11 +00:00
Erik Johnston	086d1d6d0b	Fix Newsfile ... \#11966 fixes a bug introduced by #11215, which isn't in a released version.	2022-02-11 13:51:26 +00:00
Erik Johnston	705a439972	Fix Newsfile ... \#11966 fixes a bug introduced by #11215, which isn't in a released version.	2022-02-11 13:49:40 +00:00
Erik Johnston	79fb64e417	Fix to-device being dropped in limited sync in SQLite. (#11966) ... If ther are more than 100 to-device messages pending for a device `/sync` will only return the first 100, however the next batch token was incorrectly calculated and so all other pending messages would be dropped. This is due to `txn.rowcount` only returning the number of rows that *changed*, rather than the number *selected* in SQLite.	2022-02-11 13:38:05 +00:00
Richard van der Hoff	4ef39f3353	fix import cycle (#11965)	2022-02-11 13:07:55 +00:00
Patrick Cloke	a121507cfe	Adds misc missing type hints (#11953)	2022-02-11 07:20:16 -05:00
Richard van der Hoff	c3db7a0b59	Tests: replace mocked Authenticator with the real thing (#11913) ... If we prepopulate the test homeserver with a key for a remote homeserver, we can make federation requests to it without having to stub out the authenticator. This has two advantages: * means that what we are testing is closer to reality (ie, we now have complete tests for the incoming-request-authorisation flow) * some tests require that other objects be signed by the remote server (eg, the event in `/send_join`), and doing that would require a whole separate set of mocking out. It's much simpler just to use real keys.	2022-02-11 12:06:02 +00:00
Dirk Klimpel	d36943c4df	Support the stable API endpoint for MSC3283: new settings in /capabilities endpoint (#11933)	2022-02-11 09:32:11 +00:00
Shay	1e12efa1b2	Drop support for EOL Ubuntu 21.04 (#11961)	2022-02-10 13:59:42 -08:00
Patrick Cloke	df36945ff0	Support pagination tokens from /sync and /messages in the relations API. (#11952)	2022-02-10 10:52:48 -05:00
Denis Kasak	337f38cac3	Implement a content type allow list for URL previews (#11936) ... This implements an allow list for content types for which Synapse will attempt URL preview. If a URL resolves to a resource with a content type which isn't in the list, the download will terminate immediately. This makes sense given that Synapse would never successfully generate a URL preview for such files in the first place, and helps prevent issues with streaming media servers, such as #8302. Signed-off-by: Denis Kasak dkasak@termina.org.uk	2022-02-10 15:43:01 +00:00
Alexander Mnich	06e5a76322	Fix broken link in README to admin API. (#11955) ... From when the documentation was converted from rst -> md.	2022-02-10 14:18:27 +00:00
Patrick Cloke	e4fdf459e2	Basic documentation for the release cycle. (#11954)	2022-02-10 13:15:10 +00:00
Brad Jones	3914576b2b	Fix example for structured logging. (#11946) ... The StreamHandler takes a stream parameter, not location.	2022-02-09 20:56:33 +00:00
Patrick Cloke	0408d694ee	Update changelog from #11867 to be a single line.	2022-02-09 11:32:20 -05:00
Patrick Cloke	d0e78af35e	Add missing type hints to synapse.replication. (#11938)	2022-02-08 11:03:08 -05:00
Patrick Cloke	8c94b3abe9	Experimental support to include bundled aggregations in search results (MSC3666) (#11837)	2022-02-08 09:21:20 -05:00
Patrick Cloke	6c0984e3f0	Remove unnecessary ignores due to Twisted upgrade. (#11939) ... Twisted 22.1.0 fixed some internal type hints, allowing Synapse to remove ignore calls for parameters to connectTCP.	2022-02-08 09:15:59 -05:00
Patrick Cloke	63d90f10ec	Add missing type hints to synapse.replication.http. (#11856)	2022-02-08 07:44:39 -05:00
Patrick Cloke	8b309adb43	Fetch edits for multiple events in a single query. (#11660) ... This should reduce database usage when fetching bundled aggregations as the number of individual queries (and round trips to the database) are reduced.	2022-02-08 07:43:30 -05:00
Patrick Cloke	380c3d40f4	Return JSON errors for unknown resources under /matrix/client. (#11930) ... Re-applies the changes from 3e0cfd447e (#11602), reverting d93ec0a0ba (#11764) now that the conflict with the webclient listener was fixed in 119edf51eb (#11895).	2022-02-08 07:06:25 -05:00
Andrew Morgan	3655585e85	Add a docstring to add_device_change_to_streams and fix some nearby types (#11912)	2022-02-08 10:52:22 +00:00
Brendan Abolivier	0640f8ebaa	Add a callback to allow modules to deny 3PID (#11854) ... Part of the Tchap Synapse mainlining. This allows modules to implement extra logic to figure out whether a given 3PID can be added to the local homeserver. In the Tchap use case, this will allow a Synapse module to interface with the custom endpoint /internal_info.	2022-02-08 11:20:32 +01:00
Eric Eastwood	fef2e792be	Fix historical messages backfilling in random order on remote homeservers (MSC2716) (#11114) ... Fix https://github.com/matrix-org/synapse/issues/11091 Fix https://github.com/matrix-org/synapse/issues/10764 (side-stepping the issue because we no longer have to deal with `fake_prev_event_id`) 1. Made the `/backfill` response return messages in `(depth, stream_ordering)` order (previously only sorted by `depth`) - Technically, it shouldn't really matter how `/backfill` returns things but I'm just trying to make the `stream_ordering` a little more consistent from the origin to the remote homeservers in order to get the order of messages from `/messages` consistent ([sorted by `(topological_ordering, stream_ordering)`](https://github.com/matrix-org/synapse/blob/develop/docs/development/room-dag-concepts.md#depth-and-stream-ordering)). - Even now that we return backfilled messages in order, it still doesn't guarantee the same `stream_ordering` (and more importantly the [`/messages` order](https://github.com/matrix-org/synapse/blob/develop/docs/development/room-dag-concepts.md#depth-and-stream-ordering)) on the other server. For example, if a room has a bunch of history imported and someone visits a permalink to a historical message back in time, their homeserver will skip over the historical messages in between and insert the permalink as the next message in the `stream_order` and totally throw off the sort. - This will be even more the case when we add the [MSC3030 jump to date API endpoint](https://github.com/matrix-org/matrix-doc/pull/3030) so the static archives can navigate and jump to a certain date. - We're solving this in the future by switching to [online topological ordering](https://github.com/matrix-org/gomatrixserverlib/issues/187) and [chunking](https://github.com/matrix-org/synapse/issues/3785) which by its nature will apply retroactively to fix any inconsistencies introduced by people permalinking 2. As we're navigating `prev_events` to return in `/backfill`, we order by `depth` first (newest -> oldest) and now also tie-break based on the `stream_ordering` (newest -> oldest). This is technically important because MSC2716 inserts a bunch of historical messages at the same `depth` so it's best to be prescriptive about which ones we should process first. In reality, I think the code already looped over the historical messages as expected because the database is already in order. 3. Making the historical state chain and historical event chain float on their own by having no `prev_events` instead of a fake `prev_event` which caused backfill to get clogged with an unresolvable event. Fixes https://github.com/matrix-org/synapse/issues/11091 and https://github.com/matrix-org/synapse/issues/10764 4. We no longer find connected insertion events by finding a potential `prev_event` connection to the current event we're iterating over. We now solely rely on marker events which when processed, add the insertion event as an extremity and the federating homeserver can ask about it when time calls. - Related discussion, https://github.com/matrix-org/synapse/pull/11114#discussion_r741514793 Before | After --- | ---  |  #### Why aren't we sorting topologically when receiving backfill events? > The main reason we're going to opt to not sort topologically when receiving backfill events is because it's probably best to do whatever is easiest to make it just work. People will probably have opinions once they look at [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) which could change whatever implementation anyway. > > As mentioned, ideally we would do this but code necessary to make the fake edges but it gets confusing and gives an impression of “just whyyyy” (feels icky). This problem also dissolves with online topological ordering. > > -- https://github.com/matrix-org/synapse/pull/11114#discussion_r741517138 See https://github.com/matrix-org/synapse/pull/11114#discussion_r739610091 for the technical difficulties	2022-02-07 15:54:13 -06:00
Andrew Morgan	cf06783d54	Remove optional state of ApplicationService.is_interested's store parameter (#11911)	2022-02-07 18:26:42 +00:00
Patrick Cloke	314ca4c86d	Pass the proper type when uploading files. (#11927) ... The Content-Length header should be treated as an int, not a string. This shouldn't have any user-facing change.	2022-02-07 10:06:52 -05:00
Andrew Morgan	e03dde259b	Clean up an indirect reference to the homeserver datastore (#11914)	2022-02-07 13:25:09 +00:00
Andrew Morgan	0c4878caf2	Add a unit test for users receiving their own device list updates (#11909)	2022-02-07 13:21:19 +00:00
Dirk Klimpel	65ef21b1c7	Clarify that users' media are also preview images (#11862)	2022-02-04 14:39:14 +00:00
kegsay	a3865ed525	Run Complement tests sequentially (#11910) ... Since #11811 there has been general Complement flakiness around networking. It seems like tests are hitting the wrong containers. In an effort to diagnose the cause of this, as well as reduce its impact on this project, set the parallelsim to 1 (no parallelism) when running tests. If this fixes the flakiness then this indicates the cause and I can diagnose this further. If this doesn't fix the flakiness then that implies some kind of test pollution which also helps to diagnose this further.	2022-02-04 13:04:57 +00:00
Jonathan de Jong	02632b3504	Stabilise MSC3231 (Token Based Registration) (#11867)	2022-02-04 12:15:13 +00:00
Richard van der Hoff	b3d155a749	Delete MSC1711_certificates_FAQ.md (#11907) ... This document isn't really relevant any more, and its existence is more confusing than helpful.	2022-02-04 11:27:00 +00:00
Patrick Cloke	119edf51eb	Remove support for the webclient listener. (#11895) ... Also remove support for non-HTTP(S) web_client_location.	2022-02-03 18:36:49 +00:00