synapse

mirror of https://mau.dev/maunium/synapse.git synced 2024-11-16 15:01:23 +01:00

Author	SHA1	Message	Date
Jacek Kuśnierz	50f0e4028b	Allow dependency errors to pass through (#13113 ) Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-06-30 19:48:04 +02:00
Patrick Cloke	b0366853ca	Merge remote-tracking branch 'origin/release-v1.62' into develop	2022-06-30 13:27:24 -04:00
Shay	046a6513bc	Don't process /send requests for users who have hit their ratelimit (#13134 )	2022-06-30 09:22:40 -07:00
Shay	8330fc9953	Cleanup references to sample config in the docs and redirect users to configuration manual (#13077 )	2022-06-30 09:21:39 -07:00
Andrew Morgan	0ceb3af10b	Add a link to the configuration manual from the homeserver sample config documentation page (#13139 )	2022-06-30 15:59:11 +01:00
Erik Johnston	dbce28b2f1	Fix unread counts on large servers (#13140 )	2022-06-30 15:08:40 +01:00
Erik Johnston	a3a05c812d	Add index to help delete old push actions (#13141 )	2022-06-30 14:05:49 +00:00
Patrick Cloke	6ad012ef89	More type hints for `synapse.logging` (#13103 ) Completes type hints for synapse.logging.scopecontextmanager and (partially) for synapse.logging.opentracing.	2022-06-30 13:05:06 +00:00
reivilibre	9667bad55d	Improve startup times in Complement test runs against workers, particularly in CPU-constrained environments. (#13127 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-06-30 11:58:12 +00:00
David Robertson	09f6e43025	Actually typecheck `tests.test_server` (#13135 )	2022-06-30 10:45:47 +01:00
David Teller	80c7a06777	Rate limiting invites per issuer (#13125 ) Co-authored-by: reivilibre <oliverw@matrix.org>	2022-06-30 09:44:47 +00:00
Brendan Abolivier	4d3b8fb23f	Don't actually one-line the SQL statements we send to the DB (#13129 )	2022-06-30 10:43:24 +02:00
Šimon Brandner	13e359aec8	Implement MSC3827: Filtering of `/publicRooms` by room type (#13031 ) Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>	2022-06-29 17:12:45 +00:00
Moritz Stückler	e714b8a057	Fix documentation header for `allow_public_rooms_over_federation` (#13116 ) Signed-off-by: Moritz Stückler <moritz.stueckler@gmail.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-06-29 18:41:39 +02:00
Erik Johnston	92a0c18ef0	Improve performance of getting unread counts in rooms (#13119 )	2022-06-29 10:32:38 +00:00
jejo86	cdc0259449	Document the `--report-stats` argument (#13029 ) Signed-off-by: jejo86 <28619134+jejo86@users.noreply.github.com>	2022-06-29 10:24:10 +01:00
Andrew Morgan	b210146fd9	1.62.0rc1	2022-06-28 16:42:44 +01:00
Erik Johnston	7469824d58	Fix serialization errors when rotating notifications (#13118 )	2022-06-28 13:13:44 +01:00
David Robertson	f1145563f6	Extra type annotations in `test_server` (#13124 )	2022-06-28 12:12:17 +00:00
santhoshivan23	6b99a66fe0	Remove unspecced DELETE endpoint that modifies room visibility (#13123 )	2022-06-28 11:22:59 +00:00
Šimon Brandner	1017f09c18	Update MSC3786 implementation: Check the `state_key` (#12939 ) Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>	2022-06-27 20:28:34 +01:00
Robert Long	9b683ea80f	Add Cross-Origin-Resource-Policy header to thumbnail and download media endpoints (#12944 )	2022-06-27 14:44:05 +01:00
reivilibre	3c5549e74a	Refactor the Dockerfile-workers configuration script to use Jinja2 templates in Synapse workers' Supervisord blocks. (#13054 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-06-27 11:43:20 +01:00
Aaron Raimist	3ceaf1462d	Remove docs for Delete Group Admin API (#13112 ) This API no longer exists. Signed-off-by: Aaron Raimist <aaron@raim.ist>	2022-06-27 11:15:25 +01:00
santhoshivan23	d54909956e	validate room alias before interacting with the room directory (#13106 )	2022-06-22 15:32:18 +01:00
David Robertson	f33356e8f8	Use caret (semver bounds) for matrix.org packages (#13082 )	2022-06-17 19:07:04 +01:00
Shay	3d94d07db3	Update opentracing docs to reference the configuration manual rather than the configuation file. (#13076 )	2022-06-17 10:47:38 -07:00
Richard van der Hoff	d4b1c0d800	Fix inconsistencies in event validation (#13088 )	2022-06-17 16:30:59 +01:00
Richard van der Hoff	e16ea87d0f	Fix inconsistencies in event validation for `m.room.create` events (#13087 ) * Extend the auth rule checks for `m.room.create` events ... and move them up to the top of the function. Since the no auth_events are allowed for m.room.create events, we may as well get the m.room.create event checks out of the way first. * Add a test for create events with prev_events	2022-06-17 13:56:46 +00:00
Patrick Cloke	d3d84685ce	Add type hints to event push actions tests. (#13099 )	2022-06-17 12:38:13 +00:00
reivilibre	b26cbe3d45	Fix type error that made its way onto develop (#13098 ) * Fix type error introduced accidentally by #13045 * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>	2022-06-17 13:05:27 +01:00
Richard van der Hoff	5d6f55959e	Update info on downstream debs (#13095 )	2022-06-17 12:47:22 +01:00
Quentin Gliech	73af10f419	Simplify the alias deletion logic as an application service. (#13093 )	2022-06-17 12:19:22 +01:00
Erik Johnston	5ef05c70c3	Rotate notifications more frequently (#13096 )	2022-06-17 10:58:00 +00:00
Erik Johnston	5099b5ecc7	Use new `device_list_changes_in_room` table when getting device list changes (#13045 )	2022-06-17 11:42:03 +01:00
Quentin Gliech	c6d6176411	Allow MSC3030 'timestamp_to_event' calls from anyone on world-readable rooms. (#13062 ) Signed-off-by: Quentin Gliech <quenting@element.io>	2022-06-17 11:39:26 +01:00
Sean Quah	9372f6f842	Fix logging context misuse when we fail to persist a federation event (#13089 ) When we fail to persist a federation event, we kick off a task to remove its push actions in the background, using the current logging context. Since we don't `await` that task, we may finish our logging context before the task finishes. There's no reason to not `await` the task, so let's do that. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-06-17 10:22:50 +01:00
Erik Johnston	8ceed5e6b5	Add desc to `get_earliest_token_for_stats` (#13085 )	2022-06-16 17:50:46 +00:00
reivilibre	90cadcd403	Add a Subject Alternative Name to the certificate generated for Complement tests. (#13071 )	2022-06-16 12:43:21 +01:00
Patrick Cloke	0fcc0ae37c	Improve URL previews for sites with only Twitter card information. (#13056 ) Pull out `twitter:` meta tags when generating a preview and use it to augment any `og:` meta tags. Prefers Open Graph information over Twitter card information.	2022-06-16 07:41:57 -04:00
reivilibre	7552615247	Reduce the duplication of code that invokes the rate limiter. (#13070 )	2022-06-16 12:40:29 +01:00
Richard van der Hoff	1e0044e8f9	Complement: use SQLite by default (#13075 ) If no database is configured explicitly, use sqlite. This means that you don't have to pass any variables into the image.	2022-06-16 12:12:26 +01:00
Jacek Kuśnierz	0ef1307619	Add custom well-known (#13035 ) Co-authored-by: David Robertson <david.m.robertson1@gmail.com>	2022-06-16 11:48:18 +01:00
reivilibre	ffe2464836	Add instructions for running Complement with `gotestfmt`-formatted output locally. (#13073 )	2022-06-16 09:31:10 +00:00
Richard van der Hoff	8ecf6be1e1	Move some event auth checks out to a different method (#13065 ) * Add auth events to events used in tests * Move some event auth checks out to a different method Some of the event auth checks apply to an event's auth_events, rather than the state at the event - which means they can play no part in state resolution. Move them out to a separate method. * Rename check_auth_rules_for_event Now it only checks the state-dependent auth rules, it needs a better name.	2022-06-15 19:48:22 +01:00
Shay	cba1c5cbc2	Add headers to individual options in config documentation to allow for linking. (#13055 )	2022-06-15 11:31:46 -07:00
Sean Quah	99d3931974	Add more tests for room upgrades (#13074 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-06-15 18:58:23 +01:00
Erik Johnston	c95b04bb0e	Change default `sync_response_cache_duration` (#13042 )	2022-06-15 16:55:20 +00:00
Hannes Lerchl	7d99414edf	Replace pyjwt with authlib in `org.matrix.login.jwt` (#13011 )	2022-06-15 16:45:16 +00:00
reivilibre	e12ff697a4	Sort failing jobs in Complement CI to the top of the logs to make them easier to read. (#13057 )	2022-06-15 16:13:36 +00:00
Erik Johnston	de334ac183	Add a CI job to check that schema deltas are in the correct folder. (#13063 )	2022-06-15 16:27:18 +01:00
David Robertson	97e9fbe1b2	Type annotations in `synapse.databases.main.devices` (#13025 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-06-15 15:20:04 +00:00
Erik Johnston	0d1d3e0708	Speed up `get_unread_event_push_actions_by_room` (#13005 ) Fixes #11887 hopefully. The core change here is that `event_push_summary` now holds a summary of counts up until a much more recent point, meaning that the range of rows we need to count in `event_push_actions` is much smaller. This needs two major changes: 1. When we get a receipt we need to recalculate `event_push_summary` rather than just delete it 2. The logic for deleting `event_push_actions` is now divorced from calculating `event_push_summary`. In future it would be good to calculate `event_push_summary` while we persist a new event (it should just be a case of adding one to the relevant rows in `event_push_summary`), as that will further simplify the get counts logic and remove the need for us to periodically update `event_push_summary` in a background job.	2022-06-15 15:17:14 +00:00
Erik Johnston	9ad2197fa7	Rename complement-developonly (#13046 )	2022-06-15 15:11:42 +00:00
reivilibre	212be2edc1	Use updated `update_user_directory_from_worker` options in Complement tests. (#13069 )	2022-06-15 15:54:32 +01:00
reivilibre	538044ac01	Collapse Docker build commands in Complement CI runs to make the logs easier to read. (#13058 )	2022-06-15 14:42:27 +00:00
David Robertson	941dc3db13	Track a histogram of state res durations (#13036 )	2022-06-15 15:19:49 +01:00
reivilibre	0dbdc39940	Fix a long-standing bug which meant that rate limiting was not restrictive enough in some cases. (#13018 )	2022-06-15 14:11:55 +00:00
Brendan Abolivier	417f4cf40b	Don't use keyword arguments when initialising modules (#13060 )	2022-06-15 15:36:16 +02:00
Richard van der Hoff	75fb10ee45	Clean up schema for `event_edges` (#12893 ) * Remove redundant references to `event_edges.room_id` We don't need to care about the room_id here, because we are already checking the event id. * Clean up the event_edges table We make a number of changes to `event_edges`: * We give the `room_id` and `is_state` columns defaults (null and false respectively) so that we can stop populating them. * We drop any rows that have `is_state` set true - they should no longer exist. * We drop any rows that do not exist in `events` - these should not exist either. * We drop the old unique constraint on all the colums, which wasn't much use. * We create a new unique index on `(event_id, prev_event_id)`. * We add a foreign key constraint to `events`. These happen rather differently depending on whether we are on Postgres or SQLite. For SQLite, we just rebuild the whole table, copying only the rows we want to keep. For Postgres, we try to do things in the background as much as possible. * Stop populating `event_edges.room_id` and `is_state` We can just rely on the defaults.	2022-06-15 12:29:42 +01:00
David Robertson	a4ae1406d1	Fix typechecks against twisted trunk (#13061 )	2022-06-15 11:49:58 +01:00
reivilibre	5b645ae2ad	Refactor entry points so that they all have a `main` function. (#13052 )	2022-06-14 17:41:06 +00:00
David Robertson	c99b511db9	Fix `destination_is` errors seen in sentry. (#13041 ) * Rename test_fedclient to match its source file * Require at least one destination to be truthy * Explicitly validate user ID in profile endpoint GETs Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-06-14 18:28:26 +01:00
Erik Johnston	aef398457f	Up complement time outs (#13048 )	2022-06-14 17:59:06 +01:00
Brendan Abolivier	bdb6628dcf	Fix version number in spam checker callbacks doc (#13047 )	2022-06-14 17:24:25 +02:00
Shay	493c2fc44a	Remove code generating comments in configuration file (#12941 )	2022-06-14 07:53:42 -07:00
Patrick Cloke	5f4ecf759d	Rename delta to apply in the proper schema version. (#13050 )	2022-06-14 14:34:04 +00:00
Quentin Gliech	fe1daad672	Move the "email unsubscribe" resource, refactor the macaroon generator & simplify the access token verification logic. (#12986 ) This simplifies the access token verification logic by removing the `rights` parameter which was only ever used for the unsubscribe link in email notifications. The latter has been moved under the `/_synapse` namespace, since it is not a standard API. This also makes the email verification link more secure, by embedding the app_id and pushkey in the macaroon and verifying it. This prevents the user from tampering the query parameters of that unsubscribe link. Macaroon generation is refactored: - Centralised all macaroon generation and verification logic to the `MacaroonGenerator` - Moved to `synapse.utils` - Changed the constructor to require only a `Clock`, hostname, and a secret key (instead of a full `Homeserver`). - Added tests for all methods.	2022-06-14 09:12:08 -04:00
reivilibre	09a3c5ce0b	Fix Complement runs always being Postgres (#13034 ) * Fix Complement runs always being Postgres * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>	2022-06-14 13:13:35 +01:00
Sami Olmari	a542a92c57	Mention removed community/group worker endpoints in upgrade.md (#13023 )	2022-06-14 11:35:22 +01:00
Quentin Gliech	92103cb2c8	Decouple `synapse.api.auth_blocking.AuthBlocking` from `synapse.api.auth.Auth`. (#13021 )	2022-06-14 09:51:15 +01:00
David Teller	a164a46038	Uniformize spam-checker API, part 4: port other spam-checker callbacks to return `Union[Allow, Codes]`. (#12857 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-06-13 18:16:16 +00:00
Patrick Cloke	53b77b203a	Replace noop background updates with DELETE. (#12954 ) Removes the `register_noop_background_update` and deletes the background updates directly in a delta file.	2022-06-13 14:06:27 -04:00
Richard van der Hoff	f68b5e5773	Merge branch 'rav/simplify_event_auth_interface' into develop	2022-06-13 11:34:59 +01:00
Richard van der Hoff	a6173a16fe	changelog	2022-06-12 23:13:10 +01:00
David Robertson	cfff055fa2	Revert "Changelog" This reverts commit `ae09cc2ee4`. This commit was intended for a different branch.	2022-06-10 19:33:21 +01:00
David Robertson	ae09cc2ee4	Changelog	2022-06-10 19:32:40 +01:00
David Robertson	4579445cc5	Add missing TOC link to poetry cheat sheet (#13022 ) Missed by #12475.	2022-06-10 15:47:49 +01:00
Patrick Cloke	84cd0fe4e2	Fix-up the contrib/graph scripts. (#13013 ) * Clarifies comments and documentation. * Adds type-hints. * Fixes Python 3 compatibility (and runs pyupgrade). * Updates for changes in Synapse internals.	2022-06-10 08:30:14 -04:00
Patrick Cloke	81608490e3	Stop depending on `room_id` to be returned for children state in the hierarchy response. (#12991 ) The `room_id` field was removed from MSC2946 before it was accepted. It was initially kept for backwards compatibility and should be removed now that the stable form of the API is used. This change only stops Synapse from validating that it is returned, a future PR will remove returning it as part of the response.	2022-06-10 07:15:51 -04:00
reivilibre	3d1d510fa9	Enable testing against PostgreSQL databases in Complement CI. (#12965 )	2022-06-09 14:16:34 +01:00
Patrick Cloke	1df22e16df	Fix example of running complement.sh. (#12990 )	2022-06-09 07:21:15 -04:00
Richard van der Hoff	7c6b2204d1	Faster joins: add issue links to the TODOs (#13004 ) ... to help us keep track of these things	2022-06-09 10:13:03 +00:00
David Robertson	97053c9406	Type annotations for `test_v2` (#12985 )	2022-06-09 09:48:04 +01:00
Nick Mills-Barrett	04ca3a52f6	Use READ COMMITTED isolation level when inserting read receipts (#12957 )	2022-06-09 09:44:16 +01:00
Patrick Cloke	dd2d66b0c9	Move the (unstable) `dir` parameter for /relations behind an experimental flag. (#12984 ) MSC3715 defines this parameter, but the unstable version of it should be behind an experimental flag.	2022-06-08 09:00:35 -04:00
reivilibre	3c8f1290b8	Use a GitHub form for issues rather than a hard-to-read, easy-to-ignore template. (#12982 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-06-08 11:11:02 +00:00
reivilibre	67f51c84f8	Merge the Complement testing Docker images into a single, multi-purpose image. (#12881 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-06-08 09:57:05 +00:00
James	c316fe8d4a	Docker Compose Worker Documentation and Examples (#12737 )	2022-06-08 10:26:42 +01:00
Sean Quah	3c1c40d843	Clean up the test code for client disconnections (#12929 ) * Reword failure message about `await_result=False` * Use `reactor.advance()` instead of `reactor.pump()` * Raise `AssertionError`s ourselves * Un-instance method `_test_disconnect` * Replace `ThreadedMemoryReactorClock` with `MemoryReactorClock`	2022-06-07 18:17:32 +01:00
David Robertson	586bfc6dc0	Use dummy fallback engines if imports fail (#12979 )	2022-06-07 17:33:55 +01:00
Sean Quah	a10cc5f824	Test cancellation at every `await` during request handling (#12674 ) * Add tests for `/rooms/<room_id>/members` cancellation. * Add tests for `/rooms/<room_id>/state` cancellation. Signed-off-by: Sean Quah <seanq@element.io>	2022-06-07 17:14:47 +01:00
Olivier Wilkinson (reivilibre)	00d915b2a7	Merge branch 'master' into develop	2022-06-07 16:59:41 +01:00
Daniel Aloni	b5a3aecf18	Return the same error message from `/login` when password is incorrect and when account doesn't exist. (#12738 )	2022-06-07 14:58:48 +00:00
David Robertson	f30bcbd84a	Fix Synapse git info missing in version strings (#12973 )	2022-06-07 15:24:11 +01:00
Erik Johnston	a7e506ddee	Reduce amount of state we pull out when attempting to send catchup PDUs. (#12963 ) * Don't pull out state for catchup * Newsfile * Merge newsfile	2022-06-07 14:35:56 +01:00
Olivier Wilkinson (reivilibre)	495fbf5d63	1.61.0rc1	2022-06-07 13:18:02 +01:00
Patrick Cloke	d2fd7f7b5c	Fix a stale comment in get_room_version_id_txn. (#12969 )	2022-06-07 07:44:31 -04:00
Patrick Cloke	9dc3293e0b	Consolidate the logic of delete_device/delete_devices. (#12970 ) By always using delete_devices and sometimes passing a list with a single device ID. Previously these methods had gotten out of sync with each other and it seems there's little benefit to the single-device variant.	2022-06-07 07:43:35 -04:00
Andrew Morgan	c51f5b9592	Prevent breaking old sqlite's when media retention is enabled (#12977 )	2022-06-07 11:28:08 +00:00
Andrew Morgan	a47636c570	Prevent local quarantined media from being claimed by media retention (#12972 )	2022-06-07 10:53:47 +00:00
Patrick Cloke	f7baffd8ec	Remove remaining pieces of groups code. (#12966 ) * Remove an unused stream ID generator. * Remove the now unused remote profile cache.	2022-06-06 13:20:05 -04:00
Erik Johnston	44de53bb79	Reduce state pulled from DB due to sending typing and receipts over federation (#12964 ) Reducing the amount of state we pull from the DB is useful as fetching state is expensive in terms of DB, CPU and memory.	2022-06-06 16:46:11 +01:00
Patrick Cloke	148fe58a24	Do not break URL previews if an image is unreachable. (#12950 ) Avoid breaking a URL preview completely if the chosen image 404s or is unreachable for some other reason (e.g. DNS).	2022-06-06 07:46:04 -04:00
Patrick Cloke	1acc897c31	Implement MSC3816, consider the root event for thread participation. (#12766 ) As opposed to only considering a user to have "participated" if they replied to the thread.	2022-06-06 07:18:04 -04:00
Jan Christian Grünhage	fcd8703508	Allow updating passwords using the admin api without logging out devices (#12952 )	2022-06-06 12:10:13 +01:00
Erik Johnston	e3163e2e11	Reduce the amount of state we pull from the DB (#12811 )	2022-06-06 09:24:12 +01:00
Patrick Cloke	6b46c3eb3d	Remove groups code from synapse_port_db. (#12899 )	2022-06-03 12:13:35 -04:00
Patrick Cloke	01df5bacac	Improve URL previews for some pages (#12951 ) * Skip `og` and `meta` tags where the value is empty. * Fallback to the favicon if there are no other images. * Ignore tags meant for navigation.	2022-06-03 12:09:12 -04:00
Erik Johnston	888a29f412	Wait for lazy join to complete when getting current state (#12872 )	2022-06-01 16:02:53 +01:00
Michael Telatynski	782cb7420a	Fix complement tests using the wrong path (#12933 )	2022-06-01 15:57:09 +01:00
Patrick Cloke	7bc08f3201	Remove remaining bits of groups code. (#12936 ) * Update worker docs to remove group endpoints. * Removes an unused parameter to `ApplicationService`. * Break dependency between media repo and groups. * Avoid copying `m.room.related_groups` state events during room upgrades.	2022-06-01 09:41:25 -04:00
Jacek Kuśnierz	88193f2125	Remove direct refeferences to PyNaCl (use signedjson instead). (#12902 )	2022-06-01 07:32:35 -04:00
Richard van der Hoff	79dadf7216	Fix 404 on `/sync` when the last event is a redaction of an unknown/purged event (#12905 ) Currently, we try to pull the event corresponding to a sync token from the database. However, when we fetch redaction events, we check the target of that redaction (because we aren't allowed to send redactions to clients without validating them). So, if the sync token points to a redaction of an event that we don't have, we have a problem. It turns out we don't really need that event, and can just work with its ID and metadata, which sidesteps the whole problem.	2022-06-01 11:29:51 +00:00
Erik Johnston	5949ab86f8	Fix potential thumbnail memory leaks. (#12932 )	2022-06-01 10:57:49 +00:00
Patrick Cloke	2e8763ec96	Remove most groups datastore code. (#12895 ) The remaining piece is a background update that is needed for backwards compatibility.	2022-05-31 20:28:17 -04:00
Richard van der Hoff	f0aec0abef	Improve logging when signature checks fail (#12925 ) * Raise a dedicated `InvalidEventSignatureError` from `_check_sigs_on_pdu` * Downgrade logging about redactions to DEBUG this can be very spammy during a room join, and it's not very useful. * Raise `InvalidEventSignatureError` from `_check_sigs_and_hash` ... and, more importantly, move the logging out to the callers. * changelog	2022-05-31 23:32:56 +01:00
Patrick Cloke	cf05258f76	Remove groups replication code. (#12900 ) The replication logic for groups is no longer used, so the message passing infrastructure can be removed.	2022-05-31 13:04:08 -04:00
Andrew Morgan	2fc787c341	Add config options for media retention (#12732 )	2022-05-31 16:35:29 +00:00
Sean Quah	641908f72f	Faster room joins: Resume state re-syncing after a Synapse restart (#12813 ) Signed-off-by: Sean Quah <seanq@matrix.org>	2022-05-31 15:15:08 +00:00
Sean Quah	2fba1076c5	Faster room joins: Try other destinations when resyncing the state of a partial-state room (#12812 ) Signed-off-by: Sean Quah <seanq@matrix.org>	2022-05-31 15:50:29 +01:00
reivilibre	bf01e51554	Test Synapse against Complement with workers. (#12810 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-05-31 13:02:00 +00:00
Erik Johnston	c8684e6792	Reduce DB load of /sync when using presence (#12885 ) While the query was fast, we were calling it a lot.	2022-05-31 13:01:05 +00:00
Richard van der Hoff	5e17922ef7	Stop reading from `event_edges.room_id`. (#12914 ) event_edges.room_id is implied by the event id, so there is no need to join on the room id.	2022-05-31 13:51:49 +01:00
Erik Johnston	1e453053cb	Rename storage classes (#12913 )	2022-05-31 12:17:50 +00:00
Patrick Cloke	e541bb9eed	Rework stream token to stop caring about groups. (#12897 )	2022-05-31 07:42:50 -04:00
Travis Ralston	d0e40dfe29	Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12923 )	2022-05-31 08:42:18 +01:00
Travis Ralston	bcfdfeb65d	Revert "Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12922 )" This reverts commit `e0fae823e9`.	2022-05-30 20:29:40 -06:00
Travis Ralston	e0fae823e9	Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12922 ) `M_` is a reserved namespace.	2022-05-31 02:27:19 +00:00
Jacek Kuśnierz	c4f548e05d	Don't return `end` from `/messages` if there are no more events (#12903 ) Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de>	2022-05-30 21:03:52 +01:00
Brendan Abolivier	cd9fc058de	Document the Synapse version of a new module API method (#12917 )	2022-05-30 18:37:52 +02:00
David Teller	af7db19e1e	Uniformize spam-checker API, part 3: Expand check_event_for_spam with the ability to return additional fields (#12846 ) Signed-off-by: David Teller <davidt@element.io>	2022-05-30 18:24:56 +02:00
Mathieu Velten	1fd1856afc	demo: check if we are in a virtualenv before overriding PYTHONPATH (#12916 )	2022-05-30 15:41:24 +00:00
Mathieu Velten	7f92ac4c1c	Add a migration step to cleanup potential leftovers of bug 11833 (#12784 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-05-30 16:51:37 +02:00
DeepBlueV7.X	b10211871f	Fix invite notifications for users without pushers (#12840 ) Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>	2022-05-30 13:14:43 +02:00
Richard van der Hoff	2480461879	Fix `get_metadata_for_events` (#12904 ) This method was introduced in #12852. It is using the `state_key` column from the `events` table, which is not (yet) reliable (see #11496).	2022-05-30 10:51:09 +01:00
David Robertson	119938792b	Remove unused `contrib/experiments/cursesio.py` (#12910 )	2022-05-30 10:47:54 +01:00
David Robertson	80bd614dac	Remove `contrib/experiments/test_messaging.py` (#12911 )	2022-05-30 10:47:47 +01:00
David Robertson	563ef172ae	Remove contrib/jitsimeetbridge (#12909 )	2022-05-30 10:47:40 +01:00
David Robertson	72df42078b	Remove contrib/scripts/kick_users.py (#12908 )	2022-05-30 10:47:25 +01:00
David Robertson	796a0312e1	Bump jsonschema stubs (#12912 )	2022-05-30 10:47:09 +01:00
Jonathan de Jong	6be4953b99	Mutual rooms: Remove dependency on user directory (#12836 )	2022-05-30 10:05:31 +01:00
Sumner Evans	bda4600399	LockStore: fix acquiring a lock via `LockStore.try_acquire_lock` (#12832 ) Signed-off-by: Sumner Evans <sumner@beeper.com>	2022-05-30 09:41:13 +01:00
Brendan Abolivier	28989cb301	Add a background job to automatically delete stale devices (#12855 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-05-27 17:47:32 +02:00
David Teller	888eb736a1	Add code M_USER_ACCOUNT_SUSPENDED, as per MSC3823. (#12845 ) Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-05-27 13:13:29 +00:00
Patrick Cloke	724e11d620	Clean-up some receipts code (#12888 ) * Properly marks private methods as private. * Adds missing docstrings. * Rework inline methods.	2022-05-27 07:44:10 -04:00
Patrick Cloke	c52abc1cfd	Additional constants for EDU types. (#12884 ) Instead of hard-coding strings in many places.	2022-05-27 07:14:36 -04:00
Patrick Cloke	d9f092285b	Remove federation client code for groups. (#12563 )	2022-05-27 07:13:58 -04:00
Matt C	a7da00d4f7	Add storage and module API methods to get monthly active users and their appservices (#12838 )	2022-05-27 10:25:57 +00:00
David Robertson	3503f42741	Easy type hints in synapse.logging.opentracing (#12894 )	2022-05-27 11:17:33 +01:00
Richard van der Hoff	f1605b7447	Fix room deletion (#12889 ) * Fix room deletion `ae7858f` broke room deletion by attempting to delete the entry from `rooms` before the tables that reference it. * faster_joins: remove database rows on purge	2022-05-27 10:31:08 +01:00
Richard van der Hoff	bc1beebc27	Refactor have_seen_events to reduce OOMs (#12886 ) My server is currently OOMing in the middle of have_seen_events, so let's try to fix that.	2022-05-27 10:27:33 +01:00
Patrick Cloke	49f06866e4	Remove backing code for groups/communities (#12558 ) Including handlers, configuration code, appservice support, and the GroupID construct.	2022-05-26 09:04:34 -04:00
dependabot[bot]	1cba285a79	Bump pyjwt from 2.3.0 to 2.4.0 (#12865 ) Bumps [pyjwt](https://github.com/jpadilla/pyjwt) from 2.3.0 to 2.4.0. - [Release notes](https://github.com/jpadilla/pyjwt/releases) - [Changelog](https://github.com/jpadilla/pyjwt/blob/master/CHANGELOG.rst) - [Commits](https://github.com/jpadilla/pyjwt/compare/2.3.0...2.4.0) --- updated-dependencies: - dependency-name: pyjwt dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>	2022-05-26 12:42:21 +00:00
reivilibre	e768644368	Fix ambiguous column name that would prevent use of MSC2716 History Import when using Postgres as a database. (#12843 )	2022-05-26 11:19:01 +00:00
Patrick Cloke	1885ee0113	Remove unstable APIs for /hierarchy. (#12851 ) Removes the unstable endpoint as well as a duplicated field which was modified during stabilization.	2022-05-26 07:10:28 -04:00
Patrick Cloke	b5707ceaba	Avoid attempting to delete push actions for remote users. (#12879 ) Remote users will never have push actions, so we can avoid a database round-trip/transaction completely.	2022-05-26 07:09:16 -04:00
Erik Johnston	b83bc5fab5	Pull out less state when handling gaps mk2 (#12852 )	2022-05-26 09:48:12 +00:00
Richard van der Hoff	1b338476af	Allow bigger responses to `/federation/v1/state` (#12877 ) * Refactor HTTP response size limits Rather than passing a separate `max_response_size` down the stack, make it an attribute of the `parser`. * Allow bigger responses on `federation/v1/state` `/state` can return huge responses, so we need to handle that.	2022-05-25 22:24:28 +01:00
Erik Johnston	4660d9fdcf	Fix up `state_store` naming (#12871 )	2022-05-25 12:59:04 +01:00
Patrick Cloke	a8db8c6eba	Remove user-visible groups/communities code (#12553 ) Makes it so that groups/communities no longer exist from a user-POV. E.g. we remove: * All API endpoints (including Client-Server, Server-Server, and admin). * Documented configuration options (and the experimental flag, which is now unused). * Special handling during room upgrades. * The `groups` section of the `/sync` response.	2022-05-25 07:53:40 -04:00
Patrick Cloke	759f9c09e1	Fix caching behavior for relations push rules. (#12859 ) By always returning all requested values from the function wrapped by cachedList. Otherwise implicit None values get added into the cache, which are unexpected.	2022-05-25 07:49:54 -04:00
Patrick Cloke	4cbcd4a999	Misc clean-up of push rules datastore (#12856 )	2022-05-25 07:49:12 -04:00
David Robertson	6aeee9a19d	Correct typo in changelog for #12858 .	2022-05-25 11:19:22 +01:00
Nick Mills-Barrett	1f9013ce60	Add the `batch_send` endpoint to generic workers (#12868 )	2022-05-25 09:51:07 +00:00
Nick Mills-Barrett	33e2916858	Don't create empty AS txns when the AS is down (#12869 )	2022-05-25 09:46:05 +00:00
Nick Mills-Barrett	2e5f88b5e6	Add the `/account/whoami` endpoint to generic workers (#12866 )	2022-05-25 10:41:41 +01:00
Nick Mills-Barrett	b4fab0b14f	Fix incorrect worker-allowed path in documentation (#12867 )	2022-05-25 09:20:34 +00:00
Carl Bordum Hansen	774ac4930d	Make sure `prev_ids` defaults to empty list (#12829 ) Signed-off-by: Carl Bordum Hansen <carl@bordum.dk>	2022-05-25 09:14:45 +00:00
Dirk Klimpel	298911555c	Fix typos in documentation (#12863 )	2022-05-25 10:14:03 +01:00
David Robertson	e7c77a8750	Correct annotation of `_iterate_over_text` (#12860 )	2022-05-24 18:17:21 +00:00
David Robertson	81d9f2a8e9	Fixes to MSC3787 implementation (#12858 )	2022-05-24 16:50:50 +00:00
Šimon Brandner	042e47970b	Remove `dont_notify` from the `.m.rule.room.server_acl` rule (#12849 ) Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>	2022-05-24 17:42:32 +01:00
Will Hunt	6855024e0a	Add authentication to thirdparty bridge APIs (#12746 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-05-24 16:39:54 +02:00
Sean Quah	5d9f886aab	Synapse 1.60.0rc1 (2022-05-24) ============================== This release of Synapse adds a unique index to the `state_group_edges` table, in order to prevent accidentally introducing duplicate information (for example, because a database backup was restored multiple times). If your Synapse database already has duplicate rows in this table, this could fail with an error and require manual remediation. Additionally, the signature of the `check_event_for_spam` module callback has changed. The previous signature has been deprecated and remains working for now. Module authors should update their modules to use the new signature where possible. See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1600) for more details. Features -------- - Measure the time taken in spam-checking callbacks and expose those measurements as metrics. ([\#12513](https://github.com/matrix-org/synapse/issues/12513)) - Add a `default_power_level_content_override` config option to set default room power levels per room preset. ([\#12618](https://github.com/matrix-org/synapse/issues/12618)) - Add support for [MSC3787: Allowing knocks to restricted rooms](https://github.com/matrix-org/matrix-spec-proposals/pull/3787). ([\#12623](https://github.com/matrix-org/synapse/issues/12623)) - Send `USER_IP` commands on a different Redis channel, in order to reduce traffic to workers that do not process these commands. ([\#12672](https://github.com/matrix-org/synapse/issues/12672), [\#12809](https://github.com/matrix-org/synapse/issues/12809)) - Synapse will now reload [cache config](https://matrix-org.github.io/synapse/latest/usage/configuration/config_documentation.html#caching) when it receives a [SIGHUP](https://en.wikipedia.org/wiki/SIGHUP) signal. ([\#12673](https://github.com/matrix-org/synapse/issues/12673)) - Add a config options to allow for auto-tuning of caches. ([\#12701](https://github.com/matrix-org/synapse/issues/12701)) - Update [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716) implementation to process marker events from the current state to avoid markers being lost in timeline gaps for federated servers which would cause the imported history to be undiscovered. ([\#12718](https://github.com/matrix-org/synapse/issues/12718)) - Add a `drop_federated_event` callback to `SpamChecker` to disregard inbound federated events before they take up much processing power, in an emergency. ([\#12744](https://github.com/matrix-org/synapse/issues/12744)) - Implement [MSC3818: Copy room type on upgrade](https://github.com/matrix-org/matrix-spec-proposals/pull/3818). ([\#12786](https://github.com/matrix-org/synapse/issues/12786), [\#12792](https://github.com/matrix-org/synapse/issues/12792)) - Update to the `check_event_for_spam` module callback. Deprecate the current callback signature, replace it with a new signature that is both less ambiguous (replacing booleans with explicit allow/block) and more powerful (ability to return explicit error codes). ([\#12808](https://github.com/matrix-org/synapse/issues/12808)) Bugfixes -------- - Fix a bug introduced in Synapse 1.7.0 that would prevent events from being sent to clients if there's a retention policy in the room when the support for retention policies is disabled. ([\#12611](https://github.com/matrix-org/synapse/issues/12611)) - Fix a bug introduced in Synapse 1.57.0 where `/messages` would throw a 500 error when querying for a non-existent room. ([\#12683](https://github.com/matrix-org/synapse/issues/12683)) - Add a unique index to `state_group_edges` to prevent duplicates being accidentally introduced and the consequential impact to performance. ([\#12687](https://github.com/matrix-org/synapse/issues/12687)) - Fix a long-standing bug where an empty room would be created when a user with an insufficient power level tried to upgrade a room. ([\#12696](https://github.com/matrix-org/synapse/issues/12696)) - Fix a bug introduced in Synapse 1.30.0 where empty rooms could be automatically created if a monthly active users limit is set. ([\#12713](https://github.com/matrix-org/synapse/issues/12713)) - Fix push to dismiss notifications when read on another client. Contributed by @SpiritCroc @ Beeper. ([\#12721](https://github.com/matrix-org/synapse/issues/12721)) - Fix poor database performance when reading the cache invalidation stream for large servers with lots of workers. ([\#12747](https://github.com/matrix-org/synapse/issues/12747)) - Delete events from the `federation_inbound_events_staging` table when a room is purged through the admin API. ([\#12770](https://github.com/matrix-org/synapse/issues/12770)) - Give a meaningful error message when a client tries to create a room with an invalid alias localpart. ([\#12779](https://github.com/matrix-org/synapse/issues/12779)) - Fix a bug introduced in 1.43.0 where a file (`providers.json`) was never closed. Contributed by @arkamar. ([\#12794](https://github.com/matrix-org/synapse/issues/12794)) - Fix a long-standing bug where finished log contexts would be re-started when failing to contact remote homeservers. ([\#12803](https://github.com/matrix-org/synapse/issues/12803)) - Fix a bug, introduced in Synapse 1.21.0, that led to media thumbnails being unusable before the index has been added in the background. ([\#12823](https://github.com/matrix-org/synapse/issues/12823)) Updates to the Docker image --------------------------- - Fix the docker file after a dependency update. ([\#12853](https://github.com/matrix-org/synapse/issues/12853)) Improved Documentation ---------------------- - Fix a typo in the Media Admin API documentation. ([\#12715](https://github.com/matrix-org/synapse/issues/12715)) - Update the OpenID Connect example for Keycloak to be compatible with newer versions of Keycloak. Contributed by @nhh. ([\#12727](https://github.com/matrix-org/synapse/issues/12727)) - Fix typo in server listener documentation. ([\#12742](https://github.com/matrix-org/synapse/issues/12742)) - Link to the configuration manual from the welcome page of the documentation. ([\#12748](https://github.com/matrix-org/synapse/issues/12748)) - Fix typo in `run_background_tasks_on` option name in configuration manual documentation. ([\#12749](https://github.com/matrix-org/synapse/issues/12749)) - Add information regarding the `rc_invites` ratelimiting option to the configuration docs. ([\#12759](https://github.com/matrix-org/synapse/issues/12759)) - Add documentation for cancellation of request processing. ([\#12761](https://github.com/matrix-org/synapse/issues/12761)) - Recommend using docker to run tests against postgres. ([\#12765](https://github.com/matrix-org/synapse/issues/12765)) - Add missing user directory endpoint from the generic worker documentation. Contributed by @olmari. ([\#12773](https://github.com/matrix-org/synapse/issues/12773)) - Add additional info to documentation of config option `cache_autotuning`. ([\#12776](https://github.com/matrix-org/synapse/issues/12776)) - Update configuration manual documentation to document size-related suffixes. ([\#12777](https://github.com/matrix-org/synapse/issues/12777)) - Fix invalid YAML syntax in the example documentation for the `url_preview_accept_language` config option. ([\#12785](https://github.com/matrix-org/synapse/issues/12785)) Deprecations and Removals ------------------------- - Require a body in POST requests to `/rooms/{roomId}/receipt/{receiptType}/{eventId}`, as required by the [Matrix specification](https://spec.matrix.org/v1.2/client-server-api/#post_matrixclientv3roomsroomidreceiptreceipttypeeventid). This breaks compatibility with Element Android 1.2.0 and earlier: users of those clients will be unable to send read receipts. ([\#12709](https://github.com/matrix-org/synapse/issues/12709)) Internal Changes ---------------- - Improve event caching mechanism to avoid having multiple copies of an event in memory at a time. ([\#10533](https://github.com/matrix-org/synapse/issues/10533)) - Preparation for faster-room-join work: return subsets of room state which we already have, immediately. ([\#12498](https://github.com/matrix-org/synapse/issues/12498)) - Add `@cancellable` decorator, for use on endpoint methods that can be cancelled when clients disconnect. ([\#12586](https://github.com/matrix-org/synapse/issues/12586), [\#12588](https://github.com/matrix-org/synapse/issues/12588), [\#12630](https://github.com/matrix-org/synapse/issues/12630), [\#12694](https://github.com/matrix-org/synapse/issues/12694), [\#12698](https://github.com/matrix-org/synapse/issues/12698), [\#12699](https://github.com/matrix-org/synapse/issues/12699), [\#12700](https://github.com/matrix-org/synapse/issues/12700), [\#12705](https://github.com/matrix-org/synapse/issues/12705)) - Enable cancellation of `GET /rooms/$room_id/members`, `GET /rooms/$room_id/state` and `GET /rooms/$room_id/state/$event_type/` requests. ([\#12708](https://github.com/matrix-org/synapse/issues/12708)) - Improve documentation of the `synapse.push` module. ([\#12676](https://github.com/matrix-org/synapse/issues/12676)) - Refactor functions to on `PushRuleEvaluatorForEvent`. ([\#12677](https://github.com/matrix-org/synapse/issues/12677)) - Preparation for database schema simplifications: stop writing to `event_reference_hashes`. ([\#12679](https://github.com/matrix-org/synapse/issues/12679)) - Remove code which updates unused database column `application_services_state.last_txn`. ([\#12680](https://github.com/matrix-org/synapse/issues/12680)) - Refactor `EventContext` class. ([\#12689](https://github.com/matrix-org/synapse/issues/12689)) - Remove an unneeded class in the push code. ([\#12691](https://github.com/matrix-org/synapse/issues/12691)) - Consolidate parsing of relation information from events. ([\#12693](https://github.com/matrix-org/synapse/issues/12693)) - Convert namespace class `Codes` into a string enum. ([\#12703](https://github.com/matrix-org/synapse/issues/12703)) - Optimize private read receipt filtering. ([\#12711](https://github.com/matrix-org/synapse/issues/12711)) - Drop the logging level of status messages for the URL preview cache expiry job from INFO to DEBUG. ([\#12720](https://github.com/matrix-org/synapse/issues/12720)) - Downgrade some OIDC errors to warnings in the logs, to reduce the noise of Sentry reports. ([\#12723](https://github.com/matrix-org/synapse/issues/12723)) - Update configs used by Complement to allow more invites/3PID validations during tests. ([\#12731](https://github.com/matrix-org/synapse/issues/12731)) - Fix a long-standing bug where the user directory background process would fail to make forward progress if a user included a null codepoint in their display name or avatar. ([\#12762](https://github.com/matrix-org/synapse/issues/12762)) - Tweak the mypy plugin so that `@cached` can accept `on_invalidate=None`. ([\#12769](https://github.com/matrix-org/synapse/issues/12769)) - Move methods that call `add_push_rule` to the `PushRuleStore` class. ([\#12772](https://github.com/matrix-org/synapse/issues/12772)) - Make handling of federation Authorization header (more) compliant with RFC7230. ([\#12774](https://github.com/matrix-org/synapse/issues/12774)) - Refactor `resolve_state_groups_for_events` to not pull out full state when no state resolution happens. ([\#12775](https://github.com/matrix-org/synapse/issues/12775)) - Do not keep going if there are 5 back-to-back background update failures. ([\#12781](https://github.com/matrix-org/synapse/issues/12781)) - Fix federation when using the demo scripts. ([\#12783](https://github.com/matrix-org/synapse/issues/12783)) - The `hash_password` script now fails when it is called without specifying a config file. Contributed by @jae1911. ([\#12789](https://github.com/matrix-org/synapse/issues/12789)) - Improve and fix type hints. ([\#12567](https://github.com/matrix-org/synapse/issues/12567), [\#12477](https://github.com/matrix-org/synapse/issues/12477), [\#12717](https://github.com/matrix-org/synapse/issues/12717), [\#12753](https://github.com/matrix-org/synapse/issues/12753), [\#12695](https://github.com/matrix-org/synapse/issues/12695), [\#12734](https://github.com/matrix-org/synapse/issues/12734), [\#12716](https://github.com/matrix-org/synapse/issues/12716), [\#12726](https://github.com/matrix-org/synapse/issues/12726), [\#12790](https://github.com/matrix-org/synapse/issues/12790), [\#12833](https://github.com/matrix-org/synapse/issues/12833)) - Update EventContext `get_current_event_ids` and `get_prev_event_ids` to accept state filters and update calls where possible. ([\#12791](https://github.com/matrix-org/synapse/issues/12791)) - Remove Caddy from the Synapse workers image used in Complement. ([\#12818](https://github.com/matrix-org/synapse/issues/12818)) - Add Complement's shared registration secret to the Complement worker image. This fixes tests that depend on it. ([\#12819](https://github.com/matrix-org/synapse/issues/12819)) - Support registering Application Services when running with workers under Complement. ([\#12826](https://github.com/matrix-org/synapse/issues/12826)) - Disable 'faster room join' Complement tests when testing against Synapse with workers. ([\#12842](https://github.com/matrix-org/synapse/issues/12842)) -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEWMTnW8Z8khaaf90R+84KzgcyGG8FAmKM0+wACgkQ+84Kzgcy GG/yxwv/ZlGP+H6eE4cF0Bv2LPiyj7RuJl0oC3lj+ebLLfnNKwzDYx3y4u0nMYSJ KrTn3dQOhRuY54+dbK3imlHswxWr2f+xX2ouN3/y3WOGaduojgGc/Tir2sk61FM6 mljLC4dwER2uKlXo4wqrUdtMHEWZ8EM85NI+sbUIDJbXrolf3fXfr8aWReElx3YH z6eFS8qFgH7jKvaf/0V4jAS7ue0JkPElQLUctDTPpuL9FWC3mcV1dIbf6FZp5GnD fGyfl7810JtfHZtFOfMb9NculmlvfndiF8lpGX+wpdWIrdMHQJlcLDDCTtAKDpED 9wphX7RY/Z1CKsHXEK/7GKH/AcL7dDR7t1X1XMvwYXxoLH+JJ+2r2C0c0jh6pAhk 23prI/yUZ8YUOvrMYYuhCl5YA4ZAGP2H4j4Cu9v5WNi9gAEPUBhb/p86nM4Pgpng 5Di7PYKWzrpbZSiRidHVniGOHSygdLZ68RzT6s/5Pvkfn8dRMjm4okbVpA8pIzKM oqk/hrqt =hQ5p -----END PGP SIGNATURE----- Merge tag 'v1.60.0rc1' into develop Synapse 1.60.0rc1 (2022-05-24) ============================== This release of Synapse adds a unique index to the `state_group_edges` table, in order to prevent accidentally introducing duplicate information (for example, because a database backup was restored multiple times). If your Synapse database already has duplicate rows in this table, this could fail with an error and require manual remediation. Additionally, the signature of the `check_event_for_spam` module callback has changed. The previous signature has been deprecated and remains working for now. Module authors should update their modules to use the new signature where possible. See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1600) for more details. Features -------- - Measure the time taken in spam-checking callbacks and expose those measurements as metrics. ([\#12513](https://github.com/matrix-org/synapse/issues/12513)) - Add a `default_power_level_content_override` config option to set default room power levels per room preset. ([\#12618](https://github.com/matrix-org/synapse/issues/12618)) - Add support for [MSC3787: Allowing knocks to restricted rooms](https://github.com/matrix-org/matrix-spec-proposals/pull/3787). ([\#12623](https://github.com/matrix-org/synapse/issues/12623)) - Send `USER_IP` commands on a different Redis channel, in order to reduce traffic to workers that do not process these commands. ([\#12672](https://github.com/matrix-org/synapse/issues/12672), [\#12809](https://github.com/matrix-org/synapse/issues/12809)) - Synapse will now reload [cache config](https://matrix-org.github.io/synapse/latest/usage/configuration/config_documentation.html#caching) when it receives a [SIGHUP](https://en.wikipedia.org/wiki/SIGHUP) signal. ([\#12673](https://github.com/matrix-org/synapse/issues/12673)) - Add a config options to allow for auto-tuning of caches. ([\#12701](https://github.com/matrix-org/synapse/issues/12701)) - Update [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716) implementation to process marker events from the current state to avoid markers being lost in timeline gaps for federated servers which would cause the imported history to be undiscovered. ([\#12718](https://github.com/matrix-org/synapse/issues/12718)) - Add a `drop_federated_event` callback to `SpamChecker` to disregard inbound federated events before they take up much processing power, in an emergency. ([\#12744](https://github.com/matrix-org/synapse/issues/12744)) - Implement [MSC3818: Copy room type on upgrade](https://github.com/matrix-org/matrix-spec-proposals/pull/3818). ([\#12786](https://github.com/matrix-org/synapse/issues/12786), [\#12792](https://github.com/matrix-org/synapse/issues/12792)) - Update to the `check_event_for_spam` module callback. Deprecate the current callback signature, replace it with a new signature that is both less ambiguous (replacing booleans with explicit allow/block) and more powerful (ability to return explicit error codes). ([\#12808](https://github.com/matrix-org/synapse/issues/12808)) Bugfixes -------- - Fix a bug introduced in Synapse 1.7.0 that would prevent events from being sent to clients if there's a retention policy in the room when the support for retention policies is disabled. ([\#12611](https://github.com/matrix-org/synapse/issues/12611)) - Fix a bug introduced in Synapse 1.57.0 where `/messages` would throw a 500 error when querying for a non-existent room. ([\#12683](https://github.com/matrix-org/synapse/issues/12683)) - Add a unique index to `state_group_edges` to prevent duplicates being accidentally introduced and the consequential impact to performance. ([\#12687](https://github.com/matrix-org/synapse/issues/12687)) - Fix a long-standing bug where an empty room would be created when a user with an insufficient power level tried to upgrade a room. ([\#12696](https://github.com/matrix-org/synapse/issues/12696)) - Fix a bug introduced in Synapse 1.30.0 where empty rooms could be automatically created if a monthly active users limit is set. ([\#12713](https://github.com/matrix-org/synapse/issues/12713)) - Fix push to dismiss notifications when read on another client. Contributed by @SpiritCroc @ Beeper. ([\#12721](https://github.com/matrix-org/synapse/issues/12721)) - Fix poor database performance when reading the cache invalidation stream for large servers with lots of workers. ([\#12747](https://github.com/matrix-org/synapse/issues/12747)) - Delete events from the `federation_inbound_events_staging` table when a room is purged through the admin API. ([\#12770](https://github.com/matrix-org/synapse/issues/12770)) - Give a meaningful error message when a client tries to create a room with an invalid alias localpart. ([\#12779](https://github.com/matrix-org/synapse/issues/12779)) - Fix a bug introduced in 1.43.0 where a file (`providers.json`) was never closed. Contributed by @arkamar. ([\#12794](https://github.com/matrix-org/synapse/issues/12794)) - Fix a long-standing bug where finished log contexts would be re-started when failing to contact remote homeservers. ([\#12803](https://github.com/matrix-org/synapse/issues/12803)) - Fix a bug, introduced in Synapse 1.21.0, that led to media thumbnails being unusable before the index has been added in the background. ([\#12823](https://github.com/matrix-org/synapse/issues/12823)) Updates to the Docker image --------------------------- - Fix the docker file after a dependency update. ([\#12853](https://github.com/matrix-org/synapse/issues/12853)) Improved Documentation ---------------------- - Fix a typo in the Media Admin API documentation. ([\#12715](https://github.com/matrix-org/synapse/issues/12715)) - Update the OpenID Connect example for Keycloak to be compatible with newer versions of Keycloak. Contributed by @nhh. ([\#12727](https://github.com/matrix-org/synapse/issues/12727)) - Fix typo in server listener documentation. ([\#12742](https://github.com/matrix-org/synapse/issues/12742)) - Link to the configuration manual from the welcome page of the documentation. ([\#12748](https://github.com/matrix-org/synapse/issues/12748)) - Fix typo in `run_background_tasks_on` option name in configuration manual documentation. ([\#12749](https://github.com/matrix-org/synapse/issues/12749)) - Add information regarding the `rc_invites` ratelimiting option to the configuration docs. ([\#12759](https://github.com/matrix-org/synapse/issues/12759)) - Add documentation for cancellation of request processing. ([\#12761](https://github.com/matrix-org/synapse/issues/12761)) - Recommend using docker to run tests against postgres. ([\#12765](https://github.com/matrix-org/synapse/issues/12765)) - Add missing user directory endpoint from the generic worker documentation. Contributed by @olmari. ([\#12773](https://github.com/matrix-org/synapse/issues/12773)) - Add additional info to documentation of config option `cache_autotuning`. ([\#12776](https://github.com/matrix-org/synapse/issues/12776)) - Update configuration manual documentation to document size-related suffixes. ([\#12777](https://github.com/matrix-org/synapse/issues/12777)) - Fix invalid YAML syntax in the example documentation for the `url_preview_accept_language` config option. ([\#12785](https://github.com/matrix-org/synapse/issues/12785)) Deprecations and Removals ------------------------- - Require a body in POST requests to `/rooms/{roomId}/receipt/{receiptType}/{eventId}`, as required by the [Matrix specification](https://spec.matrix.org/v1.2/client-server-api/#post_matrixclientv3roomsroomidreceiptreceipttypeeventid). This breaks compatibility with Element Android 1.2.0 and earlier: users of those clients will be unable to send read receipts. ([\#12709](https://github.com/matrix-org/synapse/issues/12709)) Internal Changes ---------------- - Improve event caching mechanism to avoid having multiple copies of an event in memory at a time. ([\#10533](https://github.com/matrix-org/synapse/issues/10533)) - Preparation for faster-room-join work: return subsets of room state which we already have, immediately. ([\#12498](https://github.com/matrix-org/synapse/issues/12498)) - Add `@cancellable` decorator, for use on endpoint methods that can be cancelled when clients disconnect. ([\#12586](https://github.com/matrix-org/synapse/issues/12586), [\#12588](https://github.com/matrix-org/synapse/issues/12588), [\#12630](https://github.com/matrix-org/synapse/issues/12630), [\#12694](https://github.com/matrix-org/synapse/issues/12694), [\#12698](https://github.com/matrix-org/synapse/issues/12698), [\#12699](https://github.com/matrix-org/synapse/issues/12699), [\#12700](https://github.com/matrix-org/synapse/issues/12700), [\#12705](https://github.com/matrix-org/synapse/issues/12705)) - Enable cancellation of `GET /rooms/$room_id/members`, `GET /rooms/$room_id/state` and `GET /rooms/$room_id/state/$event_type/` requests. ([\#12708](https://github.com/matrix-org/synapse/issues/12708)) - Improve documentation of the `synapse.push` module. ([\#12676](https://github.com/matrix-org/synapse/issues/12676)) - Refactor functions to on `PushRuleEvaluatorForEvent`. ([\#12677](https://github.com/matrix-org/synapse/issues/12677)) - Preparation for database schema simplifications: stop writing to `event_reference_hashes`. ([\#12679](https://github.com/matrix-org/synapse/issues/12679)) - Remove code which updates unused database column `application_services_state.last_txn`. ([\#12680](https://github.com/matrix-org/synapse/issues/12680)) - Refactor `EventContext` class. ([\#12689](https://github.com/matrix-org/synapse/issues/12689)) - Remove an unneeded class in the push code. ([\#12691](https://github.com/matrix-org/synapse/issues/12691)) - Consolidate parsing of relation information from events. ([\#12693](https://github.com/matrix-org/synapse/issues/12693)) - Convert namespace class `Codes` into a string enum. ([\#12703](https://github.com/matrix-org/synapse/issues/12703)) - Optimize private read receipt filtering. ([\#12711](https://github.com/matrix-org/synapse/issues/12711)) - Drop the logging level of status messages for the URL preview cache expiry job from INFO to DEBUG. ([\#12720](https://github.com/matrix-org/synapse/issues/12720)) - Downgrade some OIDC errors to warnings in the logs, to reduce the noise of Sentry reports. ([\#12723](https://github.com/matrix-org/synapse/issues/12723)) - Update configs used by Complement to allow more invites/3PID validations during tests. ([\#12731](https://github.com/matrix-org/synapse/issues/12731)) - Fix a long-standing bug where the user directory background process would fail to make forward progress if a user included a null codepoint in their display name or avatar. ([\#12762](https://github.com/matrix-org/synapse/issues/12762)) - Tweak the mypy plugin so that `@cached` can accept `on_invalidate=None`. ([\#12769](https://github.com/matrix-org/synapse/issues/12769)) - Move methods that call `add_push_rule` to the `PushRuleStore` class. ([\#12772](https://github.com/matrix-org/synapse/issues/12772)) - Make handling of federation Authorization header (more) compliant with RFC7230. ([\#12774](https://github.com/matrix-org/synapse/issues/12774)) - Refactor `resolve_state_groups_for_events` to not pull out full state when no state resolution happens. ([\#12775](https://github.com/matrix-org/synapse/issues/12775)) - Do not keep going if there are 5 back-to-back background update failures. ([\#12781](https://github.com/matrix-org/synapse/issues/12781)) - Fix federation when using the demo scripts. ([\#12783](https://github.com/matrix-org/synapse/issues/12783)) - The `hash_password` script now fails when it is called without specifying a config file. Contributed by @jae1911. ([\#12789](https://github.com/matrix-org/synapse/issues/12789)) - Improve and fix type hints. ([\#12567](https://github.com/matrix-org/synapse/issues/12567), [\#12477](https://github.com/matrix-org/synapse/issues/12477), [\#12717](https://github.com/matrix-org/synapse/issues/12717), [\#12753](https://github.com/matrix-org/synapse/issues/12753), [\#12695](https://github.com/matrix-org/synapse/issues/12695), [\#12734](https://github.com/matrix-org/synapse/issues/12734), [\#12716](https://github.com/matrix-org/synapse/issues/12716), [\#12726](https://github.com/matrix-org/synapse/issues/12726), [\#12790](https://github.com/matrix-org/synapse/issues/12790), [\#12833](https://github.com/matrix-org/synapse/issues/12833)) - Update EventContext `get_current_event_ids` and `get_prev_event_ids` to accept state filters and update calls where possible. ([\#12791](https://github.com/matrix-org/synapse/issues/12791)) - Remove Caddy from the Synapse workers image used in Complement. ([\#12818](https://github.com/matrix-org/synapse/issues/12818)) - Add Complement's shared registration secret to the Complement worker image. This fixes tests that depend on it. ([\#12819](https://github.com/matrix-org/synapse/issues/12819)) - Support registering Application Services when running with workers under Complement. ([\#12826](https://github.com/matrix-org/synapse/issues/12826)) - Disable 'faster room join' Complement tests when testing against Synapse with workers. ([\#12842](https://github.com/matrix-org/synapse/issues/12842))	2022-05-24 15:38:38 +01:00
Patrick Cloke	88ce3080d4	Experimental support for MSC3772 (#12740 ) Implements the following behind an experimental configuration flag: * A new push rule kind for mutually related events. * A new default push rule (`.m.rule.thread_reply`) under an unstable prefix. This is missing part of MSC3772: * The `.m.rule.thread_reply_to_me` push rule, this depends on MSC3664 / #11804.	2022-05-24 13:23:23 +00:00
Sean Quah	a670b5cda2	1.60.0rc1	2022-05-24 12:05:33 +01:00
Erik Johnston	f5b1c09909	Pin poetry.core in Docker images (#12853 )	2022-05-24 11:35:08 +01:00
Eric Eastwood	7c2a78bb3b	Marker events as state - MSC2716 (#12718 ) Sending marker events as state now so they are always able to be seen by homeservers (not lost in some timeline gap). Part of [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716) Complement tests: https://github.com/matrix-org/complement/pull/371 As initially discussed at https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r782629097 and https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r876684431 When someone joins a room, process all of the marker events we see in the current state. Marker events should be sent with a unique `state_key` so that they can all resolve in the current state to easily be discovered. Marker events as state - If we re-use the same `state_key` (like `""`), then we would have to fetch previous snapshots of state up through time to find all of the marker events. This way we can avoid all of that. This PR was originally doing this but then thought of the smarter way to tackle in an [out of band discussion with @erikjohnston](https://docs.google.com/document/d/1JJDuPfcPNX75fprdTWlxlaKjWOdbdJylbpZ03hzo638/edit#bookmark=id.sm92fqyq7vpp). - Also avoids state resolution conflicts where only one of the marker events win As a homeserver, when we see new marker state, we know there is new history imported somewhere back in time and should process it to fetch the insertion event where the historical messages are and set it as an insertion extremity. This way we know where to backfill more messages when someone asks for scrollback.	2022-05-23 20:43:37 -05:00
David Teller	28199e9357	Uniformize spam-checker API, part 2: check_event_for_spam (#12808 ) Signed-off-by: David Teller <davidt@element.io>	2022-05-23 17:27:39 +00:00
Brendan Abolivier	4cc4229cd7	Prevent expired events from being filtered out when retention is disabled (#12611 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-05-23 17:18:23 +00:00
Jess Porter	a608ac847b	add SpamChecker callback for silently dropping inbound federated events (#12744 ) Signed-off-by: jesopo <github@lolnerd.net>	2022-05-23 16:36:21 +00:00
reivilibre	7a68203cde	Disable 'faster room join' Complement tests when testing against Synapse with workers. (#12842 )	2022-05-23 17:27:05 +01:00
reivilibre	67aae05ece	Support registering Application Services when running with workers under Complement. (#12826 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-05-23 14:11:06 +01:00
Dirk Klimpel	444588c5fc	Add some type hints to tests files (#12833 ) Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2022-05-23 11:23:26 +00:00
reivilibre	438925c422	Fix Complement `TestCanRegisterAdmin` with workers, by adding Complement's shared registration secret. (#12819 )	2022-05-23 12:20:30 +01:00
reivilibre	4fef76ca34	Remove Caddy from the Synapse workers image used in Complement. (#12818 )	2022-05-23 10:29:24 +01:00
reivilibre	fbf904bd54	Fix media thumbnails being unusable before the index had been added in the background. (#12823 )	2022-05-23 10:28:56 +01:00
reivilibre	39dee30f01	Send `USER_IP` commands on a different Redis channel, in order to reduce traffic to workers that do not process these commands. (#12809 )	2022-05-20 15:28:23 +01:00
David Teller	10280fc943	Uniformize spam-checker API, part 1: the `Code` enum. (#12703 )	2022-05-20 14:53:25 +02:00
Shay	71e8afe34d	Update EventContext `get_current_event_ids` and `get_prev_event_ids` to accept state filters and update calls where possible (#12791 )	2022-05-20 09:54:12 +01:00
Sean Quah	2be5a2b07b	Fix `RetryDestinationLimiter` re-starting finished log contexts (#12803 ) Signed-off-by: Sean Quah <seanq@matrix.org>	2022-05-19 20:17:10 +01:00
Andrew Morgan	96df31239c	Add a unit test for copying over arbitrary room types when upgrading a room (#12792 )	2022-05-19 18:32:48 +01:00
reivilibre	177b884ad7	Lay some foundation work to allow workers to only subscribe to some kinds of messages, reducing replication traffic. (#12672 )	2022-05-19 16:29:08 +01:00
Shay	eb4aaa1b4b	Add detail to `cache_autotuning` config option documentation (#12776 )	2022-05-19 07:47:07 -07:00
Shay	ab2a615cfb	Update configuration manual to document size-related suffixes (#12777 )	2022-05-19 07:46:33 -07:00
Petr Vaněk	684feeaf2f	Properly close providers.json file stream. (#12794 )	2022-05-19 14:23:59 +00:00
reivilibre	66a5f6c400	Add a unique index to `state_group_edges` to prevent duplicates being accidentally introduced and the consequential impact to performance. (#12687 )	2022-05-19 14:16:49 +01:00
Jae Lo Presti	f16ec055cc	hash_password: raise an error if no config file is specified (#12789 )	2022-05-19 13:03:13 +00:00
David Robertson	b935c9529c	Simplify untyped-defs config in mypy.ini (#12790 )	2022-05-19 13:49:58 +01:00
Aminda Suomalainen	d25935cd3d	Implement MSC3818: copy room type on upgrade (#12786 ) Resolves: #11896 Signed-off-by: Aminda Suomalainen <suomalainen+git@mikaela.info>	2022-05-19 12:28:10 +01:00
Sami Olmari	47619017f9	Add missing user directory search endpoint to the generic worker documentation (#12773 ) Signed-off-by: Sami Olmari <sami@olmari.fi>	2022-05-19 12:03:12 +01:00
David Robertson	6ff99e3bea	Downgrade some OIDC exceptions to warnings (#12723 )	2022-05-18 20:10:21 +01:00
Patrick Cloke	a1cb05b3e8	Fix federation in demo scripts. (#12783 )	2022-05-18 14:49:33 -04:00
Richard van der Hoff	d38c73e9ab	Skip waiting for full state if a StateFilter does not require it (#12498 ) If `StateFilter` specifies a state set which we will have regardless of state-syncing, then we may as well return it immediately.	2022-05-18 18:33:57 +00:00
Andrew Morgan	0fce474a40	Fix YAML parsing error in `url_preview_accept_language` (#12785 )	2022-05-18 17:24:44 +00:00
Shay	19d79b6ebe	Refactor `resolve_state_groups_for_events` to not pull out full state when no state resolution happens. (#12775 )	2022-05-18 10:15:52 -07:00
Sean Quah	3d8839c30c	Add documentation for cancellation of request processing (#12761 ) Signed-off-by: Sean Quah <seanq@matrix.org>	2022-05-18 17:56:23 +01:00
Dirk Klimpel	50ae4eafe1	Add some type hints to `event_federation` datastore (#12753 ) Co-authored-by: David Robertson <david.m.robertson1@gmail.com>	2022-05-18 16:02:10 +01:00
reivilibre	635f0d916b	Do not keep going if there are 5 back-to-back background update failures. (#12781 )	2022-05-18 13:57:59 +00:00
reivilibre	df4963548b	Give a meaningful error message when a client tries to create a room with an invalid alias localpart. (#12779 )	2022-05-18 11:46:06 +00:00
Andrew Morgan	a167304c8b	Switch the 'Configuration' link in the docs homepage to the config manual (#12748 )	2022-05-18 11:29:32 +00:00
Andrew Morgan	deca250e3f	Add some documentation around the `rc_invites` option to the config docs (#12759 )	2022-05-18 12:21:32 +01:00
David Robertson	d4713d3e33	Discard null-containing strings before updating the user directory (#12762 )	2022-05-18 11:28:14 +01:00
Hubert Chathi	8afb7b55d0	Make handling of federation Authorization header (more) compliant with RFC7230 (#12774 ) The main differences are: - values with delimiters (such as colons) should be quoted, so always quote the origin, since it could contain a colon followed by a port number - should allow more than one space after "X-Matrix" - quoted values with backslash-escaped characters should be unescaped - names should be case insensitive	2022-05-18 11:19:30 +01:00
Adam	37935b5183	Move methods that call add_push_rule to PushRuleStore (#12772 ) Signed-off-by: Adam Roddick <ajroddick@tuta.io>	2022-05-18 09:37:48 +00:00
David Robertson	0d17357fcd	Suggest using docker when testing against postgres (#12765 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-05-17 18:05:53 +00:00
Mathieu Velten	182ca78a12	Delete events from federation_inbound_events_staging table on purge (#12770 )	2022-05-17 17:01:06 +00:00
David Robertson	5331fb5b47	allow `on_invalidate=None` in `@cached` methods (#12769 )	2022-05-17 16:06:45 +00:00
Dirk Klimpel	6edefef602	Add some type hints to datastore (#12717 )	2022-05-17 15:29:06 +01:00
Travis Ralston	942c30b16b	Add a new room version for MSC3787's knock+restricted join rule (#12623 )	2022-05-17 10:41:39 +00:00
Richard van der Hoff	24b590de32	Remove code which updates `application_services_state.last_txn` (#12680 ) This column is unused as of #12209, so let's stop writing to it.	2022-05-17 11:07:18 +01:00
SpiritCroc	a34a41f135	Fix push for m.read events (#12721 ) badge_count_last_call was always zero when the response for push notifications included a "rejected" key which mapped to an empty list.	2022-05-17 11:03:07 +01:00
Erik Johnston	32ef24fbd7	Add index to cache invalidations (#12747 ) For workers that rarely write to the cache the `get_all_updated_caches` query can become expensive if the worker falls behind when reading the cache.	2022-05-17 09:34:59 +00:00
Erik Johnston	fcf951d5dc	Track in memory events using weakrefs (#10533 )	2022-05-17 10:34:27 +01:00
David Robertson	1fe202a1a3	Tidy up and type-hint the database engine modules (#12734 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-05-17 00:34:38 +01:00
Andrew Morgan	6d8d1218dd	Fix typo in name of 'run_background_tasks_on' option in config manual (#12749 )	2022-05-16 17:31:12 +00:00
Andrew Morgan	3eafee629d	Revert "changelog" This reverts commit `e24c11afd6`. whoops...	2022-05-16 17:52:22 +01:00
Andrew Morgan	e24c11afd6	changelog	2022-05-16 17:51:43 +01:00
Andrew Morgan	83be72d76c	Add `StreamKeyType` class and replace string literals with constants (#12567 )	2022-05-16 15:35:31 +00:00
Šimon Brandner	3ce15cc7be	Avoid unnecessary copies when filtering private read receipts. (#12711 ) A minor optimization to avoid unnecessary copying/building identical dictionaries when filtering private read receipts. Also clarifies comments and cleans-up some tests.	2022-05-16 15:06:23 +00:00
Dirk Klimpel	8060034612	Fix typo in listener config (#12742 )	2022-05-16 13:50:07 +00:00
Sean Quah	a5c26750b5	Fix room upgrades creating an empty room when auth fails (#12696 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-05-16 14:06:04 +01:00
Patrick Cloke	86a515ccbf	Consolidate logic for parsing relations. (#12693 ) Parse the `m.relates_to` event content field (which describes relations) in a single place, this is used during: * Event persistence. * Validation of the Client-Server API. * Fetching bundled aggregations. * Processing of push rules. Each of these separately implement the logic and each made slightly different assumptions about what was valid. Some had minor / potential bugs.	2022-05-16 12:42:45 +00:00
Shay	cde8af9a49	Add config flags to allow for cache auto-tuning (#12701 )	2022-05-13 12:32:39 -07:00
Till	e8ae472d3b	Update configs used by Complement to allow more invites (#12731 )	2022-05-13 16:45:47 +01:00
Brendan Abolivier	9013104429	Don't create an empty room when checking for MAU limits (#12713 )	2022-05-13 15:30:15 +02:00
David Robertson	aec69d2481	Another batch of type annotations (#12726 )	2022-05-13 12:35:31 +01:00
Jess Porter	39bed28b28	SpamChecker metrics (#12513 ) * add Measure blocks all over SpamChecker Signed-off-by: jesopo <github@lolnerd.net> * fix test_spam_checker_may_join_room and test_threepid_invite_spamcheck * better changelog entry	2022-05-13 12:17:38 +01:00
Niklas	c9fc2c0d22	Update issuer URL in example OIDC Keycloak config (#12727 ) * Update openid.md Newer versions of keycloak returning a 404 when using the `/auth` prefix. Related: https://github.com/matrix-org/synapse/issues/12714	2022-05-13 10:15:51 +00:00
Andrew Morgan	57f6c496d0	URL preview cache expiry logs: INFO -> DEBUG, text clarifications (#12720 )	2022-05-12 18:16:32 +01:00
David Robertson	17e1eb7749	Reduce the number of "untyped defs" (#12716 )	2022-05-12 14:33:50 +00:00
Andy Balaam	de1e599b9d	add default_power_level_content_override config option. (#12618 ) Co-authored-by: Matthew Hodgson <matthew@matrix.org>	2022-05-12 10:41:35 +00:00
Andrew Morgan	409573f6d0	Fix reference to the wrong symbol in the media admin api docs (#12715 )	2022-05-12 09:29:37 +01:00
Sean Quah	bf7ce92bf7	Enable cancellation of `GET /members` and `GET /state` requests (#12708 ) Enable cancellation of `GET /rooms/$room_id/members`, `GET /rooms/$room_id/state` and `GET /rooms/$room_id/state/$state_key/*` requests. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 17:22:34 +01:00
David Robertson	db10f2c037	No longer permit empty body when sending receipts (#12709 )	2022-05-11 15:34:17 +00:00
Sean Quah	6ee61b9052	Complain if a federation endpoint has the `@cancellable` flag (#12705 ) `BaseFederationServlet` wraps its endpoints in a bunch of async code that has not been vetted for compatibility with cancellation. Fail CI if a `@cancellable` flag is applied to a federation endpoint. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 14:52:26 +01:00
David Robertson	d38d242411	Reload cache factors from disk on SIGHUP (#12673 )	2022-05-11 13:43:22 +00:00
Sean Quah	a559c8b0d9	Respect the `@cancellable` flag for `ReplicationEndpoint`s (#12700 ) While `ReplicationEndpoint`s register themselves via `JsonResource`, they pass a method that calls the handler, instead of the handler itself, to `register_paths`. As a result, `JsonResource` will not correctly pick up the `@cancellable` flag and we have to apply it ourselves. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 12:25:39 +01:00
Sean Quah	9d8e380d2e	Respect the `@cancellable` flag for `RestServlet`s and `BaseFederationServlet`s (#12699 ) Both `RestServlet`s and `BaseFederationServlet`s register their handlers with `HttpServer.register_paths` / `JsonResource.register_paths`. Update `JsonResource` to respect the `@cancellable` flag on handlers registered in this way. Although `ReplicationEndpoint` also registers itself using `register_paths`, it does not pass the handler method that would have the `@cancellable` flag directly, and so needs separate handling. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 12:25:13 +01:00
Sean Quah	dffecade7d	Respect the `@cancellable` flag for `DirectServe{Html,Json}Resource`s (#12698 ) `DirectServeHtmlResource` and `DirectServeJsonResource` both inherit from `_AsyncResource`. These classes expect to be subclassed with `_async_render_*` methods. This commit has no effect on `JsonResource`, despite inheriting from `_AsyncResource`. `JsonResource` has its own `_async_render` override which will need to be updated separately. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 12:24:48 +01:00
Patrick Cloke	a4c75918b3	Remove unneeded `ActionGenerator` class. (#12691 ) It simply passes through to `BulkPushRuleEvaluator`, which can be called directly instead.	2022-05-11 07:15:21 -04:00
Eric Eastwood	84facf769e	Fix `/messages` throwing a 500 when querying for non-existent room (#12683 ) Fix https://github.com/matrix-org/synapse/issues/12678 Complement test added: https://github.com/matrix-org/complement/pull/369 Before: 500 internal server error After: According to the [spec](https://spec.matrix.org/latest/client-server-api/#get_matrixclientv3roomsroomidmessages), calling `/messages` against a non-existent `room_id` should throw a 403 forbidden (since you're not part of the room). This also matches the behavior before https://github.com/matrix-org/synapse/pull/12370 which regressed Synapse to the 500 behavior. ```json { "errcode": "M_FORBIDDEN", "error": "User @test:my.synapse.server not in room !dne:my.synapse.server, and room previews are disabled" } ```	2022-05-10 23:39:14 -05:00
Erik Johnston	c72d26c1e1	Refactor `EventContext` (#12689 ) Refactor how the `EventContext` class works, with the intention of reducing the amount of state we fetch from the DB during event processing. The idea here is to get rid of the cached `current_state_ids` and `prev_state_ids` that live in the `EventContext`, and instead defer straight to the database (and its caching). One change that may have a noticeable effect is that we now no longer prefill the `get_current_state_ids` cache on a state change. However, that query is relatively light, since its just a case of reading a table from the DB (unlike fetching state at an event which is more heavyweight). For deployments with workers this cache isn't even used. Part of #12684	2022-05-10 19:43:13 +00:00
Sean Quah	c997bfb926	Capture the `Deferred` for request cancellation in `_AsyncResource` (#12694 ) All async request processing goes through `_AsyncResource`, so this is the only place where a `Deferred` needs to be captured for cancellation. Unfortunately, the same isn't true for determining whether a request can be cancelled. Each of `RestServlet`, `BaseFederationServlet`, `DirectServe{Html,Json}Resource` and `ReplicationEndpoint` have different wrappers around the method doing the request handling and they all need to be handled separately. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-10 20:39:05 +01:00
Patrick Cloke	29f06704b8	Fix incorrect type hint in filtering code. (#12695 )	2022-05-10 14:10:22 -04:00
Dirk Klimpel	989fa33096	Add some type hints to datastore. (#12477 )	2022-05-10 14:07:48 -04:00
Richard van der Hoff	147f098fb4	Stop writing to `event_reference_hashes` (#12679 ) This table is never read, since #11794. We stop writing to it; in future we can drop it altogether.	2022-05-10 15:35:08 +01:00
Sean Quah	dbb12a0b54	Add helper class for testing request cancellation (#12630 ) Also expose the `SynapseRequest` from `FakeChannel` in tests, so that we can call `Request.connectionLost` to simulate a client disconnecting. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-10 14:06:56 +01:00
Sean Quah	5cfb004595	Add ability to cancel disconnected requests to `SynapseRequest` (#12588 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-05-10 14:06:08 +01:00
Sean Quah	5c00151c28	Add `@cancellable` decorator, for use on request handlers (#12586 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-05-10 14:05:22 +01:00
David Robertson	2aad0ae57f	Synapse 1.59.0rc1 (2022-05-10) ============================== This release makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](https://github.com/matrix-org/synapse/issues/12452), [\#12654](https://github.com/matrix-org/synapse/issues/12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) Features -------- - Support [MSC3266](https://github.com/matrix-org/matrix-doc/pull/3266) room summaries over federation. ([\#11507](https://github.com/matrix-org/synapse/issues/11507)) - Implement [changes](`4a77139249`) to [MSC2285 (hidden read receipts)](https://github.com/matrix-org/matrix-spec-proposals/pull/2285). Contributed by @SimonBrandner. ([\#12168](https://github.com/matrix-org/synapse/issues/12168), [\#12635](https://github.com/matrix-org/synapse/issues/12635), [\#12636](https://github.com/matrix-org/synapse/issues/12636), [\#12670](https://github.com/matrix-org/synapse/issues/12670)) - Extend the [module API](https://github.com/matrix-org/synapse/blob/release-v1.59/synapse/module_api/__init__.py) to allow modules to change actions for existing push rules of local users. ([\#12406](https://github.com/matrix-org/synapse/issues/12406)) - Add the `notify_appservices_from_worker` configuration option (superseding `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. ([\#12452](https://github.com/matrix-org/synapse/issues/12452)) - Add the `update_user_directory_from_worker` configuration option (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. ([\#12654](https://github.com/matrix-org/synapse/issues/12654)) - Add new `enable_registration_token_3pid_bypass` configuration option to allow registrations via token as an alternative to verifying a 3pid. ([\#12526](https://github.com/matrix-org/synapse/issues/12526)) - Implement [MSC3786](https://github.com/matrix-org/matrix-spec-proposals/pull/3786): Add a default push rule to ignore `m.room.server_acl` events. ([\#12601](https://github.com/matrix-org/synapse/issues/12601)) - Add new `mau_appservice_trial_days` configuration option to specify a different trial period for users registered via an appservice. ([\#12619](https://github.com/matrix-org/synapse/issues/12619)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where the latest thread reply provided failed to include the proper bundled aggregations. ([\#12273](https://github.com/matrix-org/synapse/issues/12273)) - Fix a bug introduced in Synapse 1.22.0 where attempting to send a large amount of read receipts to an application service all at once would result in duplicate content and abnormally high memory usage. Contributed by Brad & Nick @ Beeper. ([\#12544](https://github.com/matrix-org/synapse/issues/12544)) - Fix a bug introduced in Synapse 1.57.0 which could cause `Failed to calculate hosts in room` errors to be logged for outbound federation. ([\#12570](https://github.com/matrix-org/synapse/issues/12570)) - Fix a long-standing bug where status codes would almost always get logged as `200!`, irrespective of the actual status code, when clients disconnect before a request has finished processing. ([\#12580](https://github.com/matrix-org/synapse/issues/12580)) - Fix race when persisting an event and deleting a room that could lead to outbound federation breaking. ([\#12594](https://github.com/matrix-org/synapse/issues/12594)) - Fix a bug introduced in Synapse 1.53.0 where bundled aggregations for annotations/edits were incorrectly calculated. ([\#12633](https://github.com/matrix-org/synapse/issues/12633)) - Fix a long-standing bug where rooms containing power levels with string values could not be upgraded. ([\#12657](https://github.com/matrix-org/synapse/issues/12657)) - Prevent memory leak from reoccurring when presence is disabled. ([\#12656](https://github.com/matrix-org/synapse/issues/12656)) Updates to the Docker image --------------------------- - Explicitly opt-in to using [BuildKit-specific features](https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/syntax.md) in the Dockerfile. This fixes issues with building images in some GitLab CI environments. ([\#12541](https://github.com/matrix-org/synapse/issues/12541)) - Update the "Build docker images" GitHub Actions workflow to use `docker/metadata-action` to generate docker image tags, instead of a custom shell script. Contributed by @henryclw. ([\#12573](https://github.com/matrix-org/synapse/issues/12573)) Improved Documentation ---------------------- - Update SQL statements and replace use of old table `user_stats_historical` in docs for Synapse Admins. ([\#12536](https://github.com/matrix-org/synapse/issues/12536)) - Add missing linebreak to `pipx` install instructions. ([\#12579](https://github.com/matrix-org/synapse/issues/12579)) - Add information about the TCP replication module to docs. ([\#12621](https://github.com/matrix-org/synapse/issues/12621)) - Fixes to the formatting of `README.rst`. ([\#12627](https://github.com/matrix-org/synapse/issues/12627)) - Fix docs on how to run specific Complement tests using the `complement.sh` test runner. ([\#12664](https://github.com/matrix-org/synapse/issues/12664)) Deprecations and Removals ------------------------- - Remove unstable identifiers from [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069). ([\#12596](https://github.com/matrix-org/synapse/issues/12596)) - Remove the unspecified `m.login.jwt` login type and the unstable `uk.half-shot.msc2778.login.application_service` from [MSC2778](https://github.com/matrix-org/matrix-doc/pull/2778). ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) - Synapse now requires at least Python 3.7.1 (up from 3.7.0), for compatibility with the latest Twisted trunk. ([\#12613](https://github.com/matrix-org/synapse/issues/12613)) Internal Changes ---------------- - Use supervisord to supervise Postgres and Caddy in the Complement image to reduce restart time. ([\#12480](https://github.com/matrix-org/synapse/issues/12480)) - Immediately retry any requests that have backed off when a server comes back online. ([\#12500](https://github.com/matrix-org/synapse/issues/12500)) - Use `make_awaitable` instead of `defer.succeed` for return values of mocks in tests. ([\#12505](https://github.com/matrix-org/synapse/issues/12505)) - Consistently check if an object is a `frozendict`. ([\#12564](https://github.com/matrix-org/synapse/issues/12564)) - Protect module callbacks with read semantics against cancellation. ([\#12568](https://github.com/matrix-org/synapse/issues/12568)) - Improve comments and error messages around access tokens. ([\#12577](https://github.com/matrix-org/synapse/issues/12577)) - Improve docstrings for the receipts store. ([\#12581](https://github.com/matrix-org/synapse/issues/12581)) - Use constants for read-receipts in tests. ([\#12582](https://github.com/matrix-org/synapse/issues/12582)) - Log status code of cancelled requests as 499 and avoid logging stack traces for them. ([\#12587](https://github.com/matrix-org/synapse/issues/12587), [\#12663](https://github.com/matrix-org/synapse/issues/12663)) - Remove special-case for `twisted` logger from default log config. ([\#12589](https://github.com/matrix-org/synapse/issues/12589)) - Use `getClientAddress` instead of the deprecated `getClientIP`. ([\#12599](https://github.com/matrix-org/synapse/issues/12599)) - Add link to documentation in Grafana Dashboard. ([\#12602](https://github.com/matrix-org/synapse/issues/12602)) - Reduce log spam when running multiple event persisters. ([\#12610](https://github.com/matrix-org/synapse/issues/12610)) - Add extra debug logging to federation sender. ([\#12614](https://github.com/matrix-org/synapse/issues/12614)) - Prevent remote homeservers from requesting local user device names by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - Add a consistency check on events which we read from the database. ([\#12620](https://github.com/matrix-org/synapse/issues/12620)) - Remove use of the `constantly` library and switch to enums for `EventRedactBehaviour`. Contributed by @andrewdoh. ([\#12624](https://github.com/matrix-org/synapse/issues/12624)) - Remove unused code related to receipts. ([\#12632](https://github.com/matrix-org/synapse/issues/12632)) - Minor improvements to the scripts for running Synapse in worker mode under Complement. ([\#12637](https://github.com/matrix-org/synapse/issues/12637)) - Move `pympler` back in to the `all` extras. ([\#12652](https://github.com/matrix-org/synapse/issues/12652)) - Fix spelling of `M_UNRECOGNIZED` in comments. ([\#12665](https://github.com/matrix-org/synapse/issues/12665)) - Release script: confirm the commit to be tagged before tagging. ([\#12556](https://github.com/matrix-org/synapse/issues/12556)) - Fix a typo in the announcement text generated by the Synapse release development script. ([\#12612](https://github.com/matrix-org/synapse/issues/12612)) - Fix scripts-dev to pass typechecking. ([\#12356](https://github.com/matrix-org/synapse/issues/12356)) - Add some type hints to datastore. ([\#12485](https://github.com/matrix-org/synapse/issues/12485)) - Remove unused `# type: ignore`s. ([\#12531](https://github.com/matrix-org/synapse/issues/12531)) - Allow unused `# type: ignore` comments in bleeding edge CI jobs. ([\#12576](https://github.com/matrix-org/synapse/issues/12576)) - Remove redundant lines of config from `mypy.ini`. ([\#12608](https://github.com/matrix-org/synapse/issues/12608)) - Update to mypy 0.950. ([\#12650](https://github.com/matrix-org/synapse/issues/12650)) - Use `Concatenate` to better annotate `_do_execute`. ([\#12666](https://github.com/matrix-org/synapse/issues/12666)) - Use `ParamSpec` to refine type hints. ([\#12667](https://github.com/matrix-org/synapse/issues/12667)) - Fix mypy against latest pillow stubs. ([\#12671](https://github.com/matrix-org/synapse/issues/12671)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmJ6UDoACgkQkD7OEIo5 3t3XMw/9GfROfC///lio77EhdI0lh39bkgvfqkFE/wRYtTs4n3ZSiclgVBnNmgnN WnLvjL/4wXRjzJZ8vcO+qG0OasT3H9l5xdGE+7h8oUMIYCG7Xdyx37xnhv5IC8Y5 dAjqs2mMnIWnAqyOAVZQVgmNLDhRAb9YGCJ3fJY9cV8dmzr8/RzR8gXrFPaBT9Nj w5Xag0jkiJuff4+Y5oan2yBxMvHT/zAb8rQf5wNjen00lwYHSAr/5aiAsbnHcMYM q0ZahVB/hVaA5GqxwrySlE0mqrPP6M/CpbcLr1h8LlmLdgA6f3vcf/sREGq6wCRK Z8yYXM4RyvNTyYirQfnP5QseVazJqcCY0pCXrMnQxwXda7nSDKjXo0WFBmyIQpK4 YqDvlOhECr+Pcac/EAviH2OEvTMBg4cUs1xdm4/CBElIOZQPyXHJ0DLku8R0CRx/ i01fN0I/r/wX1Oliy4wFJgSYt/uUQzZaJmRieK8fznlFibM3Gk1GvniX0M5Hu6cZ PQuHdPqRxQzvBmEAA1hxTfyOaDeP3g29NnOz9cjsBiAVNqUbEV5KFusjwksI4kcT Bsdk+v/i8/Kx6t0ovRI2i3JJAFNWmUzpY0iDzY3kJCn1YmEMZ7rs+e5qRmv2eBLW oS9dhLGsW7A/mJC6fLM+CATwbFiL/SqB5ocnl4POodZ/b27eDyw= =NPHq -----END PGP SIGNATURE----- gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmJ6V/YACgkQkD7OEIo5 3t0ANA/7BZ762LAjLNsFvJVxnH8LjDEjsjCyjHQ/zzVkAete3354zcW/mqN2YzMl shaxHucfZ9sKCXlOSuwY9N+1Q24ALMAb8QebCQZjNamxKqddpMD0+ijeaKRoFq8P 6VY5saL+rjW0g2QaKE/IHc99UKnw/cNN/vGa3xc3dJFRiiNkK95jS8R7aaaT2mXB 9frbbN0Q45Q6JTU9qJTP6jqdYmKZNjvIHBJcEXkstGqS8NPJXpfVKMZIgTj/8nGL RVJqOStsnHdx4vywZ76GPTAxQ+ZjXMilIbz+bF/6Zw1SCJEZfwFOelYApwMi0qU7 yDK7xeokKxzXyykzmptmiqmePCbr9fHbk+BJtE7VblMdj7OaM7jX7foSX6J1elIp zwDwBK0VH3CJzk9SRoy4JW3PI9K45DZodev33CT+sT39/wYTiV3mbGIYkgP8oSDH rd588QZDovVDy6NWzxkT0MsutHE5Rhx2aP+hkIFDHL4WWnKeFRD5HbiZfg/eC6r0 0nPRY2CCikvqLRqefTi4dgxb+twVBnioPZiDBTEKA/M1/qVg978SIpdHsfmaDJf9 BzWsvfsns0t54J2QnazOjKx2yxIYH6pZ2VFnrb47404O5O3+TuKZL9eX8oNZeBFl JKZKD2xii/ktkw5p27RxEpBJ13hrssN+RMd0JrvS3LTa5G9aIUM= =2gaD -----END PGP SIGNATURE----- Merge tag 'v1.59.0rc1' into develop Synapse 1.59.0rc1 (2022-05-10) ============================== This release makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](https://github.com/matrix-org/synapse/issues/12452), [\#12654](https://github.com/matrix-org/synapse/issues/12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) Features -------- - Support [MSC3266](https://github.com/matrix-org/matrix-doc/pull/3266) room summaries over federation. ([\#11507](https://github.com/matrix-org/synapse/issues/11507)) - Implement [changes](`4a77139249`) to [MSC2285 (hidden read receipts)](https://github.com/matrix-org/matrix-spec-proposals/pull/2285). Contributed by @SimonBrandner. ([\#12168](https://github.com/matrix-org/synapse/issues/12168), [\#12635](https://github.com/matrix-org/synapse/issues/12635), [\#12636](https://github.com/matrix-org/synapse/issues/12636), [\#12670](https://github.com/matrix-org/synapse/issues/12670)) - Extend the [module API](https://github.com/matrix-org/synapse/blob/release-v1.59/synapse/module_api/__init__.py) to allow modules to change actions for existing push rules of local users. ([\#12406](https://github.com/matrix-org/synapse/issues/12406)) - Add the `notify_appservices_from_worker` configuration option (superseding `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. ([\#12452](https://github.com/matrix-org/synapse/issues/12452)) - Add the `update_user_directory_from_worker` configuration option (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. ([\#12654](https://github.com/matrix-org/synapse/issues/12654)) - Add new `enable_registration_token_3pid_bypass` configuration option to allow registrations via token as an alternative to verifying a 3pid. ([\#12526](https://github.com/matrix-org/synapse/issues/12526)) - Implement [MSC3786](https://github.com/matrix-org/matrix-spec-proposals/pull/3786): Add a default push rule to ignore `m.room.server_acl` events. ([\#12601](https://github.com/matrix-org/synapse/issues/12601)) - Add new `mau_appservice_trial_days` configuration option to specify a different trial period for users registered via an appservice. ([\#12619](https://github.com/matrix-org/synapse/issues/12619)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where the latest thread reply provided failed to include the proper bundled aggregations. ([\#12273](https://github.com/matrix-org/synapse/issues/12273)) - Fix a bug introduced in Synapse 1.22.0 where attempting to send a large amount of read receipts to an application service all at once would result in duplicate content and abnormally high memory usage. Contributed by Brad & Nick @ Beeper. ([\#12544](https://github.com/matrix-org/synapse/issues/12544)) - Fix a bug introduced in Synapse 1.57.0 which could cause `Failed to calculate hosts in room` errors to be logged for outbound federation. ([\#12570](https://github.com/matrix-org/synapse/issues/12570)) - Fix a long-standing bug where status codes would almost always get logged as `200!`, irrespective of the actual status code, when clients disconnect before a request has finished processing. ([\#12580](https://github.com/matrix-org/synapse/issues/12580)) - Fix race when persisting an event and deleting a room that could lead to outbound federation breaking. ([\#12594](https://github.com/matrix-org/synapse/issues/12594)) - Fix a bug introduced in Synapse 1.53.0 where bundled aggregations for annotations/edits were incorrectly calculated. ([\#12633](https://github.com/matrix-org/synapse/issues/12633)) - Fix a long-standing bug where rooms containing power levels with string values could not be upgraded. ([\#12657](https://github.com/matrix-org/synapse/issues/12657)) - Prevent memory leak from reoccurring when presence is disabled. ([\#12656](https://github.com/matrix-org/synapse/issues/12656)) Updates to the Docker image --------------------------- - Explicitly opt-in to using [BuildKit-specific features](https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/syntax.md) in the Dockerfile. This fixes issues with building images in some GitLab CI environments. ([\#12541](https://github.com/matrix-org/synapse/issues/12541)) - Update the "Build docker images" GitHub Actions workflow to use `docker/metadata-action` to generate docker image tags, instead of a custom shell script. Contributed by @henryclw. ([\#12573](https://github.com/matrix-org/synapse/issues/12573)) Improved Documentation ---------------------- - Update SQL statements and replace use of old table `user_stats_historical` in docs for Synapse Admins. ([\#12536](https://github.com/matrix-org/synapse/issues/12536)) - Add missing linebreak to `pipx` install instructions. ([\#12579](https://github.com/matrix-org/synapse/issues/12579)) - Add information about the TCP replication module to docs. ([\#12621](https://github.com/matrix-org/synapse/issues/12621)) - Fixes to the formatting of `README.rst`. ([\#12627](https://github.com/matrix-org/synapse/issues/12627)) - Fix docs on how to run specific Complement tests using the `complement.sh` test runner. ([\#12664](https://github.com/matrix-org/synapse/issues/12664)) Deprecations and Removals ------------------------- - Remove unstable identifiers from [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069). ([\#12596](https://github.com/matrix-org/synapse/issues/12596)) - Remove the unspecified `m.login.jwt` login type and the unstable `uk.half-shot.msc2778.login.application_service` from [MSC2778](https://github.com/matrix-org/matrix-doc/pull/2778). ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) - Synapse now requires at least Python 3.7.1 (up from 3.7.0), for compatibility with the latest Twisted trunk. ([\#12613](https://github.com/matrix-org/synapse/issues/12613)) Internal Changes ---------------- - Use supervisord to supervise Postgres and Caddy in the Complement image to reduce restart time. ([\#12480](https://github.com/matrix-org/synapse/issues/12480)) - Immediately retry any requests that have backed off when a server comes back online. ([\#12500](https://github.com/matrix-org/synapse/issues/12500)) - Use `make_awaitable` instead of `defer.succeed` for return values of mocks in tests. ([\#12505](https://github.com/matrix-org/synapse/issues/12505)) - Consistently check if an object is a `frozendict`. ([\#12564](https://github.com/matrix-org/synapse/issues/12564)) - Protect module callbacks with read semantics against cancellation. ([\#12568](https://github.com/matrix-org/synapse/issues/12568)) - Improve comments and error messages around access tokens. ([\#12577](https://github.com/matrix-org/synapse/issues/12577)) - Improve docstrings for the receipts store. ([\#12581](https://github.com/matrix-org/synapse/issues/12581)) - Use constants for read-receipts in tests. ([\#12582](https://github.com/matrix-org/synapse/issues/12582)) - Log status code of cancelled requests as 499 and avoid logging stack traces for them. ([\#12587](https://github.com/matrix-org/synapse/issues/12587), [\#12663](https://github.com/matrix-org/synapse/issues/12663)) - Remove special-case for `twisted` logger from default log config. ([\#12589](https://github.com/matrix-org/synapse/issues/12589)) - Use `getClientAddress` instead of the deprecated `getClientIP`. ([\#12599](https://github.com/matrix-org/synapse/issues/12599)) - Add link to documentation in Grafana Dashboard. ([\#12602](https://github.com/matrix-org/synapse/issues/12602)) - Reduce log spam when running multiple event persisters. ([\#12610](https://github.com/matrix-org/synapse/issues/12610)) - Add extra debug logging to federation sender. ([\#12614](https://github.com/matrix-org/synapse/issues/12614)) - Prevent remote homeservers from requesting local user device names by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - Add a consistency check on events which we read from the database. ([\#12620](https://github.com/matrix-org/synapse/issues/12620)) - Remove use of the `constantly` library and switch to enums for `EventRedactBehaviour`. Contributed by @andrewdoh. ([\#12624](https://github.com/matrix-org/synapse/issues/12624)) - Remove unused code related to receipts. ([\#12632](https://github.com/matrix-org/synapse/issues/12632)) - Minor improvements to the scripts for running Synapse in worker mode under Complement. ([\#12637](https://github.com/matrix-org/synapse/issues/12637)) - Move `pympler` back in to the `all` extras. ([\#12652](https://github.com/matrix-org/synapse/issues/12652)) - Fix spelling of `M_UNRECOGNIZED` in comments. ([\#12665](https://github.com/matrix-org/synapse/issues/12665)) - Release script: confirm the commit to be tagged before tagging. ([\#12556](https://github.com/matrix-org/synapse/issues/12556)) - Fix a typo in the announcement text generated by the Synapse release development script. ([\#12612](https://github.com/matrix-org/synapse/issues/12612)) - Fix scripts-dev to pass typechecking. ([\#12356](https://github.com/matrix-org/synapse/issues/12356)) - Add some type hints to datastore. ([\#12485](https://github.com/matrix-org/synapse/issues/12485)) - Remove unused `# type: ignore`s. ([\#12531](https://github.com/matrix-org/synapse/issues/12531)) - Allow unused `# type: ignore` comments in bleeding edge CI jobs. ([\#12576](https://github.com/matrix-org/synapse/issues/12576)) - Remove redundant lines of config from `mypy.ini`. ([\#12608](https://github.com/matrix-org/synapse/issues/12608)) - Update to mypy 0.950. ([\#12650](https://github.com/matrix-org/synapse/issues/12650)) - Use `Concatenate` to better annotate `_do_execute`. ([\#12666](https://github.com/matrix-org/synapse/issues/12666)) - Use `ParamSpec` to refine type hints. ([\#12667](https://github.com/matrix-org/synapse/issues/12667)) - Fix mypy against latest pillow stubs. ([\#12671](https://github.com/matrix-org/synapse/issues/12671))	2022-05-10 13:17:56 +01:00
Patrick Cloke	b44fbdffa4	Move free functions into PushRuleEvaluatorForEvent. (#12677 ) * Move `_condition_checker` into `PushRuleEvaluatorForEvent`. * Move the condition cache into `PushRuleEvaluatorForEvent`. * Improve docstrings. * Inline a method which is only called once.	2022-05-10 07:54:30 -04:00
Patrick Cloke	02cdace707	Add class-diagrams and notes for push. (#12676 )	2022-05-10 07:43:34 -04:00
David Robertson	2bae6d93c9	I manually added O's change, remove newsfile	2022-05-10 11:17:42 +01:00
reivilibre	699192fc1a	Add the `update_user_directory_from_worker` configuration option (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. (#12654 ) Co-authored-by: Shay <hillerys@element.io>	2022-05-10 11:08:45 +01:00
David Robertson	e5fd23fb6f	1.59.0rc1	2022-05-10 10:45:13 +01:00
Erik Johnston	8dd3e0e084	Immediately retry any requests that have backed off when a server comes back online. (#12500 ) Otherwise it can take up to a minute for any in-flight `/send` requests to be retried.	2022-05-10 10:39:54 +01:00
Šimon Brandner	ade3008821	Implement MSC3786: Add a default push rule to ignore m.room.server_acl events (#12601 ) Fixes vector-im/element-web#20788 Implements matrix-org/matrix-spec-proposals#3786	2022-05-10 08:57:36 +01:00
Shay	d80a7ab151	Update `replication.md` with info on TCP module structure (#12621 )	2022-05-09 14:46:43 -07:00
Dirk Klimpel	615d96ad6e	Update SQL statements in docs for Synapse Admins (#12536 )	2022-05-09 14:43:02 -07:00
Richard van der Hoff	34e84fee68	Tweaks to workers-under-complement (#12637 ) * Bump the HS startup timeout * Log prefixes for more processes * Bump the overall timeout	2022-05-09 22:41:06 +01:00
Val Lorentz	bf0c3ca20a	Fix inconsistent spelling of 'M_UNRECOGNIZED'. (#12665 )	2022-05-09 20:29:07 +00:00
Sean Quah	a00462dd99	Implement cancellation support/protection for module callbacks (#12568 ) There's no guarantee that module callbacks will handle cancellation appropriately. Protect module callbacks with read semantics from cancellation and avoid swallowing `CancelledError`s that arise. Other module callbacks, such as the `on_*` callbacks, are presumed to live on code paths that involve writes and aren't cancellation-friendly. These module callbacks have been left alone. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-09 12:31:14 +01:00
David Robertson	8de0facaae	Fix mypy against latest pillow stubs (#12671 )	2022-05-09 10:48:14 +00:00
Sean Quah	41a882e62d	Update changelog for #12587 to be more accurate (#12663 ) #12587 has fallen on the wrong side of the release cutoff to the rest of the related PRs. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-09 11:34:39 +01:00
David Robertson	fa0eab9c8e	Use `ParamSpec` in a few places (#12667 )	2022-05-09 10:27:39 +00:00
Erik Johnston	c5969b346d	Don't error on unknown receipt types (#12670 ) Fixes #12669	2022-05-09 11:09:19 +01:00
Sheogorath	77258b6725	docs(contrib): Add link to documentation in dashboard (#12602 )	2022-05-09 10:08:31 +00:00
Eric Eastwood	18d6c18aa1	Fix docs on how to run specific Complement tests after recent `complement.sh` change (#12664 )	2022-05-09 10:38:32 +01:00
David Robertson	26c1ad71c5	Use `Concatenate` to annotate `do_execute` (#12666 )	2022-05-09 10:28:38 +01:00
David Robertson	0ce2201932	Move `pympler` back into the `all` extras (#12652 ) * Move `pympler` back into the `all` extras Undoes a change I made in #12381. I can't fully remember my reasoning, but this changed the contents of the debian packages in a backwards incompatible way. We're not aware of anyone who's been bitten by this, but we still want to fix it. To the reviewer: please be convinced that the debian packages will still contain pympler after this change. * Debian changelog entry to keep the linter happy	2022-05-07 13:40:58 +01:00
David Robertson	051a1c3f22	Convert stringy power levels to integers on room upgrade (#12657 )	2022-05-07 13:37:29 +01:00
Erik Johnston	4337d33a73	Prevent memory leak from reoccurring when presence is disabled. (#12656 )	2022-05-06 16:41:57 +00:00
David Robertson	2607b3e181	Update mypy to 0.950 and fix complaints (#12650 )	2022-05-06 12:35:20 +00:00
reivilibre	c2d50e9f6c	Add the `notify_appservices_from_worker` configuration option (superseding `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. (#12452 )	2022-05-06 11:43:53 +01:00
DeepBlueV7.X	a377a43386	Support MSC3266 room summaries over federation (#11507 ) Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>	2022-05-05 15:25:00 +01:00
Šimon Brandner	ef86cf3d28	Update `_on_new_receipts()` to work with MSC2285 changes. (#12636 )	2022-05-05 13:25:51 +00:00
reivilibre	07fa53ec40	Improve comments and error messages around access tokens. (#12577 )	2022-05-05 13:39:59 +01:00
Henry	b8fa24b022	Use `docker/metadata-action` to generate docker image tags (#12573 ) Update the "Build docker images" GitHub Actions workflow to use `docker/metadata-action` to generate docker image tags, instead of a custom shell script. Signed-off-by: Henry <97804910+henryclw@users.noreply.github.com>	2022-05-05 12:36:42 +00:00
Šimon Brandner	9ae0253f4e	Use `private` instead of `hidden` in MSC2285 related code. (#12635 )	2022-05-05 12:31:25 +00:00
Patrick Cloke	f90d381c7b	Edits/annotations should not have any bundled aggregations calculated. (#12633 ) Fixes a regression from `8b309adb43` (#11660) and `b65acead42` (#11752) where events which themselves were an edit or an annotation could have bundled aggregations calculated, which is not allowed.	2022-05-05 08:15:12 -04:00
Patrick Cloke	ddc8bba00f	Remove unused receipt datastore methods. (#12632 ) The last usage was removed in `5a1dd297c3` (#8059).	2022-05-05 07:51:19 -04:00
Will Hunt	cc7656099d	Fix typo in some instances of enable_registration_token_3pid_bypass. (#12639 )	2022-05-05 07:11:52 -04:00
Erik Johnston	c0379d6e5b	Reduce log spam when running multiple event persisters (#12610 )	2022-05-05 10:20:23 +01:00
Will Hunt	2d74a8c178	Add `mau_appservice_trial_days` config (#12619 ) * Add mau_appservice_trial_days * Add a test * Tweaks * changelog * Ensure we sync after the delay * Fix types * Add config statement * Fix test * Reinstate logging that got removed * Fix feature name	2022-05-04 19:33:26 +01:00
Patrick Cloke	7fbf42499d	Use `getClientAddress` instead of `getClientIP`. (#12599 ) getClientIP was deprecated in Twisted 18.4.0, which also added getClientAddress. The Synapse minimum version for Twisted is currently 18.9.0, so all supported versions have the new API.	2022-05-04 14:11:21 -04:00
Šimon Brandner	116a4c8340	Implement changes to MSC2285 (hidden read receipts) (#12168 ) * Changes hidden read receipts to be a separate receipt type (instead of a field on `m.read`). * Updates the `/receipts` endpoint to accept `m.fully_read`.	2022-05-04 11:59:22 -04:00
Andrew Morgan	332cce8dcf	Disable device name lookup over federation by default (#12616 )	2022-05-04 16:41:40 +01:00
Patrick Cloke	ba3fd54bad	Remove unstable/unspecced login types. (#12597 ) * `m.login.jwt`, which was never specced and has been deprecated since Synapse 1.16.0. (`org.matrix.login.jwt` can be used instead.) * `uk.half-shot.msc2778.login.application_service`, which was stabilized as part of the Matrix spec v1.2 release.	2022-05-04 13:53:21 +00:00

... 4 5 6 7 8 ...

6358 commits